coreboot-gerrit April 2017

coreboot-gerrit@coreboot.org

1 participants
4151 discussions

Change in coreboot[master]: acpi: fix FADT header version for ChromeOS devices
by Matt DeVillier (Code Review) 30 Apr '17

30 Apr '17

Matt DeVillier has uploaded a new change for review. ( https://review.coreboot.org/19498 ) Change subject: acpi: fix FADT header version for ChromeOS devices ...................................................................... acpi: fix FADT header version for ChromeOS devices Haswell, Broadwell, Baytrail, and Braswell ChromeOS devices' FADT version were incorrectly set to 3, rather than the correct ACPI_FADT_REV_ACPI_3_0. The incorrect value resulted in these devices reporting compliance to ACPI 2.0, rather than ACPI 3.0. This mirrors similar recent changes to SKL and APL SoCs. Test: boot any affected device and check ACPI version reported vai FADT header using OS-appropriate tools. Change-Id: I689d2f848f4b8e5750742ea07f31162ee36ff64d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/auron/fadt.c M src/mainboard/google/beltino/fadt.c M src/mainboard/google/cyan/fadt.c M src/mainboard/google/jecht/fadt.c M src/mainboard/google/rambi/fadt.c M src/mainboard/google/slippy/fadt.c 6 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/19498/1 diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c index 70fd2ce..dea67d0 100644 --- a/src/mainboard/google/auron/fadt.c +++ b/src/mainboard/google/auron/fadt.c @@ -24,7 +24,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); diff --git a/src/mainboard/google/beltino/fadt.c b/src/mainboard/google/beltino/fadt.c index 877a4b3..486a343 100644 --- a/src/mainboard/google/beltino/fadt.c +++ b/src/mainboard/google/beltino/fadt.c @@ -27,7 +27,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c index af222b5..d62c28d 100644 --- a/src/mainboard/google/cyan/fadt.c +++ b/src/mainboard/google/cyan/fadt.c @@ -24,7 +24,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c index 70fd2ce..dea67d0 100644 --- a/src/mainboard/google/jecht/fadt.c +++ b/src/mainboard/google/jecht/fadt.c @@ -24,7 +24,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c index 2434d1a..b0fe9d6 100644 --- a/src/mainboard/google/rambi/fadt.c +++ b/src/mainboard/google/rambi/fadt.c @@ -23,7 +23,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); diff --git a/src/mainboard/google/slippy/fadt.c b/src/mainboard/google/slippy/fadt.c index 2452ac2..fe86f56 100644 --- a/src/mainboard/google/slippy/fadt.c +++ b/src/mainboard/google/slippy/fadt.c @@ -27,7 +27,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 3; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); -- To view, visit https://review.coreboot.org/19498 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I689d2f848f4b8e5750742ea07f31162ee36ff64d Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Clean up code by using common FAST_SPI mo...
by Furquan Shaikh (Code Review) 29 Apr '17

29 Apr '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19055 ) Change subject: soc/intel/skylake: Clean up code by using common FAST_SPI module ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/#/c/19055/22/src/soc/intel/skylake/pch.c File src/soc/intel/skylake/pch.c: PS22, Line 24: #include <intelblocks/fast_spi.h> why is this required here? -- To view, visit https://review.coreboot.org/19055 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc90504d322db70ed4ea644b1593cc0605b5fe8 Gerrit-PatchSet: 22 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: arch/x86: Share storage data structures between early stages
by Sumeet R Pawnikar (Code Review) 29 Apr '17

29 Apr '17

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/19300 ) Change subject: arch/x86: Share storage data structures between early stages ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/19300 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20a01b850a31df9887a428bf07ca476c8410d33e Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by build bot (Jenkins) (Code Review) 29 Apr '17

29 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19494 ) Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/52970/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8815/ : SUCCESS -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/mainboard.c: Get rid of SPI AFC register
by build bot (Jenkins) (Code Review) 29 Apr '17

29 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19493 ) Change subject: mb/*/mainboard.c: Get rid of SPI AFC register ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/52968/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8813/ : SUCCESS -- To view, visit https://review.coreboot.org/19493 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627082e09dd055e3b3c4dd8e0b90965a9fcb4342 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by build bot (Jenkins) (Code Review) 29 Apr '17

29 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19494 ) Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/52969/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/8814/ : SUCCESS -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by Patrick Rudolph (Code Review) 29 Apr '17

29 Apr '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19494 to look at the new patch set (#4). Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... mb/lenvovo/*: Clean mainboard.c Move board specific SPI registers to devicetree. Remove unused headers. Remove obsolete methods. Fix coding style. Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/l520/mainboard.c M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/lenovo/t400/mainboard.c M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420/mainboard.c M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t420s/mainboard.c M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t430s/mainboard.c M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t520/mainboard.c M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/mainboard.c M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x220/mainboard.c M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/mainboard.c 19 files changed, 89 insertions(+), 202 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/19494/4 -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mb/*/mainboard.c: Get rid of SPI AFC register
by Patrick Rudolph (Code Review) 29 Apr '17

29 Apr '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19493 to look at the new patch set (#2). Change subject: mb/*/mainboard.c: Get rid of SPI AFC register ...................................................................... mb/*/mainboard.c: Get rid of SPI AFC register The AFC—Additional Flash Control Register is set by southbridge code. Remove redundant calls and get rid of it in autoport. Change-Id: I627082e09dd055e3b3c4dd8e0b90965a9fcb4342 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/apple/macbookair4_2/mainboard.c M src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c M src/mainboard/gigabyte/ga-b75m-d3v/mainboard.c M src/mainboard/lenovo/l520/mainboard.c M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/lenovo/t420/mainboard.c M src/mainboard/lenovo/t420s/mainboard.c M src/mainboard/lenovo/t430s/mainboard.c M src/mainboard/lenovo/t520/mainboard.c M src/mainboard/lenovo/t530/mainboard.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/mainboard.c M src/mainboard/lenovo/x230/mainboard.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/sapphire/pureplatinumh61/mainboard.c M util/autoport/bd82x6x.go 16 files changed, 1 insertion(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/19493/2 -- To view, visit https://review.coreboot.org/19493 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I627082e09dd055e3b3c4dd8e0b90965a9fcb4342 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by Patrick Rudolph (Code Review) 29 Apr '17

29 Apr '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19494 to look at the new patch set (#3). Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... mb/lenvovo/*: Clean mainboard.c Move board specific SPI registers to devicetree. Remove unused headers. Remove obsolete methods. Fix coding style. Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/l520/mainboard.c M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/lenovo/t400/mainboard.c M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420/mainboard.c M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t420s/mainboard.c M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t430s/mainboard.c M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t520/mainboard.c M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/mainboard.c M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x220/mainboard.c M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/mainboard.c 19 files changed, 98 insertions(+), 194 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/19494/3 -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/skylake: Set xtal bypass on low power idle
by build bot (Jenkins) (Code Review) 29 Apr '17

29 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19442 ) Change subject: soc/intel/skylake: Set xtal bypass on low power idle ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/52967/ : SUCCESS -- To view, visit https://review.coreboot.org/19442 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide2d01536f652cd1b0ac32eede89ec410c5101cf Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Roy Park <roy.mingi.park(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com> Gerrit-HasComments: No

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
416
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2017