coreboot-gerrit April 2017

coreboot-gerrit@coreboot.org

1 participants
4151 discussions

Change in coreboot[master]: lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms usi...
by Arthur Heymans (Code Review) 30 Apr '17

30 Apr '17

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/19504 ) Change subject: lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms using LAPIC_UDELAY ...................................................................... lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms using LAPIC_UDELAY This allows for more accurate timestamps. Also adds core2duo 1600MHz FSB support. Change-Id: Ic643681c3b9646bf7efbcd786c35a9beda9afc49 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/lapic/apic_timer.c 1 file changed, 30 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/19504/2 -- To view, visit https://review.coreboot.org/19504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic643681c3b9646bf7efbcd786c35a9beda9afc49 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: lib/edid.c: Allow use of when not NGI
by Arthur Heymans (Code Review) 30 Apr '17

30 Apr '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19501 ) Change subject: lib/edid.c: Allow use of when not NGI ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/19501/1/src/device/Kconfig File src/device/Kconfig: PS1, Line 28: > It's futile here since the `y` above takes precedence. Why did you Indeed, should be fixed in v2. https://review.coreboot.org/#/c/19501/2/src/lib/edid.c File src/lib/edid.c: Line 1749: #if IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT) > Why would it need another guard? multiple definitions which conflicts with src/device/oprom/realmode/x86.c. Could be it is the wrong guard though... -- To view, visit https://review.coreboot.org/19501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8709e3e61686979137b08d24efad903700d18e0b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms usi...
by Arthur Heymans (Code Review) 30 Apr '17

30 Apr '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19504 ) Change subject: lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms using LAPIC_UDELAY ...................................................................... lapic/apic_timer.c: Provide a tsc_freq_mhz for platforms using LAPIC_UDELAY This allows for more accurate timestamps. Change-Id: Ic643681c3b9646bf7efbcd786c35a9beda9afc49 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/lapic/apic_timer.c 1 file changed, 31 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/19504/1 diff --git a/src/cpu/x86/lapic/apic_timer.c b/src/cpu/x86/lapic/apic_timer.c index cddc5ad..30a8ef3 100644 --- a/src/cpu/x86/lapic/apic_timer.c +++ b/src/cpu/x86/lapic/apic_timer.c @@ -22,6 +22,7 @@ #include <arch/cpu.h> #include <arch/early_variables.h> #include <cpu/x86/msr.h> +#include <cpu/x86/tsc.h> #include <cpu/x86/lapic.h> #include <cpu/intel/speedstep.h> @@ -42,11 +43,11 @@ #else static u32 g_timer_fsb CAR_GLOBAL; -static int set_timer_fsb(void) +static int get_fsb(void) { - struct cpuinfo_x86 c; + struct cpuinfo_x86 c; int core_fsb[8] = { -1, 133, -1, 166, -1, 100, -1, -1 }; - int core2_fsb[8] = { 266, 133, 200, 166, 333, 100, -1, -1 }; + int core2_fsb[8] = { 266, 133, 200, 166, 333, 100, 400, -1 }; int f2x_fsb[8] = { 100, 133, 200, 166, -1, -1, -1, -1 }; get_fms(&c, cpuid_eax(1)); @@ -55,42 +56,53 @@ switch (c.x86_model) { case 0xe: /* Core Solo/Duo */ case 0x1c: /* Atom */ - car_set_var(g_timer_fsb, - core_fsb[rdmsr(MSR_FSB_FREQ).lo & 7]); - return 0; + return core_fsb[rdmsr(MSR_FSB_FREQ).lo & 7]; case 0xf: /* Core 2 or Xeon */ case 0x17: /* Enhanced Core */ - car_set_var(g_timer_fsb, - core2_fsb[rdmsr(MSR_FSB_FREQ).lo & 7]); - return 0; + return core2_fsb[rdmsr(MSR_FSB_FREQ).lo & 7]; case 0x2a: /* SandyBridge BCLK fixed at 100MHz*/ case 0x3a: /* IvyBridge BCLK fixed at 100MHz*/ case 0x3c: /* Haswell BCLK fixed at 100MHz */ case 0x45: /* Haswell-ULT BCLK fixed at 100MHz */ - car_set_var(g_timer_fsb, 100); - return 0; + return 100; default: - car_set_var(g_timer_fsb, 200); - return 0; + return 200; } case 0xf: /* Netburst */ switch (c.x86_model) { case 0x2: - car_set_var(g_timer_fsb, - f2x_fsb[(rdmsr(0x2c).lo >> 16) & 7]); - return 0; + return f2x_fsb[(rdmsr(0x2c).lo >> 16) & 7]; case 0x3: case 0x4: case 0x6: - car_set_var(g_timer_fsb, - core2_fsb[(rdmsr(0x2c).lo >> 16) & 7]); - return 0; + return core2_fsb[(rdmsr(0x2c).lo >> 16) & 7]; } /* default: fallthrough */ default: return -1; } } +unsigned long tsc_freq_mhz(void) +{ + msr_t msr; + unsigned long divisor; + + msr = rdmsr(IA32_PERF_STS); + divisor = (msr.hi >> 8) & 0x1f; + return get_fsb() * divisor; +} + +static int set_timer_fsb(void) +{ + int fsb = get_fsb(); + if (fsb > 0) { + car_set_var(g_timer_fsb, get_fsb()); + return 0; + } else { + return 1; + } +} + static inline u32 get_timer_fsb(void) { return car_get_var(g_timer_fsb); -- To view, visit https://review.coreboot.org/19504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic643681c3b9646bf7efbcd786c35a9beda9afc49 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: lib/edid.c: Allow use of when not NGI
by Arthur Heymans (Code Review) 30 Apr '17

30 Apr '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19501 to look at the new patch set (#2). Change subject: lib/edid.c: Allow use of when not NGI ...................................................................... lib/edid.c: Allow use of when not NGI Change-Id: I8709e3e61686979137b08d24efad903700d18e0b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/lib/Makefile.inc M src/lib/edid.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/19501/2 -- To view, visit https://review.coreboot.org/19501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8709e3e61686979137b08d24efad903700d18e0b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by build bot (Jenkins) (Code Review) 30 Apr '17

30 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19503 ) Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/52979/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8824/ : SUCCESS -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid.c: Allow use of when not NGI
by build bot (Jenkins) (Code Review) 30 Apr '17

30 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19501 ) Change subject: lib/edid.c: Allow use of when not NGI ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/52977/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8822/ : SUCCESS -- To view, visit https://review.coreboot.org/19501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8709e3e61686979137b08d24efad903700d18e0b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 30 Apr '17

30 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/52976/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8821/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid.c: Return value differentiates absent and non-confo...
by build bot (Jenkins) (Code Review) 30 Apr '17

30 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19502 ) Change subject: lib/edid.c: Return value differentiates absent and non-conformant ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/52978/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8823/ : SUCCESS -- To view, visit https://review.coreboot.org/19502 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id90aa210ff72092c4ab638a7bafb82bd11889bdc Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 30 Apr '17

30 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/52975/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8820/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid.c: Allow use of when not NGI
by Arthur Heymans (Code Review) 30 Apr '17

30 Apr '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19501 ) Change subject: lib/edid.c: Allow use of when not NGI ...................................................................... Patch Set 1: Another option would be to simply not reconfigure PWM freq for option rom users, since afaik blob does that too. -- To view, visit https://review.coreboot.org/19501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8709e3e61686979137b08d24efad903700d18e0b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-HasComments: No

1 0

← Newer
1
2
3
4
5
6
7
8
...
416
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2017