Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18297
-gerrit
commit b1f580f4af760fc960686cc20fb74360b0dcbfe5
Author: Yuji Sasaki <sasakiy(a)google.com>
Date: Thu Jan 26 10:17:45 2017 -0800
qualcomm/ipq40xx: add vector operation method
Adding spi_xfer_two_vectors as .xfer_vector for ipq40xx spi_ctrlr.
Commit 22e7b86790fa ("UPSTREAM: spi: Get rid of SPI_ATOMIC_SEQUENCING")
has added new driver method xfer_vector to support combined write-read
operation within single CS cycle. The metohd is wrapped in
spi_xfer_vector() API. When spi_ctrlr structure does not have
xfer_vector method, API calls write and read operations sequentially.
However the QCA40xx SPI driver has "forced" CS activation-inactivation
in xfer method, so individual operation will break CS after write
operation, making combined write-read cycle broken.
Adding xfer_vector method to spi_ctrlr is quick fix to prevent this.
BUG=None
BRANCH=none
TEST=built and run on Gale
Change-Id: I2258e563d0793bcacd626f78b8e96b3649a8e4a4
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Commit-Id: 88a8824951cef4fe293dfa6e3a1a837ae07b6156
Original-Change-Id: I031e85ce5b847353cb1084f6f68b2af8c6f702e1
Original-Signed-off-by: Yuji Sasaki <sasakiy(a)google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/433439
Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org>
Original-Reviewed-by: Kan Yan <kyan(a)google.com>
---
src/soc/qualcomm/ipq40xx/spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c
index 6d044b3..68c2dd0 100644
--- a/src/soc/qualcomm/ipq40xx/spi.c
+++ b/src/soc/qualcomm/ipq40xx/spi.c
@@ -656,6 +656,7 @@ static const struct spi_ctrlr spi_ctrlr = {
.claim_bus = spi_ctrlr_claim_bus,
.release_bus = spi_ctrlr_release_bus,
.xfer = spi_ctrlr_xfer,
+ .xfer_vector = spi_xfer_two_vectors,
};
int spi_setup_slave(unsigned int bus, unsigned int cs, struct spi_slave *slave)
the following patch was just integrated into master:
commit 3d3c8c30ead13f641d97e4b526547fe5af71522f
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Mon Aug 15 10:04:21 2016 +0300
devtree: Drop unused parameter show_devs_tree() call
Change-Id: I14c044bb32713ef4133bce8a8238a2bc200c4959
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Reviewed-on: https://review.coreboot.org/18085
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/18085 for details.
-gerrit
the following patch was just integrated into master:
commit 8e4aafb531cb0455bf01effec5bbbc16c890cdf8
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Dec 15 15:25:15 2016 -0700
src/Kconfig: Move options with no prompt towards the end of the file
Options with no prompt can go anywhere in the tree with the same
dependencies and they have the same effect. Moving them lower in
the tree allows the default values to be overridden by other Kconfig
files.
This patch just moves options with default values that aren't 'n'. The
'n' options are just removed in the next patch, since they aren't needed.
Verified that this makes no significant changes to any config file.
Change-Id: I46175756b937a241edba87dbf70ce1be851fa89d
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/17907
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See https://review.coreboot.org/17907 for details.
-gerrit
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18294
-gerrit
commit 2cdbdebe5e416603e3a9f2d0088e59ae52a3f1b0
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Mon Feb 6 15:08:04 2017 +0100
nb/i945/gma.c: Remove writes to FIFO Watermark registers
Those are the result from tracing what linux or the option rom do
but are not needed here.
TESTED on Thinkpad X60.
Change-Id: I4297a78c4ab6a19ef6161778c993fc3f3fb08c7e
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/northbridge/intel/i945/gma.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 0d4ca43..eac8717 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -293,14 +293,6 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf,
write32(mmiobase + DSPPOS(0), 0);
/* Backlight init. */
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
- write32(mmiobase + FW_BLC, 0x011d011a);
- write32(mmiobase + FW_BLC2, 0x00000102);
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
- write32(mmiobase + FW_BLC_SELF, 0x0001003f);
- write32(mmiobase + FW_BLC, 0x011d0109);
- write32(mmiobase + FW_BLC2, 0x00000102);
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
write32(mmiobase + BLC_PWM_CTL, conf->gpu_backlight);
edid.bytes_per_line = (edid.bytes_per_line + 63) & ~63;
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18294
-gerrit
commit 2e03e732265530fcb041a7e66e829d7ca095d270
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Mon Feb 6 15:08:04 2017 +0100
nb/i945/gma.c: Remove writes to FIFO Watermarks
Those are the result from tracing what linux or the option rom do
but are not needed here.
TESTED on Thinkpad X60.
Change-Id: I4297a78c4ab6a19ef6161778c993fc3f3fb08c7e
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/northbridge/intel/i945/gma.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 0d4ca43..eac8717 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -293,14 +293,6 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf,
write32(mmiobase + DSPPOS(0), 0);
/* Backlight init. */
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
- write32(mmiobase + FW_BLC, 0x011d011a);
- write32(mmiobase + FW_BLC2, 0x00000102);
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
- write32(mmiobase + FW_BLC_SELF, 0x0001003f);
- write32(mmiobase + FW_BLC, 0x011d0109);
- write32(mmiobase + FW_BLC2, 0x00000102);
- write32(mmiobase + FW_BLC_SELF, FW_BLC_SELF_EN_MASK);
write32(mmiobase + BLC_PWM_CTL, conf->gpu_backlight);
edid.bytes_per_line = (edid.bytes_per_line + 63) & ~63;