coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/cannonlake: Add SoC API to make use SMM common code
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22870 ) Change subject: soc/intel/cannonlake: Add SoC API to make use SMM common code ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64784/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19561/ : SUCCESS -- To view, visit https://review.coreboot.org/22870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If526cbae9afee47fa272bdf74e04416aff100e88 Gerrit-Change-Number: 22870 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:32:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Make use of common SMM code for SKL
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22826 ) Change subject: soc/intel/skylake: Make use of common SMM code for SKL ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64783/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19562/ : SUCCESS -- To view, visit https://review.coreboot.org/22826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8163dc7e18bb417e8c18a12628988959c128b3df Gerrit-Change-Number: 22826 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:32:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Add smi_handler_get_sci_mask() in soc code
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22871 ) Change subject: soc/intel/apollolake: Add smi_handler_get_sci_mask() in soc code ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64782/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19560/ : SUCCESS -- To view, visit https://review.coreboot.org/22871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b453e9ca659ea16e9e6c27bd83959ee343c7520 Gerrit-Change-Number: 22871 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:31:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add missing SoC common function into SMM library
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22869 ) Change subject: soc/intel/common: Add missing SoC common function into SMM library ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64781/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19559/ : SUCCESS -- To view, visit https://review.coreboot.org/22869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9f90df3336c1278b73284815b5197400512c1d2 Gerrit-Change-Number: 22869 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:31:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Implement pmc_soc_restore_power_failure as per EDS
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22840 ) Change subject: soc/intel/cannonlake: Implement pmc_soc_restore_power_failure as per EDS ...................................................................... Patch Set 7: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64780/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19558/ : SUCCESS -- To view, visit https://review.coreboot.org/22840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e655fe79d958cce9e627ea2f2380185364ab19 Gerrit-Change-Number: 22840 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:30:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move Enable power button SMI code from smi.c to pmc.c
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22868 ) Change subject: soc/intel/skylake: Move Enable power button SMI code from smi.c to pmc.c ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64779/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19557/ : SUCCESS -- To view, visit https://review.coreboot.org/22868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4fe2694006baf24ed475c85aaffa6a0d2a6031d Gerrit-Change-Number: 22868 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 09:30:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Add TPM measurement code
by Patrick Rudolph (Code Review) 19 Dec '17

19 Dec '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22867 ) Change subject: security/tpm: Add TPM measurement code ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c File src/security/tpm/tss/tcg-1.2/tss.c: https://review.coreboot.org/#/c/22867/4/src/security/tpm/tss/tcg-1.2/tss.c@… PS4, Line 489: *ptr += 1; you are incrementing the entry counter twice in case the cbmem entry already exists. Has to be moved to else { ... } -- To view, visit https://review.coreboot.org/22867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 08:27:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: libpayload/arch/x86: support read cpu speed from msr
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22943 ) Change subject: libpayload/arch/x86: support read cpu speed from msr ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19554/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64776/ : SUCCESS -- To view, visit https://review.coreboot.org/22943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69da73ab479785c7b5d8add15705c1cd42925a75 Gerrit-Change-Number: 22943 Gerrit-PatchSet: 1 Gerrit-Owner: JianfengX Zhou <jianfengx.zhou(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 08:02:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload/arch/x86: support read cpu speed from msr
by JianfengX Zhou (Code Review) 19 Dec '17

19 Dec '17

JianfengX Zhou has uploaded this change for review. ( https://review.coreboot.org/22943 Change subject: libpayload/arch/x86: support read cpu speed from msr ...................................................................... libpayload/arch/x86: support read cpu speed from msr on icelake, "while (!(inb(0x61) & 0x20))" lead to dead loop, can not boot normally. when CONFIG_LP_GET_CPU_SPEED_FROM_MSR set to 1, read cpu speed from msr platfrom information register. Change-Id: I69da73ab479785c7b5d8add15705c1cd42925a75 Signed-off-by: zhouji3x <jianfengx.zhou(a)intel.com> --- M payloads/libpayload/arch/x86/timer.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/22943/1 diff --git a/payloads/libpayload/arch/x86/timer.c b/payloads/libpayload/arch/x86/timer.c index bf0c30a..845876f 100644 --- a/payloads/libpayload/arch/x86/timer.c +++ b/payloads/libpayload/arch/x86/timer.c @@ -46,6 +46,21 @@ * * @return The CPU speed in kHz. */ +#ifdef CONFIG_LP_GET_CPU_SPEED_FROM_MSR +unsigned int get_cpu_speed(void) +{ + uint32_t info_lo; + uint32_t info_hi; + unsigned max_nb_ratio; + + /* read MSR PLATFORM INFO */ + asm volatile ("rdmsr" : "=a" (info_lo), "=d" (info_hi) : "c" (0xce)); + max_nb_ratio = (info_lo >> 8) & 0xff; + + cpu_khz = 100 * max_nb_ratio * 1000; + return cpu_khz; +} +#else unsigned int get_cpu_speed(void) { unsigned long long start, end; @@ -76,3 +91,4 @@ return cpu_khz; } +#endif -- To view, visit https://review.coreboot.org/22943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I69da73ab479785c7b5d8add15705c1cd42925a75 Gerrit-Change-Number: 22943 Gerrit-PatchSet: 1 Gerrit-Owner: JianfengX Zhou <jianfengx.zhou(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Move Enable power button SMI code from smi.c to pmc.c
by build bot (Jenkins) (Code Review) 19 Dec '17

19 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22868 ) Change subject: soc/intel/skylake: Move Enable power button SMI code from smi.c to pmc.c ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19551/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64774/ : SUCCESS -- To view, visit https://review.coreboot.org/22868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4fe2694006baf24ed475c85aaffa6a0d2a6031d Gerrit-Change-Number: 22868 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Dec 2017 07:27:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017