coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/amd/common/block/pi/agesawrapper.c: Add new function sb_program_g...
by Richard Spiegel (Code Review) 26 Dec '17

26 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22987 ) Change subject: soc/amd/common/block/pi/agesawrapper.c: Add new function sb_program_gpio() ...................................................................... Patch Set 1: Some changes left for commit 0f0af54668 ( amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table) are required earlier. Working on it. -- To view, visit https://review.coreboot.org/22987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38da26cd1e20617958a6b17d55b7d7c08b8a0230 Gerrit-Change-Number: 22987 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:19:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset
by Richard Spiegel (Code Review) 26 Dec '17

26 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22989 ) Change subject: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset ...................................................................... Patch Set 1: Some changes left for commit 0f0af54668 ( amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table) are required earlier. Working on it. -- To view, visit https://review.coreboot.org/22989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7 Gerrit-Change-Number: 22989 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:18:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table
by Richard Spiegel (Code Review) 26 Dec '17

26 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22988 ) Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table ...................................................................... Patch Set 1: Some changes left for commit 0f0af54668 ( amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table) are required earlier. Working on it. -- To view, visit https://review.coreboot.org/22988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667 Gerrit-Change-Number: 22988 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:17:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/common/block/pi/agesawrapper.c: Add new function sb_program_g...
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22987 ) Change subject: soc/amd/common/block/pi/agesawrapper.c: Add new function sb_program_gpio() ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64999/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19756/ : SUCCESS -- To view, visit https://review.coreboot.org/22987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38da26cd1e20617958a6b17d55b7d7c08b8a0230 Gerrit-Change-Number: 22987 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:13:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22988 ) Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/65000/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19757/ : SUCCESS -- To view, visit https://review.coreboot.org/22988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667 Gerrit-Change-Number: 22988 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:10:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22990 ) Change subject: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19759/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65002/ : SUCCESS -- To view, visit https://review.coreboot.org/22990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2ea63656a7d2f20f55fc5a4c75457db85b80cbd Gerrit-Change-Number: 22990 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:09:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table
by Richard Spiegel (Code Review) 26 Dec '17

26 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22988 ) Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variant… PS1, Line 145: FCH_GPIO_OUTPUT_VALUE Should this be replaced with OUTPUT_L? The way it's here, output is not enabled. https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variant… PS1, Line 148: FCH_GPIO_OUTPUT_VALUE Ditto. https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variant… PS1, Line 226: FCH_GPIO_OUTPUT_VALUE Ditto. -- To view, visit https://review.coreboot.org/22988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667 Gerrit-Change-Number: 22988 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:07:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Create a GPIO programming function
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22986 ) Change subject: soc/amd/stoneyridge/southbridge.c: Create a GPIO programming function ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19755/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64998/ : SUCCESS -- To view, visit https://review.coreboot.org/22986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88d65c78a186bed9739bc208d5711a31aa3c3bb6 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:04:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset
by build bot (Jenkins) (Code Review) 26 Dec '17

26 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22989 ) Change subject: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/65001/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19758/ : SUCCESS -- To view, visit https://review.coreboot.org/22989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7 Gerrit-Change-Number: 22989 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Dec 2017 16:04:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table
by Richard Spiegel (Code Review) 26 Dec '17

26 Dec '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/22990 Change subject: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table ...................................................................... amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table As function platform_FchParams_reset() is no longer called or declared, it needs to be removed. Replace GPIO table with the new format, and platform_FchParams_reset() with new function board_get_gpio(). BUG=b:64140392 TEST=Build gardenia. Change-Id: Id2ea63656a7d2f20f55fc5a4c75457db85b80cbd Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/amd/gardenia/Makefile.inc M src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c 2 files changed, 28 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/22990/1 diff --git a/src/mainboard/amd/gardenia/Makefile.inc b/src/mainboard/amd/gardenia/Makefile.inc index 4c637bb..1825f42 100644 --- a/src/mainboard/amd/gardenia/Makefile.inc +++ b/src/mainboard/amd/gardenia/Makefile.inc @@ -19,6 +19,7 @@ romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c +ramstage-y += bootblock/BiosCallOuts.c ramstage-y += BiosCallOuts.c ramstage-y += OemCustomize.c ramstage-$(CONFIG_STONEYRIDGE_IMC_FWM) += fchec.c diff --git a/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c b/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c index 7e60dae..30877a7 100644 --- a/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c +++ b/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c @@ -18,33 +18,42 @@ #include <soc/southbridge.h> #include <stdlib.h> -static const GPIO_CONTROL oem_gardenia_gpio[] = { +/* + * The definitions bellow are valid only within this file, with the sole + * purpose of making the array below compact and easy to understand. + */ +#define PULL_UP FCH_GPIO_PULL_UP_ENABLE +#define PULL_DOWN FCH_GPIO_PULL_DOWN_ENABLE +#define INPUT 0 +#define OUTPUT_H (FCH_GPIO_OUTPUT_ENABLE | FCH_GPIO_OUTPUT_VALUE) +#define OUTPUT_L FCH_GPIO_OUTPUT_ENABLE + +/* + * As a rule of thumb, GPIO used by coreboot should be initialized at + * STAGE_RESET while GPIO used only by the OS should be initialized at + * STAGE_INIT_LATE. + */ +const struct soc_amd_stoneyridge_gpio gpio_set_stage[] = { /* BT radio disable */ - {14, Function1, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, + {14, Function1, PULL_UP | OUTPUT_H, STAGE_INIT_LATE }, /* NFC PU */ - {64, Function0, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, + {64, Function0, PULL_UP | OUTPUT_H, STAGE_RESET }, /* NFC wake */ - {65, Function0, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, + {65, Function0, PULL_UP | OUTPUT_H, STAGE_INIT_LATE }, /* Webcam */ - {66, Function0, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, + {66, Function0, PULL_UP | OUTPUT_H, STAGE_INIT_LATE }, /* PCIe presence detect */ - {69, Function0, FCH_GPIO_PULL_UP_ENABLE}, + {69, Function0, PULL_UP | INPUT, STAGE_RESET }, /* GPS sleep */ - {70, Function0, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, + {70, Function0, PULL_UP | OUTPUT_H, STAGE_INIT_LATE }, /* MUX for Power Express Eval */ - {116, Function1, FCH_GPIO_PULL_DOWN_ENABLE}, + {116, Function1, PULL_DOWN | INPUT, STAGE_RESET }, /* SD power */ - {119, Function2, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE - | FCH_GPIO_OUTPUT_ENABLE}, - {-1} + {119, Function2, PULL_UP | OUTPUT_H, STAGE_RESET }, }; -void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset) +const struct soc_amd_stoneyridge_gpio *board_get_gpio(size_t *size) { - FchParams_reset->EarlyOemGpioTable = (void *)oem_gardenia_gpio; + *size = ARRAY_SIZE(gpio_set_stage); + return gpio_set_stage; } -- To view, visit https://review.coreboot.org/22990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id2ea63656a7d2f20f55fc5a4c75457db85b80cbd Gerrit-Change-Number: 22990 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017