coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22688 ) Change subject: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64040/ : SUCCESS -- To view, visit https://review.coreboot.org/22688 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Gerrit-Change-Number: 22688 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 06:11:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22690 ) Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64042/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18886/ : SUCCESS -- To view, visit https://review.coreboot.org/22690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Gerrit-Change-Number: 22690 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 06:05:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy, nautilus, soraka: Disable PD on AC_PRESENT in deep Sx
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22689 ) Change subject: mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64039/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18885/ : SUCCESS -- To view, visit https://review.coreboot.org/22689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a Gerrit-Change-Number: 22689 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 05:59:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22688 ) Change subject: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64037/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18884/ : ABORTED -- To view, visit https://review.coreboot.org/22688 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Gerrit-Change-Number: 22688 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 05:57:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22690 ) Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64038/ : ABORTED -- To view, visit https://review.coreboot.org/22690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Gerrit-Change-Number: 22690 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 05:57:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
by Furquan Shaikh (Code Review) 04 Dec '17

04 Dec '17

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/22690 ) Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT DSX_CFG provides a config option to disable internal pull-down on AC_PRESENT. This change updates macro name to reflect this correctly. Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/include/soc/pmc.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/22690/2 -- To view, visit https://review.coreboot.org/22690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Gerrit-Change-Number: 22690 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy, nautilus, soraka: Disable PD on AC_PRESENT in deep Sx
by Furquan Shaikh (Code Review) 04 Dec '17

04 Dec '17

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/22689 ) Change subject: mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx ...................................................................... mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx This change updates device tree deep_sx_config to disable internal pull-down on AC_PRESENT. BUG=b:69983729 Change-Id: I041900a5262f8fd920856f126185329242a0639a Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22689/2 -- To view, visit https://review.coreboot.org/22689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a Gerrit-Change-Number: 22689 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT
by Furquan Shaikh (Code Review) 04 Dec '17

04 Dec '17

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/22688 ) Change subject: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT DSX_CFG provides a config option to disable internal pull-down on AC_PRESENT. This change updates macro name to reflect this correctly. BUG=b:69983729 Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/include/soc/pmc.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22688/2 -- To view, visit https://review.coreboot.org/22688 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Gerrit-Change-Number: 22688 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
by Furquan Shaikh (Code Review) 04 Dec '17

04 Dec '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22690 Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT DSX_CFG provides a config option to disable internal pull-down on AC_PRESENT. This change updates macro name to reflect this correctly. Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/include/soc/pmc.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/22690/1 diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 9d6f594..fd89339 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -77,7 +77,7 @@ /* Deep Sx Configuration * DSX_EN_WAKE_PIN - Enable WAKE# pin * DSX_EN_LAN_WAKE_PIN - Enable LAN_WAKE# pin - * DSX_EN_AC_PRESENT_PIN - Enable AC_PRESENT pin */ + * DSX_DIS_AC_PRESENT_PD - Disable pull-down on AC_PRESENT pin */ uint32_t deep_sx_config; /* TCC activation offset */ diff --git a/src/soc/intel/cannonlake/include/soc/pmc.h b/src/soc/intel/cannonlake/include/soc/pmc.h index fd28859..0276d46 100644 --- a/src/soc/intel/cannonlake/include/soc/pmc.h +++ b/src/soc/intel/cannonlake/include/soc/pmc.h @@ -103,7 +103,7 @@ #define REQ_CNV_NOWAKE_DSX (1 << 4) #define REQ_BATLOW_DSX (1 << 3) #define DSX_EN_WAKE_PIN (1 << 2) -#define DSX_EN_AC_PRESENT_PIN (1 << 1) +#define DSX_DIS_AC_PRESENT_PD (1 << 1) #define DSX_EN_LAN_WAKE_PIN (1 << 0) #define DSX_CFG_MASK (0x1f << 0) -- To view, visit https://review.coreboot.org/22690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Gerrit-Change-Number: 22690 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy, nautilus, soraka: Disable PD on AC_PRESENT in deep Sx
by Furquan Shaikh (Code Review) 04 Dec '17

04 Dec '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22689 Change subject: mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx ...................................................................... mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx This change updates device tree deep_sx_config to disable internal pull-down on AC_PRESENT. Change-Id: I041900a5262f8fd920856f126185329242a0639a Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/22689/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 920ab5c..232aea5 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -5,7 +5,7 @@ register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" - register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" + register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD" # GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index fe11a2e..771bd72 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -5,7 +5,7 @@ register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" - register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" + register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD" # GPE configuration # Note that GPE events called out in ASL code rely on this diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index db3f2a2..5e5a537 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -5,7 +5,7 @@ register "deep_s3_enable_dc" = "0" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" - register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN" + register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD" # GPE configuration # Note that GPE events called out in ASL code rely on this -- To view, visit https://review.coreboot.org/22689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a Gerrit-Change-Number: 22689 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017