coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22690 ) Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64064/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18898/ : SUCCESS -- To view, visit https://review.coreboot.org/22690 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce Gerrit-Change-Number: 22690 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:36:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22688 ) Change subject: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64063/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18897/ : SUCCESS -- To view, visit https://review.coreboot.org/22688 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Gerrit-Change-Number: 22688 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:32:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy, nautilus, soraka: Disable PD on AC_PRESENT in deep Sx
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22689 ) Change subject: mb/google/poppy,nautilus,soraka: Disable PD on AC_PRESENT in deep Sx ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/64062/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/18896/ : SUCCESS -- To view, visit https://review.coreboot.org/22689 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I041900a5262f8fd920856f126185329242a0639a Gerrit-Change-Number: 22689 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tony Lin <tonycwlin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:32:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Add SKU ID for Scarlet
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22697 ) Change subject: google/gru: Add SKU ID for Scarlet ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64061/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18895/ : SUCCESS -- To view, visit https://review.coreboot.org/22697 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d889a845950923bc7b5be9b79792cf3c8b6b8ad Gerrit-Change-Number: 22697 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:32:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: boardid: Switch from Kconfig to weak functions
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22695 ) Change subject: boardid: Switch from Kconfig to weak functions ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64060/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/18894/ : SUCCESS -- To view, visit https://review.coreboot.org/22695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97d6d1103ebb2a2a7cf1ecfc45709c7e8c1a5cb0 Gerrit-Change-Number: 22695 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:24:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: boardid: Add helpers to read sku_id strapping into coreboot tables
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22696 ) Change subject: boardid: Add helpers to read sku_id strapping into coreboot tables ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/64059/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/18893/ : SUCCESS -- To view, visit https://review.coreboot.org/22696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aabffe8e1003b0d6fb70d689ae513ca4b46aeda Gerrit-Change-Number: 22696 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:09:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Kconfig: Remove BOARD_ID_MANUAL option
by build bot (Jenkins) (Code Review) 05 Dec '17

05 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22694 ) Change subject: Kconfig: Remove BOARD_ID_MANUAL option ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/18892/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/64058/ : SUCCESS -- To view, visit https://review.coreboot.org/22694 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e7018066eadb38bced96d8eca2ffd4f0dd17110 Gerrit-Change-Number: 22694 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Dec 2017 12:07:41 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: gfx_test: Update i915 binding in wrapper script
by Nico Huber (Code Review) 05 Dec '17

05 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22715 Change subject: gfx_test: Update i915 binding in wrapper script ...................................................................... gfx_test: Update i915 binding in wrapper script Always load i915 even if it wasn't loaded before. Also, force `modeset=1` as that's our use case and we might have booted with `i915.modeset=0`. Last but not least, search for the correct vtcon* entry in sysfs instead of guessing, and always unbind it (i.e. unbind the dummy driver when we want to switch back to i915). Change-Id: Ib62a05a3621aef2992372a6d3acad1196a363a95 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gfxtest/gfx_test.sh 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/15/22715/1 diff --git a/gfxtest/gfx_test.sh b/gfxtest/gfx_test.sh index 9df0005..5315b51 100755 --- a/gfxtest/gfx_test.sh +++ b/gfxtest/gfx_test.sh @@ -35,10 +35,15 @@ while [ `fgconsole` -eq $orig_vt ]; do :; done # take i915 out of charge - echo 0 >/sys/devices/virtual/vtconsole/vtcon1/bind + for vtcon in /sys/devices/virtual/vtconsole/vtcon*; do + if grep -q frame\ buffer $vtcon/name >/dev/null 2>&1; then + echo 0 >$vtcon/bind + break + fi + done # try unloading it - if lsmod | grep -q i915 && modprobe -r i915 >/dev/null 2>&1; then + if modprobe -r i915 >/dev/null 2>&1; then reload_i915=1 fi } @@ -46,11 +51,16 @@ restore_vt() { # reload i915 if [ $reload_i915 -eq 1 ]; then - modprobe i915 + modprobe i915 modeset=1 + else + # put i915 back in charge + for vtcon in /sys/devices/virtual/vtconsole/vtcon*; do + if grep -q dummy $vtcon/name >/dev/null 2>&1; then + echo 0 >$vtcon/bind + break + fi + done fi - - # put i915 back in charge - echo 1 >/sys/devices/virtual/vtconsole/vtcon1/bind # return to original VT chvt $orig_vt -- To view, visit https://review.coreboot.org/22715 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib62a05a3621aef2992372a6d3acad1196a363a95 Gerrit-Change-Number: 22715 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gfx_test: Add top marker for rotated framebuffers
by Nico Huber (Code Review) 05 Dec '17

05 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22714 Change subject: gfx_test: Add top marker for rotated framebuffers ...................................................................... gfx_test: Add top marker for rotated framebuffers Mark the top with an arrow. Desperately needs anti aliasing. Change-Id: Ide0e06c29fefc8b5288714d53ee9fa15df2d5452 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gfxtest/hw-gfx-gma-gfx_test.adb 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/14/22714/1 diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index e0ad71f..514e60f 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -160,6 +160,19 @@ -- We have pixel offset wheras the framebuffer has a byte offset Offset_Y : Natural := Natural (Framebuffer.Offset / 4); Offset : Natural; + + function Top_Test (X, Y : Natural) return Boolean + is + C : constant Natural := Natural (Framebuffer.Width) / 2; + S_Y : constant Natural := 3 * Y / 2; + Left : constant Integer := X - C + S_Y; + Right : constant Integer := X - C - S_Y; + begin + return + Y < 12 and + ((-1 <= Left and Left <= 0) or + (0 <= Right and Right <= 1)); + end Top_Test; begin for Y in 0 .. Natural (Framebuffer.Height) - 1 loop Offset := Offset_Y; @@ -168,6 +181,10 @@ (Y < 32 or Y >= Natural (Framebuffer.Height) - 32) then P := Corner_Fill (X, Y, Framebuffer, Pipe); + elsif Framebuffer.Rotation /= No_Rotation and then + Top_Test (X, Y) + then + P := White; elsif Y mod 16 = 0 or X mod 16 = 0 then P := Black; else -- To view, visit https://review.coreboot.org/22714 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide0e06c29fefc8b5288714d53ee9fa15df2d5452 Gerrit-Change-Number: 22714 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gfx_test: Add rotation parameter
by Nico Huber (Code Review) 05 Dec '17

05 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22713 Change subject: gfx_test: Add rotation parameter ...................................................................... gfx_test: Add rotation parameter Pass the requested rotation through to libgfxinit and enable Y tiling in case of 90° rotations. Change-Id: Icc4c4ee1ce43ecf1603cb673f1a10609494f757d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M gfxtest/gfx_test.sh M gfxtest/hw-gfx-gma-gfx_test.adb 2 files changed, 44 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/13/22713/1 diff --git a/gfxtest/gfx_test.sh b/gfxtest/gfx_test.sh index 9df0005..0115443 100755 --- a/gfxtest/gfx_test.sh +++ b/gfxtest/gfx_test.sh @@ -2,7 +2,7 @@ set -e -usage="Usage: $0 [seconds]\n" +usage="Usage: $0 [<delay seconds> [(0|90|128|270)]]\n" err_msgs= command -v chvt >/dev/null || err_msgs="${err_msgs}"'Need `chvt`\n' @@ -13,7 +13,7 @@ [ -x build/gfx_test ] || \ err_msgs="${err_msgs}"'Please run from *libgfxinit* source dir and build `gfx_test` first.\n' -[ "$#" -gt 1 ] && err_msgs="${err_msgs}${usage}" +[ "$#" -gt 2 ] && err_msgs="${err_msgs}${usage}" if [ -n "$err_msgs" ]; then printf "$err_msgs" diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 4016664..e0ad71f 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -183,25 +183,38 @@ procedure Calc_Framebuffer (FB : out Framebuffer_Type; Mode : in Mode_Type; + Rotation : in Rotation_Type; Offset : in out Word32) is begin Offset := (Offset + FB_Align - 1) and not (FB_Align - 1); - FB := - (Width => Width_Type (Mode.H_Visible), - Height => Height_Type (Mode.V_Visible), - BPC => 8, - Stride => Width_Type ((Word32 (Mode.H_Visible) + 15) and not 15), - V_Stride => Height_Type (Mode.V_Visible), - Tiling => Linear, - Rotation => No_Rotation, - Offset => Offset); + if Rotation = Rotated_90 or Rotation = Rotated_270 then + FB := + (Width => Width_Type (Mode.V_Visible), + Height => Height_Type (Mode.H_Visible), + BPC => 8, + Stride => Div_Round_Up (Pos32 (Mode.V_Visible), 32) * 32, + V_Stride => Div_Round_Up (Pos32 (Mode.H_Visible), 32) * 32, + Tiling => Y_Tiled, + Rotation => Rotation, + Offset => Offset); + else + FB := + (Width => Width_Type (Mode.H_Visible), + Height => Width_Type (Mode.V_Visible), + BPC => 8, + Stride => Div_Round_Up (Pos32 (Mode.H_Visible), 16) * 16, + V_Stride => Height_Type (Mode.V_Visible), + Tiling => Linear, + Rotation => Rotation, + Offset => Offset); + end if; Offset := Offset + Word32 (FB_Size (FB)); end Calc_Framebuffer; Pipes : GMA.Pipe_Configs; - procedure Prepare_Configs + procedure Prepare_Configs (Rotation : Rotation_Type) is use type HW.GFX.GMA.Port_Type; @@ -215,6 +228,7 @@ Calc_Framebuffer (FB => Pipes (Pipe).Framebuffer, Mode => Pipes (Pipe).Mode, + Rotation => Rotation, Offset => Offset); GMA.Setup_Default_FB (FB => Pipes (Pipe).Framebuffer, @@ -233,7 +247,9 @@ is begin Debug.Put_Line - ("Usage: " & Ada.Command_Line.Command_Name & " <delay seconds>"); + ("Usage: " & Ada.Command_Line.Command_Name & + " <delay seconds>" & + " [(0|90|180|270)]"); Debug.New_Line; end Print_Usage; @@ -246,6 +262,7 @@ Res_Addr : Word64; Delay_S : Natural; + Rotation : Rotation_Type := No_Rotation; Dev_Init, Initialized : Boolean; @@ -253,12 +270,24 @@ function iopl (level : Interfaces.C.int) return Interfaces.C.int; pragma Import (C, iopl, "iopl"); begin - if Ada.Command_Line.Argument_Count /= 1 then + if Ada.Command_Line.Argument_Count < 1 then Print_Usage; return; end if; Delay_S := Natural'Value (Ada.Command_Line.Argument (1)); + + if Ada.Command_Line.Argument_Count >= 2 then + declare + Rotation_Degree : constant String := Ada.Command_Line.Argument (2); + begin + if Rotation_Degree = "0" then Rotation := No_Rotation; + elsif Rotation_Degree = "90" then Rotation := Rotated_90; + elsif Rotation_Degree = "180" then Rotation := Rotated_180; + elsif Rotation_Degree = "270" then Rotation := Rotated_270; + else Print_Usage; return; end if; + end; + end if; if iopl (3) /= 0 then Debug.Put_Line ("Failed to change i/o privilege level."); @@ -292,7 +321,7 @@ if Initialized then Backup_GTT; - Prepare_Configs; + Prepare_Configs (Rotation); GMA.Update_Outputs (Pipes); -- To view, visit https://review.coreboot.org/22713 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icc4c4ee1ce43ecf1603cb673f1a10609494f757d Gerrit-Change-Number: 22713 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017