coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: soc/intel/apollolake: Make use of Intel common Graphics block
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22616 ) Change subject: soc/intel/apollolake: Make use of Intel common Graphics block ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18800/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63941/ : SUCCESS -- To view, visit https://review.coreboot.org/22616 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0edd7454912201598c43e35990e470ec18a32638 Gerrit-Change-Number: 22616 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 10:15:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common Graphics controller support
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22614 ) Change subject: soc/intel/common/block: Add Intel common Graphics controller support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18798/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63939/ : SUCCESS -- To view, visit https://review.coreboot.org/22614 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbc73854ce9fc21a8a3e3663a98e01fc94d5a5e4 Gerrit-Change-Number: 22614 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 10:13:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63937/ : SUCCESS -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 6 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 10:12:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Make use of Intel common Graphics block
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22615 ) Change subject: soc/intel/skylake: Make use of Intel common Graphics block ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18799/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63940/ : SUCCESS -- To view, visit https://review.coreboot.org/22615 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I416226d0374700cea6eea602f839c3d17f1f39a6 Gerrit-Change-Number: 22615 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 10:07:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Add PNP config
by Divya Chellappa (Code Review) 30 Nov '17

30 Nov '17

Divya Chellappa has uploaded a new patch set (#6). ( https://review.coreboot.org/22488 ) Change subject: soc/intel/apollolake: Add PNP config ...................................................................... soc/intel/apollolake: Add PNP config 1. Programs PNP values for AUNIT, BUNIT & TUNIT registers as per reference code. 2. A new configuration option pnp_settings is introduced in devicetree.cb to select PNP settings among performance, power, power & performance. TEST = built and booted glkrvp, verfied that the callback gets control, verified warm and cold reboots. Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Signed-off-by: Divya Chellap <divya.chellappa(a)intel.com> --- M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/include/soc/pcr_ids.h A src/soc/intel/apollolake/include/soc/pnpconfig.h A src/soc/intel/apollolake/pnpconfig.c 5 files changed, 860 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22488/6 -- To view, visit https://review.coreboot.org/22488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd70a42c9406941c8a93cc972f22c2475e9d0200 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 6 Gerrit-Owner: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chellappa(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/cannonlake_rvp: Enable Touchpad
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22369 ) Change subject: mb/cannonlake_rvp: Enable Touchpad ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/18796/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63935/ : SUCCESS -- To view, visit https://review.coreboot.org/22369 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I461b9d119b1cac6c8c6cb9b096697f58e00d80ad Gerrit-Change-Number: 22369 Gerrit-PatchSet: 4 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: Wei-nan Liu <wei-nan.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 07:58:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/glkrvp: Enable Touchpad
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22627 ) Change subject: mb/glkrvp: Enable Touchpad ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63936/ : SUCCESS -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 2 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 07:53:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/glkrvp: Enable Touchpad
by build bot (Jenkins) (Code Review) 30 Nov '17

30 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22627 ) Change subject: mb/glkrvp: Enable Touchpad ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/63934/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/18795/ : SUCCESS -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 Nov 2017 07:45:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/mainboard/glkrvp: Enable Touchpad
by Shaunak Saha (Code Review) 30 Nov '17

30 Nov '17

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/22627 ) Change subject: src/mainboard/glkrvp: Enable Touchpad ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22627/1/src/mainboard/intel/glkrvp/dsdt.asl File src/mainboard/intel/glkrvp/dsdt.asl: https://review.coreboot.org/#/c/22627/1/src/mainboard/intel/glkrvp/dsdt.asl… PS1, Line 18: This change is not related to the touchpad. I can put it in separate CL if suggested. -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Comment-Date: Thu, 30 Nov 2017 07:43:46 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/mainboard/glkrvp: Enable Touchpad
by Shaunak Saha (Code Review) 30 Nov '17

30 Nov '17

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/22627 Change subject: src/mainboard/glkrvp: Enable Touchpad ...................................................................... src/mainboard/glkrvp: Enable Touchpad This patch enables the APLS touchpad in glkrvp platform. TEST= Boot and test touchpad works. Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb 3 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22627/1 diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 56ab00b..dfb53b8 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -4,13 +4,13 @@ select SOC_INTEL_GLK select BOARD_ROMSIZE_KB_16384 select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID select DRIVERS_PS2_KEYBOARD select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2 - select DRIVERS_I2C_GENERIC select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 diff --git a/src/mainboard/intel/glkrvp/dsdt.asl b/src/mainboard/intel/glkrvp/dsdt.asl index 9dee22a..3a80f6c 100644 --- a/src/mainboard/intel/glkrvp/dsdt.asl +++ b/src/mainboard/intel/glkrvp/dsdt.asl @@ -14,8 +14,7 @@ */ #include <variant/ec.h> -#define GPE_EC_WAKE 0x26 -#define EC_SCI_GPI GPE0_DW1_05 +#include <variant/gpio.h> DefinitionBlock( "dsdt.aml", @@ -66,6 +65,4 @@ /* Include common dptf ASL files */ #include <soc/intel/common/acpi/dptf/dptf.asl> } - #include "touchpad.asl" - #include "touchpanel.asl" } diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb index 4b93947..c083145 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb +++ b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb @@ -143,7 +143,15 @@ device pci 16.1 off end # - I2C 1 device pci 16.2 off end # - I2C 2 device pci 16.3 off end # - I2C 3 - device pci 17.0 on end # - I2C 4 + device pci 17.0 on + chip drivers/i2c/hid + register "generic.hid" = ""ALPS0001"" + register "generic.desc" = ""Touchpad"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)" + register "hid_desc_reg_offset" = "0x1" + device i2c 2C on end + end + end # I2C 4 device pci 17.1 off end # - I2C 5 device pci 17.2 off end # - I2C 6 device pci 17.3 on end # - I2C 7 -- To view, visit https://review.coreboot.org/22627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f Gerrit-Change-Number: 22627 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
163
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017