coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: device/device_util: Add string for DEVICE_PATH_NONE
by Patrick Rudolph (Code Review) 01 Nov '17

01 Nov '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/22272 Change subject: device/device_util: Add string for DEVICE_PATH_NONE ...................................................................... device/device_util: Add string for DEVICE_PATH_NONE Add string for DEVICE_PATH_NONE in dev_path. The enum DEVICE_PATH_NONE can be translated to string and should not be translated by "Unknown device path type: 0". Makes console output a lot prettier and readable. Note: DEVICE_PATH_NONE is used as dummy devices for hotplugable slots. Change-Id: I08d471d8217f966e80daefe2d9971e357defde62 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/device/device_util.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/22272/1 diff --git a/src/device/device_util.c b/src/device/device_util.c index 762f0e7..03ba43d 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -274,6 +274,9 @@ memcpy(buffer, "<null>", 7); } else { switch(dev->path.type) { + case DEVICE_PATH_NONE: + memcpy(buffer, "NONE", 5); + break; case DEVICE_PATH_ROOT: memcpy(buffer, "Root Device", 12); break; -- To view, visit https://review.coreboot.org/22272 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I08d471d8217f966e80daefe2d9971e357defde62 Gerrit-Change-Number: 22272 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: genbuild_h: git builds: Make date(1) lang, locale, and timezone indep...
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18415 ) Change subject: genbuild_h: git builds: Make date(1) lang, locale, and timezone independent ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17772/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62774/ : SUCCESS -- To view, visit https://review.coreboot.org/18415 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If67db4aaa5e72d58e149d34f8d230c42cf503e33 Gerrit-Change-Number: 18415 Gerrit-PatchSet: 2 Gerrit-Owner: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 09:21:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22210 ) Change subject: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17771/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62773/ : SUCCESS -- To view, visit https://review.coreboot.org/22210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741b0b2f87eb9147c375b405a5b6989a10c7ad0a Gerrit-Change-Number: 22210 Gerrit-PatchSet: 6 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 07:36:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22210 ) Change subject: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62772/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/17770/ : SUCCESS -- To view, visit https://review.coreboot.org/22210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741b0b2f87eb9147c375b405a5b6989a10c7ad0a Gerrit-Change-Number: 22210 Gerrit-PatchSet: 5 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 07:23:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22210 ) Change subject: mainboard/compulab_ltd: support for CompuLab Ltd. Intense-PC ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62771/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/17769/ : SUCCESS -- To view, visit https://review.coreboot.org/22210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741b0b2f87eb9147c375b405a5b6989a10c7ad0a Gerrit-Change-Number: 22210 Gerrit-PatchSet: 4 Gerrit-Owner: Hal Martin <hal.martin+coreboot(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 07:22:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vx900: skip remap of high memory ranges if unnecessary
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22271 ) Change subject: vx900: skip remap of high memory ranges if unnecessary ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17768/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62770/ : SUCCESS -- To view, visit https://review.coreboot.org/22271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic221723a26c5d1a03bf34c7722b0abe115f456ba Gerrit-Change-Number: 22271 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 06:59:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vx900/chrome9hd: fix a trivial typo
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22270 ) Change subject: vx900/chrome9hd: fix a trivial typo ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17767/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62769/ : SUCCESS -- To view, visit https://review.coreboot.org/22270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe6a6dc63454deacfd12de6dad2d6a792474f55 Gerrit-Change-Number: 22270 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 06:57:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vx900: skip remap of high memory ranges if unnecessary
by Lubomir Rintel (Code Review) 01 Nov '17

01 Nov '17

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/22271 Change subject: vx900: skip remap of high memory ranges if unnecessary ...................................................................... vx900: skip remap of high memory ranges if unnecessary If the DRAM does *not* actually overlap the PCI space, the remap code notices it is the case, but for some reason proceeds with the remapping, attempting to remap a negatively sized chunk. Bummer. With a single 1024M (two ranks of 512M) module: Nothing to remap Mem remapping enabled Remapstart 5120(MB) Remapend 6144(MB) Top of RAM 1024MB New top of RAM 2560MB Wrote remap map a0101 Mem remapping enabled Remapstart 4096(MB) Remapend 2560(MB) New top of memory is at 2560MB Needless to say, subsequent ram_resource() ruins the memory map for the OS -- Linux won't boot without a mem= argument and memtest quickly. TEST=memtest and Linux boot on HP t5550 with 1024M of memory Change-Id: Ic221723a26c5d1a03bf34c7722b0abe115f456ba Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M src/northbridge/via/vx900/northbridge.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/22271/1 diff --git a/src/northbridge/via/vx900/northbridge.c b/src/northbridge/via/vx900/northbridge.c index 3638293..774f744 100644 --- a/src/northbridge/via/vx900/northbridge.c +++ b/src/northbridge/via/vx900/northbridge.c @@ -120,6 +120,7 @@ */ if (tolm >= vx900_get_top_of_ram(mcu)) { printk(BIOS_DEBUG, "Nothing to remap\n"); + return 0; } /* This is how the Vendor BIOS. Keep it for comparison for now */ @@ -275,7 +276,8 @@ uma_memory_size >> 20); /* FIXME: How do we handle remapping above 4G? */ u64 tor = vx900_remap_above_4g(mcu, pci_tolm); - ram_resource(dev, idx++, RAM_4GB >> 10, (tor - RAM_4GB) >> 10); + if (tor) + ram_resource(dev, idx++, RAM_4GB >> 10, (tor - RAM_4GB) >> 10); set_late_cbmem_top(tolmk << 10); -- To view, visit https://review.coreboot.org/22271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic221723a26c5d1a03bf34c7722b0abe115f456ba Gerrit-Change-Number: 22271 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in coreboot[master]: vx900/chrome9hd: fix a trivial typo
by Lubomir Rintel (Code Review) 01 Nov '17

01 Nov '17

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/22270 Change subject: vx900/chrome9hd: fix a trivial typo ...................................................................... vx900/chrome9hd: fix a trivial typo Change-Id: Ibfe6a6dc63454deacfd12de6dad2d6a792474f55 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M src/northbridge/via/vx900/chrome9hd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/22270/1 diff --git a/src/northbridge/via/vx900/chrome9hd.c b/src/northbridge/via/vx900/chrome9hd.c index 333b28d..147b308 100644 --- a/src/northbridge/via/vx900/chrome9hd.c +++ b/src/northbridge/via/vx900/chrome9hd.c @@ -89,7 +89,7 @@ tom_mb = (pci_read_config16(mcu, 0x88) & 0x07ff) << (24 - 20); max_size_mb = tom_mb >> 2; if (size_mb > max_size_mb) { - printk(BIOS_ALERT, "The framebuffer size of of %dMB is larger" + printk(BIOS_ALERT, "The framebuffer size of %dMB is larger" " than 1/4 of available memory.\n" " Limiting framebuffer to %dMB\n", size_mb, max_size_mb); size_mb = max_size_mb; -- To view, visit https://review.coreboot.org/22270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfe6a6dc63454deacfd12de6dad2d6a792474f55 Gerrit-Change-Number: 22270 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in coreboot[master]: mainboard/google/coral: Update touchscreen device ACPI nodes
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22252 ) Change subject: mainboard/google/coral: Update touchscreen device ACPI nodes ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/62768/ : SUCCESS -- To view, visit https://review.coreboot.org/22252 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf501b40ecfc957fd8be7ebffd2357dfa0e07757 Gerrit-Change-Number: 22252 Gerrit-PatchSet: 2 Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 06:42:10 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017