coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add ACPI fan control
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21227 ) Change subject: ec/lenovo/h8/acpi/thermal: Add ACPI fan control ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62969/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/17932/ : SUCCESS -- To view, visit https://review.coreboot.org/21227 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I075ff5c69676927db1c5e731294e18796884f97e Gerrit-Change-Number: 21227 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Vasya Boytsov <vasiliy.boytsov(a)phystech.edu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 14:07:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add support for passive cooling
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21223 ) Change subject: ec/lenovo/h8/acpi/thermal: Add support for passive cooling ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62968/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/17931/ : SUCCESS -- To view, visit https://review.coreboot.org/21223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922923a9029de77158988ac254bab4aad9536935 Gerrit-Change-Number: 21223 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Vasya Boytsov <vasiliy.boytsov(a)phystech.edu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 14:07:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86/acpigen: Add function to write a CPU package
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21324 ) Change subject: arch/x86/acpigen: Add function to write a CPU package ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/62966/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/17929/ : SUCCESS -- To view, visit https://review.coreboot.org/21324 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e9ebad84343d1fb282b3fbb28f5f014f664f14 Gerrit-Change-Number: 21324 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Vasya Boytsov <vasiliy.boytsov(a)phystech.edu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 14:07:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/acpi: add mechanisms to clear EC output queue
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22180 ) Change subject: ec/acpi: add mechanisms to clear EC output queue ...................................................................... Patch Set 23: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17928/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62965/ : SUCCESS -- To view, visit https://review.coreboot.org/22180 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee031306c02f5211a4512c6b4ec90f7f0db196ae Gerrit-Change-Number: 22180 Gerrit-PatchSet: 23 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 12:53:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Clear EC output queue before enablement
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22181 ) Change subject: ec/lenovo/h8: Clear EC output queue before enablement ...................................................................... Patch Set 23: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17927/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62964/ : SUCCESS -- To view, visit https://review.coreboot.org/22181 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1733f7350232d0b10ac0d1bc912b62e7fa4da75 Gerrit-Change-Number: 22181 Gerrit-PatchSet: 23 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Schander <coreboot(a)mimoja.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 12:45:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22329 ) Change subject: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17926/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62963/ : SUCCESS -- To view, visit https://review.coreboot.org/22329 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 11:46:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Clarify the raminit memory mapping
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22328 ) Change subject: nb/intel/x4x: Clarify the raminit memory mapping ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/62962/ : SUCCESS -- To view, visit https://review.coreboot.org/22328 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7 Gerrit-Change-Number: 22328 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 11:45:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training
by Arthur Heymans (Code Review) 04 Nov '17

04 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22329 to look at the new patch set (#3). Change subject: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training ...................................................................... [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training Code looks bad and does weird things over ranks. Should probably do things like gm45 and train one lane over all available ranks. Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/Makefile.inc A src/northbridge/intel/x4x/dq_dqs.c M src/northbridge/intel/x4x/raminit_ddr2.c M src/northbridge/intel/x4x/x4x.h 4 files changed, 629 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/22329/3 -- To view, visit https://review.coreboot.org/22329 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/x4x: Clarify the raminit memory mapping
by Arthur Heymans (Code Review) 04 Nov '17

04 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22328 to look at the new patch set (#3). Change subject: nb/intel/x4x: Clarify the raminit memory mapping ...................................................................... nb/intel/x4x: Clarify the raminit memory mapping This replaces magic values by macros and adds some comments to improve readability. C1DRB3 Channel 1, rank 3 is now changed (MCHBAR16(0x606) is now 0x0008 instead of 0x0010). Having that rank populated was probably never tested. Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/raminit_ddr2.c M src/northbridge/intel/x4x/x4x.h 2 files changed, 84 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/22328/3 -- To view, visit https://review.coreboot.org/22328 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7 Gerrit-Change-Number: 22328 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22329 ) Change subject: [WIP/UNTESTED]nb/intel/x4x: Implement both read and write training ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17925/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62961/ : SUCCESS -- To view, visit https://review.coreboot.org/22329 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 10:22:53 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017