coreboot-gerrit November 2017

coreboot-gerrit@coreboot.org

1 participants
1623 discussions

Change in coreboot[master]: drvs/lenovo/hybrid_graphics/romstage: Fix switching while on power
by Patrick Rudolph (Code Review) 04 Nov '17

04 Nov '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/22341 Change subject: drvs/lenovo/hybrid_graphics/romstage: Fix switching while on power ...................................................................... drvs/lenovo/hybrid_graphics/romstage: Fix switching while on power Don't assume default values in PMH7 on boot. Change-Id: I30ec19e13269cb254e51ad1fab3b10ad1a49e86e Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/lenovo/hybrid_graphics/romstage.c 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/22341/1 diff --git a/src/drivers/lenovo/hybrid_graphics/romstage.c b/src/drivers/lenovo/hybrid_graphics/romstage.c index 9009c58..e46b7f6 100644 --- a/src/drivers/lenovo/hybrid_graphics/romstage.c +++ b/src/drivers/lenovo/hybrid_graphics/romstage.c @@ -77,13 +77,28 @@ /* * Need to do power handling here as we know there's a dGPU to - * turn off. Support GPIO and Thinker1. + * turn on/off. Support GPIO and Thinker1. */ - if (!*enable_peg) { + if (*enable_peg) { + if (config->has_dgpu_power_gpio) { + set_gpio(config->dgpu_power_gpio, + ~config->dgpu_power_off_lvl); + } else if (config->has_thinker1 && + !(pmh7_register_read(0x50) & 0x08)) { + pmh7_register_set_bit(0x50, 3); // DGPU_PWR + pmh7_register_clear_bit(0x50, 7); // DGPU_RST + mdelay(10); + pmh7_register_set_bit(0x50, 7); // DGPU_RST + } else { + printk(BIOS_ERR, "Hybrid graphics:" + " FIXME: dGPU power not enabled !\n"); + } + } else { if (config->has_dgpu_power_gpio) { set_gpio(config->dgpu_power_gpio, config->dgpu_power_off_lvl); - } else if (config->has_thinker1) { + } else if (config->has_thinker1 && + (pmh7_register_read(0x50) & 0x08)) { pmh7_register_clear_bit(0x50, 7); // DGPU_RST udelay(100); pmh7_register_clear_bit(0x50, 3); // DGPU_PWR -- To view, visit https://review.coreboot.org/22341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I30ec19e13269cb254e51ad1fab3b10ad1a49e86e Gerrit-Change-Number: 22341 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: nb/intel/sandybridge/peg: Add PEG driver
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22337 ) Change subject: nb/intel/sandybridge/peg: Add PEG driver ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17963/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63002/ : SUCCESS -- To view, visit https://review.coreboot.org/22337 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96835c43522580c95fd4f250c56bf9438e993bc1 Gerrit-Change-Number: 22337 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 18:32:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge/peg: Add PEG driver
by Patrick Rudolph (Code Review) 04 Nov '17

04 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22337 to look at the new patch set (#3). Change subject: nb/intel/sandybridge/peg: Add PEG driver ...................................................................... nb/intel/sandybridge/peg: Add PEG driver Required for other ACPI generators, like the one used for _ROM. * Add ACPI code for PEG10/PEG11/PEG12/PEG60 and include it on all platforms. * Add PCIe driver for PEG. The driver returns ACPI names for ssdt generators and includes an ACPI generator to write _STA method. Needs test on real hardware. Change-Id: I96835c43522580c95fd4f250c56bf9438e993bc1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/sandybridge/Makefile.inc M src/northbridge/intel/sandybridge/acpi/hostbridge.asl A src/northbridge/intel/sandybridge/acpi/peg.asl M src/northbridge/intel/sandybridge/acpi/sandybridge.asl A src/northbridge/intel/sandybridge/pcie.c M src/southbridge/intel/bd82x6x/acpi/default_irq_route.asl 6 files changed, 308 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/22337/3 -- To view, visit https://review.coreboot.org/22337 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I96835c43522580c95fd4f250c56bf9438e993bc1 Gerrit-Change-Number: 22337 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22340 ) Change subject: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/63001/ : SUCCESS -- To view, visit https://review.coreboot.org/22340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Gerrit-Change-Number: 22340 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 17:59:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate
by Matt DeVillier (Code Review) 04 Nov '17

04 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22340 to look at the new patch set (#2). Change subject: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate ...................................................................... google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate some Google boards were missing this selection, which led to them being incorrectly identified as type 'Desktop' in SMBIOS type 3 table. TEST: boot Linux and check correct chassis type listed via dmidecode Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/chell/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/lars/Kconfig M src/mainboard/google/rambi/Kconfig 6 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/22340/2 -- To view, visit https://review.coreboot.org/22340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Gerrit-Change-Number: 22340 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22340 ) Change subject: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17962/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/63000/ : SUCCESS -- To view, visit https://review.coreboot.org/22340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Gerrit-Change-Number: 22340 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 17:49:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate
by Matt DeVillier (Code Review) 04 Nov '17

04 Nov '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/22340 Change subject: google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate ...................................................................... google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate some Google boards were missing this selection, which led to them being incorrectly identified as type 'Desktop' in SMBIOS type 3 table. TEST: boot Linux and check chassis type correct listed via dmidecode Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/auron/Kconfig M src/mainboard/google/chell/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/lars/Kconfig M src/mainboard/google/rambi/Kconfig 6 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/22340/1 diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 8cf7e8f..791dcba 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -11,6 +11,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select INTEL_INT15 + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_AURON diff --git a/src/mainboard/google/chell/Kconfig b/src/mainboard/google/chell/Kconfig index 277c98f..c09ad48 100644 --- a/src/mainboard/google/chell/Kconfig +++ b/src/mainboard/google/chell/Kconfig @@ -19,6 +19,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 0ecb317..7b8fd44 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -13,6 +13,7 @@ select SOC_INTEL_BRASWELL select HAVE_ACPI_RESUME select PCIEXP_L1_SUB_STATE if !BOARD_GOOGLE_CYAN + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_CYAN diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 1a19fd1..b893a6a 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -19,6 +19,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig index 4a49460..e274b13 100644 --- a/src/mainboard/google/lars/Kconfig +++ b/src/mainboard/google/lars/Kconfig @@ -21,6 +21,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index c1b0ca2..3db8ac6 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -10,6 +10,7 @@ select HAVE_ACPI_RESUME select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM + select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO if BOARD_GOOGLE_BASEBOARD_RAMBI -- To view, visit https://review.coreboot.org/22340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a Gerrit-Change-Number: 22340 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add ACPI fan control
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21227 ) Change subject: ec/lenovo/h8/acpi/thermal: Add ACPI fan control ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17961/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62999/ : SUCCESS -- To view, visit https://review.coreboot.org/21227 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I075ff5c69676927db1c5e731294e18796884f97e Gerrit-Change-Number: 21227 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Vasya Boytsov <vasiliy.boytsov(a)phystech.edu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 17:33:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Add SMU firmware blobs to cbfs
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22057 ) Change subject: amd/stoneyridge: Add SMU firmware blobs to cbfs ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17957/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62995/ : SUCCESS -- To view, visit https://review.coreboot.org/22057 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8510823e2232b74ec6fe001cc28953f53b2aa520 Gerrit-Change-Number: 22057 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 17:19:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Load SMU fimware using PSP
by build bot (Jenkins) (Code Review) 04 Nov '17

04 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22058 ) Change subject: soc/amd/stoneyridge: Load SMU fimware using PSP ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/17959/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/62997/ : SUCCESS -- To view, visit https://review.coreboot.org/22058 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf768e54a7c3b3e7cf07e266a6906923c0fad42 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 Nov 2017 17:18:54 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2017