the following patch was just integrated into master:
commit f6776fa62c84ae516f84c99859d826f77d508079
Author: Paul Menzel <pmenzel(a)molgen.mpg.de>
Date: Fri Jan 20 14:49:35 2017 +0100
amd/amdht: Fix format security errors
Ubuntu’s default compiler flags for GCC [1][2] include `-Wformat
-Wformat-security`, causing errors similar like the one below.
```
CC romstage/northbridge/amd/amdht/ht_wrapper.o
src/northbridge/amd/amdht/ht_wrapper.c: In function 'AMD_CB_EventNotify':
src/northbridge/amd/amdht/ht_wrapper.c:124:4: error: format not a string literal and no format arguments [-Werror=format-security]
printk(log_level, event_class_string_decodes[evtClass]);
^
[…]
```
Fix that, by explicitly using a format string.
TEST=Built and booted on ASUS KGPE-D16.
[1] https://stackoverflow.com/questions/17260409/fprintf-error-format-not-a-str…
"fprintf, error: format not a string literal and no format arguments [-Werror=format-security"
[2] I tested with gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609.
Change-Id: Iabe60deeffa441146eab31dac4416846ce95c32a
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18208
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
See https://review.coreboot.org/18208 for details.
-gerrit
Iru Cai (mytbk920423(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14209
-gerrit
commit 8b8704807d8331829fa6039da7f220a70c0df3d6
Author: Iru Cai <mytbk920423(a)gmail.com>
Date: Thu Mar 31 23:13:09 2016 +0800
hp/2760p: reserve space in bootblock
The space started from 0x7ff700 is reserved for data needed by (maybe)
EC.
Change-Id: Iae7eb8a67fcce173500d91951ee71a3361475fc9
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
---
src/mainboard/hp/2760p/Kconfig | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig
index 440c1f6..295785f 100644
--- a/src/mainboard/hp/2760p/Kconfig
+++ b/src/mainboard/hp/2760p/Kconfig
@@ -62,4 +62,13 @@ config MAX_CPUS
config USBDEBUG_HCD_INDEX
int
default 1
+
+config ID_SECTION_OFFSET
+ hex
+ default 0x900
+
+config RESERVED_SPACE_BEFORE_RESET_VECTOR
+ hex
+ default 0xa00
+
endif
Iru Cai (mytbk920423(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14208
-gerrit
commit 8ee8150a09904f19fffdabbdd415b7b43069f2c0
Author: Iru Cai <mytbk920423(a)gmail.com>
Date: Thu Mar 31 15:32:25 2016 +0800
[RFC] add CONFIG_RESERVED_SPACE_BEFORE_RESET_VECTOR
HP Elitebook 2760p (and some other HP laptops) stores some data which
may be used by EC in bootblock region. So some space needs to be
reserved before the reset vector.
Change-Id: I992d285a1a76883ff7a69445a0ff9efe62dbbd7f
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
---
src/arch/x86/Kconfig | 4 ++++
src/arch/x86/failover.ld | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 6280024..1daddd9 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -181,6 +181,10 @@ config ID_SECTION_OFFSET
hex
default 0x80
+config RESERVED_SPACE_BEFORE_RESET_VECTOR
+ hex
+ default 0xf0
+
# 64KiB default bootblock size when employing C_ENVIRONMENT_BOOTBLOCK.
config C_ENV_BOOTBLOCK_SIZE
hex
diff --git a/src/arch/x86/failover.ld b/src/arch/x86/failover.ld
index e9613d9..a434704 100644
--- a/src/arch/x86/failover.ld
+++ b/src/arch/x86/failover.ld
@@ -50,8 +50,8 @@ SECTIONS
* may cause the total size of a section to change when the start
* address gets applied.
*/
- ROMLOC_MIN = 0xffffff00 - (_erom - _rom + 16) -
- (CONFIG_SIPI_VECTOR_IN_ROM ? 4096 : 0);
+ ROMLOC_MIN = 0xfffffff0 - CONFIG_RESERVED_SPACE_BEFORE_RESET_VECTOR
+ - (_erom - _rom + 16) - (CONFIG_SIPI_VECTOR_IN_ROM ? 4096 : 0);
/* Post-check proper SIPI vector. */
_bogus = ASSERT(!CONFIG_SIPI_VECTOR_IN_ROM || ((ap_sipi_vector & 0x0fff) == 0x0),
Naresh Solanki (naresh.solanki(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18234
-gerrit
commit e38e6d13f6f39545eb236ec17060ed3e057adcca
Author: Naresh G Solanki <naresh.solanki(a)intel.com>
Date: Wed Jan 25 22:42:24 2017 +0530
soc/intel/skylake: Add include path for FSP UPD
FSP binary comes along with FSP UPD header. The header
file present in src/vendorcode/intel/fsp/fsp2_0/skykabylake
may be not in sync with currently used fsp binary.
Hence add include path for FSP UPD header to
3rdparty/blobs/mainboard/$(MAINBOARD)/fsp/ to be
considered during build.
Change-Id: Iaeae6a845e57a285a0737b0dff7c95bf20f56b12
Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com>
---
src/soc/intel/skylake/Makefile.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc
index 4b6fcfc..743a4f3 100644
--- a/src/soc/intel/skylake/Makefile.inc
+++ b/src/soc/intel/skylake/Makefile.inc
@@ -109,6 +109,8 @@ smm-$(CONFIG_UART_DEBUG) += uart_debug.c
CPPFLAGS_common += -I$(src)/soc/intel/skylake
CPPFLAGS_common += -I$(src)/soc/intel/skylake/include
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD)/fsp/
+
ifeq ($(CONFIG_PLATFORM_USES_FSP1_1),y)
CPPFLAGS_common += -I$(src)/soc/intel/skylake/include/fsp11
CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/skylake
Naresh Solanki (naresh.solanki(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18234
-gerrit
commit 69b5a9a26821df32b224dfacd3318170ccb56544
Author: Naresh G Solanki <naresh.solanki(a)intel.com>
Date: Wed Jan 25 22:42:24 2017 +0530
soc/intel/skylake: Add include path for FSP UPD
FSP binary comes along with FSP UPD header. The header
file present in src/vendorcode/intel/fsp/fsp2_0/skykabylake
may be not in sync with currently used fsp binary.
Hence use the config to specify path to FSP UPD header
to be considered during build.
Change-Id: Iaeae6a845e57a285a0737b0dff7c95bf20f56b12
Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com>
---
src/soc/intel/skylake/Makefile.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc
index 4b6fcfc..743a4f3 100644
--- a/src/soc/intel/skylake/Makefile.inc
+++ b/src/soc/intel/skylake/Makefile.inc
@@ -109,6 +109,8 @@ smm-$(CONFIG_UART_DEBUG) += uart_debug.c
CPPFLAGS_common += -I$(src)/soc/intel/skylake
CPPFLAGS_common += -I$(src)/soc/intel/skylake/include
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD)/fsp/
+
ifeq ($(CONFIG_PLATFORM_USES_FSP1_1),y)
CPPFLAGS_common += -I$(src)/soc/intel/skylake/include/fsp11
CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/skylake