Matt DeVillier (matt.devillier(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18249
-gerrit
commit 7b8dd5275f8fd7e39cfd78518370ceb075fe1dda
Author: Matt DeVillier <matt.devillier(a)gmail.com>
Date: Thu Jan 26 10:58:15 2017 -0600
google/jecht: Fix LED for guado/rikku variants
When guado/rikku/tidus were rolled into jecht, an error was
made in set_power_led() as guado/rikku set the polarity
differently than tidus. Fix the power LED for guado/rikku
by setting the polarity correctly.
Test: boot guado/rikku and observe proper function of power LED
under S0, S3, and S5 power states.
Change-Id: I23072ac60bc9683776f748ca1326d98257c3c54f
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
src/mainboard/google/jecht/led.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/google/jecht/led.c b/src/mainboard/google/jecht/led.c
index 50cf32e..286b65e 100644
--- a/src/mainboard/google/jecht/led.c
+++ b/src/mainboard/google/jecht/led.c
@@ -19,10 +19,18 @@
void set_power_led(int state)
{
+ int polarity;
+
+ if (IS_ENABLED(CONFIG_BOARD_GOOGLE_TIDUS)) {
+ polarity = state == LED_OFF ? 0x00 : 0x01;
+ } else {
+ polarity = state == LED_BLINK ? 0x01 : 0x00;
+ }
+
it8772f_gpio_led(IT8772F_GPIO_DEV,
1, /* set */
0x01, /* select */
- state == LED_OFF ? 0x00 : 0x01, /* polarity */
+ polarity, /* polarity */
state == LED_BLINK ? 0x01 : 0x00, /* pullup/pulldown */
0x01, /* output */
state == LED_BLINK ? 0x00 : 0x01, /* I/O function */
Iru Cai (mytbk920423(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14208
-gerrit
commit 061bad5b78a6ef80ddc91c27344e0e95d85ad68a
Author: Iru Cai <mytbk920423(a)gmail.com>
Date: Thu Mar 31 15:32:25 2016 +0800
[RFC] add CONFIG_RESERVED_SPACE_BEFORE_RESET_VECTOR
HP Elitebook 2760p (and some other HP laptops) stores some data which
may be used by EC in bootblock region. So some space needs to be
reserved before the reset vector.
Change-Id: I992d285a1a76883ff7a69445a0ff9efe62dbbd7f
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
---
src/arch/x86/Kconfig | 4 ++++
src/arch/x86/failover.ld | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 6280024..1daddd9 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -181,6 +181,10 @@ config ID_SECTION_OFFSET
hex
default 0x80
+config RESERVED_SPACE_BEFORE_RESET_VECTOR
+ hex
+ default 0xf0
+
# 64KiB default bootblock size when employing C_ENVIRONMENT_BOOTBLOCK.
config C_ENV_BOOTBLOCK_SIZE
hex
diff --git a/src/arch/x86/failover.ld b/src/arch/x86/failover.ld
index e9613d9..a434704 100644
--- a/src/arch/x86/failover.ld
+++ b/src/arch/x86/failover.ld
@@ -50,8 +50,8 @@ SECTIONS
* may cause the total size of a section to change when the start
* address gets applied.
*/
- ROMLOC_MIN = 0xffffff00 - (_erom - _rom + 16) -
- (CONFIG_SIPI_VECTOR_IN_ROM ? 4096 : 0);
+ ROMLOC_MIN = 0xfffffff0 - CONFIG_RESERVED_SPACE_BEFORE_RESET_VECTOR
+ - (_erom - _rom + 16) - (CONFIG_SIPI_VECTOR_IN_ROM ? 4096 : 0);
/* Post-check proper SIPI vector. */
_bogus = ASSERT(!CONFIG_SIPI_VECTOR_IN_ROM || ((ap_sipi_vector & 0x0fff) == 0x0),
the following patch was just integrated into master:
commit 27f3ce6337b293cfc7be0eb8592feb411cf2cc5f
Author: Martin Roth <martinroth(a)google.com>
Date: Tue Jan 24 21:13:18 2017 -0700
board_status/to-wiki: Update bucketize script
- Fix TODO: restrict $1 to allowed values.
- Specifically exclude 'oem' board status directories.
- Exclude any directory that doesn't follow the date format to keep
the script from breaking again in the future if something it doesn't
recognize is pushed. Just ignore it for the wiki.
- Fix shellcheck warnings.
Change-Id: I2864f09f5f1b1f5ec626d06e4849830400ef5814
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/18225
Tested-by: build bot (Jenkins)
Reviewed-by: Timothy Pearson <tpearson(a)raptorengineering.com>
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See https://review.coreboot.org/18225 for details.
-gerrit
Iru Cai (mytbk920423(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14209
-gerrit
commit a2b07cd8e18a5b601c00b6b0a056c97890f48810
Author: Iru Cai <mytbk920423(a)gmail.com>
Date: Thu Mar 31 23:13:09 2016 +0800
hp/2760p: reserve space in bootblock
The space from 0x7ff700 to 0x7fff07 is reserved for data needed by (maybe)
EC.
The default ID_SECTION_OFFSET is enough so it doesn't need to be changed.
Change-Id: Iae7eb8a67fcce173500d91951ee71a3361475fc9
Signed-off-by: Iru Cai <mytbk920423(a)gmail.com>
---
src/mainboard/hp/2760p/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig
index 440c1f6..20ed531 100644
--- a/src/mainboard/hp/2760p/Kconfig
+++ b/src/mainboard/hp/2760p/Kconfig
@@ -62,4 +62,9 @@ config MAX_CPUS
config USBDEBUG_HCD_INDEX
int
default 1
+
+config RESERVED_SPACE_BEFORE_RESET_VECTOR
+ hex
+ default 0x900
+
endif