coreboot-gerrit September 2016

coreboot-gerrit@coreboot.org

1 participants
1340 discussions

Patch set updated for coreboot: nb/intel/*/gma.c: remove spaces at the fake vbt generation
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16740 -gerrit commit e8a2faf382b3fc19fb2a3b2f9e6861b3b68153ea Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:48:00 2016 +0200 nb/intel/*/gma.c: remove spaces at the fake vbt generation Padding the VBT id string is now done automatically. Change-Id: I8f9baf7b1585026bc29b82d07e451aa11e284ffb Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/northbridge/intel/gm45/gma.c | 3 +-- src/northbridge/intel/pineview/gma.c | 3 +-- src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c | 2 +- src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c | 2 +- src/northbridge/intel/x4x/gma.c | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 14f695e..0545ba5 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -740,8 +740,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT CANTIGA "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT CANTIGA"); } } diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index 335e38a..d670198 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -277,8 +277,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT PINEVIEW "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT PINEVIEW"); } } diff --git a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c index f6818dd..831e8ce 100644 --- a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c @@ -524,7 +524,7 @@ int i915lightup_ivy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c index 3b4b64c..c2c8087 100644 --- a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c @@ -479,7 +479,7 @@ int i915lightup_sandy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index 2679026..a98a1dc 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -177,7 +177,7 @@ static void native_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE"); } static void gma_func0_init(struct device *dev)

1 0

Patch set updated for coreboot: intel/gma/vbt.c: pad the ID string with spaces.
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16739 -gerrit commit 6f72ca56b9afaf53af4bf19555e4ea2b9a42e2d6 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:36:26 2016 +0200 intel/gma/vbt.c: pad the ID string with spaces. The VBT id string is 20 characters long. If the string is shorter than 20 it needs spaces at the end. Head used to be fully set to 0 (including signature). When an IDstring was shorter than 20, the remaining part of the header->signature would still be 0. This patch sets the remaining part to spaces just like the vbios does. Linux (at least 4.1-4.7) does not seem to care a lot about VBT, because previously it was not generated on i945 and the wrong string was used on gm45 and those still worked properly. Change-Id: Id6439f1d3dbd09319ee99ce9d15dbc3bcead1f53 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/drivers/intel/gma/vbt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index e768402..9ec09d3 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -34,7 +34,9 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, memset (head, 0, sizeof (*head)); - memcpy (head->signature, idstr, 20); + memset(head->signature, ' ', sizeof(head->signature)); + memcpy(head->signature, idstr, MIN(strlen(idstr), + sizeof(head->signature))); head->version = 100; head->header_size = sizeof (*head); head->bdb_offset = sizeof (*head);

1 0

Patch set updated for coreboot: nb/intel/*/gma.c: remove spaces at the fake vbt generation
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16740 -gerrit commit 340d11cb23d56d76b15b939fa6cc68b02626abb1 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:48:00 2016 +0200 nb/intel/*/gma.c: remove spaces at the fake vbt generation Padding the VBT id string is now done automatically. Change-Id: I8f9baf7b1585026bc29b82d07e451aa11e284ffb Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/northbridge/intel/gm45/gma.c | 3 +-- src/northbridge/intel/pineview/gma.c | 3 +-- src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c | 2 +- src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c | 2 +- src/northbridge/intel/x4x/gma.c | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 14f695e..0545ba5 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -740,8 +740,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT CANTIGA "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT CANTIGA"); } } diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index 335e38a..d670198 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -277,8 +277,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT PINEVIEW "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT PINEVIEW"); } } diff --git a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c index f6818dd..831e8ce 100644 --- a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c @@ -524,7 +524,7 @@ int i915lightup_ivy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c index 3b4b64c..c2c8087 100644 --- a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c @@ -479,7 +479,7 @@ int i915lightup_sandy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index 2679026..a98a1dc 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -177,7 +177,7 @@ static void native_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE"); } static void gma_func0_init(struct device *dev)

1 0

Patch set updated for coreboot: intel/gma/vbt.c: pad the ID string with spaces.
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16739 -gerrit commit f5010fa92f701c24dde10b7b27fa424e04b35f1c Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:36:26 2016 +0200 intel/gma/vbt.c: pad the ID string with spaces. The VBT id string is 20 characters long. If the string is shorter than 20 it needs spaces at the end. Head used to be fully set to 0 (including signature). When an IDstring was shorter the remaining part of the header->signature would still be 0. This patch sets the remaining part to spaces just like the vbios does. Linux (at least 4.1-4.7) does not seem to care a lot about VBT, because previously it was not generated on i945 and the wrong string was used on gm45 and those still worked properly. Change-Id: Id6439f1d3dbd09319ee99ce9d15dbc3bcead1f53 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/drivers/intel/gma/vbt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index e768402..9ec09d3 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -34,7 +34,9 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, memset (head, 0, sizeof (*head)); - memcpy (head->signature, idstr, 20); + memset(head->signature, ' ', sizeof(head->signature)); + memcpy(head->signature, idstr, MIN(strlen(idstr), + sizeof(head->signature))); head->version = 100; head->header_size = sizeof (*head); head->bdb_offset = sizeof (*head);

1 0

Patch merged into coreboot/master: mainboard/*/*/dsdt.asl: Use tabs for indents
by gerrit＠coreboot.org 26 Sep '16

26 Sep '16

the following patch was just integrated into master: commit b87a734771449ed06cd91621da4c893a1ad722b0 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Sat Sep 24 08:53:34 2016 +0200 mainboard/*/*/dsdt.asl: Use tabs for indents Change-Id: Idef587d8261784e916e8d50f4336cbcfca39b9b0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/16730 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/16730 for details. -gerrit

1 0

Patch merged into coreboot/master: mainboard/*/*/mptable.c: Improve code formatting
by gerrit＠coreboot.org 26 Sep '16

26 Sep '16

the following patch was just integrated into master: commit 8da96e57c89860f429f1bf590c10fa364b8019d4 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Thu Sep 22 21:20:54 2016 +0200 mainboard/*/*/mptable.c: Improve code formatting Change-Id: I341293cd334d6d465636db7e81400230d61bc693 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/16723 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/16723 for details. -gerrit

1 0

Patch set updated for coreboot: nb/intel/*/gma.c: remove spaces at the fake vbt generation
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16740 -gerrit commit 2cb017548bd1c5b1b3eef5a5e0601b293ed98a4b Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:48:00 2016 +0200 nb/intel/*/gma.c: remove spaces at the fake vbt generation Padding the VBT id string is now done automatically. Change-Id: I8f9baf7b1585026bc29b82d07e451aa11e284ffb Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/northbridge/intel/gm45/gma.c | 3 +-- src/northbridge/intel/pineview/gma.c | 3 +-- src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c | 2 +- src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c | 2 +- src/northbridge/intel/x4x/gma.c | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 14f695e..0545ba5 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -740,8 +740,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT CANTIGA "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT CANTIGA"); } } diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index 335e38a..d670198 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -277,8 +277,7 @@ static void gma_func0_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, - "$VBT PINEVIEW "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT PINEVIEW"); } } diff --git a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c index f6818dd..831e8ce 100644 --- a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c @@ -524,7 +524,7 @@ int i915lightup_ivy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c index 3b4b64c..c2c8087 100644 --- a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c @@ -479,7 +479,7 @@ int i915lightup_sandy(const struct i915_gpu_controller_info *info, /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(info, dev_find_slot(0, PCI_DEVFN(2, 0)), - "$VBT SNB/IVB-MOBILE "); + "$VBT SNB/IVB-MOBILE"); return 1; } diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index 2679026..a98a1dc 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -177,7 +177,7 @@ static void native_init(struct device *dev) } /* Linux relies on VBT for panel info. */ - generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE "); + generate_fake_intel_oprom(&conf->gfx, dev, "$VBT EAGLELAKE"); } static void gma_func0_init(struct device *dev)

1 0

Patch set updated for coreboot: intel/gma/vbt.c: pad the ID string with spaces.
by Arthur Heymans 26 Sep '16

26 Sep '16

Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16739 -gerrit commit ca5999f8728bb690aa3533b25c68ff05f35445af Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sun Sep 25 22:36:26 2016 +0200 intel/gma/vbt.c: pad the ID string with spaces. The VBT id string is 20 characters long. If the string is shorter than 20 it needs spaces at the end. Change-Id: Id6439f1d3dbd09319ee99ce9d15dbc3bcead1f53 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- src/drivers/intel/gma/vbt.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index e768402..f5cc839 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -34,7 +34,13 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, memset (head, 0, sizeof (*head)); - memcpy (head->signature, idstr, 20); + /* + * make sure the 20 char length signature is filled + * with spaces if the idstr is shorter than 20 + */ + memset(head->signature, ' ', sizeof(head->signature)); + memcpy(head->signature, idstr, MIN(strlen(idstr), + sizeof(head->signature))); head->version = 100; head->header_size = sizeof (*head); head->bdb_offset = sizeof (*head);

1 0

Patch merged into coreboot/master: mainboard/*/*/irq_tables.c: Use tabs for indents
by gerrit＠coreboot.org 26 Sep '16

26 Sep '16

the following patch was just integrated into master: commit f4df9d11560acf6f7c4c844cfd97a7da82f0d140 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Fri Sep 23 17:57:38 2016 +0200 mainboard/*/*/irq_tables.c: Use tabs for indents Change-Id: Idc29373cb01f4304d22ae315812bd40f0aaa94c9 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/16729 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/16729 for details. -gerrit

1 0

Patch merged into coreboot/master: mainboard/lippert: Use tabs for indents
by gerrit＠coreboot.org 26 Sep '16

26 Sep '16

the following patch was just integrated into master: commit 57a3cd21f1a619891d65a2eb96005954b4672eaa Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Wed Sep 21 21:14:02 2016 +0200 mainboard/lippert: Use tabs for indents Change-Id: If16d55e4ba0702176dc61524915d215ea46c14ba Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/16686 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/16686 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2016