Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15076
-gerrit
commit 1db0dc7ea0179660291e6c5ded65fb4a9a83fcbb
Author: Martin Roth <martinroth(a)google.com>
Date: Sun Jun 5 10:30:34 2016 -0600
SeaBIOS: Add option to include a bootorder file in cbfs
Including the SeaBIOS bootorder file seems to be a fairly common desire,
so let's make it easy.
Change-Id: Ib0874dee46215287b09c0b52648072ef3ff06ec5
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
payloads/external/Makefile.inc | 7 +++++++
payloads/external/SeaBIOS/Kconfig | 16 ++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index 65b3dd2..f070bb4 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -85,6 +85,13 @@ payloads/external/SeaBIOS/seabios/out/vgabios.bin: seabios
payloads/external/SeaBIOS/seabios/.config: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
payloads/external/SeaBIOS/seabios/out/autoversion.h: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
+# add a SeaBIOS bootorder file
+ifneq ($(strip $(CONFIG_SEABIOS_BOOTORDER_FILE)),)
+cbfs-files-y += bootorder
+bootorder-file := $(strip $(CONFIG_SEABIOS_BOOTORDER_FILE))
+bootorder-type := raw
+endif
+
payloads/external/depthcharge/depthcharge/build/depthcharge.elf depthcharge: $(top)/$(DOTCONFIG) $(CBFSTOOL)
$(MAKE) -C payloads/external/depthcharge \
BOARD=$(call ws_to_under,$(call strip_quotes,$(call tolower,$(CONFIG_MAINBOARD_PART_NUMBER)))) \
diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index 94aac8f..abfd291 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -70,6 +70,22 @@ config PAYLOAD_CONFIGFILE
SeaBIOS payload. In general, if the option is used, the default
would be "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios"
+config SEABIOS_BOOTORDER_FILE
+ string "SeaBIOS bootorder file"
+ default ""
+ help
+ Add a SeaBIOS bootorder file. From the wiki:
+ "The bootorder file may be used to configure the boot up order. The file
+ should be ASCII text and contain one line per boot method. The description
+ of each boot method follows an Open Firmware device path format. SeaBIOS
+ will attempt to boot from each item in the file - first line of the file
+ first."
+
+ See: https://www.coreboot.org/SeaBIOS#Configuring_boot_order
+
+ If used, a typical value would be:
+ $(top)/src/mainboard/$(MAINBOARDDIR)/bootorder
+
config PAYLOAD_FILE
default "payloads/external/SeaBIOS/seabios/out/bios.bin.elf"
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15063
-gerrit
commit a0c1f0afd997ac3ea1ae81f14771c9da6019723b
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Fri Jun 3 18:37:38 2016 +0200
lenovo/x60: add hda_verb.c
This creates a config for the x60 audio based
on values taken from vendor bios.
The pin config is stored in (for linux 4.5 at least):
/sys/class/sound/card0/hw*/init_pin_configs
In the left column there is the pin number.
In the right column there is the default configuration of that pin.
(This has to be done while running the proprietary bios)
More information on the sound card can be found in:
/proc/asound/card0/codec#*
This also hold the information of /sys/class/sound/
What is improved:
- internal microphone is chosen by default
- when jack is inserted it is chosen instead of internal speaker
Before this had to be done manually in alsa or pulseaudio.
TEST= check if internal microphone is used by default in
pavucontrol if you are using pulseaudio.
Plug in a jack with headphones and check if there
is sound output through these and not the build-in
speaker.
Change-Id: Id3b700fd84905a72cc1f69e7d8bfa6145f231756
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/mainboard/lenovo/x60/hda_verb.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/lenovo/x60/hda_verb.c b/src/mainboard/lenovo/x60/hda_verb.c
index 072a306..dee3e80 100644
--- a/src/mainboard/lenovo/x60/hda_verb.c
+++ b/src/mainboard/lenovo/x60/hda_verb.c
@@ -1,7 +1,22 @@
#include <device/azalia_device.h>
-const u32 cim_verb_data[0] = {};
+const u32 cim_verb_data[] = {
+ 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */
+ 0x17aa2025, /* Subsystem ID */
+ 0x0000000b, /* Number of 4 dword sets */
-const u32 pc_beep_verbs[0] = {};
+ AZALIA_SUBVENDOR(0x0, 0x17aa2025),
+ AZALIA_PIN_CFG(0, 0x05, 0xc3014110),
+ AZALIA_PIN_CFG(0, 0x06, 0x4221401f),
+ AZALIA_PIN_CFG(0, 0x07, 0x591311f0),
+ AZALIA_PIN_CFG(0, 0x08, 0xc3a15020),
+ AZALIA_PIN_CFG(0, 0x09, 0x41813021),
+ AZALIA_PIN_CFG(0, 0x0a, 0x014470f0),
+ AZALIA_PIN_CFG(0, 0x16, 0x59f311f0),
+ AZALIA_PIN_CFG(0, 0x17, 0x59931122),
+ AZALIA_PIN_CFG(0, 0x18, 0x41a19023),
+ AZALIA_PIN_CFG(0, 0x19, 0x9933e12e)
+};
+const u32 pc_beep_verbs[0] = {};
AZALIA_ARRAY_SIZES;
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15063
-gerrit
commit 25a091273b14d78deb7e1cb3f81f9c124bfc9cd2
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Fri Jun 3 18:37:38 2016 +0200
lenovo/x60: add hda_verb.c
This creates a config for the x60 audio based
on values taken from vendor bios.
The pin config is stored in (for linux 4.5 at least):
/sys/class/sound/card0/hw*/init_pin_configs
In the left collumn there is the pin number.
In the right collumn there is the default configuration of that pin.
(This has to be done while running the proprietary bios)
More information on the sound card can be found in:
/proc/asound/card0/codec#*
This also hold the information of /sys/class/sound/
What is improved:
- internal microphone is chosen by default
- when jack is inserted it is chosen instead of internal speaker
Before this had to be done manually in alsa or pulseaudio.
TEST= check if internal microphone is used by default in
pavucontrol if you are using pulseaudio.
Plug in a jack with headphones and check if there
is sound output through these and not the pc
speaker.
Change-Id: Id3b700fd84905a72cc1f69e7d8bfa6145f231756
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/mainboard/lenovo/x60/hda_verb.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/lenovo/x60/hda_verb.c b/src/mainboard/lenovo/x60/hda_verb.c
index 072a306..dee3e80 100644
--- a/src/mainboard/lenovo/x60/hda_verb.c
+++ b/src/mainboard/lenovo/x60/hda_verb.c
@@ -1,7 +1,22 @@
#include <device/azalia_device.h>
-const u32 cim_verb_data[0] = {};
+const u32 cim_verb_data[] = {
+ 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */
+ 0x17aa2025, /* Subsystem ID */
+ 0x0000000b, /* Number of 4 dword sets */
-const u32 pc_beep_verbs[0] = {};
+ AZALIA_SUBVENDOR(0x0, 0x17aa2025),
+ AZALIA_PIN_CFG(0, 0x05, 0xc3014110),
+ AZALIA_PIN_CFG(0, 0x06, 0x4221401f),
+ AZALIA_PIN_CFG(0, 0x07, 0x591311f0),
+ AZALIA_PIN_CFG(0, 0x08, 0xc3a15020),
+ AZALIA_PIN_CFG(0, 0x09, 0x41813021),
+ AZALIA_PIN_CFG(0, 0x0a, 0x014470f0),
+ AZALIA_PIN_CFG(0, 0x16, 0x59f311f0),
+ AZALIA_PIN_CFG(0, 0x17, 0x59931122),
+ AZALIA_PIN_CFG(0, 0x18, 0x41a19023),
+ AZALIA_PIN_CFG(0, 0x19, 0x9933e12e)
+};
+const u32 pc_beep_verbs[0] = {};
AZALIA_ARRAY_SIZES;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15078
-gerrit
commit ae7d201a1a4f62312627b385c960025bef83f1f6
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sun Jun 5 21:03:18 2016 +0200
intel/skylake: Fix typo in comment
Correct the spelling of *firmware* in a comment.
Change-Id: I44bcd95f754ff839d582dc2150e1883a6315da9e
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/soc/intel/skylake/nhlt/nau88l25.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/skylake/nhlt/nau88l25.c b/src/soc/intel/skylake/nhlt/nau88l25.c
index d9b9cbd..0a6dd1b 100644
--- a/src/soc/intel/skylake/nhlt/nau88l25.c
+++ b/src/soc/intel/skylake/nhlt/nau88l25.c
@@ -15,7 +15,7 @@
#include <soc/nhlt.h>
-/* The same DSP firmwware settings are used for both the capture and
+/* The same DSP firmware settings are used for both the capture and
* render endpoints. */
static const struct nhlt_format_config nau88l25_cfg[] = {
/* 48 KHz 24-bits per sample. */
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15076
-gerrit
commit 9413e73af64ebf7fbb7db550e86174a00df6214d
Author: Martin Roth <martinroth(a)google.com>
Date: Sun Jun 5 10:30:34 2016 -0600
SeaBIOS: Add option to include a bootorder file in cbfs
Including the SeaBIOS bootorder file seems to be a fairly common desire,
so let's make it easy.
Change-Id: Ib0874dee46215287b09c0b52648072ef3ff06ec5
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
payloads/external/Makefile.inc | 7 +++++++
payloads/external/SeaBIOS/Kconfig | 16 ++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index 65b3dd2..f070bb4 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -85,6 +85,13 @@ payloads/external/SeaBIOS/seabios/out/vgabios.bin: seabios
payloads/external/SeaBIOS/seabios/.config: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
payloads/external/SeaBIOS/seabios/out/autoversion.h: payloads/external/SeaBIOS/seabios/out/bios.bin.elf
+# add a SeaBIOS bootorder file
+ifneq ($(strip $(CONFIG_SEABIOS_BOOTORDER_FILE)),)
+cbfs-files-y += bootorder
+bootorder-file := $(strip $(CONFIG_SEABIOS_BOOTORDER_FILE))
+bootorder-type := raw
+endif
+
payloads/external/depthcharge/depthcharge/build/depthcharge.elf depthcharge: $(top)/$(DOTCONFIG) $(CBFSTOOL)
$(MAKE) -C payloads/external/depthcharge \
BOARD=$(call ws_to_under,$(call strip_quotes,$(call tolower,$(CONFIG_MAINBOARD_PART_NUMBER)))) \
diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index 94aac8f..a4de3d2 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -70,6 +70,22 @@ config PAYLOAD_CONFIGFILE
SeaBIOS payload. In general, if the option is used, the default
would be "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios"
+config SEABIOS_BOOTORDER_FILE
+ string "SeaBIOS bootorder file"
+ default ""
+ help
+ Add a SeaBIOS bootorder file. From the wiki:
+ "The bootorder file may be used to configure the boot up order. The file
+ should be ASCII text and contain one line per boot method. The description
+ of each boot method follows an Open Firmware device path format. SeaBIOS
+ will attempt to boot from each item in the file - first line of the file
+ first."
+
+ See: https://www.coreboot.org/SeaBIOS#Configuring_boot_order
+
+ If used, a typical value would be:
+ $(top)/src/mainboard/$(MAINBOARDDIR)/bootorder
+
config PAYLOAD_FILE
default "payloads/external/SeaBIOS/seabios/out/bios.bin.elf"