the following patch was just integrated into master:
commit 82657cad24416441688c2e449dbbe13471e3b280
Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
Date: Wed Mar 9 17:20:26 2016 -0600
crossgcc: Fix compiler detect for POWER8 big endian mode switch.
Change-Id: I7afb35fd5bc971a2c4d63e3a084ce7473f7a66fa
Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/14018
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/14018 for details.
-gerrit
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14018
-gerrit
commit ffc00b180f92e307c7781853f18c342c25ae992d
Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
Date: Wed Mar 9 17:20:26 2016 -0600
crossgcc: Fix compiler detect for POWER8 big endian mode switch.
Change-Id: I7afb35fd5bc971a2c4d63e3a084ce7473f7a66fa
Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com>
---
util/xcompile/xcompile | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 53f0a85..2b9b818 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -4,6 +4,7 @@
#
# Copyright (C) 2007-2010 coresystems GmbH
# Copyright (C) 2012 Google Inc
+# Copyright (C) 2016 Raptor Engineering, LLC
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -367,12 +368,12 @@ arch_config_mipsel() {
arch_config_power8() {
TARCH="power8"
- TBFDARCHS="powerpcle"
- TCLIST="powerpc64 powerpc64le"
+ TBFDARCHS="powerpc"
+ TCLIST="powerpc64"
TWIDTH="64"
TSUPP="power8"
- TABI="linux" # there is no generic ABI on ppc64
- CC_RT_EXTRA_GCC="-mcpu=power8 -mlittle-endian"
+ TABI="linux-gnu" # there is no generic ABI on ppc64
+ CC_RT_EXTRA_GCC="-mcpu=power8 -mbig-endian"
}
test_architecture() {
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14194
-gerrit
commit 07b01253f4b6c8a8226e7be149929197167db168
Author: Martin Roth <martinroth(a)google.com>
Date: Wed Mar 30 13:56:23 2016 -0600
lint/lint-stable-004-style-labels: Update script
- Look at entire tree instead of just the current commit. This was
causing the test to overlook some issues that were already in the tree.
- If git is on the system, and the code is in a git repo, use the
'git ls-files' command to find the files to examine. If those
conditions aren't met, fall back to using the find command.
- Wrap the command so it's easier to read.
Change-Id: I3dce219a29ffb1ae56a31318b995e3ba8ea43e70
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/lint/lint-stable-004-style-labels | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/util/lint/lint-stable-004-style-labels b/util/lint/lint-stable-004-style-labels
index f024ca1..7b68b4a 100755
--- a/util/lint/lint-stable-004-style-labels
+++ b/util/lint/lint-stable-004-style-labels
@@ -2,6 +2,7 @@
# This file is part of the coreboot project.
#
# Copyright (C) 2012 Patrick Georgi <patrick(a)georgi-clan.de>
+# Copyright (C) 2016 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -15,4 +16,15 @@
# DESCR: Check that C labels begin at start-of-line
LC_ALL=C export LC_ALL
-git diff --name-status |grep -v "^D" |cut -c3- |grep "^src/.*\.[csS]" | xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' |grep -v "[^a-z_]default:"
+
+# Use git ls-files if the code is in a git repo, otherwise use find.
+if [ -n "$(command -v git)" ] && [ -d .git ]; then
+ FIND_FILES="git ls-files"
+else
+ FIND_FILES="find src"
+fi
+
+${FIND_FILES} | \
+ grep "^src/.*\.[csS]$" | \
+ xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' | \
+ grep -v "[^a-z_]default:"
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14231
-gerrit
commit 5fc6faabcb21b987a1a1674bfde5db60ea36294c
Author: Martin Roth <martinroth(a)google.com>
Date: Sat Apr 2 11:10:08 2016 -0600
crossgcc/Makefile.inc: Update jenkins-build-toolchain
Because the builders have the coreboot cross-compilers in their path,
the XGCCPATH variable needs to be set after building the new toolchain
before it will be used.
- Add $DEST/bin to $PATH if $DEST is set, add the default location
for toolchain builds otherwise. Because the jenkins build image puts
the tools in the path, we ca
- Add KEEP_SOURCES option to help speed up compilation (Slightly).
- Log .xcompile for verification that the right toolchain was used.
- Verify that test-toolchain passes.
Change-Id: I7c270dab94be7e8f801d527169767018a24986e4
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/crossgcc/Makefile.inc | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/util/crossgcc/Makefile.inc b/util/crossgcc/Makefile.inc
index 5be4c10..0bd91a5 100644
--- a/util/crossgcc/Makefile.inc
+++ b/util/crossgcc/Makefile.inc
@@ -69,7 +69,8 @@ endif # ifeq ($(COMPILER_OUT_OF_DATE),1)
# This target controls what the jenkins builder tests
jenkins-build-toolchain:
- $(MAKE) crosstools clang \
- BUILDGCC_OPTIONS='-y --nocolor'
+ $(MAKE) crosstools clang KEEP_SOURCES=1 BUILDGCC_OPTIONS='-y --nocolor'
rm -f .xcompile
- $(MAKE) what-jenkins-does
+ PATH=$(if $(DEST),$(DEST)/bin,$(top)/util/crossgcc/xgcc/bin):$PATH; $(MAKE) what-jenkins-does
+ cat .xcompile
+ PATH=$(if $(DEST),$(DEST)/bin,$(top)/util/crossgcc/xgcc/bin):$PATH; $(MAKE) test-toolchain
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14237
-gerrit
commit e46a1b72ca88007b3dd24f309b618633774b3d02
Author: Patrick Georgi <pgeorgi(a)google.com>
Date: Wed Mar 30 20:59:29 2016 +0200
futility: don't pass CFLAGS into futility's build
cros_sdk puts weird stuff into CFLAGS and we never cares because we
don't use CFLAGS. futility's Makefiles do.
BUG=chromium:595715
BRANCH=none
TEST=none
Change-Id: I512d5adb55cad8b31dc29d9c076ecd5d9c701cf6
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Commit-Id: 58739332ddba7ef759aac37f3a4410dd487f210f
Original-Change-Id: I66898c7e66d808047b0326c7471c64eaae950b15
Original-Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/336436
Original-Commit-Ready: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Tested-by: Patrick Georgi <pgeorgi(a)chromium.org>
Original-Reviewed-by: Patrick Georgi <pgeorgi(a)chromium.org>
---
util/futility/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc
index 26b218d..d37be4b 100644
--- a/util/futility/Makefile.inc
+++ b/util/futility/Makefile.inc
@@ -2,7 +2,7 @@ additional-dirs += $(objutil)/futility
$(objutil)/futility/build/futility/futility:
@printf " MAKE $(subst $(objutil)/,,$(@))\n"
- $(MAKE) -C $(VB_SOURCE) \
+ unset CFLAGS LDFLAGS; $(MAKE) -C $(VB_SOURCE) \
BUILD=$(abspath $@/../..) \
CC="$(HOSTCC)" \
V=$(V) \