coreboot-gerrit February 2016

coreboot-gerrit@coreboot.org

1 participants
1305 discussions

Patch merged into coreboot/master: commonlib: move uefi includes out of commonlib includes
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit f76ceea7051a29883fdaab16e5879f5f742384e5 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Sat Jan 30 02:05:56 2016 -0800 commonlib: move uefi includes out of commonlib includes ... and move them into the code using them, instead. Change-Id: I2391234797ad00da8038dda198eadf0b0fcaedb2 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/13526 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/13526 for details. -gerrit

1 0

Patch merged into coreboot/master: asus/f2a85-m: Configure Hudson to be legacy-free
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit 0d473512c74217f346d77c93f090c625b545dbf3 Author: Loic <hackurx(a)opensec.fr> Date: Fri Jan 29 14:15:40 2016 +0100 asus/f2a85-m: Configure Hudson to be legacy-free Change-Id: I67271f2a209fc96eea6181f8875a5e69cf98d8c4 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: https://review.coreboot.org/13511 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/13511 for details. -gerrit

1 0

Patch merged into coreboot/master: amd/agesa/family15tn: Add Richland CPU ID
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit 96a598b6c9f372a14026a06512ed39bf07c4831a Author: Loic <hackurx(a)opensec.fr> Date: Fri Jan 29 14:14:16 2016 +0100 amd/agesa/family15tn: Add Richland CPU ID Add the AMD A8-660K APU. Change-Id: I210a8ba962529c26a535965689672a46b09e325f Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Reviewed-on: https://review.coreboot.org/13510 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13510 for details. -gerrit

1 0

Patch set updated for coreboot: lint: test for assembler dialect switches
by Martin Roth 02 Feb '16

02 Feb '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13135 -gerrit commit ef9eace9ee4c706adaee9fcdfd48f2c50042054e Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Fri Jan 22 13:37:14 2016 +0100 lint: test for assembler dialect switches We prefer the default AT&T dialect on x86 Change-Id: I7a5778c82ab5df6e971dfc73e98373893cfeeb92 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- util/lint/lint-stable-010-asm-syntax | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/util/lint/lint-stable-010-asm-syntax b/util/lint/lint-stable-010-asm-syntax new file mode 100755 index 0000000..909eb0e --- /dev/null +++ b/util/lint/lint-stable-010-asm-syntax @@ -0,0 +1,18 @@ +#!/bin/sh +# This file is part of the coreboot project. +# +# Copyright 2016 Google Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# DESCR: Check that we use a single assembler syntax + +LC_ALL=C export LC_ALL +git grep -n "\.$att\|intel$_syntax\>"

1 0

Patch merged into coreboot/master: arch/x86: Add second paragraph to license header
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit cfc80c2211355625844e3c66b8f6196cc7cd93e7 Author: Martin Roth <martinroth(a)google.com> Date: Tue Feb 2 06:14:44 2016 -0700 arch/x86: Add second paragraph to license header Change-Id: Ic1da46d2abc8d20987048e4ef1e7a776d0c685d6 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13555 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See https://review.coreboot.org/13555 for details. -gerrit

1 0

New patch to review for coreboot: arch/x86: Add second paragraph to license header
by Martin Roth 02 Feb '16

02 Feb '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13555 -gerrit commit cb6891426dd595c5a97b7b8a3cce8c2fd14cc731 Author: Martin Roth <martinroth(a)google.com> Date: Tue Feb 2 06:14:44 2016 -0700 arch/x86: Add second paragraph to license header Change-Id: Ic1da46d2abc8d20987048e4ef1e7a776d0c685d6 Signed-off-by: Martin Roth <martinroth(a)google.com> --- src/arch/x86/bootblock_crt0.S | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/arch/x86/bootblock_crt0.S b/src/arch/x86/bootblock_crt0.S index 926cda0..2ecddba 100644 --- a/src/arch/x86/bootblock_crt0.S +++ b/src/arch/x86/bootblock_crt0.S @@ -14,6 +14,11 @@ * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. */ #define CR0_MP (1 << 1)

1 0

Patch merged into coreboot/master: Makefile: Add a comment to fix syntax highlighting
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit bbf1399c73b135f9b86d9981846fde290ca1c5d3 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 15:59:24 2016 -0700 Makefile: Add a comment to fix syntax highlighting Trivial fix for syntax highlighting in editors. Some get confused by the double quote that doesn't have a close quote and stop highlighting at that point. This comment closes the quote and the paren pair so that they can recover. Change-Id: I566e8e0f4412009f679ab079f20ae30c2049b502 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13435 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/13435 for details. -gerrit

1 0

Patch merged into coreboot/master: lint: Check license headers for both paragraphs of the GPL
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit f8db028a32bf3aae2eb2783802c643a03287d412 Author: Martin Roth <martinroth(a)google.com> Date: Thu Jan 21 13:20:39 2016 -0700 lint: Check license headers for both paragraphs of the GPL If the GPLv2 or GPLv2+ license header is being used on a coreboot file, make sure it has two paragraphs as specified by the Common License Header section in the developer guidelines in the coreboot wiki. Change-Id: Ifffa0fa7272f5a4b129d4b7b8a515f8795bc2401 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13119 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13119 for details. -gerrit

1 0

Patch merged into coreboot/master: payloads/coreinfo: Add defaultbuild target
by gerrit＠coreboot.org 02 Feb '16

02 Feb '16

the following patch was just integrated into master: commit 50943b15a35020b5f411e380c413abe337ab2b69 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 25 14:01:55 2016 -0700 payloads/coreinfo: Add defaultbuild target Add a single target to do the full coreinfo build using default Kconfig values for both coreinfo and libpayload. Change-Id: Id622fb2df480e826f6d868dbe01385d76587be26 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/13426 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/13426 for details. -gerrit

1 0

New patch to review for coreboot: build_system: Extend site-local
by Martin Roth 02 Feb '16

02 Feb '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13413 -gerrit commit 931867ca6a331c45adb28f40a57bcaf496e548f2 Author: Martin Roth <martinroth(a)google.com> Date: Sun Jan 24 19:38:33 2016 -0700 build_system: Extend site-local - Add a target at the end of the build that can be used to run additional scripts or additional targets after coreboot.rom is built. - Source a site-local Kconfig file to allow site-specific configuration. This eliminates the need to add a hook for a script at the end of the build because you can add one yourself in site-local. Example site-local/Makefile.inc: build_complete:: ifeq ($(CONFIG_SITE_LOCAL),y) echo "Running additional steps in site-local" # run some script here to make my build unreproducible. endif .phony: build_complete Example site-local/Kconfig: menu "site-local" config SITE_LOCAL bool "site-local enabled" help Enable my site-local configuration to do stuff. endmenu Change-Id: Id4d1e727c69b5cdb05e7d52731bbb1d1e201864a Signed-off-by: Martin Roth <martinroth(a)google.com> --- Makefile.inc | 10 +++++++++- src/Kconfig | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index 89f02d4..22ad915 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -49,9 +49,16 @@ export objgenerated := $(obj)/generated real-target: $(obj)/config.h coreboot coreboot: build-dirs $(obj)/coreboot.rom $(obj)/cbfstool $(obj)/rmodtool +build_complete:: + printf "\nBuilt %s (%s)\n" $(CONFIG_MAINBOARD_DIR) \ + $(CONFIG_MAINBOARD_PART_NUMBER) + # This target can be used in site local to run scripts or additional + # targets after the build completes by creating a Makefile.inc in the + # site-local directory with a target named 'build_complete::' + ####################################################################### # our phony targets -PHONY+= clean-abuild coreboot lint lint-stable build-dirs +PHONY+= clean-abuild coreboot lint lint-stable build-dirs build_complete ####################################################################### # root source directories of coreboot @@ -827,6 +834,7 @@ ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),) @printf "\n***** WARNING: IASL warnings as errors is disabled! *****\n" @printf "***** Please fix the ASL for this platform. *****\n\n" endif + $(MAKE) build_complete cbfs-files-y += $(CONFIG_CBFS_PREFIX)/romstage $(CONFIG_CBFS_PREFIX)/romstage-file := $(objcbfs)/romstage.elf diff --git a/src/Kconfig b/src/Kconfig index 4df037b..3f02843 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -407,6 +407,9 @@ config FMDFILE endmenu +# load site-local kconfig to allow user specific defaults and overrides +source "site-local/Kconfig" + config SYSTEM_TYPE_LAPTOP default n bool

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2016