coreboot-gerrit October 2016

coreboot-gerrit@coreboot.org

1 participants
1281 discussions

New patch to review for coreboot: Revert "util/lint/kconfig_lint: change warning levels and text"
by Martin Roth 03 Oct '16

03 Oct '16

Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16868 -gerrit commit 850c4f7613a2b808ef762d9402d301e08e25b40e Author: Martin Roth <martinroth(a)google.com> Date: Mon Oct 3 23:00:04 2016 +0200 Revert "util/lint/kconfig_lint: change warning levels and text" This reverts commit dfdb0733a6a71b11d15006dafc13841e84fab7cd. Change-Id: I91bf5e42f4ac241f544742ce161bae651f9f9947 --- util/lint/kconfig_lint | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 39a0291..064f3db 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -197,11 +197,8 @@ sub check_for_ifdef { my $symbol = $3; if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) { - # TODO: Remove special check for CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL - if ($symbol ne "MAINBOARD_POWER_ON_AFTER_POWER_FAIL") { - show_error( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." + show_warning( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." . " Symbols of type '$symbols{$symbol}{type}' are always defined." ); - } } } } @@ -264,10 +261,7 @@ sub check_for_def { my $symbol = $3; if ( ( exists $symbols{$symbol} ) ) { - # TODO: Remove special check for CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL - if ($symbol ne "MAINBOARD_POWER_ON_AFTER_POWER_FAIL") { - show_error("#define of symbol 'CONFIG_$symbol' used at $file:$lineno."); - } + show_warning("#define of symbol 'CONFIG_$symbol' used at $file:$lineno."); } else { show_warning( "#define 'CONFIG_$symbol' used at $file:$lineno." @@ -466,9 +460,7 @@ sub check_used_symbols { for ( my $i = 0 ; $i <= $symbols{$key}{count} ; $i++ ) { my $filename = $symbols{$key}{$i}{file}; my $line_no = $symbols{$key}{$i}{line_no}; - if ($show_note_output) { - print("#!!!!! Note: Unused symbol '$key' defined at $filename:$line_no."); - } + show_warning("Unused symbol '$key' referenced at $filename:$line_no."); } } } @@ -1170,9 +1162,9 @@ sub load_kconfig_file { #if the file exists, try to load it. elsif ( -e "$input_file" ) { - #throw an error if the file has already been loaded. + #throw a warning if the file has already been loaded. if ( exists $loaded_files{$input_file} ) { - show_error("'$input_file' sourced at $loadfile:$loadline was already loaded by $loaded_files{$input_file}"); + show_warning("'$input_file' sourced at $loadfile:$loadline was already loaded by $loaded_files{$input_file}"); } #load the file's contents and mark the file as loaded for checking later

1 0

Patch merged into coreboot/master: google/gale: Remove #ifdef of Kconfig bool symbol
by gerrit＠coreboot.org 03 Oct '16

03 Oct '16

the following patch was just integrated into master: commit 6d6c00a50237dd8c9102fd24cb183ceda1aa90ac Author: Martin Roth <martinroth(a)google.com> Date: Fri Sep 30 14:51:24 2016 -0600 google/gale: Remove #ifdef of Kconfig bool symbol Kconfig symbols of type bool are ALWAYS defined, so this code was always being included and run, which isn't what the author wanted. Change to use IS_ENABLED(), and a regular if() instead of an #ifdef. Change-Id: I72623fa27e47980c602135f4b73f371c7f50139b Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/16837 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/16837 for details. -gerrit

1 0

Patch set updated for coreboot: src/drivers: Remove whitespace after sizeof
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16867 -gerrit commit f2ac8a895a8b93ce522b9ea55cb41193e1461ab2 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:29:04 2016 +0200 src/drivers: Remove whitespace after sizeof Change-Id: Ifd8477966feb744fb30cae7fd62e3783092c9d34 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/drivers/i2c/at24rf08c/lenovo_serials.c | 18 +++++++++--------- src/drivers/intel/gma/vbt.c | 18 +++++++++--------- src/drivers/usb/ehci_debug.c | 4 ++-- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index 881bf53..1b5e4ba 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -59,7 +59,7 @@ static void at24rf08c_read_string_dev(struct device *dev, u8 start, int t = at24rf08c_read_byte(dev, start + i); if (t < 0x20 || t > 0x7f) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return; } result[i] = t; @@ -74,7 +74,7 @@ static void at24rf08c_read_string(u8 bank, u8 start, u8 len, char *result) dev = at24rf08c_find_bank(bank); if (dev == NULL) { printk(BIOS_WARNING, "EEPROM not found\n"); - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return; } @@ -89,7 +89,7 @@ const char *smbios_mainboard_serial_number(void) if (already_read) return result; - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); at24rf08c_read_string(0, 0x2e, 7, result); already_read = 1; @@ -104,7 +104,7 @@ const char *lenovo_mainboard_partnumber(void) if (already_read) return result; - memset (result, 0, sizeof (result)); + memset (result, 0, sizeof(result)); at24rf08c_read_string(0, 0x27, 7, result); already_read = 1; @@ -133,7 +133,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) return; } - memset (result, 0, sizeof (result)); + memset (result, 0, sizeof(result)); dev = dev_find_slot_on_smbus(1, 0x56); if (dev == NULL) { @@ -155,7 +155,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) break; } if (t < 0) { - memset (result, 0, sizeof (result)); + memset (result, 0, sizeof(result)); break; } result[remap[i]] = t; @@ -176,17 +176,17 @@ const char *smbios_mainboard_version(void) if (already_read) return result; - memset (result, 0, sizeof (result)); + memset (result, 0, sizeof(result)); dev = at24rf08c_find_bank(2); if (dev == NULL) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return result; } len = at24rf08c_read_byte(dev, 0x26) - 2; if (len < 0 || len > sizeof(result) - 1) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return result; } diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index 9ec09d3..4a7c9c7 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -32,30 +32,30 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, struct bdb_general_features *genfeat; u8 *ptr; - memset (head, 0, sizeof (*head)); + memset (head, 0, sizeof(*head)); memset(head->signature, ' ', sizeof(head->signature)); memcpy(head->signature, idstr, MIN(strlen(idstr), sizeof(head->signature))); head->version = 100; - head->header_size = sizeof (*head); - head->bdb_offset = sizeof (*head); + head->header_size = sizeof(*head); + head->bdb_offset = sizeof(*head); bdb_head = (struct bdb_header *) (head + 1); - memset (bdb_head, 0, sizeof (*bdb_head)); + memset (bdb_head, 0, sizeof(*bdb_head)); memcpy (bdb_head->signature, "BIOS_DATA_BLOCK ", 16); bdb_head->version = 0xa8; - bdb_head->header_size = sizeof (*bdb_head); + bdb_head->header_size = sizeof(*bdb_head); ptr = (u8 *) (bdb_head + 1); ptr[0] = BDB_GENERAL_FEATURES; - ptr[1] = sizeof (*genfeat); - ptr[2] = sizeof (*genfeat) >> 8; + ptr[1] = sizeof(*genfeat); + ptr[2] = sizeof(*genfeat) >> 8; ptr += 3; genfeat = (struct bdb_general_features *) ptr; - memset (genfeat, 0, sizeof (*genfeat)); + memset (genfeat, 0, sizeof(*genfeat)); genfeat->panel_fitting = 3; genfeat->flexaim = 1; genfeat->download_ext_vbt = 1; @@ -66,7 +66,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, genfeat->int_crt_support = 1; genfeat->dp_ssc_enb = 1; - ptr += sizeof (*genfeat); + ptr += sizeof(*genfeat); bdb_head->bdb_size = ptr - (u8 *)bdb_head; head->vbt_size = ptr - (u8 *)head; diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index cac043e..84e2c66 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -427,7 +427,7 @@ static int usbdebug_init_(unsigned ehci_bar, unsigned offset, struct ehci_debug_ int playtimes = 3; /* Keep all endpoints disabled before any printk() call. */ - memset(info, 0, sizeof (*info)); + memset(info, 0, sizeof(*info)); info->ehci_base = (void *)ehci_bar; info->ehci_debug = (void *)(ehci_bar + offset); @@ -659,7 +659,7 @@ static int get_usbdebug_from_cbmem(struct ehci_debug_info *info) if (dbg_info_cbmem == NULL) return -1; - memcpy(info, dbg_info_cbmem, sizeof (*info)); + memcpy(info, dbg_info_cbmem, sizeof(*info)); printk(BIOS_DEBUG, "EHCI debug port found in CBMEM.\n"); return 0;

1 0

New patch to review for coreboot: src/drivers: Remove whitespace after sizeof
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16867 -gerrit commit ff297daa681d35a4ddd350caa9d763a324a25928 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:26:42 2016 +0200 src/drivers: Remove whitespace after sizeof Change-Id: Ifd8477966feb744fb30cae7fd62e3783092c9d34 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/drivers/i2c/at24rf08c/lenovo_serials.c | 18 +++++++++--------- src/drivers/intel/gma/vbt.c | 18 +++++++++--------- src/drivers/usb/ehci_debug.c | 4 ++-- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index d0d006f..7578397 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -59,7 +59,7 @@ static void at24rf08c_read_string_dev(struct device *dev, u8 start, int t = at24rf08c_read_byte(dev, start + i); if (t < 0x20 || t > 0x7f) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return; } result[i] = t; @@ -74,7 +74,7 @@ static void at24rf08c_read_string(u8 bank, u8 start, u8 len, char *result) dev = at24rf08c_find_bank(bank); if (dev == NULL) { printk(BIOS_WARNING, "EEPROM not found\n"); - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return; } @@ -89,7 +89,7 @@ const char *smbios_mainboard_serial_number(void) if (already_read) return result; - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); at24rf08c_read_string(0, 0x2e, 7, result); already_read = 1; @@ -104,7 +104,7 @@ const char *lenovo_mainboard_partnumber(void) if (already_read) return result; - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); at24rf08c_read_string(0, 0x27, 7, result); already_read = 1; @@ -133,7 +133,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) return; } - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); dev = dev_find_slot_on_smbus(1, 0x56); if (dev == NULL) { @@ -155,7 +155,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) break; } if (t < 0) { - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); break; } result[remap[i]] = t; @@ -176,17 +176,17 @@ const char *smbios_mainboard_version(void) if (already_read) return result; - memset(result, 0, sizeof (result)); + memset(result, 0, sizeof(result)); dev = at24rf08c_find_bank(2); if (dev == NULL) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return result; } len = at24rf08c_read_byte(dev, 0x26) - 2; if (len < 0 || len > sizeof(result) - 1) { - memcpy(result, ERROR_STRING, sizeof (ERROR_STRING)); + memcpy(result, ERROR_STRING, sizeof(ERROR_STRING)); return result; } diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index 430aa9b..16670f7 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -32,30 +32,30 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, struct bdb_general_features *genfeat; u8 *ptr; - memset(head, 0, sizeof (*head)); + memset(head, 0, sizeof(*head)); memset(head->signature, ' ', sizeof(head->signature)); memcpy(head->signature, idstr, MIN(strlen(idstr), sizeof(head->signature))); head->version = 100; - head->header_size = sizeof (*head); - head->bdb_offset = sizeof (*head); + head->header_size = sizeof(*head); + head->bdb_offset = sizeof(*head); bdb_head = (struct bdb_header *) (head + 1); - memset(bdb_head, 0, sizeof (*bdb_head)); + memset(bdb_head, 0, sizeof(*bdb_head)); memcpy(bdb_head->signature, "BIOS_DATA_BLOCK ", 16); bdb_head->version = 0xa8; - bdb_head->header_size = sizeof (*bdb_head); + bdb_head->header_size = sizeof(*bdb_head); ptr = (u8 *) (bdb_head + 1); ptr[0] = BDB_GENERAL_FEATURES; - ptr[1] = sizeof (*genfeat); - ptr[2] = sizeof (*genfeat) >> 8; + ptr[1] = sizeof(*genfeat); + ptr[2] = sizeof(*genfeat) >> 8; ptr += 3; genfeat = (struct bdb_general_features *) ptr; - memset(genfeat, 0, sizeof (*genfeat)); + memset(genfeat, 0, sizeof(*genfeat)); genfeat->panel_fitting = 3; genfeat->flexaim = 1; genfeat->download_ext_vbt = 1; @@ -66,7 +66,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, genfeat->int_crt_support = 1; genfeat->dp_ssc_enb = 1; - ptr += sizeof (*genfeat); + ptr += sizeof(*genfeat); bdb_head->bdb_size = ptr - (u8 *)bdb_head; head->vbt_size = ptr - (u8 *)head; diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index cac043e..84e2c66 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -427,7 +427,7 @@ static int usbdebug_init_(unsigned ehci_bar, unsigned offset, struct ehci_debug_ int playtimes = 3; /* Keep all endpoints disabled before any printk() call. */ - memset(info, 0, sizeof (*info)); + memset(info, 0, sizeof(*info)); info->ehci_base = (void *)ehci_bar; info->ehci_debug = (void *)(ehci_bar + offset); @@ -659,7 +659,7 @@ static int get_usbdebug_from_cbmem(struct ehci_debug_info *info) if (dbg_info_cbmem == NULL) return -1; - memcpy(info, dbg_info_cbmem, sizeof (*info)); + memcpy(info, dbg_info_cbmem, sizeof(*info)); printk(BIOS_DEBUG, "EHCI debug port found in CBMEM.\n"); return 0;

1 0

Patch set updated for coreboot: src/drivers: Remove whitespace after memcpy & memset
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16866 -gerrit commit 5461e39fa42e329d8aa9b2032729e88572ff0789 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:19:16 2016 +0200 src/drivers: Remove whitespace after memcpy & memset Change-Id: If79eb706b6d44f7c34dfe31a1545f5850870b334 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/drivers/i2c/at24rf08c/lenovo_serials.c | 14 +++++++------- src/drivers/intel/gma/vbt.c | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index 881bf53..d0d006f 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -104,7 +104,7 @@ const char *lenovo_mainboard_partnumber(void) if (already_read) return result; - memset (result, 0, sizeof (result)); + memset(result, 0, sizeof (result)); at24rf08c_read_string(0, 0x27, 7, result); already_read = 1; @@ -129,17 +129,17 @@ void smbios_mainboard_set_uuid(u8 *uuid) if (already_read) { - memcpy (uuid, result, 16); + memcpy(uuid, result, 16); return; } - memset (result, 0, sizeof (result)); + memset(result, 0, sizeof (result)); dev = dev_find_slot_on_smbus(1, 0x56); if (dev == NULL) { printk(BIOS_WARNING, "EEPROM not found\n"); already_read = 1; - memset (uuid, 0, 16); + memset(uuid, 0, 16); return; } @@ -155,7 +155,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) break; } if (t < 0) { - memset (result, 0, sizeof (result)); + memset(result, 0, sizeof (result)); break; } result[remap[i]] = t; @@ -163,7 +163,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) already_read = 1; - memcpy (uuid, result, 16); + memcpy(uuid, result, 16); } const char *smbios_mainboard_version(void) @@ -176,7 +176,7 @@ const char *smbios_mainboard_version(void) if (already_read) return result; - memset (result, 0, sizeof (result)); + memset(result, 0, sizeof (result)); dev = at24rf08c_find_bank(2); if (dev == NULL) { diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index 9ec09d3..430aa9b 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -32,7 +32,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, struct bdb_general_features *genfeat; u8 *ptr; - memset (head, 0, sizeof (*head)); + memset(head, 0, sizeof (*head)); memset(head->signature, ' ', sizeof(head->signature)); memcpy(head->signature, idstr, MIN(strlen(idstr), @@ -42,8 +42,8 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, head->bdb_offset = sizeof (*head); bdb_head = (struct bdb_header *) (head + 1); - memset (bdb_head, 0, sizeof (*bdb_head)); - memcpy (bdb_head->signature, "BIOS_DATA_BLOCK ", 16); + memset(bdb_head, 0, sizeof (*bdb_head)); + memcpy(bdb_head->signature, "BIOS_DATA_BLOCK ", 16); bdb_head->version = 0xa8; bdb_head->header_size = sizeof (*bdb_head); @@ -55,7 +55,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, ptr += 3; genfeat = (struct bdb_general_features *) ptr; - memset (genfeat, 0, sizeof (*genfeat)); + memset(genfeat, 0, sizeof (*genfeat)); genfeat->panel_fitting = 3; genfeat->flexaim = 1; genfeat->download_ext_vbt = 1;

1 0

New patch to review for coreboot: src/drivers: Remove whitespace after memcpy
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16866 -gerrit commit e67d895c2afdb4fd575b6064552bfe58ac0e9f63 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:19:16 2016 +0200 src/drivers: Remove whitespace after memcpy Change-Id: If79eb706b6d44f7c34dfe31a1545f5850870b334 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/drivers/i2c/at24rf08c/lenovo_serials.c | 4 ++-- src/drivers/intel/gma/vbt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index 881bf53..cc46b75 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -129,7 +129,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) if (already_read) { - memcpy (uuid, result, 16); + memcpy(uuid, result, 16); return; } @@ -163,7 +163,7 @@ void smbios_mainboard_set_uuid(u8 *uuid) already_read = 1; - memcpy (uuid, result, 16); + memcpy(uuid, result, 16); } const char *smbios_mainboard_version(void) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index 9ec09d3..3559e68 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -43,7 +43,7 @@ static size_t generate_vbt(const struct i915_gpu_controller_info *conf, bdb_head = (struct bdb_header *) (head + 1); memset (bdb_head, 0, sizeof (*bdb_head)); - memcpy (bdb_head->signature, "BIOS_DATA_BLOCK ", 16); + memcpy(bdb_head->signature, "BIOS_DATA_BLOCK ", 16); bdb_head->version = 0xa8; bdb_head->header_size = sizeof (*bdb_head);

1 0

New patch to review for coreboot: src/arch: Remove whitespace after sizeof
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16865 -gerrit commit c91628d5edb55f80bd5c8535ce3f50e69eb1b163 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:11:07 2016 +0200 src/arch: Remove whitespace after sizeof Change-Id: Ia2fc3d5ea88d61ba7c4a1daebfe74a24948c8f6e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/arch/x86/acpi.c | 4 ++-- src/arch/x86/acpigen.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index edb6835..53c4135 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -870,7 +870,7 @@ unsigned long write_acpi_tables(unsigned long start) } if (dsdt_file->length > dsdt_size - || dsdt_file->length < sizeof (acpi_header_t) + || dsdt_file->length < sizeof(acpi_header_t) || memcmp(dsdt_file->signature, "DSDT", 4) != 0) { printk(BIOS_ERR, "Invalid DSDT file, skipping ACPI tables\n"); return current; @@ -880,7 +880,7 @@ unsigned long write_acpi_tables(unsigned long start) CBFS_TYPE_RAW, &slic_size); if (slic_file && (slic_file->length > slic_size - || slic_file->length < sizeof (acpi_header_t) + || slic_file->length < sizeof(acpi_header_t) || memcmp(slic_file->signature, "SLIC", 4) != 0)) { slic_file = 0; } diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index 2d626ab..00f8bd0 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -348,7 +348,7 @@ void acpigen_write_processor(u8 cpuindex, u32 pblock_addr, u8 pblock_len) acpigen_emit_byte(0x83); acpigen_write_len_f(); - snprintf(pscope, sizeof (pscope), + snprintf(pscope, sizeof(pscope), "\\_PR.CP%02d", (unsigned int) cpuindex); acpigen_emit_namestring(pscope); acpigen_emit_byte(cpuindex);

1 0

New patch to review for coreboot: src/cpu: Remove whitespace after sizeof
by HAOUAS Elyes 03 Oct '16

03 Oct '16

HAOUAS Elyes (ehaouas(a)noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16864 -gerrit commit 082ea487f760dba8f75773929fdc529907dc2273 Author: Elyes HAOUAS <ehaouas(a)noos.fr> Date: Mon Oct 3 22:06:08 2016 +0200 src/cpu: Remove whitespace after sizeof Change-Id: I30b911a8444529653c8ea4a736a902143fe7ab20 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- src/cpu/amd/agesa/heapmanager.c | 26 +++++++++++++------------- src/cpu/amd/pi/heapmanager.c | 26 +++++++++++++------------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/cpu/amd/agesa/heapmanager.c b/src/cpu/amd/agesa/heapmanager.c index 701185a..087959d 100644 --- a/src/cpu/amd/agesa/heapmanager.c +++ b/src/cpu/amd/agesa/heapmanager.c @@ -131,23 +131,23 @@ static AGESA_STATUS agesa_AllocateBuffer(UINT32 Func, UINT32 Data, VOID *ConfigP return alloc_cbmem(AllocParams); #endif - AvailableHeapSize = BIOS_HEAP_SIZE - sizeof (BIOS_HEAP_MANAGER); + AvailableHeapSize = BIOS_HEAP_SIZE - sizeof(BIOS_HEAP_MANAGER); BiosHeapBaseAddr = GetHeapBase(); BiosHeapBasePtr = (BIOS_HEAP_MANAGER *) BiosHeapBaseAddr; if (BiosHeapBasePtr->StartOfAllocatedNodes == 0) { /* First allocation */ - CurrNodeOffset = sizeof (BIOS_HEAP_MANAGER); + CurrNodeOffset = sizeof(BIOS_HEAP_MANAGER); CurrNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + CurrNodeOffset); CurrNodePtr->BufferHandle = AllocParams->BufferHandle; CurrNodePtr->BufferSize = AllocParams->BufferLength; CurrNodePtr->NextNodeOffset = 0; - AllocParams->BufferPointer = (UINT8 *) CurrNodePtr + sizeof (BIOS_BUFFER_NODE); + AllocParams->BufferPointer = (UINT8 *) CurrNodePtr + sizeof(BIOS_BUFFER_NODE); /* Update the remaining free space */ - FreedNodeOffset = CurrNodeOffset + CurrNodePtr->BufferSize + sizeof (BIOS_BUFFER_NODE); + FreedNodeOffset = CurrNodeOffset + CurrNodePtr->BufferSize + sizeof(BIOS_BUFFER_NODE); FreedNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + FreedNodeOffset); - FreedNodePtr->BufferSize = AvailableHeapSize - sizeof (BIOS_BUFFER_NODE) - CurrNodePtr->BufferSize; + FreedNodePtr->BufferSize = AvailableHeapSize - sizeof(BIOS_BUFFER_NODE) - CurrNodePtr->BufferSize; FreedNodePtr->NextNodeOffset = 0; /* Update the offsets for Allocated and Freed nodes */ @@ -177,7 +177,7 @@ static AGESA_STATUS agesa_AllocateBuffer(UINT32 Func, UINT32 Data, VOID *ConfigP BestFitPrevNodeOffset = 0; while (FreedNodeOffset != 0) { FreedNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + FreedNodeOffset); - if (FreedNodePtr->BufferSize >= (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE))) { + if (FreedNodePtr->BufferSize >= (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE))) { if (BestFitNodeOffset == 0) { /* First node that fits the requested buffer size */ BestFitNodeOffset = FreedNodeOffset; @@ -205,11 +205,11 @@ static AGESA_STATUS agesa_AllocateBuffer(UINT32 Func, UINT32 Data, VOID *ConfigP BestFitPrevNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + BestFitPrevNodeOffset); /* If BestFitNode is larger than the requested buffer, fragment the node further */ - if (BestFitNodePtr->BufferSize > (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE))) { - NextFreeOffset = BestFitNodeOffset + AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE); + if (BestFitNodePtr->BufferSize > (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE))) { + NextFreeOffset = BestFitNodeOffset + AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE); NextFreePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + NextFreeOffset); - NextFreePtr->BufferSize = BestFitNodePtr->BufferSize - (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE)); + NextFreePtr->BufferSize = BestFitNodePtr->BufferSize - (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE)); NextFreePtr->NextNodeOffset = BestFitNodePtr->NextNodeOffset; } else { /* Otherwise, next free node is NextNodeOffset of BestFitNode */ @@ -232,7 +232,7 @@ static AGESA_STATUS agesa_AllocateBuffer(UINT32 Func, UINT32 Data, VOID *ConfigP BestFitNodePtr->NextNodeOffset = 0; /* Remove BestFitNode from list of Freed nodes */ - AllocParams->BufferPointer = (UINT8 *) BestFitNodePtr + sizeof (BIOS_BUFFER_NODE); + AllocParams->BufferPointer = (UINT8 *) BestFitNodePtr + sizeof(BIOS_BUFFER_NODE); } } @@ -281,9 +281,9 @@ static AGESA_STATUS agesa_DeallocateBuffer(UINT32 Func, UINT32 Data, VOID *Confi PrevNodePtr->NextNodeOffset = AllocNodePtr->NextNodeOffset; /* Zero out the buffer, and clear the BufferHandle */ - LibAmdMemFill ((UINT8 *)AllocNodePtr + sizeof (BIOS_BUFFER_NODE), 0, AllocNodePtr->BufferSize, &(AllocParams->StdHeader)); + LibAmdMemFill ((UINT8 *)AllocNodePtr + sizeof(BIOS_BUFFER_NODE), 0, AllocNodePtr->BufferSize, &(AllocParams->StdHeader)); AllocNodePtr->BufferHandle = 0; - AllocNodePtr->BufferSize += sizeof (BIOS_BUFFER_NODE); + AllocNodePtr->BufferSize += sizeof(BIOS_BUFFER_NODE); /* Add deallocated node in order to the list of freed nodes */ FreedNodeOffset = BiosHeapBasePtr->StartOfFreedNodes; @@ -385,7 +385,7 @@ static AGESA_STATUS agesa_LocateBuffer(UINT32 Func, UINT32 Data, VOID *ConfigPtr } } - AllocParams->BufferPointer = (UINT8 *) ((UINT8 *) AllocNodePtr + sizeof (BIOS_BUFFER_NODE)); + AllocParams->BufferPointer = (UINT8 *) ((UINT8 *) AllocNodePtr + sizeof(BIOS_BUFFER_NODE)); AllocParams->BufferLength = AllocNodePtr->BufferSize; return AGESA_SUCCESS; diff --git a/src/cpu/amd/pi/heapmanager.c b/src/cpu/amd/pi/heapmanager.c index d4a79b8..7fc8fb8 100644 --- a/src/cpu/amd/pi/heapmanager.c +++ b/src/cpu/amd/pi/heapmanager.c @@ -89,23 +89,23 @@ AGESA_STATUS agesa_AllocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) return alloc_cbmem(AllocParams); #endif - AvailableHeapSize = BIOS_HEAP_SIZE - sizeof (BIOS_HEAP_MANAGER); + AvailableHeapSize = BIOS_HEAP_SIZE - sizeof(BIOS_HEAP_MANAGER); BiosHeapBaseAddr = (UINT8 *) GetHeapBase(&(AllocParams->StdHeader)); BiosHeapBasePtr = (BIOS_HEAP_MANAGER *) BiosHeapBaseAddr; if (BiosHeapBasePtr->StartOfAllocatedNodes == 0) { /* First allocation */ - CurrNodeOffset = sizeof (BIOS_HEAP_MANAGER); + CurrNodeOffset = sizeof(BIOS_HEAP_MANAGER); CurrNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + CurrNodeOffset); CurrNodePtr->BufferHandle = AllocParams->BufferHandle; CurrNodePtr->BufferSize = AllocParams->BufferLength; CurrNodePtr->NextNodeOffset = 0; - AllocParams->BufferPointer = (UINT8 *) CurrNodePtr + sizeof (BIOS_BUFFER_NODE); + AllocParams->BufferPointer = (UINT8 *) CurrNodePtr + sizeof(BIOS_BUFFER_NODE); /* Update the remaining free space */ - FreedNodeOffset = CurrNodeOffset + CurrNodePtr->BufferSize + sizeof (BIOS_BUFFER_NODE); + FreedNodeOffset = CurrNodeOffset + CurrNodePtr->BufferSize + sizeof(BIOS_BUFFER_NODE); FreedNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + FreedNodeOffset); - FreedNodePtr->BufferSize = AvailableHeapSize - sizeof (BIOS_BUFFER_NODE) - CurrNodePtr->BufferSize; + FreedNodePtr->BufferSize = AvailableHeapSize - sizeof(BIOS_BUFFER_NODE) - CurrNodePtr->BufferSize; FreedNodePtr->NextNodeOffset = 0; /* Update the offsets for Allocated and Freed nodes */ @@ -135,7 +135,7 @@ AGESA_STATUS agesa_AllocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) BestFitPrevNodeOffset = 0; while (FreedNodeOffset != 0) { FreedNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + FreedNodeOffset); - if (FreedNodePtr->BufferSize >= (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE))) { + if (FreedNodePtr->BufferSize >= (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE))) { if (BestFitNodeOffset == 0) { /* First node that fits the requested buffer size */ BestFitNodeOffset = FreedNodeOffset; @@ -163,11 +163,11 @@ AGESA_STATUS agesa_AllocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) BestFitPrevNodePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + BestFitPrevNodeOffset); /* If BestFitNode is larger than the requested buffer, fragment the node further */ - if (BestFitNodePtr->BufferSize > (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE))) { - NextFreeOffset = BestFitNodeOffset + AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE); + if (BestFitNodePtr->BufferSize > (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE))) { + NextFreeOffset = BestFitNodeOffset + AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE); NextFreePtr = (BIOS_BUFFER_NODE *) (BiosHeapBaseAddr + NextFreeOffset); - NextFreePtr->BufferSize = BestFitNodePtr->BufferSize - (AllocParams->BufferLength + sizeof (BIOS_BUFFER_NODE)); + NextFreePtr->BufferSize = BestFitNodePtr->BufferSize - (AllocParams->BufferLength + sizeof(BIOS_BUFFER_NODE)); NextFreePtr->NextNodeOffset = BestFitNodePtr->NextNodeOffset; } else { /* Otherwise, next free node is NextNodeOffset of BestFitNode */ @@ -190,7 +190,7 @@ AGESA_STATUS agesa_AllocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) BestFitNodePtr->NextNodeOffset = 0; /* Remove BestFitNode from list of Freed nodes */ - AllocParams->BufferPointer = (UINT8 *) BestFitNodePtr + sizeof (BIOS_BUFFER_NODE); + AllocParams->BufferPointer = (UINT8 *) BestFitNodePtr + sizeof(BIOS_BUFFER_NODE); } } @@ -239,9 +239,9 @@ AGESA_STATUS agesa_DeallocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) PrevNodePtr->NextNodeOffset = AllocNodePtr->NextNodeOffset; /* Zero out the buffer, and clear the BufferHandle */ - LibAmdMemFill ((UINT8 *)AllocNodePtr + sizeof (BIOS_BUFFER_NODE), 0, AllocNodePtr->BufferSize, &(AllocParams->StdHeader)); + LibAmdMemFill ((UINT8 *)AllocNodePtr + sizeof(BIOS_BUFFER_NODE), 0, AllocNodePtr->BufferSize, &(AllocParams->StdHeader)); AllocNodePtr->BufferHandle = 0; - AllocNodePtr->BufferSize += sizeof (BIOS_BUFFER_NODE); + AllocNodePtr->BufferSize += sizeof(BIOS_BUFFER_NODE); /* Add deallocated node in order to the list of freed nodes */ FreedNodeOffset = BiosHeapBasePtr->StartOfFreedNodes; @@ -343,7 +343,7 @@ AGESA_STATUS agesa_LocateBuffer (UINT32 Func, UINT32 Data, VOID *ConfigPtr) } } - AllocParams->BufferPointer = (UINT8 *) ((UINT8 *) AllocNodePtr + sizeof (BIOS_BUFFER_NODE)); + AllocParams->BufferPointer = (UINT8 *) ((UINT8 *) AllocNodePtr + sizeof(BIOS_BUFFER_NODE)); AllocParams->BufferLength = AllocNodePtr->BufferSize; return AGESA_SUCCESS;

1 0

Patch merged into coreboot/master: util/lint/kconfig_lint: change warning levels and text
by gerrit＠coreboot.org 03 Oct '16

03 Oct '16

the following patch was just integrated into master: commit 8bc8be4d0ecd2c939a36f2846ef85d6f469180eb Author: Martin Roth <martinroth(a)google.com> Date: Fri Sep 30 15:56:27 2016 -0600 util/lint/kconfig_lint: change warning levels and text - Add an exception for MAINBOARD_POWER_ON_AFTER_POWER_FAIL when checking - With those exceptions set, we don't have anymore #define or #ifdef warnings, so turn them to errors so no more can be pushed. - Change the definition of an unused symbol from a warning to a note. There are times when unused symbols are expected. - Upgrade the warning for loading Kconfig files multiple times from a warning to an error. Change-Id: I6dcb06d4f0b099d5ccaf7643e72dd790719bdf58 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/16840 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/16840 for details. -gerrit

1 0

Patch merged into coreboot/master: util/lint/kconfig_lint: Check default types
by gerrit＠coreboot.org 03 Oct '16

03 Oct '16

the following patch was just integrated into master: commit fa95625867fa1f373e8c5d8ec160a65e50a3d5c2 Author: Martin Roth <martinroth(a)google.com> Date: Fri Sep 30 15:51:32 2016 -0600 util/lint/kconfig_lint: Check default types The type of the default value wasn't being checked to make sure that it matched the type of the Kconfig symbol. This makes sure that the symbol is being set to either a reasonable looking value or to another Kconfig symbol. Change-Id: Ia01bd2d8b387f319d29f0a005d55cb8e20cd3853 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/16839 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See https://review.coreboot.org/16839 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2016