coreboot-gerrit July 2015

coreboot-gerrit@coreboot.org

1 participants
1048 discussions

Patch merged into coreboot/master: arm: add __umoddi3() to libgcc implementation
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit db03c2259a2ff2eceddecc92e7dd1fc6bc9ca126 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 8 23:59:15 2015 +0200 arm: add __umoddi3() to libgcc implementation Change-Id: Ida01506406d1d74211f0155a84c2b25dbaac5f1c Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10860 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/10860 for details. -gerrit

1 0

Patch merged into coreboot/master: rk3288: Fix & vs && mix up in hdmi driver
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit a3f1a2e2bf4f749b9eb7cb5108ce76b7c1c2247b Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 8 23:31:46 2015 +0200 rk3288: Fix & vs && mix up in hdmi driver Change-Id: I54650671adaef3bc129c662d6e972474c869afaa Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10859 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/10859 for details. -gerrit

1 0

Patch merged into coreboot/master: device: remove unused x86 include from common code
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit b538a69936fa6467a59f92ff965a97f814567035 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 8 23:25:17 2015 +0200 device: remove unused x86 include from common code The include breaks compilation on ARM with clang. Change-Id: I1ce0d58dbcbb8785c23739670c8c9574c329a81c Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10858 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/10858 for details. -gerrit

1 0

Patch merged into coreboot/master: arm: enhance eabi compat functions
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit 808f784db5f22784619f306f76a9da94706142cc Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Wed Jul 8 23:18:11 2015 +0200 arm: enhance eabi compat functions This fixes issues with our clang reference toolchain on ARM. Change-Id: Ib754941059285f15332bc694814aff6285969545 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10857 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/10857 for details. -gerrit

1 0

New patch to review for coreboot: libpayload: Use top level xcompile
by Stefan Reinauer 08 Jul '15

08 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10863 -gerrit commit 6d9d4ca9013c252cd219283e8e0222d5544253c8 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Jul 9 00:26:49 2015 +0200 libpayload: Use top level xcompile Instead of having a second copy that already within 2-3 days becamer quite outdated, use the same xcompile copy for coreboot and libpayload, as we do with Kconfig already. This requires a simple change to the top level xcompile to understand both CONFIG_COMPILER_GCC and CONFIG_LP_COMPILER_GCC (only one of them will occur at the same time) libpayload's .xcompile target was moved later so that it can make use of $(top) Change-Id: I44001067f551cd0776dd303cbaeaa40eb3d5c1db Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- payloads/libpayload/Makefile | 20 +- payloads/libpayload/util/xcompile/xcompile | 337 ----------------------------- util/xcompile/xcompile | 2 +- 3 files changed, 11 insertions(+), 348 deletions(-) diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile index 2b9bbcb..fc3d944 100644 --- a/payloads/libpayload/Makefile +++ b/payloads/libpayload/Makefile @@ -38,16 +38,6 @@ endif # to silence stupid warnings about a file that would be generated anyway. $(if $(wildcard .xcompile),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > .xcompile))) -.xcompile: util/xcompile/xcompile - $< $(XGCCPATH) > $@.tmp - \mv -f $@.tmp $@ 2> /dev/null - -ifeq ($(INNER_SCANBUILD),y) -CC:=$(CC_real) -HOSTCC:=$(CC_real) --hostcc -HOSTCXX:=$(CC_real) --hostcxx -endif - export top := $(CURDIR) export src := src export srck := $(abspath $(top)/../../util/kconfig) @@ -95,6 +85,16 @@ DOXYGEN_OUTPUT_DIR := doxygen all: real-all +.xcompile: $(top)/../../util/xcompile/xcompile + $< $(XGCCPATH) > $@.tmp + \mv -f $@.tmp $@ 2> /dev/null + +ifeq ($(INNER_SCANBUILD),y) +CC:=$(CC_real) +HOSTCC:=$(CC_real) --hostcc +HOSTCXX:=$(CC_real) --hostcxx +endif + # This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules. include $(srck)/Makefile diff --git a/payloads/libpayload/util/xcompile/xcompile b/payloads/libpayload/util/xcompile/xcompile deleted file mode 100755 index b6759a9..0000000 --- a/payloads/libpayload/util/xcompile/xcompile +++ /dev/null @@ -1,337 +0,0 @@ -#!/bin/bash -# -# This file is part of the coreboot project. -# -# Copyright (C) 2007-2010 coresystems GmbH -# Copyright (C) 2012 Google Inc -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc. -# - -TMPFILE="" -XGCCPATH=${1:-"`pwd`/util/crossgcc/xgcc/bin/"} - -die() { - echo "ERROR: $*" >&2 - exit 1 -} - -clean_up() { - if [ -n "$TMPFILE" ]; then - rm -f "$TMPFILE" "$TMPFILE.c" "$TMPFILE.o" - fi -} - -# Create temporary file(s). -TMPFILE="$(mktemp /tmp/temp.XXXX 2>/dev/null || echo /tmp/temp.78gOIUGz)" -touch "$TMPFILE" -trap clean_up EXIT - - -program_exists() { - type "$1" >/dev/null 2>&1 -} - - -if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then - IASL=${XGCCPATH}iasl -elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then - IASL=iasl -else - die "no iasl found" -fi - -if program_exists gcc; then - HOSTCC=gcc -elif program_exists cc; then - HOSTCC=cc -else - die "no host compiler found" -fi - -cat <<EOF -# platform agnostic and host tools -IASL:=${IASL} -HOSTCC?=${HOSTCC} - -EOF - -testcc() { - local tmp_c="$TMPFILE.c" - local tmp_o="$TMPFILE.o" - rm -f "$tmp_c" "$tmp_o" - echo "void _start(void) {}" >"$tmp_c" - "$1" -nostdlib -Werror $2 "$tmp_c" -o "$tmp_o" >/dev/null 2>&1 -} - -testas() { - local gccprefix="$1" - local twidth="$2" - local arch="$3" - local use_dash_twidth="$4" - local endian="$5" - local obj_file="$TMPFILE.o" - local full_arch="elf$twidth-$arch" - - rm -f "$obj_file" - [ -n "$use_dash_twidth" ] && use_dash_twidth="--$twidth" - [ -n "$endian" ] && endian="-$endian" - ${gccprefix}as $use_dash_twidth $endian -o "$obj_file" $TMPFILE \ - 2>/dev/null || return 1 - - # Check output content type. - local obj_type="$(${gccprefix}objdump -p $obj_file)" - local obj_arch="$(expr "$obj_type" : '.*format $.[a-z0-9-]*$')" - [ "$obj_arch" = "$full_arch" ] || return 1 - - # Architecture matched. - GCCPREFIX="$gccprefix" - - unset ASFLAGS LDFLAGS - unset CFLAGS_GCC CFLAGS_CLANG - - if [ -n "$use_dash_twidth" ]; then - ASFLAGS="--$twidth" - CFLAGS_GCC="-m$twidth" - CFLAGS_CLANG="-m$twidth" - LDFLAGS="-b $full_arch" - - fi - - # Special parameters only available in dash_twidth mode. - [ -n "$use_dash_twidth" ] && case "$full_arch" in - "elf32-i386" ) - LDFLAGS="$LDFLAGS -melf_i386" - CFLAGS_GCC="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" - CFLAGS_CLANG="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" - ;; - esac - - return 0 -} - -detect_special_flags() { - local architecture="$1" - # GCC 4.6 is much more picky about unused variables. - # Turn off it's warnings for now: - testcc "$GCC" "$CFLAGS_GCC -Wno-unused-but-set-variable " && - CFLAGS_GCC="$CFLAGS_GCC -Wno-unused-but-set-variable " - - # Check for an operational -m32/-m64 - testcc "$GCC" "$CFLAGS_GCC -m$TWIDTH " && - CFLAGS_GCC="$CFLAGS_GCC -m$TWIDTH " - - # Use bfd linker instead of gold if available: - testcc "$GCC" "$CFLAGS_GCC -fuse-ld=bfd" && - CFLAGS_GCC="$CFLAGS_GCC -fuse-ld=bfd" && LINKER_SUFFIX='.bfd' - - testcc "$GCC" "$CFLAGS_GCC -fno-stack-protector"&& - CFLAGS_GCC="$CFLAGS_GCC -fno-stack-protector" - testcc "$GCC" "$CFLAGS_GCC -Wl,--build-id=none" && - CFLAGS_GCC="$CFLAGS_GCC -Wl,--build-id=none" - - case "$architecture" in - x86) - testcc "$GCC" "$CFLAGS_GCC -Wa,--divide" && - CFLAGS_GCC="$CFLAGS_GCC -Wa,--divide" - testcc "$CLANG" "$CFLAGS_CLANG -Wa,--divide" && - CFLAGS_CLANG="$CFLAGS_CLANG -Wa,--divide" - # Always build for i686 -- no sse/mmx instructions since SMM - # modules are compiled using these flags. Note that this - # doesn't prevent a project using xcompile to explicitly - # specify -mmsse, etc flags. - CFLAGS_GCC="$CFLAGS_GCC -march=i686" - ;; - x64) - testcc "$GCC" "$CFLAGS_GCC -Wa,--divide" && - CFLAGS_GCC="$CFLAGS_GCC -Wa,--divide" - testcc "$CLANG" "$CFLAGS_CLANG -Wa,--divide" && - CFLAGS_CLANG="$CFLAGS_CLANG -Wa,--divide" - ;; - mipsel) - testcc "$GCC" "$CFLAGS_GCC -mno-abicalls -fno-pic" && \ - CFLAGS_GCC+=" -mno-abicalls -fno-pic" - - # Enforce little endian mode. - testcc "$GCC" "$CFLAGS_GCC -EL" && \ - CFLAGS_GCC+=" -EL" - ;; - esac -} - -detect_compiler_runtime() { - test -z "$CLANG" || \ - CC_RT_CLANG="`${CLANG} ${CFLAGS} -print-librt-file-name 2>/dev/null`" - test -z "$GCC" || \ - CC_RT_GCC="`${GCC} ${CFLAGS} -print-libgcc-file-name`" -} - -report_arch_toolchain() { - cat <<EOF -# elf${TWIDTH}-${TBFDARCH} toolchain (${GCC}) -ARCH_SUPPORTED+=${TARCH} -SUBARCH_SUPPORTED+=${TSUPP-${TARCH}} -ifeq (\$(CONFIG_LP_COMPILER_GCC),y) -CC_${TARCH}:=${GCC} -CFLAGS_${TARCH}:=${CFLAGS_GCC} -COMPILER_RT_${TARCH}:=${CC_RT_GCC} -COMPILER_RT_FLAGS_${TARCH}:=${CC_RT_EXTRA_GCC} -else -CC_${TARCH}:=${CLANG} -CFLAGS_${TARCH}:=${CFLAGS_CLANG} -CFLAGS_${TARCH}+=-no-integrated-as -Qunused-arguments -m${TWIDTH} -# tone down compiler warnings -CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare -Wno-shift-overflow -COMPILER_RT_${TARCH}:=${CC_RT_CLANG} -COMPILER_RT_FLAGS_${TARCH}:=${CC_RT_EXTRA_CLANG} -endif -CPP_${TARCH}:=${GCCPREFIX}cpp -AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS} -LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS} -NM_${TARCH}:=${GCCPREFIX}nm -OBJCOPY_${TARCH}:=${GCCPREFIX}objcopy -OBJDUMP_${TARCH}:=${GCCPREFIX}objdump -READELF_${TARCH}:=${GCCPREFIX}readelf -STRIP_${TARCH}:=${GCCPREFIX}strip -AR_${TARCH}:=${GCCPREFIX}ar -CROSS_COMPILE_${TARCH}:=${GCCPREFIX} - -EOF -} - -# Architecture definitions -SUPPORTED_ARCHITECTURES="arm arm64 mipsel riscv x64 x86" - -arch_config_arm() { - TARCH="arm" - TBFDARCHS="littlearm" - TCLIST="armv7a armv7-a" - TWIDTH="32" - TSUPP="arm armv4 armv7 armv7_m" - TABI="eabi" -} - -arch_config_arm64() { - TARCH="arm64" - TBFDARCHS="littleaarch64" - TCLIST="aarch64" - TWIDTH="64" - TSUPP="arm64 armv8_64" - TABI="elf" -} - -arch_config_riscv() { - TARCH="riscv" - TBFDARCHS="littleriscv" - TCLIST="riscv" - TWIDTH="64" - TABI="elf" -} - -arch_config_x64() { - TARCH="x86_64" - TBFDARCHS="x86-64" - TCLIST="x86_64" - TWIDTH="64" - TABI="elf" -} - -arch_config_x86() { - TARCH="x86_32" - TBFDARCHS="i386" - TCLIST="i386 x86_64" - TWIDTH="32" - TABI="elf" - CC_RT_EXTRA_GCC="--wrap __divdi3 --wrap __udivdi3 --wrap __moddi3 --wrap __umoddi3" -} - -arch_config_mipsel() { - TARCH="mips" - TBFDARCHS="tradlittlemips littlemips" - TCLIST="mipsel" - TWIDTH="32" - TSUPP="mips mipsel" - TABI="elf" - TENDIAN="EL" -} - -test_architecture() { - local architecture=$1 - local endian gccprefix search - - GCCPREFIX="invalid" - unset TABI TARCH TBFDARCH TCLIST TENDIAN TSUPP TWIDTH - unset CC_RT_EXTRA_GCC CC_RT_EXTRA_CLANG - unset GCC CLANG - if type arch_config_$architecture > /dev/null; then - arch_config_$architecture - else - die "no architecture definition for $architecture" - fi - - # To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as - # environment variable. - # Ex: CROSS_COMPILE_arm="armv7a-cros-linux-gnueabi-" - # CROSS_COMPILE_x86="i686-pc-linux-gnu-" - search="$(eval echo \$CROSS_COMPILE_$architecture 2>/dev/null)" - search="$search $CROSS_COMPILE" - for toolchain in $TCLIST; do - search="$search $XGCCPATH$toolchain-$TABI-" - search="$search $toolchain-$TABI-" - search="$search $toolchain-linux-gnu-" - search="$search $toolchain-" - done - echo "# $architecture TARCH_SEARCH=$search" - - # Search toolchain by checking assembler capability. - for TBFDARCH in $TBFDARCHS; do - for gccprefix in $search ""; do - program_exists "${gccprefix}as" || continue - for endian in $TENDIAN ""; do - testas "$gccprefix" "$TWIDTH" "$TBFDARCH" \ - "" "$endian" && break 3 - testas "$gccprefix" "$TWIDTH" "$TBFDARCH" \ - "TRUE" "$endian" && break 3 - done - done - done - if [ "invalid" != "$GCCPREFIX" ]; then - GCC="${GCCPREFIX}gcc" - fi - - for clang_arch in $TCLIST invalid; do - testcc "clang" "-target ${clang_arch}-$TABI -c" && break - done - - if [ "invalid" != "$clang_arch" ]; then - # FIXME: this may break in a clang && !gcc configuration, - # but that's more of a clang limitation. Let's be optimistic - # that this will change in the future. - CLANG="clang -target ${clang_arch}-${TABI} -ccc-gcc-name ${GCC}" - fi - - if [ -z "$GCC" -a -z "$CLANG" ]; then - echo "Warning: no suitable compiler for $architecture." >&2 - return 1 - fi -} - -# This loops over all supported architectures. -for architecture in $SUPPORTED_ARCHITECTURES; do - if test_architecture $architecture; then - detect_special_flags "$architecture" - detect_compiler_runtime "$architecture" - report_arch_toolchain - fi -done diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 884d7b8..5151aab 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -174,7 +174,7 @@ report_arch_toolchain() { # elf${TWIDTH}-${TBFDARCH} toolchain (${GCC}) ARCH_SUPPORTED+=${TARCH} SUBARCH_SUPPORTED+=${TSUPP-${TARCH}} -ifeq (\$(CONFIG_COMPILER_GCC),y) +ifeq (\$(CONFIG_COMPILER_GCC)\$(CONFIG_LP_COMPILER_GCC),y) CC_${TARCH}:=${GCC} CFLAGS_${TARCH}:=${CFLAGS_GCC} COMPILER_RT_${TARCH}:=${CC_RT_GCC}

1 0

Patch merged into coreboot/master: xcompile: switch around armv7 TCARCHes
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit b30045fd06d55da65675e578aa31001212153b38 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Tue Jul 7 23:34:30 2015 +0200 xcompile: switch around armv7 TCARCHes clang probing will pick up the first one that clang does not complain about and right now that is armv7a-eabi, even though our toolchain builds for armv7-a-eabi (and consecutively the build fails because there is no armv7a-eabi-as) Change-Id: I2594151150107f8e9c1aad33647dcb2f9878f953 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: http://review.coreboot.org/10830 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/10830 for details. -gerrit

1 0

New patch to review for coreboot: tegra124/tegra210: Include stages.h in bootblock.c
by Stefan Reinauer 08 Jul '15

08 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10862 -gerrit commit 6adf5c34814cf36c6ead4e40c1ea2664f7559b49 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Jul 9 00:18:03 2015 +0200 tegra124/tegra210: Include stages.h in bootblock.c Needed for the main() prototype Change-Id: I921a77d8b131b751291d3a279b23ee18b13eca8d Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/soc/nvidia/tegra124/bootblock.c | 1 + src/soc/nvidia/tegra210/bootblock.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/soc/nvidia/tegra124/bootblock.c b/src/soc/nvidia/tegra124/bootblock.c index 16e4d04..9d0ad76 100644 --- a/src/soc/nvidia/tegra124/bootblock.c +++ b/src/soc/nvidia/tegra124/bootblock.c @@ -19,6 +19,7 @@ #include <assert.h> #include <arch/exception.h> +#include <arch/stages.h> #include <bootblock_common.h> #include <cbfs.h> #include <console/console.h> diff --git a/src/soc/nvidia/tegra210/bootblock.c b/src/soc/nvidia/tegra210/bootblock.c index f141927..2e26fbf 100644 --- a/src/soc/nvidia/tegra210/bootblock.c +++ b/src/soc/nvidia/tegra210/bootblock.c @@ -19,6 +19,7 @@ #include <arch/exception.h> #include <arch/hlt.h> +#include <arch/stages.h> #include <bootblock_common.h> #include <console/console.h> #include <program_loading.h>

1 0

New patch to review for coreboot: tegra210: Fix coding style in clock.c
by Stefan Reinauer 08 Jul '15

08 Jul '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10861 -gerrit commit 1d2984f819d7550ddfcca669dcfb0504743ca773 Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Date: Thu Jul 9 00:17:02 2015 +0200 tegra210: Fix coding style in clock.c Change-Id: I1a8ce0b8ec291a5ddd8fdefcda24842e2a3c692d Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/soc/nvidia/tegra210/clock.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/soc/nvidia/tegra210/clock.c b/src/soc/nvidia/tegra210/clock.c index 394c781..9cbae81 100644 --- a/src/soc/nvidia/tegra210/clock.c +++ b/src/soc/nvidia/tegra210/clock.c @@ -146,7 +146,7 @@ struct { int khz; struct pll_fields plls[PLL_MAX_INDEX]; } static osc_table[16] = { - [OSC_FREQ_12]{ + [OSC_FREQ_12] = { .khz = 12000, .plls = { PLLX(TEGRA_PLLX_KHZ / 12000, 1, 0, 0, 0), @@ -155,7 +155,7 @@ struct { PLLDP(90, 1, 2, 0, 0), /* 270 MHz */ }, }, - [OSC_FREQ_13]{ + [OSC_FREQ_13] = { .khz = 13000, .plls = { PLLX(TEGRA_PLLX_KHZ / 13000, 1, 0, 0, 0), @@ -164,7 +164,7 @@ struct { PLLDP(83, 1, 3, 0, 0), /* 269.8 MHz */ }, }, - [OSC_FREQ_16P8]{ + [OSC_FREQ_16P8] = { .khz = 16800, .plls = { PLLX(TEGRA_PLLX_KHZ / 16800, 1, 0, 0, 0), @@ -173,7 +173,7 @@ struct { PLLDP(64, 1, 2, 0, 0), /* 268.8 MHz */ }, }, - [OSC_FREQ_19P2]{ + [OSC_FREQ_19P2] = { .khz = 19200, .plls = { PLLX(TEGRA_PLLX_KHZ / 19200, 1, 0, 0, 0), @@ -182,7 +182,7 @@ struct { PLLDP(56, 1, 2, 0, 0), /* 268.8 MHz */ }, }, - [OSC_FREQ_26]{ + [OSC_FREQ_26] = { .khz = 26000, .plls = { PLLX(TEGRA_PLLX_KHZ / 26000, 1, 0, 0, 0), @@ -191,7 +191,7 @@ struct { PLLDP(83, 2, 2, 0, 0), /* 269.8 MHz */ }, }, - [OSC_FREQ_38P4]{ + [OSC_FREQ_38P4] = { .khz = 38400, .plls = { PLLX(TEGRA_PLLX_KHZ / 38400, 1, 0, 0, 0), @@ -200,7 +200,7 @@ struct { PLLDP(56, 2, 2, 0, 0), /* 268.8 MHz */ }, }, - [OSC_FREQ_48]{ + [OSC_FREQ_48] = { .khz = 48000, .plls = { PLLX(TEGRA_PLLX_KHZ / 48000, 1, 0, 0, 0),

1 0

Patch merged into coreboot/master: ipq8064: enable timestamp collection
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit 62b4de13c656d5a773d78a35192d560c2216d669 Author: Vadim Bendebury <vbendeb(a)chromium.org> Date: Fri Dec 12 17:54:27 2014 -0800 ipq8064: enable timestamp collection One kilobyte of SRAM needs to be allocated and the feature enabled. BRANCH=storm BUG=chrome-os-partner:34161 TEST=timer error messages do not show up in the coreboot log any more Change-Id: I1d5e5521bf9ae495d4f4f50ff017c846a8420719 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: ffb9bfb0cdfab1391f8ae07669a2ab6b24d88dd7 Original-Change-Id: I60066672334db36f5e7adbef6794d7afd177d292 Original-Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/235893 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10847 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10847 for details. -gerrit

1 0

Patch merged into coreboot/master: libpayload: Add LZ4 decompression algorithm
by gerrit＠coreboot.org 08 Jul '15

08 Jul '15

the following patch was just integrated into master: commit bf27391da5b12f53444a9e678bcfb912f88e30e4 Author: Julius Werner <jwerner(a)chromium.org> Date: Tue Jun 30 10:30:30 2015 -0700 libpayload: Add LZ4 decompression algorithm This patch adds support for the LZ4 decompression algorithm to libpayload. It's what all the cool kids are using for decompression these days and has many interesting advantages over LZMA (and everything else I know of): blazing fast decompression (20(!) times faster than LZMA, twice as fast as LZO on my Cortex-A72), no memory requirements on decompression, and possibly in-place decompression support. It pays for that with a lower compression ratio (about 50% larger compressed size than LZMA, 10% larger than LZO for an ARM64 Linux kernel binary), but the boot time math still works in its favor for our IO speeds. This patch only adds the raw decompression functions for use by external payloads, we can later try integrating them in CBFS. It copies the decompression code itself unmodified from the upstream LZ4 library at github.com/Cyan4973/lz4 which will hopefully make it easy to update. The frame format parsing is reimplemented since the upstream version looks unnecessarily complex and unreadable for our needs. BRANCH=smaug BUG=chrome-os-partner:32184 TEST=With other patches, booted ARM64 kernel that got compressed from 15M to 5.1M and decompresses in 44ms. Change-Id: I65bdc4b2b19bd51c7b7e17a4e4b79da301a2a014 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Original-Commit-Id: f8a1fc996d5b0234d07f567fa8163d0f802d5144 Original-Change-Id: I15c0620da05561ade2552b15ffdf6bb3afd7eb26 Original-Signed-off-by: Julius Werner <jwerner(a)chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/282743 Original-Reviewed-by: Stefan Reinauer <reinauer(a)google.com> Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/10845 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/10845 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2015