coreboot-gerrit April 2015

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

Patch set updated for coreboot: 475c876 uart8250io: add '\r' before '\n'
by Patrick Georgi 28 Apr '15

28 Apr '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9932 -gerrit commit 475c8763c184290881a244e3a720f8ef31df5d81 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Tue Mar 31 20:32:41 2015 -0500 uart8250io: add '\r' before '\n' Make serial output prettier now. Change-Id: Ieeffd1a25e58dfbd498539ce0ef51ef746eab76f Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/drivers/uart/uart8250io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index 2cb586e..6e7174f 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -122,6 +122,8 @@ void uart_init(int idx) void uart_tx_byte(int idx, unsigned char data) { + if (data == '\n') + uart8250_tx_byte(uart_platform_base(idx), '\r'); uart8250_tx_byte(uart_platform_base(idx), data); }

1 0

Patch merged into coreboot/master: e2edf71 Makefile x86 SMM: Move smm_wrap recipes
by gerrit＠coreboot.org 28 Apr '15

28 Apr '15

the following patch was just integrated into master: commit e2edf71204ca8bab4ade1da0bef216efa72f69e4 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Fri Apr 10 11:52:53 2015 +0300 Makefile x86 SMM: Move smm_wrap recipes This is not used together with SMM_MODULES. Change-Id: I52621787cfa5a9e3863c150ce64f62aceb423eb4 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/10014 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/10014 for details. -gerrit

1 0

Patch merged into coreboot/master: 804c139 arm: guard verstage rules
by gerrit＠coreboot.org 28 Apr '15

28 Apr '15

the following patch was just integrated into master: commit 804c13982a2373222708ee7788066ee97bd52e3e Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 22 12:10:06 2015 -0500 arm: guard verstage rules Do not unconditially supply verstage rules for all platforms. Change-Id: Ic0713350aa21a9966fca828211750d25c2b6b71d Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/9969 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/9969 for details. -gerrit

1 0

Patch set updated for coreboot: 7a13ba3 arm: guard verstage rules
by Aaron Durbin 28 Apr '15

28 Apr '15

Aaron Durbin (adurbin(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9969 -gerrit commit 7a13ba3c21a96b390ca4d8dace4b89216eebffed Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 22 12:10:06 2015 -0500 arm: guard verstage rules Do not unconditially supply verstage rules for all platforms. Change-Id: Ic0713350aa21a9966fca828211750d25c2b6b71d Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/arch/arm/Makefile.inc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/arch/arm/Makefile.inc b/src/arch/arm/Makefile.inc index c6c38d5..272a495 100644 --- a/src/arch/arm/Makefile.inc +++ b/src/arch/arm/Makefile.inc @@ -73,6 +73,8 @@ endif # CONFIG_ARCH_BOOTBLOCK_ARM # verification stage ############################################################################### +ifeq ($(CONFIG_ARCH_VERSTAGE_ARM),y) + $(objcbfs)/verstage.debug: $(objgenerated)/libverstage.a $(obj)/mainboard/$(MAINBOARDDIR)/memlayout.verstage.ld @printf " LINK $(subst $(obj)/,,$(@))\n" $(LD_verstage) --gc-sections -static -o $@ -L$(obj) -T $(obj)/mainboard/$(MAINBOARDDIR)/memlayout.verstage.ld --start-group $(objgenerated)/libverstage.a --end-group @@ -84,6 +86,8 @@ verstage-y += memcpy.S verstage-y += memmove.S verstage-y += stages.c +endif # CONFIG_ARCH_VERSTAGE_ARM + ############################################################################### # romstage ###############################################################################

1 0

New patch to review for coreboot: 6ce8b2d board-status: Improve revision URL collection
by Patrick Georgi 28 Apr '15

28 Apr '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10016 -gerrit commit 6ce8b2daa5e54d018b96df1f072385ac6ab53d55 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Tue Apr 28 17:49:30 2015 +0200 board-status: Improve revision URL collection It now assumes that origin points to the official repo (while there may be more) and doesn't assume anymore that there's a user ID that needs to be pruned (although it is, if present). Change-Id: Id4c5ee2cb7c08e997eaba1c750097a2e2bf51af5 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/board_status/getrevision.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/board_status/getrevision.sh b/util/board_status/getrevision.sh index 0a6b6c6..9a949ff 100755 --- a/util/board_status/getrevision.sh +++ b/util/board_status/getrevision.sh @@ -52,8 +52,8 @@ is_file_tracked() { # Takes one optional argument: the path to inspect git_url() { # Note: This may not work as expected if multiple remotes are fetched from. - echo $(git remote -v | \ - awk '/fetch/ {split($2, pieces, "@"); print pieces[2]; exit 0}') + echo $(git remote -v | grep "^origin\>" | \ + awk '/fetch/ {print $2; exit 0}' | sed "s,^.*@,,") } # Returns a string indicating where others can get the current source code (excluding uncommitted changes)

1 0

Patch merged into coreboot/master: 6f5b18c vboot: remove vboot_helper.c
by gerrit＠coreboot.org 28 Apr '15

28 Apr '15

the following patch was just integrated into master: commit 6f5b18c03b9fb1803013b535dfc20132c3a27f95 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 22 10:50:34 2015 -0500 vboot: remove vboot_helper.c This file was moved previously to get it out of the way for easier merging from the chromium repo. It's not used currently so remove it. Change-Id: I8e691623f29ac2218b83bc46f5b4a348e0e1b3ef Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/9960 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/9960 for details. -gerrit

1 0

Patch merged into coreboot/master: be3e0a0 boards: remove VBOOT_(REFCODE|RAMSTAGE|ROMSTAGE)_INDEX
by gerrit＠coreboot.org 28 Apr '15

28 Apr '15

the following patch was just integrated into master: commit be3e0a04b5ec01ff71e9fab61a136b858dfdaf9c Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 22 10:48:01 2015 -0500 boards: remove VBOOT_(REFCODE|RAMSTAGE|ROMSTAGE)_INDEX These options will need to just be selected in within the .config files. There's not need in duplicating all these options. Change-Id: I7b670bc59a3b35e39eee4faecaf4aa779d47a3bb Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/9959 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/9959 for details. -gerrit

1 0

Patch merged into coreboot/master: 1124cec chromeos: remove VBOOT2_VERIFY_FIRMWARE option
by gerrit＠coreboot.org 28 Apr '15

28 Apr '15

the following patch was just integrated into master: commit 1124cec59a2c705a4ef3740dbdf0f68113602d31 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Apr 22 10:41:42 2015 -0500 chromeos: remove VBOOT2_VERIFY_FIRMWARE option There's no need to have the VBOOT2_VERIFY_FIRMWARE distinction because it's the only game in town. Change-Id: I82aab665934c27829e1a04115bf499ae527a91aa Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: http://review.coreboot.org/9958 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See http://review.coreboot.org/9958 for details. -gerrit

1 0

Patch set updated for coreboot: d2fcc0c cbfstool: compare pointer difference with ptrdiff_t value
by Patrick Georgi 28 Apr '15

28 Apr '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10015 -gerrit commit d2fcc0ca55d3db1cb76e98c0c35b40bb32b88b41 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Tue Apr 28 13:09:36 2015 +0200 cbfstool: compare pointer difference with ptrdiff_t value Fixes building cbfstool in 32bit environments. Change-Id: I3c94afc9c961eb8b41d1e08f4a16e5cab2a6bb8b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/cbfstool/cbfs_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index e61664c..2581bef 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -19,6 +19,7 @@ #include <inttypes.h> #include <libgen.h> +#include <stddef.h> #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -449,7 +450,7 @@ static int cbfs_add_entry_at(struct cbfs_image *image, content_offset, (int)((char*)CBFS_SUBHEADER(entry) - image->buffer.data)); assert((char*)CBFS_SUBHEADER(entry) - image->buffer.data == - content_offset); + (ptrdiff_t)content_offset); memcpy(CBFS_SUBHEADER(entry), data, size); if (verbose > 1) cbfs_print_entry_info(image, entry, stderr);

1 0

New patch to review for coreboot: d322d8c cbfstool: compare pointer difference with ptrdiff_t value
by Patrick Georgi 28 Apr '15

28 Apr '15

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10015 -gerrit commit d322d8ce3068cf1e74ec8edb41003d2ac2318018 Author: Patrick Georgi <pgeorgi(a)google.com> Date: Tue Apr 28 13:09:36 2015 +0200 cbfstool: compare pointer difference with ptrdiff_t value Change-Id: I3c94afc9c961eb8b41d1e08f4a16e5cab2a6bb8b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- util/cbfstool/cbfs_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index e61664c..2581bef 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -19,6 +19,7 @@ #include <inttypes.h> #include <libgen.h> +#include <stddef.h> #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -449,7 +450,7 @@ static int cbfs_add_entry_at(struct cbfs_image *image, content_offset, (int)((char*)CBFS_SUBHEADER(entry) - image->buffer.data)); assert((char*)CBFS_SUBHEADER(entry) - image->buffer.data == - content_offset); + (ptrdiff_t)content_offset); memcpy(CBFS_SUBHEADER(entry), data, size); if (verbose > 1) cbfs_print_entry_info(image, entry, stderr);

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
305
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2015