Marc Jones (marc.jones(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8046
-gerrit
commit f9268b23c63c60dd4e581d2622af31268b8e820d
Author: Duncan Laurie <dlaurie(a)chromium.org>
Date: Mon Jun 2 08:36:38 2014 -0700
samus: Enable DDI2 hotplug
Both DDI ports may be used on this board so it needs to be
able to detect a device on either port.
BUG=chrome-os-partner:28234
TEST=None (needs hardware)
Original-Change-Id: I5fc5ec3fe887fb51e7bdeae43c8297580e0ba6d6
Original-Signed-off-by: Duncan Laurie <dlaurie(a)chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/202358
Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org>
(cherry picked from commit 574bb6ac5d33c98f0214d6c738af24172164f4a1)
Signed-off-by: Marc Jones <marc.jones(a)se-eng.com>
Change-Id: I57613fcea10af0fecaf0f2ad6a83ca011c650099
---
src/mainboard/google/samus/devicetree.cb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mainboard/google/samus/devicetree.cb b/src/mainboard/google/samus/devicetree.cb
index 8810c47..ce13a1d 100644
--- a/src/mainboard/google/samus/devicetree.cb
+++ b/src/mainboard/google/samus/devicetree.cb
@@ -3,12 +3,12 @@ chip soc/intel/broadwell
# Enable eDP Hotplug with 6ms pulse
register "gpu_dp_d_hotplug" = "0x06"
- # Disable DDI2 Hotplug
- register "gpu_dp_c_hotplug" = "0x00"
-
# Enable DDI1 Hotplug with 6ms pulse
register "gpu_dp_b_hotplug" = "0x06"
+ # Enable DDI2 Hotplug with 6ms pulse
+ register "gpu_dp_c_hotplug" = "0x06"
+
# Set backlight PWM values for eDP
register "gpu_cpu_backlight" = "0x00000200"
register "gpu_pch_backlight" = "0x04000000"
Marc Jones (marc.jones(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8042
-gerrit
commit facd5fc99b0fea5594ce29417b58d138248b4429
Author: Todd Broch <tbroch(a)chromium.org>
Date: Fri Jun 6 17:03:49 2014 -0700
nyan: Ignore the recovery GPIO.
CrOS devices with Chromeos EC need only use hostevent to communicate
recovery assertion to the BIOS. This CL removes wired GPIO from
determining recovery as it appears under certain conditions (cold
reset) the internal PU on the AP isn't strong enough and therefore the
value is sometimes seen as asserted.
BRANCH=none
BUG=chrome-os-partner:29333
TEST=compiles & BIOS no longer responds to rec_mode GPIO during boot.
Original-Change-Id: Ib220cfa5f5bfe7193d555bfd32c0444b063d00f2
Original-Signed-off-by: Todd Broch <tbroch(a)chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/202996
Original-Reviewed-by: David Hendricks <dhendrix(a)chromium.org>
Original-Reviewed-by: Tom Warren <twarren(a)nvidia.com>
(cherry picked from commit d9927bcd67b0fb069fde231314e654d727092282)
Signed-off-by: Marc Jones <marc.jones(a)se-eng.com>
Change-Id: I6e086cbabc884f18deb2791a0f897e332b31032f
---
src/mainboard/google/nyan/chromeos.c | 4 ----
src/mainboard/google/nyan_big/chromeos.c | 4 ----
src/mainboard/google/nyan_blaze/chromeos.c | 4 ----
3 files changed, 12 deletions(-)
diff --git a/src/mainboard/google/nyan/chromeos.c b/src/mainboard/google/nyan/chromeos.c
index 6377fb2..c4d98b7 100644
--- a/src/mainboard/google/nyan/chromeos.c
+++ b/src/mainboard/google/nyan/chromeos.c
@@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
{
uint32_t ec_events;
- /* The GPIO is active low. */
- if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
- return 1;
-
ec_events = google_chromeec_get_events_b();
return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
diff --git a/src/mainboard/google/nyan_big/chromeos.c b/src/mainboard/google/nyan_big/chromeos.c
index 298fd6a..054abf6 100644
--- a/src/mainboard/google/nyan_big/chromeos.c
+++ b/src/mainboard/google/nyan_big/chromeos.c
@@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
{
uint32_t ec_events;
- /* The GPIO is active low. */
- if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
- return 1;
-
ec_events = google_chromeec_get_events_b();
return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
diff --git a/src/mainboard/google/nyan_blaze/chromeos.c b/src/mainboard/google/nyan_blaze/chromeos.c
index 16f0c98..da017ea 100644
--- a/src/mainboard/google/nyan_blaze/chromeos.c
+++ b/src/mainboard/google/nyan_blaze/chromeos.c
@@ -88,10 +88,6 @@ int get_recovery_mode_switch(void)
{
uint32_t ec_events;
- /* The GPIO is active low. */
- if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
- return 1;
-
ec_events = google_chromeec_get_events_b();
return !!(ec_events &
EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));