the following patch was just integrated into master:
commit 34e76152351a9c846d850064990a37e3d453d97f
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Sep 5 23:54:04 2014 +0200
romcc: avoid use-after-free
Windows bugchecks on this for a while, so we ifndef'd the free() call out.
Now some Linuxes (depending on their glibc) also fail on it, so just
remove the call altogether at the cost of some leaked memory (couple
hundred kilobytes) because tracking down the precise fix is too hard.
In case someone wants to fix it, valgrind sees the issues, so
revert this change and work on romcc's memory management until valgrind
is happy.
To get a fix in, provide a good explanation why your change is actually
the right way to fix it - for silencing valgrind, this change will do.
Change-Id: Iae3f847e09a0d7bcb8bb4f50983a1b0727570b23
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-on: http://review.coreboot.org/6846
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/6846 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6846
-gerrit
commit 2ed4a87c71c6749887c3f9111c434b38652e5182
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Fri Sep 5 23:54:04 2014 +0200
romcc: avoid use-after-free
Windows bugchecks on this for a while, so we ifndef'd the free() call out.
Now some Linuxes (depending on their glibc) also fail on it, so just
remove the call altogether at the cost of some leaked memory (couple
hundred kilobytes) because tracking down the precise fix is too hard.
In case someone wants to fix it, valgrind sees the issues, so
revert this change and work on romcc's memory management until valgrind
is happy.
To get a fix in, provide a good explanation why your change is actually
the right way to fix it - for silencing valgrind, this change will do.
Change-Id: Iae3f847e09a0d7bcb8bb4f50983a1b0727570b23
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/romcc/romcc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index 01d836c..ad90a1e 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -15161,9 +15161,6 @@ static void free_basic_block(struct compile_state *state, struct block *block)
}
}
memset(block, -1, sizeof(*block));
-#ifndef WIN32
- xfree(block);
-#endif
}
static void free_basic_blocks(struct compile_state *state,
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6845
-gerrit
commit 0f3bb9bd7bb8e86b3c965d04facc9e51b18997ae
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Fri Sep 5 23:53:39 2014 +0200
roda/rk886ex: Move dummy DCC ON# to finalize stage
During Vladimir's ACPI cleanups, this was moved into the mainboard's
enable stage, which will prevent the VGA option rom from executing
correctly. Move it to the finalize stage to make sure it runs after
all initialize functions have been called.
Change-Id: I0fcca4d4a95f89382f377ce923f82ecb71467fd8
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
src/mainboard/roda/rk886ex/mainboard.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/mainboard/roda/rk886ex/mainboard.c b/src/mainboard/roda/rk886ex/mainboard.c
index ba7ed23..4c7fffa 100644
--- a/src/mainboard/roda/rk886ex/mainboard.c
+++ b/src/mainboard/roda/rk886ex/mainboard.c
@@ -63,6 +63,13 @@ static void dump_runtime_registers(void)
}
#endif
+static void mainboard_final(device_t dev)
+{
+ /* Enable Dummy DCC ON# for DVI */
+ printk(BIOS_DEBUG, "Laptop handling...\n");
+ outb(inb(0x60f) & ~(1 << 5), 0x60f);
+}
+
static void mainboard_enable(device_t dev)
{
/* Configure the MultiKey controller */
@@ -81,9 +88,8 @@ static void mainboard_enable(device_t dev)
#if DUMP_RUNTIME_REGISTERS
dump_runtime_registers();
#endif
- /* Enable Dummy DCC ON# for DVI */
- printk(BIOS_DEBUG, "Laptop handling...\n");
- outb(inb(0x60f) & ~(1 << 5), 0x60f);
+
+ dev->ops->final = mainboard_final;
}
struct chip_operations mainboard_ops = {
the following patch was just integrated into master:
commit 2d7bd8a6ebf6844b0cdef80eaaef69f39d08f076
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat Aug 30 19:28:05 2014 +0200
Implement ACPI in a per device way
This approach avoids having same basic tables 150-lines mantra over 100 times
in codebase.
Change-Id: I76fb2fbcb9ca0654f2e5fd5d90bd62392165777c
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/6801
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-by: Aaron Durbin <adurbin(a)google.com>
See http://review.coreboot.org/6801 for details.
-gerrit
the following patch was just integrated into master:
commit a2a906e47a87acc3acdca0ee2790ff96409b9b46
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Mon Sep 1 01:41:37 2014 +0200
Consolidate intel vga int15 hooks
Change-Id: I9366dded98bf15f6da44ce893dd10698ba09fd55
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/6820
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
See http://review.coreboot.org/6820 for details.
-gerrit
the following patch was just integrated into master:
commit a4857052f756507e18a54beba704f183f128a057
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sun Aug 31 01:09:12 2014 +0200
i82801gx: Kill unused TCG and SMI1
SMI1 is being written to but never read from.
Change-Id: I82c0800713e3093eb1317b5e1f6f228771134857
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/6808
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See http://review.coreboot.org/6808 for details.
-gerrit
the following patch was just integrated into master:
commit c403e42f21bc77af6db3a4222e796c102ac7e6d0
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Thu Sep 4 18:32:52 2014 +0200
what-jenkins-does: kill build results early
This reduces disk use and simplifies using abuild on
a ramdisk.
Change-Id: I3fb8d273dcbb5008fa9cfaa9465a59e3bbcb974b
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
Reviewed-on: http://review.coreboot.org/6835
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See http://review.coreboot.org/6835 for details.
-gerrit