coreboot-gerrit May 2014

coreboot-gerrit@coreboot.org

1 participants
1066 discussions

Patch set updated for coreboot: e619a62 payloads/coreinfo/README: Use `It is` instead of `Its`
by Paul Menzel 08 May '14

08 May '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5704 -gerrit commit e619a62a6de07c279d8197475de287648e20ac64 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu May 8 23:30:12 2014 +0200 payloads/coreinfo/README: Use `It is` instead of `Its` Change-Id: Ic1a9f2f01c26ee97cd7183fcf1755cb916f1b02e Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- payloads/coreinfo/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/coreinfo/README b/payloads/coreinfo/README index 4df5359..0c41452 100644 --- a/payloads/coreinfo/README +++ b/payloads/coreinfo/README @@ -1,5 +1,5 @@ This is a silly little program that demonstrates how cool libpayload is -and also serves a purpose. Its fun and educational! +and also serves a purpose. It is fun and educational! Requirements ------------

1 0

New patch to review for coreboot: ea95387 README: Use `It is` instead of `Its`
by Paul Menzel 08 May '14

08 May '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5704 -gerrit commit ea95387f3c55f2f08ae9eec4981f32e6eaf8121f Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Thu May 8 23:30:12 2014 +0200 README: Use `It is` instead of `Its` Change-Id: Ic1a9f2f01c26ee97cd7183fcf1755cb916f1b02e Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- payloads/coreinfo/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/coreinfo/README b/payloads/coreinfo/README index 4df5359..0c41452 100644 --- a/payloads/coreinfo/README +++ b/payloads/coreinfo/README @@ -1,5 +1,5 @@ This is a silly little program that demonstrates how cool libpayload is -and also serves a purpose. Its fun and educational! +and also serves a purpose. It is fun and educational! Requirements ------------

1 0

Patch set updated for coreboot: b0f9c8c superio/ite/it8661f: Make early_serial into romstage sym
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5508 -gerrit commit b0f9c8c50eaeca226e403b52cb382c53635bc739 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Apr 15 20:30:49 2014 +1000 superio/ite/it8661f: Make early_serial into romstage sym Following similar reasoning as commit: d304331 superio/fintek/f81865f: Avoid .c includes Avoid any mistaken future inclusion of early_serial.c in mainboard.c code by providing symbols in romstage. Change-Id: I9e763a7ad9de090e35acdcf4d6a280d8227c6015 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/ite/it8661f/Makefile.inc | 2 +- src/superio/ite/it8661f/early_serial.c | 3 ++- src/superio/ite/it8661f/it8661f.h | 8 +++++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/superio/ite/it8661f/Makefile.inc b/src/superio/ite/it8661f/Makefile.inc index f6f30db..af4e878 100644 --- a/src/superio/ite/it8661f/Makefile.inc +++ b/src/superio/ite/it8661f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_ITE_IT8661F) += early_serial.c ramstage-$(CONFIG_SUPERIO_ITE_IT8661F) += superio.c - diff --git a/src/superio/ite/it8661f/early_serial.c b/src/superio/ite/it8661f/early_serial.c index ee132fa..7373f71 100644 --- a/src/superio/ite/it8661f/early_serial.c +++ b/src/superio/ite/it8661f/early_serial.c @@ -19,6 +19,7 @@ */ #include <arch/io.h> +#include <device/pnp.h> #include "it8661f.h" /* Perform MB PnP setup to put the SIO chip at 0x3f0. */ @@ -68,7 +69,7 @@ static void it8661f_set_clkin(device_t dev, u8 clkin) pnp_exit_ext_func_mode(dev); } -static void it8661f_enable_serial(device_t dev, u16 iobase) +void it8661f_enable_serial(device_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/ite/it8661f/it8661f.h b/src/superio/ite/it8661f/it8661f.h index 5a51f02..045a54c 100644 --- a/src/superio/ite/it8661f/it8661f.h +++ b/src/superio/ite/it8661f/it8661f.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_ITE_IT8661F_IT8661F_H -#define SUPERIO_ITE_IT8661F_IT8661F_H +#ifndef SUPERIO_ITE_IT8661F_H +#define SUPERIO_ITE_IT8661F_H /* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8661_2.asp */ @@ -52,4 +52,6 @@ static const u8 init_values[] = { 0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39, }; -#endif +void it8661f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_ITE_IT8661F_H */

1 0

Patch set updated for coreboot: 67f8722 mainboard/advantech/pcm-5820: Convert uart to generic winbond
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5703 -gerrit commit 67f87221426ce3086a3c1c524ba18b1b10107339 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri May 9 05:07:17 2014 +1000 mainboard/advantech/pcm-5820: Convert uart to generic winbond Take advantage of generic winbond early_serial init driver link-time symbols instead of #including model specific .c implementation. Change-Id: I2fe7ecb11e10262d11c68017a00843f99a35b734 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/advantech/pcm-5820/romstage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mainboard/advantech/pcm-5820/romstage.c b/src/mainboard/advantech/pcm-5820/romstage.c index b710aad..6865f1a 100644 --- a/src/mainboard/advantech/pcm-5820/romstage.c +++ b/src/mainboard/advantech/pcm-5820/romstage.c @@ -25,14 +25,15 @@ #include <console/console.h> #include "northbridge/amd/gx1/raminit.c" #include "cpu/x86/bist.h" -#include "superio/winbond/w83977f/early_serial.c" +#include <superio/winbond/common/winbond.h> +#include <superio/winbond/w83977f/w83977f.h> #include "southbridge/amd/cs5530/enable_rom.c" #define SERIAL_DEV PNP_DEV(0x3f0, W83977F_SP1) static void main(unsigned long bist) { - w83977f_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); + winbond_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); console_init(); report_bist_failure(bist); cs5530_enable_rom();

1 0

Patch set updated for coreboot: 0e8742d superio/winbond/w83977f: Avoid .c includes
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5447 -gerrit commit 0e8742ddcebde01386f7bc137440f84bde401dc1 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Apr 3 03:29:22 2014 +1100 superio/winbond/w83977f: Avoid .c includes Following the same reasoning as commit d304331 superio/fintek/f81865f: Avoid .c includes Change-Id: I97f14306b2c269b99d60327a6f9869de6a7d7cc3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/winbond/w83977f/Makefile.inc | 2 +- src/superio/winbond/w83977f/early_serial.c | 2 +- src/superio/winbond/w83977f/w83977f.h | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/superio/winbond/w83977f/Makefile.inc b/src/superio/winbond/w83977f/Makefile.inc index e52c09d..60edac9 100644 --- a/src/superio/winbond/w83977f/Makefile.inc +++ b/src/superio/winbond/w83977f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += early_serial.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += superio.c - diff --git a/src/superio/winbond/w83977f/early_serial.c b/src/superio/winbond/w83977f/early_serial.c index c572dcb..7e3a6f8 100644 --- a/src/superio/winbond/w83977f/early_serial.c +++ b/src/superio/winbond/w83977f/early_serial.c @@ -34,7 +34,7 @@ static void pnp_exit_ext_func_mode(device_t dev) outb(0xaa, port); } -static void w83977f_enable_serial(device_t dev, u16 iobase) +void w83977f_enable_serial(device_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/winbond/w83977f/w83977f.h b/src/superio/winbond/w83977f/w83977f.h index f2b68ed..8d38463 100644 --- a/src/superio/winbond/w83977f/w83977f.h +++ b/src/superio/winbond/w83977f/w83977f.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_WINBOND_W83977F_W83977F_H -#define SUPERIO_WINBOND_W83977F_W83977F_H +#ifndef SUPERIO_WINBOND_W83977F_H +#define SUPERIO_WINBOND_W83977F_H #define W83977F_FDC 0 /* Floppy */ #define W83977F_PP 1 /* Parallel port */ @@ -31,4 +31,6 @@ #define W83977F_GPIO1 7 /* General Purpose I/O 1 */ #define W83977F_GPIO2 8 /* General Purpose I/O 2 */ -#endif +void w83977f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_WINBOND_W83977F_H */

1 0

Patch set updated for coreboot: 122b7e7 superio/winbond/w83977f: Avoid .c includes
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5447 -gerrit commit 122b7e7bf6a54bf0c5507b7274e05f29336a286b Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Apr 3 03:29:22 2014 +1100 superio/winbond/w83977f: Avoid .c includes Following the same reasoning as commit d304331 superio/fintek/f81865f: Avoid .c includes Change-Id: I97f14306b2c269b99d60327a6f9869de6a7d7cc3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/winbond/w83977f/Makefile.inc | 2 +- src/superio/winbond/w83977f/early_serial.c | 3 ++- src/superio/winbond/w83977f/w83977f.h | 8 +++++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/superio/winbond/w83977f/Makefile.inc b/src/superio/winbond/w83977f/Makefile.inc index e52c09d..60edac9 100644 --- a/src/superio/winbond/w83977f/Makefile.inc +++ b/src/superio/winbond/w83977f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += early_serial.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += superio.c - diff --git a/src/superio/winbond/w83977f/early_serial.c b/src/superio/winbond/w83977f/early_serial.c index c572dcb..c412449 100644 --- a/src/superio/winbond/w83977f/early_serial.c +++ b/src/superio/winbond/w83977f/early_serial.c @@ -19,6 +19,7 @@ */ #include <arch/io.h> +#include <device/pnp.h> #include "w83977f.h" static void pnp_enter_ext_func_mode(device_t dev) @@ -34,7 +35,7 @@ static void pnp_exit_ext_func_mode(device_t dev) outb(0xaa, port); } -static void w83977f_enable_serial(device_t dev, u16 iobase) +void w83977f_enable_serial(device_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/winbond/w83977f/w83977f.h b/src/superio/winbond/w83977f/w83977f.h index f2b68ed..8d38463 100644 --- a/src/superio/winbond/w83977f/w83977f.h +++ b/src/superio/winbond/w83977f/w83977f.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_WINBOND_W83977F_W83977F_H -#define SUPERIO_WINBOND_W83977F_W83977F_H +#ifndef SUPERIO_WINBOND_W83977F_H +#define SUPERIO_WINBOND_W83977F_H #define W83977F_FDC 0 /* Floppy */ #define W83977F_PP 1 /* Parallel port */ @@ -31,4 +31,6 @@ #define W83977F_GPIO1 7 /* General Purpose I/O 1 */ #define W83977F_GPIO2 8 /* General Purpose I/O 2 */ -#endif +void w83977f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_WINBOND_W83977F_H */

1 0

New patch to review for coreboot: eb39845 mainboard/advantech/pcm-5820: Convert uart init to generic winbond
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5703 -gerrit commit eb398454becb1af79af4c3306ee32f450df246aa Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri May 9 05:07:17 2014 +1000 mainboard/advantech/pcm-5820: Convert uart init to generic winbond Take advantage of generic winbond early_serial init driver link-time symbols instead of #including model specific .c implementation. Change-Id: I2fe7ecb11e10262d11c68017a00843f99a35b734 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/advantech/pcm-5820/romstage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mainboard/advantech/pcm-5820/romstage.c b/src/mainboard/advantech/pcm-5820/romstage.c index b710aad..6865f1a 100644 --- a/src/mainboard/advantech/pcm-5820/romstage.c +++ b/src/mainboard/advantech/pcm-5820/romstage.c @@ -25,14 +25,15 @@ #include <console/console.h> #include "northbridge/amd/gx1/raminit.c" #include "cpu/x86/bist.h" -#include "superio/winbond/w83977f/early_serial.c" +#include <superio/winbond/common/winbond.h> +#include <superio/winbond/w83977f/w83977f.h> #include "southbridge/amd/cs5530/enable_rom.c" #define SERIAL_DEV PNP_DEV(0x3f0, W83977F_SP1) static void main(unsigned long bist) { - w83977f_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); + winbond_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); console_init(); report_bist_failure(bist); cs5530_enable_rom();

1 0

Patch set updated for coreboot: b8a71e8 superio/winbond/w83977f: Avoid .c includes
by Edward O'Callaghan 08 May '14

08 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5447 -gerrit commit b8a71e875dc5228390ebe94b0ceea05d9bfd83d6 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Apr 3 03:29:22 2014 +1100 superio/winbond/w83977f: Avoid .c includes Following the same reasoning as commit d304331 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: I97f14306b2c269b99d60327a6f9869de6a7d7cc3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/advantech/pcm-5820/romstage.c | 2 +- src/superio/winbond/w83977f/Makefile.inc | 2 +- src/superio/winbond/w83977f/early_serial.c | 3 ++- src/superio/winbond/w83977f/w83977f.h | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/advantech/pcm-5820/romstage.c b/src/mainboard/advantech/pcm-5820/romstage.c index b710aad..1262300 100644 --- a/src/mainboard/advantech/pcm-5820/romstage.c +++ b/src/mainboard/advantech/pcm-5820/romstage.c @@ -25,7 +25,7 @@ #include <console/console.h> #include "northbridge/amd/gx1/raminit.c" #include "cpu/x86/bist.h" -#include "superio/winbond/w83977f/early_serial.c" +#include <superio/winbond/w83977f/w83977f.h> #include "southbridge/amd/cs5530/enable_rom.c" #define SERIAL_DEV PNP_DEV(0x3f0, W83977F_SP1) diff --git a/src/superio/winbond/w83977f/Makefile.inc b/src/superio/winbond/w83977f/Makefile.inc index e52c09d..60edac9 100644 --- a/src/superio/winbond/w83977f/Makefile.inc +++ b/src/superio/winbond/w83977f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += early_serial.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83977F) += superio.c - diff --git a/src/superio/winbond/w83977f/early_serial.c b/src/superio/winbond/w83977f/early_serial.c index c572dcb..c412449 100644 --- a/src/superio/winbond/w83977f/early_serial.c +++ b/src/superio/winbond/w83977f/early_serial.c @@ -19,6 +19,7 @@ */ #include <arch/io.h> +#include <device/pnp.h> #include "w83977f.h" static void pnp_enter_ext_func_mode(device_t dev) @@ -34,7 +35,7 @@ static void pnp_exit_ext_func_mode(device_t dev) outb(0xaa, port); } -static void w83977f_enable_serial(device_t dev, u16 iobase) +void w83977f_enable_serial(device_t dev, u16 iobase) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); diff --git a/src/superio/winbond/w83977f/w83977f.h b/src/superio/winbond/w83977f/w83977f.h index f2b68ed..44c6a4a 100644 --- a/src/superio/winbond/w83977f/w83977f.h +++ b/src/superio/winbond/w83977f/w83977f.h @@ -31,4 +31,6 @@ #define W83977F_GPIO1 7 /* General Purpose I/O 1 */ #define W83977F_GPIO2 8 /* General Purpose I/O 2 */ -#endif +void w83977f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_WINBOND_W83977F_W83977F_H */

1 0

New patch to review for coreboot: 6974d63 cbfstool: account for the trampoline code in bzImage payload
by Aaron Durbin 08 May '14

08 May '14

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5702 -gerrit commit 6974d6308f59fbcf6712159a55713f68f76f1f43 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu May 8 11:54:25 2014 -0500 cbfstool: account for the trampoline code in bzImage payload For bzImages the trampoline segment is added unconditionally. However, that segment wasn't properly being accounted for. Explicitly add the trampoline segments like the other ones. Change-Id: I74f6fcc2a65615bb87578a8a3a76cecf858fe856 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- util/cbfstool/cbfs-payload-linux.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/cbfs-payload-linux.c b/util/cbfstool/cbfs-payload-linux.c index 12fa238..33a5e1a 100644 --- a/util/cbfstool/cbfs-payload-linux.c +++ b/util/cbfstool/cbfs-payload-linux.c @@ -67,8 +67,6 @@ static int bzp_init(struct bzpayload *bzp, comp_algo algo) */ bzp->num_segments = 1; - buffer_init(&bzp->trampoline, NULL, trampoline_start, trampoline_size); - bzp->algo = algo; bzp->compress = compression_function(algo); if (bzp->compress == NULL) { @@ -101,6 +99,12 @@ static void bzp_add_segment(struct bzpayload *bzp, struct buffer *b, void *data, bzp->num_segments++; } +static int bzp_add_trampoline(struct bzpayload *bzp) +{ + bzp_add_segment(bzp, &bzp->trampoline, trampoline_start, + trampoline_size); + return 0; +} static int bzp_add_cmdline(struct bzpayload *bzp, char *cmdline) { @@ -209,6 +213,9 @@ int parse_bzImage_to_payload(const struct buffer *input, if (bzp_init(&bzp, algo) != 0) return -1; + if (bzp_add_trampoline(&bzp) != 0) + return -1; + if (bzp_add_initrd(&bzp, initrd_name) != 0) return -1;

1 0

New patch to review for coreboot: 7cf4de0 toolchain: get rid of some bashisms
by Aaron Durbin 08 May '14

08 May '14

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5701 -gerrit commit 7cf4de0750047ccd45be9b66e4e7b118d4f8e58a Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu May 8 11:14:41 2014 -0500 toolchain: get rid of some bashisms On Ubuntu /bin/sh is symlinked to /bin/dash. The current toolchain.inc was doing some things that dash doesn't support. Make the shell callouts more conforming to the POSIX sh standard. Change-Id: I26b6b82b8d6158c9029e8be9e7c088ca9e207f21 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- toolchain.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index 649d203..576e744 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -66,14 +66,14 @@ STRIP_$(1) := $(STRIP_$(2)) READELF_$(1) := $(READELF_$(2)) INCLUDES_$(1) = -Isrc/arch/$(ARCHDIR-$(2))/include CFLAGS_$(1) = $$(CFLAGS_common) $$(INCLUDES_$(1)) $(CFLAGS_$(2)) -LIBGCC_FILE_NAME_$(1) = $(shell test -r `$(CC_$(2)) -print-libgcc-file-name` && \ +LIBGCC_FILE_NAME_$(1) = $(shell [ -r `$(CC_$(2)) -print-libgcc-file-name` ] && \ $(CC_$(2)) -print-libgcc-file-name) endef # initialize standard toolchain (CC,AS and others) for give stage # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ - $(eval stage_caps := $(shell tr '[:lower:]' '[:upper:]' <<< $(1))) \ + $(eval stage_caps := $(shell printf "%s" $(1) | tr '[:lower:]' '[:upper:]' )) \ $(eval $(call set_stage_toolchain,$(stage_caps))) \ $(eval $(call create_class_compiler,$(1),$(ARCH-$(stage_caps)-y))) \ $(eval $(call set_stage_libgcc,$(1)))

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2014