coreboot-gerrit February 2014

coreboot-gerrit@coreboot.org

1 participants
1135 discussions

Patch merged into coreboot/master: 05e7498 lib/edid: Don't set vbe_valid in decode_edid.
by gerrit＠coreboot.org 21 Feb '14

21 Feb '14

the following patch was just integrated into master: commit 05e7498dcca3a17c2541d2a32b8fbcbd2c78feda Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Wed Feb 19 22:12:02 2014 +0100 lib/edid: Don't set vbe_valid in decode_edid. Decoding EDID doesn't yet mean that gfx mode is used. Change-Id: Icedd36f26877754f34dd59233cce72271d7f0b19 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> See http://review.coreboot.org/5269 for details. -gerrit

1 0

Patch set updated for coreboot: 02de292 libpayload: hexdump: Use `p` as conversion specifier for a pointer
by Paul Menzel 21 Feb '14

21 Feb '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767 -gerrit commit 02de292f85f37e84a42948562f6e0ee271fb18f5 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Tue Jan 21 12:08:18 2014 +0100 libpayload: hexdump: Use `p` as conversion specifier for a pointer Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- payloads/libpayload/libc/hexdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c index e4aa8b9..814adf2 100644 --- a/payloads/libpayload/libc/hexdump.c +++ b/payloads/libpayload/libc/hexdump.c @@ -49,7 +49,7 @@ void hexdump(void *memory, int length) } if (all_zero < 2) { - printf("%08lx:", memory + i); + printf("%8p:", memory + i); for (j = 0; j < 16; j++) printf(" %02x", m[i + j]); printf(" ");

1 0

New patch to review for coreboot: 2991e4c vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility.
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5277 -gerrit commit 2991e4ce575906e8e9a9bc1fc9109887240b8a27 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri Feb 21 12:43:07 2014 +1100 vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility. A comparison with a two's complement in gcccar.inc has dubious GAS/AT&T notation. Clang miss-parses 0x-1 as a invalid hexadecimal number. Change-Id: I88baa5c2513f062ff309df05916a3832b9bd9bb1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f10/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f12/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f14/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15tn/gcccar.inc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vendorcode/amd/agesa/f10/gcccar.inc b/src/vendorcode/amd/agesa/f10/gcccar.inc index 61a8d3e..aa3c01f 100644 --- a/src/vendorcode/amd/agesa/f10/gcccar.inc +++ b/src/vendorcode/amd/agesa/f10/gcccar.inc @@ -827,7 +827,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f12/gcccar.inc b/src/vendorcode/amd/agesa/f12/gcccar.inc index d7da81d..212b6b0 100644 --- a/src/vendorcode/amd/agesa/f12/gcccar.inc +++ b/src/vendorcode/amd/agesa/f12/gcccar.inc @@ -821,7 +821,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f14/gcccar.inc b/src/vendorcode/amd/agesa/f14/gcccar.inc index 7037344..1fc9f22 100644 --- a/src/vendorcode/amd/agesa/f14/gcccar.inc +++ b/src/vendorcode/amd/agesa/f14/gcccar.inc @@ -835,7 +835,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15/gcccar.inc b/src/vendorcode/amd/agesa/f15/gcccar.inc index b20c77e..6891ddc 100644 --- a/src/vendorcode/amd/agesa/f15/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15/gcccar.inc @@ -842,7 +842,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15tn/gcccar.inc b/src/vendorcode/amd/agesa/f15tn/gcccar.inc index c76ad16..dd76561 100644 --- a/src/vendorcode/amd/agesa/f15tn/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15tn/gcccar.inc @@ -875,7 +875,7 @@ fam14_disable_stack_hook_exit: LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL

1 0

Patch set updated for coreboot: 2b74aa4 libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument
by Paul Menzel 21 Feb '14

21 Feb '14

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767 -gerrit commit 2b74aa4e3ae22a50fca1d02826f777283d4610e2 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Tue Jan 21 12:08:18 2014 +0100 libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- payloads/libpayload/libc/hexdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c index e4aa8b9..814adf2 100644 --- a/payloads/libpayload/libc/hexdump.c +++ b/payloads/libpayload/libc/hexdump.c @@ -49,7 +49,7 @@ void hexdump(void *memory, int length) } if (all_zero < 2) { - printf("%08lx:", memory + i); + printf("%8p:", memory + i); for (j = 0; j < 16; j++) printf(" %02x", m[i + j]); printf(" ");

1 0

Patch set updated for coreboot: 8591723 CAR_GLOBAL: don't use static, but hide variables instead
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4718 -gerrit commit 8591723c7a60c97898c78e05b127571ff91a4e55 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 20:29:26 2014 +1100 CAR_GLOBAL: don't use static, but hide variables instead attribute(section) isn't to be used on local variables and clang enforces that. Change-Id: Ie0d40946cd087e40f60f9d04e2eda56df75f26da Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/include/arch/early_variables.h | 4 ++-- src/cpu/x86/car.c | 2 +- src/cpu/x86/lapic/apic_timer.c | 2 +- src/drivers/emulation/qemu/qemu_debugcon.c | 2 +- src/drivers/pc80/tpm.c | 2 +- src/drivers/usb/ehci_debug.c | 2 +- src/lib/cbmem_console.c | 4 ++-- src/lib/timestamp.c | 6 +++--- src/vendorcode/google/chromeos/vbnv.c | 4 ++-- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h index ea1a133..34f89df 100644 --- a/src/arch/x86/include/arch/early_variables.h +++ b/src/arch/x86/include/arch/early_variables.h @@ -25,8 +25,8 @@ asm(".section .car.global_data,\"w\",@nobits"); asm(".previous"); asm(".section .car.cbmem_console,\"w\",@nobits"); asm(".previous"); -#define CAR_GLOBAL __attribute__((section(".car.global_data"))) -#define CAR_CBMEM __attribute__((section(".car.cbmem_console"))) +#define CAR_GLOBAL __attribute__((section(".car.global_data"))) __attribute__((visibility ("hidden"))) +#define CAR_CBMEM __attribute__((section(".car.cbmem_console"))) __attribute__((visibility ("hidden"))) #else #define CAR_GLOBAL #define CAR_CBMEM diff --git a/src/cpu/x86/car.c b/src/cpu/x86/car.c index a7e3842..35e4704 100644 --- a/src/cpu/x86/car.c +++ b/src/cpu/x86/car.c @@ -39,7 +39,7 @@ extern char _car_data_end[]; * Based on these 2 attributes there is the ability to tell when the * cache-as-ram region has been migrated. */ -static int car_migrated CAR_GLOBAL; +int car_migrated CAR_GLOBAL; void *car_get_var_ptr(void *var) diff --git a/src/cpu/x86/lapic/apic_timer.c b/src/cpu/x86/lapic/apic_timer.c index 868fb92..5308567 100644 --- a/src/cpu/x86/lapic/apic_timer.c +++ b/src/cpu/x86/lapic/apic_timer.c @@ -41,7 +41,7 @@ static int set_timer_fsb(void) return 0; } #else -static u32 timer_fsb CAR_GLOBAL = 0; +u32 timer_fsb CAR_GLOBAL = 0; static int set_timer_fsb(void) { diff --git a/src/drivers/emulation/qemu/qemu_debugcon.c b/src/drivers/emulation/qemu/qemu_debugcon.c index 9c00585..a7def46 100644 --- a/src/drivers/emulation/qemu/qemu_debugcon.c +++ b/src/drivers/emulation/qemu/qemu_debugcon.c @@ -23,7 +23,7 @@ #include <arch/io.h> #include <arch/early_variables.h> -static int qemu_debugcon_detected CAR_GLOBAL; +int qemu_debugcon_detected CAR_GLOBAL; void qemu_debugcon_init(void) { diff --git a/src/drivers/pc80/tpm.c b/src/drivers/pc80/tpm.c index f581ab4..1955c2c 100644 --- a/src/drivers/pc80/tpm.c +++ b/src/drivers/pc80/tpm.c @@ -156,7 +156,7 @@ static const struct vendor_name vendor_names[] = { * Cached vendor/device ID pair to indicate that the device has been already * discovered */ -static u32 vendor_dev_id CAR_GLOBAL; +u32 vendor_dev_id CAR_GLOBAL; static inline u8 tpm_read_status(int locality) { diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index c60fbaa..e2f8b83 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -95,7 +95,7 @@ static int dbgp_enabled(void); #define DBGP_MICROFRAME_RETRIES 10 #define DBGP_MAX_PACKET 8 -static struct ehci_debug_info glob_dbg_info CAR_GLOBAL; +struct ehci_debug_info glob_dbg_info CAR_GLOBAL; static inline struct ehci_debug_info *dbgp_ehci_info(void) { diff --git a/src/lib/cbmem_console.c b/src/lib/cbmem_console.c index 83d44e3..e517fd7 100644 --- a/src/lib/cbmem_console.c +++ b/src/lib/cbmem_console.c @@ -34,7 +34,7 @@ struct cbmem_console { u8 buffer_body[0]; } __attribute__ ((__packed__)); -static struct cbmem_console *cbmem_console_p CAR_GLOBAL; +struct cbmem_console *cbmem_console_p CAR_GLOBAL; #ifdef __PRE_RAM__ /* @@ -43,7 +43,7 @@ static struct cbmem_console *cbmem_console_p CAR_GLOBAL; * the area are defined in the config. */ -static struct cbmem_console car_cbmem_console CAR_CBMEM; +struct cbmem_console car_cbmem_console CAR_CBMEM; #else diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index f0ee48d..477d5fe 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -27,8 +27,8 @@ #define MAX_TIMESTAMPS 30 -static struct timestamp_table* ts_table_p CAR_GLOBAL = NULL; -static tsc_t ts_basetime CAR_GLOBAL = { .lo = 0, .hi =0 }; +struct timestamp_table* ts_table_p CAR_GLOBAL = NULL; +tsc_t ts_basetime CAR_GLOBAL = { .lo = 0, .hi =0 }; static void timestamp_stash(enum timestamp_id id, tsc_t ts_time); @@ -89,7 +89,7 @@ struct timestamp_cache { tsc_t time; } timestamp_cache[MAX_TIMESTAMP_CACHE] CAR_GLOBAL; -static int timestamp_entries CAR_GLOBAL = 0; +int timestamp_entries CAR_GLOBAL = 0; /** * timestamp_stash() allows to temporarily cache timestamps. diff --git a/src/vendorcode/google/chromeos/vbnv.c b/src/vendorcode/google/chromeos/vbnv.c index a13726d..8f04f1e 100644 --- a/src/vendorcode/google/chromeos/vbnv.c +++ b/src/vendorcode/google/chromeos/vbnv.c @@ -52,8 +52,8 @@ #define KERNEL_FIELD_OFFSET 11 #define CRC_OFFSET 15 -static int vbnv_initialized CAR_GLOBAL; -static uint8_t vbnv[CONFIG_VBNV_SIZE] CAR_GLOBAL; +int vbnv_initialized CAR_GLOBAL; +uint8_t vbnv[CONFIG_VBNV_SIZE] CAR_GLOBAL; /* Wrappers for accessing the variables marked as CAR_GLOBAL. */ static inline int is_vbnv_initialized(void)

1 0

Patch set updated for coreboot: f92c773 CAR_GLOBAL: enforce compiler to check if _start != _end
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4719 -gerrit commit f92c7736b2e3c715a2261a6f80ac9f47a8bf1ce5 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 05:10:09 2014 +1100 CAR_GLOBAL: enforce compiler to check if _start != _end There are some fun rules C compilers can use to optimize their code. One of them is the assumption that two symbols point to two different addresses. In this case this wasn't true, resulting in unintended code execution (and later, a crash) with a clang build. Change-Id: I1496b22e1d1869ed0610e321b6ec6a83252e9d8b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/init/romstage.ld | 1 + src/cpu/x86/car.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch/x86/init/romstage.ld b/src/arch/x86/init/romstage.ld index f44185f..5458cfc 100644 --- a/src/arch/x86/init/romstage.ld +++ b/src/arch/x86/init/romstage.ld @@ -37,6 +37,7 @@ SECTIONS . = ALIGN(16); _car_migrate_start = .; *(.car.migrate); + LONG(0); _car_migrate_end = .; . = ALIGN(16); _erom = .; diff --git a/src/cpu/x86/car.c b/src/cpu/x86/car.c index 481153d..a7e3842 100644 --- a/src/cpu/x86/car.c +++ b/src/cpu/x86/car.c @@ -26,7 +26,6 @@ typedef void (* const car_migration_func_t)(void); extern car_migration_func_t _car_migrate_start; -extern car_migration_func_t _car_migrate_end; extern char _car_data_start[]; extern char _car_data_end[]; @@ -98,7 +97,7 @@ void car_migrate_variables(void) /* Call all the migration functions. */ migrate_func = &_car_migrate_start; - while (migrate_func != &_car_migrate_end) { + while (*migrate_func != NULL) { (*migrate_func)(); migrate_func++; }

1 0

Patch set updated for coreboot: bb00b5d util/sconfig: Fix missing prototype issue with bison/flex.
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5274 -gerrit commit bb00b5d98d2a05359a0d5fdd38740e463d31b0f0 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 19:42:59 2014 +1100 util/sconfig: Fix missing prototype issue with bison/flex. Clang throws missing prototype warnings where GCC does not. Shift around prototype declarations a little. Change-Id: I929085e5ed87452e77409889e04b05d32e5f356c Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- util/sconfig/sconfig.h | 20 ++++++++++++++++++++ util/sconfig/sconfig.tab.c_shipped | 17 +---------------- 2 files changed, 21 insertions(+), 16 deletions(-) diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index b8a231a..1aef26d 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -100,3 +100,23 @@ void alias_siblings(struct device *d); void add_resource(struct device *dev, int type, int index, int base); void add_register(struct device *dev, char *name, char *val); void add_pci_subsystem_ids(struct device *dev, int vendor, int device, int inherit); + +void add_ioapic_info(struct device *, int, const char *, int); + +void yyerror (const char *); +void yyrestart (FILE *input_file ); + +/* Prevent warnings from -Wmissing-prototypes. */ +#ifdef YYPARSE_PARAM +#if defined __STDC__ || defined __cplusplus +int yyparse (void *YYPARSE_PARAM); +#else +int yyparse (); +#endif +#else /* ! YYPARSE_PARAM */ +#if defined __STDC__ || defined __cplusplus +int yyparse (void); +#else +int yyparse (); +#endif +#endif /* ! YYPARSE_PARAM */ diff --git a/util/sconfig/sconfig.tab.c_shipped b/util/sconfig/sconfig.tab.c_shipped index 3a56ac8..56045d0 100644 --- a/util/sconfig/sconfig.tab.c_shipped +++ b/util/sconfig/sconfig.tab.c_shipped @@ -673,6 +673,7 @@ while (YYID (0)) #ifdef YYLEX_PARAM # define YYLEX yylex (YYLEX_PARAM) #else +int yylex(void); # define YYLEX yylex () #endif @@ -1127,22 +1128,6 @@ yydestruct (yymsg, yytype, yyvaluep) } -/* Prevent warnings from -Wmissing-prototypes. */ -#ifdef YYPARSE_PARAM -#if defined __STDC__ || defined __cplusplus -int yyparse (void *YYPARSE_PARAM); -#else -int yyparse (); -#endif -#else /* ! YYPARSE_PARAM */ -#if defined __STDC__ || defined __cplusplus -int yyparse (void); -#else -int yyparse (); -#endif -#endif /* ! YYPARSE_PARAM */ - - /* The lookahead symbol. */ int yychar;

1 0

Patch set updated for coreboot: b8473d6 utils/romcc.c: Fix spurious unsigned integer comparisons.
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5275 -gerrit commit b8473d6af607acf110f67c6d7679a626a96e837b Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 20:06:42 2014 +1100 utils/romcc.c: Fix spurious unsigned integer comparisons. Clang warns about comparisons of unsigned integers with being below zero. Remove spurious logic checks that are always false. Change-Id: I70c4d5331df81e48bf7ef27ff98400c4218f7edc Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- util/romcc/romcc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 3ac42f7..d6317f1 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -2870,7 +2870,7 @@ static struct triple *do_farg(struct compile_state *state, unsigned i; ftype = func->type; - if((index < 0) || (index >= (ftype->elements + 2))) { + if(index >= (ftype->elements + 2)) { internal_error(state, func, "bad argument index: %d", index); } first = RHS(func, 0); @@ -18329,7 +18329,7 @@ static void print_interference_block( } /* Do a bunch of sanity checks */ valid_ins(state, ptr); - if ((ptr->id < 0) || (ptr->id > rstate->defs)) { + if (ptr->id > rstate->defs) { internal_error(state, ptr, "Invalid triple id: %d", ptr->id); } @@ -18944,7 +18944,7 @@ static void graph_ins( */ for(entry = live; entry; entry = entry->next) { struct live_range *lr; - if ((entry->member->id < 0) || (entry->member->id > rstate->defs)) { + if (entry->member->id > rstate->defs) { internal_error(state, 0, "bad entry?"); } lr = rstate->lrd[entry->member->id].lr; @@ -19916,7 +19916,7 @@ static void verify_colors(struct compile_state *state, struct reg_state *rstate) ins = first; do { if (triple_is_def(state, ins)) { - if ((ins->id < 0) || (ins->id > rstate->defs)) { + if (ins->id > rstate->defs) { internal_error(state, ins, "triple without a live range def"); } @@ -19951,7 +19951,7 @@ static void color_triples(struct compile_state *state, struct reg_state *rstate) first = state->first; ins = first; do { - if ((ins->id < 0) || (ins->id > rstate->defs)) { + if (ins->id > rstate->defs) { internal_error(state, ins, "triple without a live range"); }

1 0

Patch set updated for coreboot: b6eea31 qemu-i440fx: Ignore missing prototype for entry point main()
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5272 -gerrit commit b6eea31187d4be47e425beb2bd0af572e5b01ec8 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 16:08:51 2014 +1100 qemu-i440fx: Ignore missing prototype for entry point main() The main of romstage in qemu-i440fx is called as the entry point in assembler and so should be compiled with -ffreestanding. We should also ignore a missing prototype in this particular case. Change-Id: Id0ce2348483c6e5388369000451811673f0c4eaa Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/arch/x86/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 4b28697..7362b64 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -266,7 +266,7 @@ else $(obj)/mainboard/$(MAINBOARDDIR)/romstage.pre.inc: $(src)/mainboard/$(MAINBOARDDIR)/romstage.c $(OPTION_TABLE_H) $(obj)/build.h $(obj)/config.h @printf " CC romstage.inc\n" - $(CC) -MMD $(CFLAGS) -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ + $(CC) -MMD $(CFLAGS) -ffreestanding -Wno-missing-prototypes -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc: $(obj)/mainboard/$(MAINBOARDDIR)/romstage.pre.inc @printf " POST romstage.inc\n"

1 0

Patch set updated for coreboot: c1f183f romcc.c: Suppress warning about unused function.
by Edward O'Callaghan 21 Feb '14

21 Feb '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5273 -gerrit commit c1f183f28cf0cc59fc96a7d916bef407c7c717ab Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu Feb 20 19:37:42 2014 +1100 romcc.c: Suppress warning about unused function. GCC suppresses warnings about unused static functions if they are inline, however Clang only does this for header files. Add attribute to suppress unused function warning on Clang. Change-Id: Ia230beba3f6367237838d9b3d90536459e1d52cb Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- util/romcc/romcc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index b045b46..3ac42f7 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -5648,6 +5648,7 @@ static struct type *invalid_type(struct compile_state *state, struct type *type) #define MASK_UCHAR(X) ((X) & ((ulong_t)0xff)) #define MASK_USHORT(X) ((X) & (((ulong_t)1 << (SIZEOF_SHORT)) - 1)) +static inline ulong_t mask_uint(ulong_t x) __attribute__((unused)); static inline ulong_t mask_uint(ulong_t x) { if (SIZEOF_INT < SIZEOF_LONG) {

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2014