coreboot-gerrit December 2014

coreboot-gerrit@coreboot.org

1 participants
1346 discussions

Patch merged into coreboot/master: daf7680 via/vx900: Plumber registered DIMM to right place.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit daf76808059c977929507ad6d4d31295cd1ed6b1 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:58:15 2014 +0100 via/vx900: Plumber registered DIMM to right place. Currently due to enum mistake DDR3 = 0xb was confused with DIMM type and interpreted as LRDIMM, considered unregistered and so every RAM was unregistered. Registered RAM is rarely used, so I suppose the code was never tested with them. For unregistered RAM exactly the same codepath is followed. Change-Id: I02fe8b1fd7be3bd382399ffa0eb513965a2a6d77 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7687 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7687 for details. -gerrit

1 0

Patch merged into coreboot/master: 0e675f7 ddr3: Plumber DIMM type to parsed structure.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 0e675f72da2a00607da59cff9adee538fdecdc98 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:56:48 2014 +0100 ddr3: Plumber DIMM type to parsed structure. Useful for distinguishing registered modules. Change-Id: Ibf4a0f2cde6d50a1c5c1da0f50e3022a2bc7ccd7 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7686 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7686 for details. -gerrit

1 0

New patch to review for coreboot: a2dcad2 vendorcode/amd/agesa/f1{5, 5tn, 6kb}: Silence empty loop warn
by Edward O'Callaghan 07 Dec '14

07 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7688 -gerrit commit a2dcad2f2807c4d3c12945750b31bd2c59a84a3a Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Dec 8 01:00:43 2014 +1100 vendorcode/amd/agesa/f1{5,5tn,6kb}: Silence empty loop warn Add decorations to specify that empty loop is intended so. Change-Id: Ia3e40d341eca5e26da3832edc733cf1ccc96c136 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Found-by: Clang --- src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c | 2 +- src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c | 2 +- src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c index 20ba2a5..9220193 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c +++ b/src/vendorcode/amd/agesa/f15/Proc/Mem/Feat/IDENDIMM/mfidendimm.c @@ -507,7 +507,7 @@ MemFGetPCI ( UINT8 Die; // Find NBBlock that associates with node NodeID - for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++); + for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++) ; ASSERT (Die < MAX_NODES_SUPPORTED); // Get the northbridge pointer for the targeted node. diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c index 20ba2a5..9220193 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/Feat/IDENDIMM/mfidendimm.c @@ -507,7 +507,7 @@ MemFGetPCI ( UINT8 Die; // Find NBBlock that associates with node NodeID - for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++); + for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++) ; ASSERT (Die < MAX_NODES_SUPPORTED); // Get the northbridge pointer for the targeted node. diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c index 6bd8521..479ce65 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c +++ b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/Feat/IDENDIMM/mfidendimm.c @@ -507,7 +507,7 @@ MemFGetPCI ( UINT8 Die; // Find NBBlock that associates with node NodeID - for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++); + for (Die = 0; (Die < MAX_NODES_SUPPORTED) && (NBPtr[Die].Node != NodeID); Die ++) ; ASSERT (Die < MAX_NODES_SUPPORTED); // Get the northbridge pointer for the targeted node.

1 0

Patch merged into coreboot/master: 76c2561 hp/pavilion_m6_1035dx: select NO_UART_ON_SUPERIO in Kconfig
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 76c256134fb263c31ed40a839a3e7ec6368d3533 Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Date: Sat Dec 6 23:56:49 2014 -0600 hp/pavilion_m6_1035dx: select NO_UART_ON_SUPERIO in Kconfig Change-Id: I324cdaf2025898b74bfc0d40c5ed8b88d2be5ad4 Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Reviewed-on: http://review.coreboot.org/7679 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/7679 for details. -gerrit

1 0

Patch merged into coreboot/master: 5235cd0 x200/devicetree: Remove extraneous eventc.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 5235cd085ae00d89c48545a13e7ac55f304632f9 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:43:44 2014 +0100 x200/devicetree: Remove extraneous eventc. Change-Id: If72daed326216e24da85a6a9d342f36f4e1d9de5 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7685 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7685 for details. -gerrit

1 0

Patch merged into coreboot/master: 1a3ee66 x200/romstage: Add missing include.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 1a3ee668c79ae117738aa44c690471778a014fd8 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:10:01 2014 +0100 x200/romstage: Add missing include. Change-Id: I47aa8619ba1e1939707ec654ffb54cae316929cf Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7684 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7684 for details. -gerrit

1 0

Patch merged into coreboot/master: 25fc532 nehalem/raminit: Add decorations to specify that empty loop is intended so.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 25fc532838f55938b59ad4337990c487ac663cc7 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:05:44 2014 +0100 nehalem/raminit: Add decorations to specify that empty loop is intended so. Change-Id: I6a05683daa6105e26017d1abf45881a9ef93ea30 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7683 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7683 for details. -gerrit

1 0

Patch merged into coreboot/master: 8e688b3 vx800: Silence clang warnings.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 8e688b3d742ff02eeac1e109e0400264cb20175f Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 12:53:07 2014 +0100 vx800: Silence clang warnings. I have no such board to check the real fixes but this board shouldn't block benefits for the rest of the tree. Change-Id: I9e9d4af1b360bcf0099ac2901b08f7fcd7569097 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7681 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/7681 for details. -gerrit

1 0

New patch to review for coreboot: 85d4744 via/vx900: Plumber registered DIMM to right place.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7687 -gerrit commit 85d4744888018617546ca30382b16caa19dbe06a Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:58:15 2014 +0100 via/vx900: Plumber registered DIMM to right place. Currently due to enum mistake DDR3 = 0xb was confused with DIMM type and interpreted as LRDIMM, considered unregistered and so every RAM was unregistered. Registered RAM is rarely used, so I suppose the code was never tested with them. For unregistered RAM exactly the same codepath is followed. Change-Id: I02fe8b1fd7be3bd382399ffa0eb513965a2a6d77 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/via/vx900/raminit.h | 1 + src/northbridge/via/vx900/raminit_ddr3.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/northbridge/via/vx900/raminit.h b/src/northbridge/via/vx900/raminit.h index c599c0f..0fd626f 100644 --- a/src/northbridge/via/vx900/raminit.h +++ b/src/northbridge/via/vx900/raminit.h @@ -71,6 +71,7 @@ typedef struct vx900_delay_calib_st { typedef struct ramctr_timing_st { enum spd_memory_type dram_type; + enum spd_dimm_type dimm_type; u16 cas_supported; /* tLatencies are in units of ns, scaled by x256 */ u32 tCK; diff --git a/src/northbridge/via/vx900/raminit_ddr3.c b/src/northbridge/via/vx900/raminit_ddr3.c index 3979466..e6dace3 100644 --- a/src/northbridge/via/vx900/raminit_ddr3.c +++ b/src/northbridge/via/vx900/raminit_ddr3.c @@ -369,9 +369,11 @@ static void dram_find_common_params(const dimm_info * dimms, if (valid_dimms == 1) { /* First DIMM defines the type of DIMM */ ctrl->dram_type = dimm->dram_type; + ctrl->dimm_type = dimm->dimm_type; } else { /* Check if we have mismatched DIMMs */ - if (ctrl->dram_type != dimm->dram_type) + if (ctrl->dram_type != dimm->dram_type + || ctrl->dimm_type != dimm->dimm_type) die("Mismatched DIMM Types"); } /* Find all possible CAS combinations */ @@ -705,7 +707,7 @@ static void vx900_dram_freq(ramctr_timing * ctrl) pci_mod_config8(MCU, 0x6b, 0x80, 0x00); /* Step 8 - If we have registered DIMMs, we need to set bit[0] */ - if (dimm_is_registered(ctrl->dram_type)) { + if (dimm_is_registered(ctrl->dimm_type)) { printram("Enabling RDIMM support in memory controller\n"); pci_mod_config8(MCU, 0x6c, 0x00, 0x01); }

1 0

New patch to review for coreboot: 6e84306 ddr3: Plumber DIMM type to parsed structure.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7686 -gerrit commit 6e843066a1b206eeff4c2fc7413e2b4cde1d6f4a Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:56:48 2014 +0100 ddr3: Plumber DIMM type to parsed structure. Useful for distinguishing registered modules. Change-Id: Ibf4a0f2cde6d50a1c5c1da0f50e3022a2bc7ccd7 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/device/dram/ddr3.c | 1 + src/include/device/dram/ddr3.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index 00f2ba9..86abea8 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -126,6 +126,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd) return SPD_STATUS_INVALID; } dimm->dram_type = SPD_MEMORY_TYPE_SDRAM_DDR3; + dimm->dimm_type = spd[3] & 0xf; crc = spd_ddr3_calc_crc(spd, sizeof(*spd)); /* Compare with the CRC in the SPD */ diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h index ef0d0ec..10924a2 100644 --- a/src/include/device/dram/ddr3.h +++ b/src/include/device/dram/ddr3.h @@ -135,6 +135,7 @@ typedef union dimm_flags_st { */ typedef struct dimm_attr_st { enum spd_memory_type dram_type; + enum spd_dimm_type dimm_type; u16 cas_supported; /* Flags extracted from SPD */ dimm_flags_t flags;

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2014