coreboot-gerrit December 2014

coreboot-gerrit@coreboot.org

1 participants
1346 discussions

New patch to review for coreboot: 94ca95d edid: fill reserved bits fields in cb_framebuffer
by Patrick Georgi 06 Dec '14

06 Dec '14

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7674 -gerrit commit 94ca95d9efa13d21f27366f6727b87ac6a44e187 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Dec 6 17:35:25 2014 +0100 edid: fill reserved bits fields in cb_framebuffer If it's a 4 byte format (as per documentation), there are some reserved bits, so let's mark them as such... Change-Id: I50f12cfff2c9bb9d082a5f3c3ac54c0d514d862b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/lib/edid.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/edid.c b/src/lib/edid.c index c8e3203..2028c70 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -1446,10 +1446,14 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr) * I'm not sure with grahpics you ever can. */ edid_fb.bits_per_pixel = edid->framebuffer_bits_per_pixel; + edid_fb.reserved_mask_pos = 0; + edid_fb.reserved_mask_size = 0; switch(edid->framebuffer_bits_per_pixel){ case 32: case 24: /* packed into 4-byte words */ + edid_fb.reserved_mask_pos = 24; + edid_fb.reserved_mask_size = 8; edid_fb.red_mask_pos = 16; edid_fb.red_mask_size = 8; edid_fb.green_mask_pos = 8; @@ -1472,8 +1476,6 @@ void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr) return; } - edid_fb.reserved_mask_pos = 0; - edid_fb.reserved_mask_size = 0; vbe_valid = 1; }

1 0

Patch merged into coreboot/master: 45b64fb vendorcode/amd/agesa: Remove unused helper.c file
by gerrit＠coreboot.org 06 Dec '14

06 Dec '14

the following patch was just integrated into master: commit 45b64fbf9dcfb0eba83f4227b11d92905c8d1e03 Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Date: Sat Dec 6 05:33:36 2014 -0600 vendorcode/amd/agesa: Remove unused helper.c file The contents of these files were guarded by a check for the _MSC_VER macro, which we don't use. Change-Id: Ic595c8e6284c54e1449cf21e0cebee8c9ce7c682 Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Reviewed-on: http://review.coreboot.org/7670 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/7670 for details. -gerrit

1 0

New patch to review for coreboot: 9027773 northbridge/amd/gx2, lx: Treat MSR constant as unsigned long
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7673 -gerrit commit 9027773a7ea80f45987174a68f99c48892ed73a0 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 03:03:08 2014 +1100 northbridge/amd/gx2,lx: Treat MSR constant as unsigned long Change-Id: I3e1c57334077feb50004d7b39abff4bd84ca095b Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/northbridge/amd/gx2/northbridgeinit.c | 2 +- src/northbridge/amd/lx/northbridgeinit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/northbridge/amd/gx2/northbridgeinit.c b/src/northbridge/amd/gx2/northbridgeinit.c index 136dcf2..0cb7803 100644 --- a/src/northbridge/amd/gx2/northbridgeinit.c +++ b/src/northbridge/amd/gx2/northbridgeinit.c @@ -548,7 +548,7 @@ static void rom_shadow_settings(void) * SYSRC(7:0) = 00h ; writeback, can set to 08h to make writethrough */ #define SYSMEM_RCONF_WRITETHROUGH 8 -#define DEVRC_RCONF_DEFAULT 0x21 +#define DEVRC_RCONF_DEFAULT 0x21ul #define ROMBASE_RCONF_DEFAULT 0xFFFC0000 #define ROMRC_RCONF_DEFAULT 0x25 diff --git a/src/northbridge/amd/lx/northbridgeinit.c b/src/northbridge/amd/lx/northbridgeinit.c index 82b3f48..b4e1d4a 100644 --- a/src/northbridge/amd/lx/northbridgeinit.c +++ b/src/northbridge/amd/lx/northbridgeinit.c @@ -602,7 +602,7 @@ static void rom_shadow_settings(void) * ***************************************************************************/ #define SYSMEM_RCONF_WRITETHROUGH 8 -#define DEVRC_RCONF_DEFAULT 0x21 +#define DEVRC_RCONF_DEFAULT 0x21ul #define ROMBASE_RCONF_DEFAULT 0xFFFC0000 #define ROMRC_RCONF_DEFAULT 0x25

1 0

Patch set updated for coreboot: 4cad7b2 TEST clang warn as error
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672 -gerrit commit 4cad7b2a89a2b8ddc0a8544d43f8382db36da7f7 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 02:46:07 2014 +1100 TEST clang warn as error Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eaba3e4..5a7e687 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a # this means the triple is i386-linux-elf instead of i386-none-elf -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function CC_x86_32:=clang HOSTCC := clang diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..7f033a2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID # the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

New patch to review for coreboot: 0d15dde TEST clang warn as error
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672 -gerrit commit 0d15dde0ea5948a3c8f10da3283ee43d0e26874f Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 02:46:07 2014 +1100 TEST clang warn as error Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eaba3e4..78d76b4 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a # this means the triple is i386-linux-elf instead of i386-none-elf -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable CC_x86_32:=clang HOSTCC := clang diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..7f033a2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID # the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

Patch set updated for coreboot: ff87c05 Revert "src/Kconfig: Don't treat warns as errors on Clang builds yet"
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7506 -gerrit commit ff87c05f8020738c771efcee3cb4e16e5a5ef5ca Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Tue Nov 18 03:17:54 2014 +1100 Revert "src/Kconfig: Don't treat warns as errors on Clang builds yet" This reverts commit 9b63c9bde2fc3b3a2d42e68618e043cf282bc566. Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Change-Id: I4f547d20c5096877b2010602a087e41702939f77 --- src/Kconfig | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..c48e592 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1126,13 +1126,9 @@ config ENABLE_APIC_EXT_ID bool default n -# XXX Currently clang/llvm builds are not fully supported, -# Let us tone down warns treated as errors until we actually build -# the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

Patch set updated for coreboot: 179591a Re-factor 'to_flash_offset()' into 'spi_flash.h'
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7519 -gerrit commit 179591a2a3b8ed3ceba4a7c855d0cfe764b28685 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 04:09:50 2014 +1000 Re-factor 'to_flash_offset()' into 'spi_flash.h' Re-factor to_flash_offset() into 'spi_flash.h' header. Motivated by Clang complaining that the function 'to_flash_offset' is unused. Change-Id: Ic75fd2fb4edc5e434c199ebd10c7384d197e0c63 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/intel/fsp/fastboot_cache.c | 13 ++----------- src/include/spi_flash.h | 11 +++++++++++ src/northbridge/intel/haswell/mrccache.c | 7 +------ src/northbridge/intel/sandybridge/mrccache.c | 7 +------ src/soc/intel/common/nvm.c | 10 ++-------- src/soc/intel/fsp_baytrail/nvm.c | 13 ++----------- 6 files changed, 19 insertions(+), 42 deletions(-) diff --git a/src/drivers/intel/fsp/fastboot_cache.c b/src/drivers/intel/fsp/fastboot_cache.c index 64982d8..907e143 100644 --- a/src/drivers/intel/fsp/fastboot_cache.c +++ b/src/drivers/intel/fsp/fastboot_cache.c @@ -31,15 +31,6 @@ #include <lib.h> // hexdump #include "fsp_util.h" -#ifndef CONFIG_VIRTUAL_ROM_SIZE -#error "CONFIG_VIRTUAL_ROM_SIZE must be set." -#endif - -/* convert a pointer to flash area into the offset inside the flash */ -static inline u32 to_flash_offset(void *p) { - return ((u32)p + CONFIG_VIRTUAL_ROM_SIZE); -} - static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) { @@ -205,7 +196,7 @@ void update_mrc_cache(void *unused) "Need to erase the MRC cache region of %d bytes at %p\n", cache_size, cache_base); - flash->erase(flash, to_flash_offset(cache_base), cache_size); + flash->erase(flash, to_flash_offset(flash, cache_base), cache_size); /* we will start at the beginning again */ cache = cache_base; @@ -213,7 +204,7 @@ void update_mrc_cache(void *unused) /* 4. write mrc data with flash->write() */ printk(BIOS_DEBUG, "Write MRC cache update to flash at %p\n", cache); - flash->write(flash, to_flash_offset(cache), + flash->write(flash, to_flash_offset(flash, cache), current->mrc_data_size + sizeof(*current), current); } diff --git a/src/include/spi_flash.h b/src/include/spi_flash.h index 70ca784..1a78b5a 100644 --- a/src/include/spi_flash.h +++ b/src/include/spi_flash.h @@ -76,4 +76,15 @@ static inline int spi_flash_erase(struct spi_flash *flash, u32 offset, return flash->erase(flash, offset, len); } +#if !defined(__PRE_RAM__) +/* convert a pointer to flash area into the offset inside the flash */ +static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { +#if defined(CONFIG_VIRTUAL_ROM_SIZE) + return ((u32)p + CONFIG_VIRTUAL_ROM_SIZE); +#else + return ((u32)p + flash->size); +#endif /* defined(CONFIG_VIRTUAL_ROM_SIZE) */ +} +#endif /* !defined(__PRE_RAM__) */ + #endif /* _SPI_FLASH_H_ */ diff --git a/src/northbridge/intel/haswell/mrccache.c b/src/northbridge/intel/haswell/mrccache.c index a921e04..88af789 100644 --- a/src/northbridge/intel/haswell/mrccache.c +++ b/src/northbridge/intel/haswell/mrccache.c @@ -33,11 +33,6 @@ #include <vendorcode/google/chromeos/fmap.h> #endif -/* convert a pointer to flash area into the offset inside the flash */ -static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { - return ((u32)p + flash->size); -} - static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) { @@ -228,7 +223,7 @@ BOOT_STATE_INIT_ENTRIES(mrc_cache_update) = { BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, update_mrc_cache, NULL), }; -#endif +#endif /* !defined(__PRE_RAM__) */ struct mrc_data_container *find_current_mrc_cache(void) { diff --git a/src/northbridge/intel/sandybridge/mrccache.c b/src/northbridge/intel/sandybridge/mrccache.c index c84ff82..664fb7f 100644 --- a/src/northbridge/intel/sandybridge/mrccache.c +++ b/src/northbridge/intel/sandybridge/mrccache.c @@ -33,11 +33,6 @@ #include <vendorcode/google/chromeos/fmap.h> #endif -/* convert a pointer to flash area into the offset inside the flash */ -static inline u32 to_flash_offset(struct spi_flash *flash, void *p) { - return ((u32)p + flash->size); -} - static struct mrc_data_container *next_mrc_block( struct mrc_data_container *mrc_cache) { @@ -227,7 +222,7 @@ BOOT_STATE_INIT_ENTRIES(mrc_cache_update) = { BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, update_mrc_cache, NULL), }; -#endif +#endif /* !defined(__PRE_RAM__) */ struct mrc_data_container *find_current_mrc_cache(void) { diff --git a/src/soc/intel/common/nvm.c b/src/soc/intel/common/nvm.c index 791422f..54b3baf 100644 --- a/src/soc/intel/common/nvm.c +++ b/src/soc/intel/common/nvm.c @@ -46,12 +46,6 @@ static int nvm_init(void) return 0; } -/* Convert memory mapped pointer to flash offset. */ -static inline uint32_t to_flash_offset(void *p) -{ - return CONFIG_ROM_SIZE + (uintptr_t)p; -} - int nvm_is_erased(const void *start, size_t size) { const uint8_t *cur = start; @@ -70,7 +64,7 @@ int nvm_erase(void *start, size_t size) { if (nvm_init() < 0) return -1; - return flash->erase(flash, to_flash_offset(start), size); + return flash->erase(flash, to_flash_offset(flash, start), size); } /* Write data to NVM. Returns 0 on success < 0 on error. */ @@ -78,5 +72,5 @@ int nvm_write(void *start, const void *data, size_t size) { if (nvm_init() < 0) return -1; - return flash->write(flash, to_flash_offset(start), size, data); + return flash->write(flash, to_flash_offset(flash, start), size, data); } diff --git a/src/soc/intel/fsp_baytrail/nvm.c b/src/soc/intel/fsp_baytrail/nvm.c index 0224463..d1e5223 100644 --- a/src/soc/intel/fsp_baytrail/nvm.c +++ b/src/soc/intel/fsp_baytrail/nvm.c @@ -47,15 +47,6 @@ static int nvm_init(void) return 0; } -/* Convert memory mapped pointer to flash offset. */ -static inline uint32_t to_flash_offset(void *p) -{ -#ifndef CONFIG_ROM_SIZE -#error CONFIG_ROM_SIZE must be set. -#endif - return CONFIG_ROM_SIZE + (uintptr_t)p; -} - int nvm_is_erased(const void *start, size_t size) { const uint8_t *cur = start; @@ -74,7 +65,7 @@ int nvm_erase(void *start, size_t size) { if (nvm_init() < 0) return -1; - flash->erase(flash, to_flash_offset(start), size); + flash->erase(flash, to_flash_offset(flash, start), size); return 0; } @@ -83,6 +74,6 @@ int nvm_write(void *start, const void *data, size_t size) { if (nvm_init() < 0) return -1; - flash->write(flash, to_flash_offset(start), size, data); + flash->write(flash, to_flash_offset(flash, start), size, data); return 0; }

1 0

Patch set updated for coreboot: 3e8457a Remove IRQ_SLOT_COUNT on all boards without PIRQ table.
by Vladimir Serbinenko 06 Dec '14

06 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7566 -gerrit commit 3e8457a510be0b57429cf2b8fbf282a3a2875efd Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Nov 23 22:01:09 2014 +0100 Remove IRQ_SLOT_COUNT on all boards without PIRQ table. This config is used only to generate PIRQ table. If no such table is supplied there is no need for config. Change-Id: I537d440f53019a6bf7f190446074e75e7420545a Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/mainboard/apple/macbook21/Kconfig | 4 ---- src/mainboard/google/bolt/Kconfig | 4 ---- src/mainboard/google/butterfly/Kconfig | 4 ---- src/mainboard/google/falco/Kconfig | 4 ---- src/mainboard/google/link/Kconfig | 4 ---- src/mainboard/google/panther/Kconfig | 4 ---- src/mainboard/google/parrot/Kconfig | 4 ---- src/mainboard/google/peppy/Kconfig | 4 ---- src/mainboard/google/samus/Kconfig | 4 ---- src/mainboard/google/slippy/Kconfig | 4 ---- src/mainboard/google/stout/Kconfig | 4 ---- src/mainboard/intel/bakersport_fsp/Kconfig | 4 ---- src/mainboard/intel/baskingridge/Kconfig | 4 ---- src/mainboard/intel/bayleybay_fsp/Kconfig | 4 ---- src/mainboard/intel/cougar_canyon2/Kconfig | 4 ---- src/mainboard/intel/emeraldlake2/Kconfig | 4 ---- src/mainboard/intel/minnowmax/Kconfig | 4 ---- src/mainboard/intel/mohonpeak/Kconfig | 4 ---- src/mainboard/intel/wtm2/Kconfig | 4 ---- src/mainboard/kontron/ktqm77/Kconfig | 4 ---- src/mainboard/lenovo/t520/Kconfig | 4 ---- src/mainboard/lenovo/t530/Kconfig | 4 ---- src/mainboard/lenovo/t60/Kconfig | 4 ---- src/mainboard/lenovo/x200/Kconfig | 4 ---- src/mainboard/lenovo/x201/Kconfig | 4 ---- src/mainboard/lenovo/x220/Kconfig | 4 ---- src/mainboard/lenovo/x230/Kconfig | 4 ---- src/mainboard/packardbell/ms2290/Kconfig | 4 ---- src/mainboard/roda/rk9/Kconfig | 4 ---- src/mainboard/samsung/lumpy/Kconfig | 4 ---- src/mainboard/samsung/stumpy/Kconfig | 4 ---- 31 files changed, 124 deletions(-) diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 8fd5f90..138ec87 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -47,10 +47,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/google/bolt/Kconfig b/src/mainboard/google/bolt/Kconfig index 7a756cc..5ffbb8d 100644 --- a/src/mainboard/google/bolt/Kconfig +++ b/src/mainboard/google/bolt/Kconfig @@ -36,10 +36,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 26ec09f..df7460a 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -30,10 +30,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/falco/Kconfig b/src/mainboard/google/falco/Kconfig index e89d14e..d8dc21e 100644 --- a/src/mainboard/google/falco/Kconfig +++ b/src/mainboard/google/falco/Kconfig @@ -39,10 +39,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index 130f025..99baba5 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -27,10 +27,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/panther/Kconfig b/src/mainboard/google/panther/Kconfig index e96746f..607b690 100644 --- a/src/mainboard/google/panther/Kconfig +++ b/src/mainboard/google/panther/Kconfig @@ -35,10 +35,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index dcc4d5d..bf423df 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -29,10 +29,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/peppy/Kconfig b/src/mainboard/google/peppy/Kconfig index acc23f2..308b843 100644 --- a/src/mainboard/google/peppy/Kconfig +++ b/src/mainboard/google/peppy/Kconfig @@ -41,10 +41,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/samus/Kconfig b/src/mainboard/google/samus/Kconfig index c6cbd18..cbfe2f2 100644 --- a/src/mainboard/google/samus/Kconfig +++ b/src/mainboard/google/samus/Kconfig @@ -37,10 +37,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 88bf501..42764a6 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -38,10 +38,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 812926a..59871fa 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -27,10 +27,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/intel/bakersport_fsp/Kconfig b/src/mainboard/intel/bakersport_fsp/Kconfig index 567889d..5c0707f 100644 --- a/src/mainboard/intel/bakersport_fsp/Kconfig +++ b/src/mainboard/intel/bakersport_fsp/Kconfig @@ -49,10 +49,6 @@ config MAINBOARD_PART_NUMBER string default "Bakersport CRB (FSP)" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index 512591e..e3c2cf7 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/bayleybay_fsp/Kconfig b/src/mainboard/intel/bayleybay_fsp/Kconfig index 384a2db..2c62390 100644 --- a/src/mainboard/intel/bayleybay_fsp/Kconfig +++ b/src/mainboard/intel/bayleybay_fsp/Kconfig @@ -49,10 +49,6 @@ config MAINBOARD_PART_NUMBER string default "Bayley Bay CRB (FSP)" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig index 3b25161..27b9a97 100644 --- a/src/mainboard/intel/cougar_canyon2/Kconfig +++ b/src/mainboard/intel/cougar_canyon2/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf8000000 # set to match FSP -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index dc04631..d6f4157 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -25,10 +25,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig index aacf174..1a940b2 100644 --- a/src/mainboard/intel/minnowmax/Kconfig +++ b/src/mainboard/intel/minnowmax/Kconfig @@ -58,10 +58,6 @@ config MINNOWMAX_2GB_SKU bool "2GB" endchoice -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/mohonpeak/Kconfig b/src/mainboard/intel/mohonpeak/Kconfig index eb97663..a140f15 100644 --- a/src/mainboard/intel/mohonpeak/Kconfig +++ b/src/mainboard/intel/mohonpeak/Kconfig @@ -48,10 +48,6 @@ config MAINBOARD_PART_NUMBER string default "Mohon Peak CRB" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index 353279a..c868e73 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 5f92c6c..485978c 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index be2f5aa..d91ed67 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -43,10 +43,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 80c04c1..33fcd7d 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index fbe2c72..0cf19a1 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -42,10 +42,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index 2dc5e4b..15e55c7 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -37,10 +37,6 @@ config USBDEBUG_HCD_INDEX int default 2 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index ac7f8df..b1ca2f5 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -31,10 +31,6 @@ config MMCONF_BASE_ADDRESS hex default 0xe0000000 -config IRQ_SLOT_COUNT - int - default 18 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 2161a8f..20e9527 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 2f8f7b2..1a1e018 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index 58053e2..3ea302a 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -38,10 +38,6 @@ config MMCONF_BASE_ADDRESS hex default 0xe0000000 -config IRQ_SLOT_COUNT - int - default 18 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig index 9477848..a17717a 100644 --- a/src/mainboard/roda/rk9/Kconfig +++ b/src/mainboard/roda/rk9/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 7d03fa0..baf0eee 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -29,10 +29,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index eee3755..17484a9 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8

1 0

Patch set updated for coreboot: fe3b535 Remove IRQ_SLOT_COUNT on all boards without PIRQ table.
by Vladimir Serbinenko 06 Dec '14

06 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7566 -gerrit commit fe3b5358e297b5baadd1db1ceeff3e90e5a4f9e9 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Nov 23 22:01:09 2014 +0100 Remove IRQ_SLOT_COUNT on all boards without PIRQ table. This config is used only to generate PIRQ table. If no such table is supplied there is no need for config. Change-Id: I537d440f53019a6bf7f190446074e75e7420545a Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/mainboard/apple/macbook21/Kconfig | 4 ---- src/mainboard/google/bolt/Kconfig | 4 ---- src/mainboard/google/butterfly/Kconfig | 4 ---- src/mainboard/google/falco/Kconfig | 4 ---- src/mainboard/google/link/Kconfig | 4 ---- src/mainboard/google/panther/Kconfig | 4 ---- src/mainboard/google/parrot/Kconfig | 4 ---- src/mainboard/google/peppy/Kconfig | 4 ---- src/mainboard/google/samus/Kconfig | 4 ---- src/mainboard/google/slippy/Kconfig | 4 ---- src/mainboard/google/stout/Kconfig | 4 ---- src/mainboard/intel/bakersport_fsp/Kconfig | 4 ---- src/mainboard/intel/baskingridge/Kconfig | 4 ---- src/mainboard/intel/bayleybay_fsp/Kconfig | 4 ---- src/mainboard/intel/cougar_canyon2/Kconfig | 4 ---- src/mainboard/intel/emeraldlake2/Kconfig | 4 ---- src/mainboard/intel/minnowmax/Kconfig | 6 +++--- src/mainboard/intel/mohonpeak/Kconfig | 4 ---- src/mainboard/intel/wtm2/Kconfig | 4 ---- src/mainboard/kontron/ktqm77/Kconfig | 4 ---- src/mainboard/lenovo/t520/Kconfig | 4 ---- src/mainboard/lenovo/t530/Kconfig | 4 ---- src/mainboard/lenovo/t60/Kconfig | 4 ---- src/mainboard/lenovo/x200/Kconfig | 4 ---- src/mainboard/lenovo/x201/Kconfig | 4 ---- src/mainboard/lenovo/x220/Kconfig | 4 ---- src/mainboard/lenovo/x230/Kconfig | 4 ---- src/mainboard/packardbell/ms2290/Kconfig | 4 ---- src/mainboard/roda/rk9/Kconfig | 4 ---- src/mainboard/samsung/lumpy/Kconfig | 4 ---- src/mainboard/samsung/stumpy/Kconfig | 4 ---- 31 files changed, 3 insertions(+), 123 deletions(-) diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 8fd5f90..138ec87 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -47,10 +47,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/google/bolt/Kconfig b/src/mainboard/google/bolt/Kconfig index 7a756cc..5ffbb8d 100644 --- a/src/mainboard/google/bolt/Kconfig +++ b/src/mainboard/google/bolt/Kconfig @@ -36,10 +36,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 26ec09f..df7460a 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -30,10 +30,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/falco/Kconfig b/src/mainboard/google/falco/Kconfig index e89d14e..d8dc21e 100644 --- a/src/mainboard/google/falco/Kconfig +++ b/src/mainboard/google/falco/Kconfig @@ -39,10 +39,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index 130f025..99baba5 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -27,10 +27,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/panther/Kconfig b/src/mainboard/google/panther/Kconfig index e96746f..607b690 100644 --- a/src/mainboard/google/panther/Kconfig +++ b/src/mainboard/google/panther/Kconfig @@ -35,10 +35,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index dcc4d5d..bf423df 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -29,10 +29,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/peppy/Kconfig b/src/mainboard/google/peppy/Kconfig index acc23f2..308b843 100644 --- a/src/mainboard/google/peppy/Kconfig +++ b/src/mainboard/google/peppy/Kconfig @@ -41,10 +41,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/samus/Kconfig b/src/mainboard/google/samus/Kconfig index c6cbd18..cbfe2f2 100644 --- a/src/mainboard/google/samus/Kconfig +++ b/src/mainboard/google/samus/Kconfig @@ -37,10 +37,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 88bf501..42764a6 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -38,10 +38,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 812926a..59871fa 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -27,10 +27,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/intel/bakersport_fsp/Kconfig b/src/mainboard/intel/bakersport_fsp/Kconfig index 567889d..5c0707f 100644 --- a/src/mainboard/intel/bakersport_fsp/Kconfig +++ b/src/mainboard/intel/bakersport_fsp/Kconfig @@ -49,10 +49,6 @@ config MAINBOARD_PART_NUMBER string default "Bakersport CRB (FSP)" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index 512591e..e3c2cf7 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/bayleybay_fsp/Kconfig b/src/mainboard/intel/bayleybay_fsp/Kconfig index 384a2db..2c62390 100644 --- a/src/mainboard/intel/bayleybay_fsp/Kconfig +++ b/src/mainboard/intel/bayleybay_fsp/Kconfig @@ -49,10 +49,6 @@ config MAINBOARD_PART_NUMBER string default "Bayley Bay CRB (FSP)" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig index 3b25161..27b9a97 100644 --- a/src/mainboard/intel/cougar_canyon2/Kconfig +++ b/src/mainboard/intel/cougar_canyon2/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf8000000 # set to match FSP -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index dc04631..d6f4157 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -25,10 +25,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig index aacf174..a31b60b 100644 --- a/src/mainboard/intel/minnowmax/Kconfig +++ b/src/mainboard/intel/minnowmax/Kconfig @@ -58,9 +58,9 @@ config MINNOWMAX_2GB_SKU bool "2GB" endchoice -config IRQ_SLOT_COUNT - int - default 18 +config MMCONF_BASE_ADDRESS + hex + default 0xe0000000 config MAX_CPUS int diff --git a/src/mainboard/intel/mohonpeak/Kconfig b/src/mainboard/intel/mohonpeak/Kconfig index eb97663..a140f15 100644 --- a/src/mainboard/intel/mohonpeak/Kconfig +++ b/src/mainboard/intel/mohonpeak/Kconfig @@ -48,10 +48,6 @@ config MAINBOARD_PART_NUMBER string default "Mohon Peak CRB" -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index 353279a..c868e73 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 16 diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 5f92c6c..485978c 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index be2f5aa..d91ed67 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -43,10 +43,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 80c04c1..33fcd7d 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index fbe2c72..0cf19a1 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -42,10 +42,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index 2dc5e4b..15e55c7 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -37,10 +37,6 @@ config USBDEBUG_HCD_INDEX int default 2 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index ac7f8df..b1ca2f5 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -31,10 +31,6 @@ config MMCONF_BASE_ADDRESS hex default 0xe0000000 -config IRQ_SLOT_COUNT - int - default 18 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 2161a8f..20e9527 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 2f8f7b2..1a1e018 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -44,10 +44,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index 58053e2..3ea302a 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -38,10 +38,6 @@ config MMCONF_BASE_ADDRESS hex default 0xe0000000 -config IRQ_SLOT_COUNT - int - default 18 - config USBDEBUG_HCD_INDEX int default 2 diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig index 9477848..a17717a 100644 --- a/src/mainboard/roda/rk9/Kconfig +++ b/src/mainboard/roda/rk9/Kconfig @@ -28,10 +28,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 2 diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 7d03fa0..baf0eee 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -29,10 +29,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8 diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index eee3755..17484a9 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -26,10 +26,6 @@ config MMCONF_BASE_ADDRESS hex default 0xf0000000 -config IRQ_SLOT_COUNT - int - default 18 - config MAX_CPUS int default 8

1 0

New patch to review for coreboot: 9c8ef9d vendorcode/amd/agesa/f15tn/*/F15TnMsrTables.c: Topology Extensions Support
by Edward O'Callaghan 06 Dec '14

06 Dec '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7671 -gerrit commit 9c8ef9d2d46dab0863de2099e56c7c7caa77ef06 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Dec 6 22:20:31 2014 +1100 vendorcode/amd/agesa/f15tn/*/F15TnMsrTables.c: Topology Extensions Support Topology Extensions Support (bit 54 of 0xC0011005) applies to PACKAGE_TYPE_FS1r2 also. Rids us of: "Re-enabling disabled Topology Extensions Support" showing up in dmesg. Change-Id: Id123fa9632936c150cf1aebc4d34b404a4398ead Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMsrTables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMsrTables.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMsrTables.c index db8a563..44bde6a 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMsrTables.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/TN/F15TnMsrTables.c @@ -257,7 +257,7 @@ SetTopologyExtensions ( PkgType = LibAmdGetPackageType (StdHeader); LibAmdMsrRead (MSR_CPUID_EXT_FEATS, &CpuMsrData, StdHeader); CpuMsrData &= ~(BIT54); - if (PkgType == PACKAGE_TYPE_FM2) { + if ((PkgType == PACKAGE_TYPE_FM2) || (PkgType == PACKAGE_TYPE_FS1r2)) { CpuMsrData |= BIT54; } LibAmdMsrWrite (MSR_CPUID_EXT_FEATS, &CpuMsrData, StdHeader);

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2014