Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672
-gerrit
commit dd6f4f0d002889056358f423afe072e557f48bee
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sun Dec 7 02:46:07 2014 +1100
TEST clang warn as error
Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
Makefile | 2 +-
src/Kconfig | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index eaba3e4..5a7e687 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
# FIXME: armv7/aarch64 won't build right now
# NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a
# this means the triple is i386-linux-elf instead of i386-none-elf
-CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32
+CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function
CC_x86_32:=clang
HOSTCC := clang
diff --git a/src/Kconfig b/src/Kconfig
index 533bc5c..7f033a2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID
# the whole treee.
config WARNINGS_ARE_ERRORS
bool
- default y if !COMPILER_LLVM_CLANG
- default n if COMPILER_LLVM_CLANG
+ default y
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are
the following patch was just integrated into master:
commit dc3d5ed3cb12fcae4ed5746d21b3f87169eb0416
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sun Dec 7 16:48:47 2014 +0100
ga-b75m-d3h: Remove duplicate sata_port_map
Change-Id: I128f1dfea013a4f94c5b006a90c10aa32563d81c
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/7691
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/7691 for details.
-gerrit
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672
-gerrit
commit 02d002d6f6bd1a508208f964ca496bff7922e87b
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sun Dec 7 02:46:07 2014 +1100
TEST clang warn as error
Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
Makefile | 2 +-
src/Kconfig | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index eaba3e4..5a7e687 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
# FIXME: armv7/aarch64 won't build right now
# NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a
# this means the triple is i386-linux-elf instead of i386-none-elf
-CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32
+CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function
CC_x86_32:=clang
HOSTCC := clang
diff --git a/src/Kconfig b/src/Kconfig
index 533bc5c..7f033a2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID
# the whole treee.
config WARNINGS_ARE_ERRORS
bool
- default y if !COMPILER_LLVM_CLANG
- default n if COMPILER_LLVM_CLANG
+ default y
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7692
-gerrit
commit 421e65e66fee369aefdeb7c59fc431dd4b7a8077
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Mon Dec 8 03:00:26 2014 +1100
southbridge/amd/sr5650/sr5650.c: Fix bitwise logic and mask in loop
Correct mask to select bits 4-6 inclusively as per comment and use
bitwise operations while working with bits. Be sure to write back out
the data on the retrain.
Change-Id: I95d1799514157b7849f3e473837aaf2fd9bd59b9
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/southbridge/amd/sr5650/sr5650.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/southbridge/amd/sr5650/sr5650.c b/src/southbridge/amd/sr5650/sr5650.c
index 7fdecf1..2a2d558 100644
--- a/src/southbridge/amd/sr5650/sr5650.c
+++ b/src/southbridge/amd/sr5650/sr5650.c
@@ -238,13 +238,12 @@ u8 PcieTrainPort(device_t nb_dev, device_t dev, u32 port)
if (reg & VC_NEGOTIATION_PENDING) { /* bit1=1 means the link needs to be re-trained. */
/* set bit8=1, bit0-2=bit4-6 */
u32 tmp;
- reg =
- nbpcie_p_read_index(dev,
- PCIE_LC_LINK_WIDTH);
- tmp = (reg >> 4) && 0x3; /* get bit4-6 */
+ reg = nbpcie_p_read_index(dev, PCIE_LC_LINK_WIDTH);
+ tmp = (reg >> 4) & 0x7; /* get bit4-6 */
reg &= 0xfff8; /* clear bit0-2 */
reg += tmp; /* merge */
reg |= 1 << 8;
+ nbpcie_p_write_index(dev, PCIE_LC_LINK_WIDTH, reg);
count++; /* CIM said "keep in loop"? */
} else {
res = 1;
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7692
-gerrit
commit 06bae6883bc4993c62c1e656cd8705c104af2d82
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Mon Dec 8 03:00:26 2014 +1100
southbridge/amd/sr5650/sr5650.c: Fix bitwise logic and mask in loop
Correct mask to select bits 4-6 inclusively as per comment and use
bitwise operations while working with bits. Be sure to write back out
the data on the retrain.
Change-Id: I95d1799514157b7849f3e473837aaf2fd9bd59b9
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/southbridge/amd/sr5650/sr5650.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/southbridge/amd/sr5650/sr5650.c b/src/southbridge/amd/sr5650/sr5650.c
index 7fdecf1..2a2d558 100644
--- a/src/southbridge/amd/sr5650/sr5650.c
+++ b/src/southbridge/amd/sr5650/sr5650.c
@@ -238,13 +238,12 @@ u8 PcieTrainPort(device_t nb_dev, device_t dev, u32 port)
if (reg & VC_NEGOTIATION_PENDING) { /* bit1=1 means the link needs to be re-trained. */
/* set bit8=1, bit0-2=bit4-6 */
u32 tmp;
- reg =
- nbpcie_p_read_index(dev,
- PCIE_LC_LINK_WIDTH);
- tmp = (reg >> 4) && 0x3; /* get bit4-6 */
+ reg = nbpcie_p_read_index(dev, PCIE_LC_LINK_WIDTH);
+ tmp = (reg >> 4) & 0x7; /* get bit4-6 */
reg &= 0xfff8; /* clear bit0-2 */
reg += tmp; /* merge */
reg |= 1 << 8;
+ nbpcie_p_write_index(dev, PCIE_LC_LINK_WIDTH, reg);
count++; /* CIM said "keep in loop"? */
} else {
res = 1;
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7690
-gerrit
commit e27c1668436d9107ce4adde37c466471b97c3604
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Mon Dec 8 02:28:39 2014 +1100
mainboard/google/samus: Fix usage of GNU field designator ext
Following the reasoning in,
8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension
In C99 we defined a syntax for this. GCC's old syntax was deprecated.
Change-Id: Id3b16872f62660393d938d6f95977a4e3842d0d1
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/mainboard/google/samus/romstage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mainboard/google/samus/romstage.c b/src/mainboard/google/samus/romstage.c
index abd93c4..bdf0e70 100644
--- a/src/mainboard/google/samus/romstage.c
+++ b/src/mainboard/google/samus/romstage.c
@@ -146,7 +146,7 @@ void mainboard_romstage_entry(unsigned long bist)
{ 0x0040, 1, USB_OC_PIN_SKIP, /* P7: BT */
USB_PORT_INTERNAL },
},
- usb3_ports: {
+ .usb3_ports = {
/* Enable, OCn# */
{ 1, 0 }, /* P1: HOST PORT */
{ 1, 1 }, /* P2: HOST PORT */
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672
-gerrit
commit 5a832499bf9d574143288fcf6f88add6a0e16df9
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sun Dec 7 02:46:07 2014 +1100
TEST clang warn as error
Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
Makefile | 2 +-
src/Kconfig | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index eaba3e4..5a7e687 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
# FIXME: armv7/aarch64 won't build right now
# NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a
# this means the triple is i386-linux-elf instead of i386-none-elf
-CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32
+CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function
CC_x86_32:=clang
HOSTCC := clang
diff --git a/src/Kconfig b/src/Kconfig
index 533bc5c..7f033a2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID
# the whole treee.
config WARNINGS_ARE_ERRORS
bool
- default y if !COMPILER_LLVM_CLANG
- default n if COMPILER_LLVM_CLANG
+ default y
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672
-gerrit
commit 76e19549d3896952b39e90470f6dc03f374a90f6
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sun Dec 7 02:46:07 2014 +1100
TEST clang warn as error
Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
Makefile | 2 +-
src/Kconfig | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index eaba3e4..5a7e687 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
# FIXME: armv7/aarch64 won't build right now
# NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a
# this means the triple is i386-linux-elf instead of i386-none-elf
-CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32
+CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function
CC_x86_32:=clang
HOSTCC := clang
diff --git a/src/Kconfig b/src/Kconfig
index 533bc5c..7f033a2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID
# the whole treee.
config WARNINGS_ARE_ERRORS
bool
- default y if !COMPILER_LLVM_CLANG
- default n if COMPILER_LLVM_CLANG
+ default y
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are