coreboot-gerrit December 2014

coreboot-gerrit@coreboot.org

1 participants
1346 discussions

New patch to review for coreboot: 040c5d5 x200/devicetree: Remove extraneous eventc.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7685 -gerrit commit 040c5d5706296bb426f1c63e30adc61fdad484db Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:43:44 2014 +0100 x200/devicetree: Remove extraneous eventc. Change-Id: If72daed326216e24da85a6a9d342f36f4e1d9de5 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/mainboard/lenovo/x200/devicetree.cb | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mainboard/lenovo/x200/devicetree.cb b/src/mainboard/lenovo/x200/devicetree.cb index acc6c3a..edd3c64 100644 --- a/src/mainboard/lenovo/x200/devicetree.cb +++ b/src/mainboard/lenovo/x200/devicetree.cb @@ -169,7 +169,6 @@ chip northbridge/intel/gm45 register "event5_enable" = "0x3c" register "event6_enable" = "0x80" register "event7_enable" = "0x01" - register "eventc_enable" = "0x3c" register "event8_enable" = "0x01" register "event9_enable" = "0xff" register "eventa_enable" = "0xff"

1 0

Patch set updated for coreboot: e444ffb TEST clang warn as error
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672 -gerrit commit e444ffbde6efada7a2e5ba24889c89acfedf1493 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 02:46:07 2014 +1100 TEST clang warn as error Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eaba3e4..5a7e687 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a # this means the triple is i386-linux-elf instead of i386-none-elf -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function CC_x86_32:=clang HOSTCC := clang diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..7f033a2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID # the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

New patch to review for coreboot: 1354701 x200/romstage: Add missing include.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7684 -gerrit commit 13547011343107eabb5483ddbf4cbaf81dca519e Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:10:01 2014 +0100 x200/romstage: Add missing include. Change-Id: I47aa8619ba1e1939707ec654ffb54cae316929cf Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/mainboard/lenovo/x200/romstage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c index 1c0668f..f232642 100644 --- a/src/mainboard/lenovo/x200/romstage.c +++ b/src/mainboard/lenovo/x200/romstage.c @@ -33,6 +33,7 @@ #include <console/console.h> #include <southbridge/intel/i82801ix/i82801ix.h> #include <northbridge/intel/gm45/gm45.h> +#include <cpu/intel/romstage.h> #define LPC_DEV PCI_DEV(0, 0x1f, 0) #define MCH_DEV PCI_DEV(0, 0, 0)

1 0

New patch to review for coreboot: 5494856 nehalem/raminit: Add decorations to specify that empty loop is intended so.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7683 -gerrit commit 5494856ad3f35419cc7db2634fbe321d60230b44 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:05:44 2014 +0100 nehalem/raminit: Add decorations to specify that empty loop is intended so. Change-Id: I6a05683daa6105e26017d1abf45881a9ef93ea30 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/intel/nehalem/raminit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index fb82484..9ca98d5 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -4571,7 +4571,9 @@ void raminit(const int s3resume, const u8 *spd_addrmap) write_mchbar32(0x140, read_mchbar32(0x140) & ~0x07000000); write_mchbar32(0x138, read_mchbar32(0x138) & ~0x07000000); write_mchbar32(0x130, 0x31111301); - while (read_mchbar32(0x130) & 1) ; + /* Wait until REG130b0 is 1. */ + while (read_mchbar32(0x130) & 1) + ; { u32 t;

1 0

New patch to review for coreboot: 6ecebf8 vx800/vga.c: Remove extraneous parentheses.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7682 -gerrit commit 6ecebf88c409b9be63bad89e7f9030c5b0b4d1b5 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 13:03:16 2014 +0100 vx800/vga.c: Remove extraneous parentheses. Change-Id: Ic81b5f66871ec78c72f2adc5723f22fa94a672e8 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/via/vx800/vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/via/vx800/vga.c b/src/northbridge/via/vx800/vga.c index 7fe33f2..4ee249f 100644 --- a/src/northbridge/via/vx800/vga.c +++ b/src/northbridge/via/vx800/vga.c @@ -186,7 +186,7 @@ static void vga_init(device_t dev) printk(BIOS_DEBUG, "Enable VGA console\n"); vga_enable_console(); - if ((acpi_sleep_type == 3)/* || (PAYLOAD_IS_SEABIOS == 0)*/) { + if (acpi_sleep_type == 3/* || (PAYLOAD_IS_SEABIOS == 0)*/) { /* It's not clear if these need to be programmed before or after * the VGA bios runs. Try both, clean up later */ /* Set memory rate to 200MHz */

1 0

Patch set updated for coreboot: 6c70a8a TEST clang warn as error
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672 -gerrit commit 6c70a8ad214c65eeeb74eb22f57b29dec0e9e5e8 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 02:46:07 2014 +1100 TEST clang warn as error Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eaba3e4..5a7e687 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a # this means the triple is i386-linux-elf instead of i386-none-elf -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function CC_x86_32:=clang HOSTCC := clang diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..7f033a2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID # the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

Patch set updated for coreboot: 61fb4b4 vx800: Silence clang warnings.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7681 -gerrit commit 61fb4b496f9083ddc5ce86e6ff6aa0e43136629c Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 12:53:07 2014 +0100 vx800: Silence clang warnings. I have no such board to check the real fixes but this board shouldn't block benefits for the rest of the tree. Change-Id: I9e9d4af1b360bcf0099ac2901b08f7fcd7569097 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/via/vx800/raminit.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/northbridge/via/vx800/raminit.c b/src/northbridge/via/vx800/raminit.c index 058337c..6d58f78 100644 --- a/src/northbridge/via/vx800/raminit.c +++ b/src/northbridge/via/vx800/raminit.c @@ -20,6 +20,14 @@ #include <spd.h> #include <delay.h> +#ifdef __clang__ +/* Silence clang warnings via pragmas to avoid the problems in this file + blocking analyzes for the rest of the tree. */ +#pragma clang diagnostic ignored "-Wsometimes-uninitialized" +#pragma clang diagnostic ignored "-Wconstant-logical-operand" +#pragma clang diagnostic ignored "-Warray-bounds" +#endif + #if CONFIG_DEBUG_RAM_SETUP #define PRINT_DEBUG_MEM(x) print_debug(x) #define PRINT_DEBUG_MEM_HEX8(x) print_debug_hex8(x)

1 0

Patch merged into coreboot/master: 29b8a09 early_me_native.c: Remove unused pci_write_dword_ptr.
by gerrit＠coreboot.org 07 Dec '14

07 Dec '14

the following patch was just integrated into master: commit 29b8a0976f3def83d88d78b04a84834a9b1a7886 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 11:47:17 2014 +0100 early_me_native.c: Remove unused pci_write_dword_ptr. Change-Id: I97f4ef373c250665c4a2265571e71a27ecef13da Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/7680 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/7680 for details. -gerrit

1 0

New patch to review for coreboot: 08e92b5 vx800: Silence clang warnings.
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7681 -gerrit commit 08e92b5d3560f442441835cfbf34812b3027a974 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sun Dec 7 12:53:07 2014 +0100 vx800: Silence clang warnings. I have no such board to check the real fixes but this board shouldn't block benefits for the rest of the tree. Change-Id: I9e9d4af1b360bcf0099ac2901b08f7fcd7569097 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/via/vx800/raminit.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/northbridge/via/vx800/raminit.c b/src/northbridge/via/vx800/raminit.c index 058337c..19726b6 100644 --- a/src/northbridge/via/vx800/raminit.c +++ b/src/northbridge/via/vx800/raminit.c @@ -20,6 +20,12 @@ #include <spd.h> #include <delay.h> +/* Silence clang warnings via pragmas to avoid the problems in this file + blocking analyzes for the rest of the tree. */ +#pragma clang diagnostic ignored "-Wsometimes-uninitialized" +#pragma clang diagnostic ignored "-Wconstant-logical-operand" +#pragma clang diagnostic ignored "-Warray-bounds" + #if CONFIG_DEBUG_RAM_SETUP #define PRINT_DEBUG_MEM(x) print_debug(x) #define PRINT_DEBUG_MEM_HEX8(x) print_debug_hex8(x)

1 0

Patch set updated for coreboot: e6ae7bc TEST clang warn as error
by Vladimir Serbinenko 07 Dec '14

07 Dec '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7672 -gerrit commit e6ae7bc133409e6cf077be446bf0613e58eb5743 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Dec 7 02:46:07 2014 +1100 TEST clang warn as error Change-Id: Iac4efa59f63437fd6c7678368f4c62ba005d2103 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- Makefile | 2 +- src/Kconfig | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eaba3e4..5a7e687 100644 --- a/Makefile +++ b/Makefile @@ -117,7 +117,7 @@ ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) # FIXME: armv7/aarch64 won't build right now # NOTE: clang puts compiler-rt under lib/linux/libclang_rt.builtins-i386.a # this means the triple is i386-linux-elf instead of i386-none-elf -CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 +CFLAGS_x86_32 = -no-integrated-as -Qunused-arguments -target i386-linux-elf -m32 -Wno-unused-variable -Wno-unused-function CC_x86_32:=clang HOSTCC := clang diff --git a/src/Kconfig b/src/Kconfig index 533bc5c..7f033a2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1131,8 +1131,7 @@ config ENABLE_APIC_EXT_ID # the whole treee. config WARNINGS_ARE_ERRORS bool - default y if !COMPILER_LLVM_CLANG - default n if COMPILER_LLVM_CLANG + default y # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2014