Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4775
-gerrit
commit 8a240062015313cb52c660384fe970021f3edb3b
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Tue Jan 21 10:44:08 2014 +0200
usbdebug: Fix data toggle on receive
USB device end toggles data PID when we ACK'd the zero-length data
packet. As USB host we need to toggle data PID too or the next data
received would get discarded.
Change-Id: I3203bc874c7ded9244c7548a666d7041a0fbb379
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/lib/usbdebug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c
index 6760aab..d0281bb 100644
--- a/src/lib/usbdebug.c
+++ b/src/lib/usbdebug.c
@@ -203,8 +203,7 @@ host_retry:
/* If I get an ACK or in-sync DATA PID, we are done. */
if ((lpid == USB_PID_ACK) || (lpid == pipe->pid)) {
- if (DBGP_LEN(rd_ctrl))
- pipe->pid ^= USB_PID_DATA_TOGGLE;
+ pipe->pid ^= USB_PID_DATA_TOGGLE;
}
/* If the port is getting full or it has dropped data
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4773
-gerrit
commit bb81c88c02cd4dce2c37886eed19fe90c3d905cd
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Tue Jan 21 23:03:27 2014 +0100
abuild: break early if building tools fails
Change-Id: I8da04df024a31c780b924a586d056a5351845153
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/abuild/abuild | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index ec5c27b..a3669e9 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -613,7 +613,7 @@ build_all_targets()
if [ "$enable_blobs" = "true" ]; then
echo "CONFIG_USE_BLOBS=y" > $TMPCFG
fi
- make -j $cpus DOTCONFIG=$TMPCFG obj=coreboot-builds/temp objutil=coreboot-builds/sharedutils tools
+ make -j $cpus DOTCONFIG=$TMPCFG obj=coreboot-builds/temp objutil=coreboot-builds/sharedutils tools || exit 1
rm -rf coreboot-builds/temp $TMPCFG
for VENDOR in $( vendors ); do
for MAINBOARD in $( mainboards $VENDOR ); do
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4584
-gerrit
commit deed4247fe6b32599b246b05362ec16c1c4a1b6e
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sun Dec 29 18:45:23 2013 +0100
buildsystem: check for coreboot toolchain by default
Other toolchains just don't cut it.
Change-Id: I7a0bdf60d89b5166c9a22c9e9f3f326b28f777b8
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
Makefile.inc | 12 ++++++++++++
src/Kconfig | 10 ++++++++++
2 files changed, 22 insertions(+)
diff --git a/Makefile.inc b/Makefile.inc
index 0fb86ce..8836277 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -24,6 +24,18 @@ export KERNELVERSION := $(shell if [ -d "$(top)/.git" -a -f "`which git`" ]; \
else echo 4.0$(KERNELREVISION); fi)
#######################################################################
+# Test for coreboot toolchain (except when explicitely not requested)
+ifneq ($(NOCOMPILE),1)
+# only run if we're doing a build (not for tests, kconfig, ...)
+ifneq ($(CONFIG_ANY_TOOLCHAIN),y)
+_toolchain=$(shell $(CC_i386) -v 2>&1 |grep -q "gcc version .*coreboot toolchain" && echo coreboot)
+ifneq ($(_toolchain),coreboot)
+$(error Please use the coreboot toolchain (or prove that your toolchain works))
+endif
+endif
+endif
+
+#######################################################################
# Basic component discovery
MAINBOARDDIR=$(call strip_quotes,$(CONFIG_MAINBOARD_DIR))
export MAINBOARDDIR
diff --git a/src/Kconfig b/src/Kconfig
index 1c80b8c..943cdef 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -79,6 +79,16 @@ config COMPILER_LLVM_CLANG
endchoice
+config ANY_TOOLCHAIN
+ bool "Allow building with any toolchain"
+ default n
+ depends on COMPILER_GCC
+ help
+ Many toolchains break when building coreboot since it uses quite
+ unusual linker features. Unless developers explicitely request it,
+ we'll have to assume that they use their distro compiler by mistake.
+ Make sure that using patched compilers is a conscious decision.
+
config SCANBUILD_ENABLE
bool "Build with scan-build for static code analysis"
default n