Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4768
-gerrit
commit 1efbcf461633d43614a401a4a1bc49f81a2d3356
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Jan 21 14:30:51 2014 +0100
libpayload/libc/hexdump.c: Change type of `length` argument to `size_t`
Representing a (non-negative) length with a signed integer is not
optimal, so change its type to `size_t`.
The same change was applied to coreboot’s implementation of `hexdump()`
in commit “lib/hexdump: Take const void * and size_t as arguments”
(3dd0e72d) [1].
[1] http://review.coreboot.org/4575
Change-Id: Ic0c2b7e081ba32d917409568ee53007d9ab7f8f3
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/include/libpayload.h | 2 +-
payloads/libpayload/libc/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index 10a4505..8a0d915 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -294,7 +294,7 @@ long int labs(long int j);
long long int llabs(long long int j);
u8 bin2hex(u8 b);
u8 hex2bin(u8 h);
-void hexdump(void *memory, int length);
+void hexdump(void *memory, size_t length);
void fatal(const char *msg) __attribute__ ((noreturn));
/** @} */
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index 814adf2..e33a306 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -29,7 +29,7 @@
#include <libpayload.h>
-void hexdump(void *memory, int length)
+void hexdump(void *memory, size_t length)
{
int i;
uint8_t *m;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767
-gerrit
commit 3c408b345efc9a1f4829f8a1ac18290ff2af888c
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Jan 21 12:08:18 2014 +0100
libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument
Address the following warning by using the correct conversion specifier.
CC libc/hexdump.libc.o
libc/hexdump.c: In function 'hexdump':
libc/hexdump.c:52:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'void *' [-Wformat]
Also remove the zero padding as that results in the warning below.
CC libc/hexdump.libc.o
libc/hexdump.c: In function 'hexdump':
libc/hexdump.c:52:4: warning: '0' flag used with '%p' gnu_printf format [-Wformat]
Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/libc/hexdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index e4aa8b9..814adf2 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -49,7 +49,7 @@ void hexdump(void *memory, int length)
}
if (all_zero < 2) {
- printf("%08lx:", memory + i);
+ printf("%8p:", memory + i);
for (j = 0; j < 16; j++)
printf(" %02x", m[i + j]);
printf(" ");
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767
-gerrit
commit 5627b6f46ce5fd6af5f854e540af4aa25282030b
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Jan 21 12:08:18 2014 +0100
payloads/libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument
Address the following warning by using the correct conversion specifier.
CC libc/hexdump.libc.o
libc/hexdump.c: In function 'hexdump':
libc/hexdump.c:52:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'void *' [-Wformat]
Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/libc/hexdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index e4aa8b9..8d7ebfd 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -49,7 +49,7 @@ void hexdump(void *memory, int length)
}
if (all_zero < 2) {
- printf("%08lx:", memory + i);
+ printf("%08p:", memory + i);
for (j = 0; j < 16; j++)
printf(" %02x", m[i + j]);
printf(" ");
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4767
-gerrit
commit b40702c13e28db2b60f2771e545edcd2f9c022ee
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Jan 21 12:08:18 2014 +0100
payloads/libpayload/libc/hexdump.c: Use `p` as conversion specifier for void * pointer argument
Address the following warning by using the correct conversion specifier.
CC libc/hexdump.libc.o
libc/hexdump.c: In function 'hexdump':
libc/hexdump.c:52:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'void *' [-Wformat]
Change-Id: Ie5c279ef90bd9ed5e2624bf852dcff1f06531a13
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/libc/hexdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index e4aa8b9..b652b41 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -49,7 +49,7 @@ void hexdump(void *memory, int length)
}
if (all_zero < 2) {
- printf("%08lx:", memory + i);
+ printf("%p:", memory + i);
for (j = 0; j < 16; j++)
printf(" %02x", m[i + j]);
printf(" ");
Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4766
-gerrit
commit c286253237e7332e742a1ab3988e1ca0a43cc09f
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Mon Jan 20 20:22:19 2014 -0600
board_info.txt: Add ROM information for google butterfly
Change-Id: I7d973ef41c4f2973e71015ec292ae88faaeb5840
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
---
src/mainboard/google/butterfly/board_info.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mainboard/google/butterfly/board_info.txt b/src/mainboard/google/butterfly/board_info.txt
index 4dd467c..dccfeeb 100644
--- a/src/mainboard/google/butterfly/board_info.txt
+++ b/src/mainboard/google/butterfly/board_info.txt
@@ -1,4 +1,7 @@
Board name: Pavilion Chromebook 14
Category: laptop
Board URL: http://h10025.www1.hp.com/ewfrf/wc/product?product=5389124&cc=us&dlc=en&lc=…
+ROM package: SOIC-8
ROM protocol: SPI
+ROM socketed: n
+Flashrom support: y
the following patch was just integrated into master:
commit 4bdd5b18c14ec05c8af8982c9233e4534dcb802f
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Tue Jan 21 02:39:46 2014 +0100
board_status.sh: Replace [[ with [.
[[ is a bashism.
Change-Id: Ief7c43fc1740db32ed97850a415b0c256b5bb35a
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
See http://review.coreboot.org/4764 for details.
-gerrit
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4765
-gerrit
commit a74dd04aa37151c9f4e794860187e0539f8e1277
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Tue Jan 21 03:09:14 2014 +0100
asrock/e350m1/board_info.txt: Specify ROM socket and Flashrom support.
Based on info by Kevin O'Connor.
Change-Id: I21d447fec976e0ee967ba64b0f506c97c22917a3
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/mainboard/asrock/e350m1/board_info.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mainboard/asrock/e350m1/board_info.txt b/src/mainboard/asrock/e350m1/board_info.txt
index 3d30b13..0e2b80b 100644
--- a/src/mainboard/asrock/e350m1/board_info.txt
+++ b/src/mainboard/asrock/e350m1/board_info.txt
@@ -2,3 +2,5 @@ Category: mini
Board URL: http://www.asrock.com/mb/overview.asp?Model=E350M1
ROM package: DIP8
ROM protocol: SPI
+ROM socketed: y
+Flashrom support: y
Alexandru Gagniuc (mr.nuke.me(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4763
-gerrit
commit 50963258c3086c535cc5deab2a198d7b86209a12
Author: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
Date: Mon Jan 20 18:04:14 2014 -0600
nb/sandybridge: Move MRC cache above mrc.bin
This small change greatly reduces CBFS fragmentation. There is now a
small gap of only 788 bytes between mrc.bin and mrc.cache, with the
64 KiB alignment maintained for mrc.cache -- assuming systemagent-r6
is used. The gap was just under 64 KiB before.
With this change, it is easier to accommodate fallback and normal
boot stages without having to manually place the stages in the highly
fragmented CBFS.
Change-Id: Ia2340c1928ed6e232949e053d1943c2f5737f741
Signed-off-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
---
src/northbridge/intel/sandybridge/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/northbridge/intel/sandybridge/Makefile.inc b/src/northbridge/intel/sandybridge/Makefile.inc
index 37d392f..cef52b2 100644
--- a/src/northbridge/intel/sandybridge/Makefile.inc
+++ b/src/northbridge/intel/sandybridge/Makefile.inc
@@ -47,7 +47,7 @@ $(obj)/mrc.cache:
cbfs-files-$(CONFIG_HAVE_MRC_CACHE) += mrc.cache
mrc.cache-file := $(obj)/mrc.cache
-mrc.cache-position := 0xfff80000
+mrc.cache-position := 0xfffd0000
mrc.cache-type := 0xac
$(obj)/northbridge/intel/sandybridge/acpi.ramstage.o : $(obj)/build.h