coreboot-gerrit August 2013

coreboot-gerrit@coreboot.org

1 participants
247 discussions

Patch merged into coreboot/master: 59c3a06 AMD AGESA: Remove INVD instruction when transitioning from CAR
by gerrit＠coreboot.org 16 Aug '13

16 Aug '13

the following patch was just integrated into master: commit 59c3a0615498b6fa79bb4152deab7e837f7ed389 Author: Bruce Griffith <bruce.griffith(a)se-eng.com> Date: Mon Aug 12 01:53:13 2013 -0600 AMD AGESA: Remove INVD instruction when transitioning from CAR The AMD AGESA function to move the stack from cache-as-ram to actual RAM doesn't need any help. The current implementation has an INVD instruction just before cache-as-RAM is torn down. It isn't needed for Trinity processors and makes Kabini boot unreliable. Change-Id: Ibe9e4105eee032471ccbb2d537471d5fa5847d22 Signed-off-by: Bruce Griffith <bruce.griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3852 Tested-by: build bot (Jenkins) Reviewed-by: Siyuan Wang <wangsiyuanbuaa(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> See http://review.coreboot.org/3852 for details. -gerrit

1 0

Patch merged into coreboot/master: 540d8ea kontron/ktqm77: Update MRC path
by gerrit＠coreboot.org 16 Aug '13

16 Aug '13

the following patch was just integrated into master: commit 540d8eaac975e1036ebc269df89316c705efbd3c Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Thu Aug 15 14:43:13 2013 +0200 kontron/ktqm77: Update MRC path It still pointed to the old binary despite implementing the newer interface Change-Id: Iebd5dae98168f5568f3ad6a18c5ebde9abc3ece0 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/3869 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/3869 for details. -gerrit

1 0

Patch merged into coreboot/master: 3f34fc4 emulation/qemu-i440fx: style cleanup
by gerrit＠coreboot.org 16 Aug '13

16 Aug '13

the following patch was just integrated into master: commit 3f34fc4bf37b6f25fa2af4ede3b870c4841a04b6 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Thu Aug 15 20:41:15 2013 +0200 emulation/qemu-i440fx: style cleanup Drop unused and commented out variable, and fix a comment while at it. Change-Id: I1bd7d10aca949c8579433ea1c91264fd816a3fb4 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/3873 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/3873 for details. -gerrit

1 0

Patch merged into coreboot/master: 1e44c3f Fix lint-stable target
by gerrit＠coreboot.org 16 Aug '13

16 Aug '13

the following patch was just integrated into master: commit 1e44c3ff5a08322afba3f52f5d9d88fb0ede9027 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri Aug 16 10:14:38 2013 +0200 Fix lint-stable target SEABIOS_PS2_TIMEOUT needs a default, otherwise the "allyesconfig" target hangs in an endless loop. The given default is correctly overridden by the (currently sole) user, the lenovo/x60 target. Change-Id: I3f5e347c29ccbb4d711a489d067b6c909f030bd0 Reported-by: Kyösti Mälkki Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/3874 Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/3874 for details. -gerrit

1 0

Patch set updated for coreboot: 218020f usbdebug: Do not support logging from SMM
by Kyösti Mälkki 16 Aug '13

16 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3858 -gerrit commit 218020f417bae164b9a66964776c779cddbbc6c0 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Tue Aug 13 21:51:53 2013 +0300 usbdebug: Do not support logging from SMM Letting SMI handler touch EHCI controller is an excellent source of USB problems. Remove usbdebug entirely from SMM. It may be possible to make usbdebug console work from SMM after hard work and coordination with payloads and even OS drivers. But we are not there. Change-Id: Id50586758ee06e8d76e682dc6f64f756ab5b79f5 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/cpu/x86/smm/smiutil.c | 6 ------ src/lib/Makefile.inc | 1 - src/southbridge/amd/sb600/Makefile.inc | 1 - src/southbridge/amd/sb700/Makefile.inc | 1 - src/southbridge/amd/sb800/Makefile.inc | 1 - src/southbridge/intel/common/Makefile.inc | 1 - src/southbridge/nvidia/ck804/Makefile.inc | 1 - src/southbridge/nvidia/mcp55/Makefile.inc | 1 - src/southbridge/sis/sis966/Makefile.inc | 1 - 9 files changed, 14 deletions(-) diff --git a/src/cpu/x86/smm/smiutil.c b/src/cpu/x86/smm/smiutil.c index c13b452..13ee12e 100644 --- a/src/cpu/x86/smm/smiutil.c +++ b/src/cpu/x86/smm/smiutil.c @@ -31,9 +31,6 @@ static u32 serial8250mem_base_address = 0; void console_tx_flush(void) { -#if CONFIG_USBDEBUG - usbdebug_tx_flush(0); -#endif } void console_tx_byte(unsigned char byte) @@ -48,9 +45,6 @@ void console_tx_byte(unsigned char byte) #if CONFIG_CONSOLE_SERIAL8250 uart8250_tx_byte(CONFIG_TTYS0_BASE, byte); #endif -#if CONFIG_USBDEBUG - usbdebug_tx_byte(0, byte); -#endif #if CONFIG_CONSOLE_NE2K ne2k_append_data(&byte, 1, CONFIG_CONSOLE_NE2K_IO_PORT); #endif diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index c421038..b378e83 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -128,7 +128,6 @@ endif smm-y += cbfs.c memcmp.c smm-$(CONFIG_CONSOLE_SERIAL8250) += uart8250.c smm-$(CONFIG_CONSOLE_SERIAL8250MEM) += uart8250mem.c -smm-$(CONFIG_USBDEBUG) += usbdebug.c smm-y += gcc.c $(obj)/lib/version.ramstage.o : $(obj)/build.h diff --git a/src/southbridge/amd/sb600/Makefile.inc b/src/southbridge/amd/sb600/Makefile.inc index 57ef4de..d0df57c 100644 --- a/src/southbridge/amd/sb600/Makefile.inc +++ b/src/southbridge/amd/sb600/Makefile.inc @@ -10,4 +10,3 @@ ramstage-y += pci.c ramstage-y += reset.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c diff --git a/src/southbridge/amd/sb700/Makefile.inc b/src/southbridge/amd/sb700/Makefile.inc index 6f699f0..b457e4a 100644 --- a/src/southbridge/amd/sb700/Makefile.inc +++ b/src/southbridge/amd/sb700/Makefile.inc @@ -12,7 +12,6 @@ romstage-y += reset.c ramstage-y += reset.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c romstage-y += early_setup.c romstage-y += smbus.c diff --git a/src/southbridge/amd/sb800/Makefile.inc b/src/southbridge/amd/sb800/Makefile.inc index 3e7bf11..1253b39 100644 --- a/src/southbridge/amd/sb800/Makefile.inc +++ b/src/southbridge/amd/sb800/Makefile.inc @@ -11,4 +11,3 @@ ramstage-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c ramstage-y += reset.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c diff --git a/src/southbridge/intel/common/Makefile.inc b/src/southbridge/intel/common/Makefile.inc index 06fa416..91b6380 100644 --- a/src/southbridge/intel/common/Makefile.inc +++ b/src/southbridge/intel/common/Makefile.inc @@ -19,4 +19,3 @@ romstage-$(CONFIG_USBDEBUG) += usb_debug.c ramstage-$(CONFIG_USBDEBUG) += usb_debug.c -smm-$(CONFIG_USBDEBUG) += usb_debug.c diff --git a/src/southbridge/nvidia/ck804/Makefile.inc b/src/southbridge/nvidia/ck804/Makefile.inc index bfafa23..0e57f20 100644 --- a/src/southbridge/nvidia/ck804/Makefile.inc +++ b/src/southbridge/nvidia/ck804/Makefile.inc @@ -17,7 +17,6 @@ ramstage-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c romstage-y += early_smbus.c chipset_bootblock_inc += $(src)/southbridge/nvidia/ck804/romstrap.inc diff --git a/src/southbridge/nvidia/mcp55/Makefile.inc b/src/southbridge/nvidia/mcp55/Makefile.inc index b20804a..e11fc78 100644 --- a/src/southbridge/nvidia/mcp55/Makefile.inc +++ b/src/southbridge/nvidia/mcp55/Makefile.inc @@ -17,7 +17,6 @@ ramstage-y += reset.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c chipset_bootblock_inc += $(src)/southbridge/nvidia/mcp55/romstrap.inc chipset_bootblock_lds += $(src)/southbridge/nvidia/mcp55/romstrap.lds diff --git a/src/southbridge/sis/sis966/Makefile.inc b/src/southbridge/sis/sis966/Makefile.inc index b25aa9e..1555973 100644 --- a/src/southbridge/sis/sis966/Makefile.inc +++ b/src/southbridge/sis/sis966/Makefile.inc @@ -12,7 +12,6 @@ ramstage-y += reset.c romstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c ramstage-$(CONFIG_USBDEBUG) += enable_usbdebug.c -smm-$(CONFIG_USBDEBUG) += enable_usbdebug.c chipset_bootblock_inc += $(src)/southbridge/sis/sis966/romstrap.inc chipset_bootblock_lds += $(src)/southbridge/sis/sis966/romstrap.lds

1 0

New patch to review for coreboot: 0518bbf Fix lint-stable target
by Patrick Georgi 16 Aug '13

16 Aug '13

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3874 -gerrit commit 0518bbf23b9fd0f481957687371005884a7b8d27 Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri Aug 16 10:14:38 2013 +0200 Fix lint-stable target SEABIOS_PS2_TIMEOUT needs a default, otherwise the "allyesconfig" target hangs in an endless loop. The given default is correctly overridden by the (currently sole) user, the lenovo/x60 target. Change-Id: I3f5e347c29ccbb4d711a489d067b6c909f030bd0 Reported-by: Kyösti Mälkki Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- src/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Kconfig b/src/Kconfig index a3d572a..515c618 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -586,6 +586,7 @@ endchoice config SEABIOS_PS2_TIMEOUT prompt "PS/2 keyboard controller initialization timeout (milliseconds)" if PAYLOAD_SEABIOS + default 0 depends on EXPERT int help

1 0

Patch merged into coreboot/master: 361cd81 console: Squelch console output from AP CPUs in romstage
by gerrit＠coreboot.org 16 Aug '13

16 Aug '13

the following patch was just integrated into master: commit 361cd8153d3426f2ba4f65ccb396e8e20e738068 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Mon Aug 12 23:29:57 2013 +0300 console: Squelch console output from AP CPUs in romstage Add Kconfig option SQUELCH_EARLY_SMP and have it enabled by default. Console drivers have unpredictable results if multiple threads attempt to share same resources without spinlock. Serial UARTs have not had huge problems, only distorted output, but those relying on cache-as-ram (CBMEM and usbdebug) may require this. Change-Id: I7f406fdea7b6dc6a341c4da2fab56f7b7ff568b4 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3854 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Aaron Durbin <adurbin(a)google.com> See http://review.coreboot.org/3854 for details. -gerrit

1 0

Patch set updated for coreboot: afc6692 Correct spelling of »shadow«, »setting« and »memory«
by Patrick Georgi 15 Aug '13

15 Aug '13

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3768 -gerrit commit afc6692d1207633fa333080752a248587f4dac22 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sun Jul 14 00:24:31 2013 +0200 Correct spelling of »shadow«, »setting« and »memory« Change-Id: Ic7d793754a8b59623b49b7a88c09b5c6b6ef2cf0 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/advansus/a785e-i/dsdt.asl | 2 +- src/mainboard/amd/bimini_fam10/dsdt.asl | 2 +- src/mainboard/amd/dbm690t/dsdt.asl | 2 +- src/mainboard/amd/mahogany/dsdt.asl | 2 +- src/mainboard/amd/mahogany_fam10/dsdt.asl | 2 +- src/mainboard/amd/pistachio/dsdt.asl | 2 +- src/mainboard/amd/tilapia_fam10/dsdt.asl | 2 +- src/mainboard/asrock/e350m1/acpi/smbus.asl | 2 +- src/mainboard/asus/m4a78-em/dsdt.asl | 2 +- src/mainboard/asus/m4a785-m/dsdt.asl | 2 +- src/mainboard/asus/m4a785t-m/dsdt.asl | 2 +- src/mainboard/asus/m5a88-v/dsdt.asl | 2 +- src/mainboard/avalue/eax-785e/dsdt.asl | 2 +- src/mainboard/gigabyte/ma785gm/dsdt.asl | 2 +- src/mainboard/gigabyte/ma785gmt/dsdt.asl | 2 +- src/mainboard/gigabyte/ma78gm/dsdt.asl | 2 +- src/mainboard/iei/kino-780am2-fam10/dsdt.asl | 2 +- src/mainboard/jetway/pa78vm5/dsdt.asl | 2 +- src/mainboard/kontron/kt690/dsdt.asl | 2 +- src/mainboard/lippert/frontrunner-af/dsdt.asl | 2 +- src/mainboard/lippert/toucan-af/dsdt.asl | 2 +- src/mainboard/siemens/sitemp_g1p1/dsdt.asl | 2 +- src/mainboard/supermicro/h8qgi/dsdt.asl | 2 +- src/mainboard/supermicro/h8scm/dsdt.asl | 2 +- src/mainboard/supermicro/h8scm_fam10/dsdt.asl | 2 +- src/mainboard/technexion/tim5690/dsdt.asl | 2 +- src/mainboard/technexion/tim8690/dsdt.asl | 2 +- src/mainboard/tyan/s8226/dsdt.asl | 2 +- src/northbridge/via/vx800/examples/romstage.c | 2 +- src/southbridge/amd/amd8111/nic.c | 2 +- src/southbridge/amd/cimx/sb800/acpi/smbus.asl | 2 +- src/vendorcode/google/chromeos/vboot_loader.c | 2 +- util/cbfstool/cbfs_image.c | 2 +- 33 files changed, 33 insertions(+), 33 deletions(-) diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl index 7f83bf1..94757b5 100644 --- a/src/mainboard/advansus/a785e-i/dsdt.asl +++ b/src/mainboard/advansus/a785e-i/dsdt.asl @@ -1668,7 +1668,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/bimini_fam10/dsdt.asl b/src/mainboard/amd/bimini_fam10/dsdt.asl index 6642680..03a00e0 100644 --- a/src/mainboard/amd/bimini_fam10/dsdt.asl +++ b/src/mainboard/amd/bimini_fam10/dsdt.asl @@ -1668,7 +1668,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/dbm690t/dsdt.asl b/src/mainboard/amd/dbm690t/dsdt.asl index d5eddfc..32df673 100644 --- a/src/mainboard/amd/dbm690t/dsdt.asl +++ b/src/mainboard/amd/dbm690t/dsdt.asl @@ -1637,7 +1637,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl index 8de013f..01cb8dd 100644 --- a/src/mainboard/amd/mahogany/dsdt.asl +++ b/src/mainboard/amd/mahogany/dsdt.asl @@ -1653,7 +1653,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl index 94e1635..f55480d 100644 --- a/src/mainboard/amd/mahogany_fam10/dsdt.asl +++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl @@ -1713,7 +1713,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/pistachio/dsdt.asl b/src/mainboard/amd/pistachio/dsdt.asl index 060b6e3..3e5ba54 100644 --- a/src/mainboard/amd/pistachio/dsdt.asl +++ b/src/mainboard/amd/pistachio/dsdt.asl @@ -1565,7 +1565,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl index ed0c4c2..e6816b0 100644 --- a/src/mainboard/amd/tilapia_fam10/dsdt.asl +++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl @@ -1716,7 +1716,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/asrock/e350m1/acpi/smbus.asl b/src/mainboard/asrock/e350m1/acpi/smbus.asl index e4ccfe3..ebf7ddb 100644 --- a/src/mainboard/asrock/e350m1/acpi/smbus.asl +++ b/src/mainboard/asrock/e350m1/acpi/smbus.asl @@ -30,7 +30,7 @@ OperationRegion (SMB0, SystemIO, 0xB00, 0x0C) DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl index c6b04d2..a844640 100644 --- a/src/mainboard/asus/m4a78-em/dsdt.asl +++ b/src/mainboard/asus/m4a78-em/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl index c6b04d2..a844640 100644 --- a/src/mainboard/asus/m4a785-m/dsdt.asl +++ b/src/mainboard/asus/m4a785-m/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl index c0835c4..5449d01 100644 --- a/src/mainboard/asus/m4a785t-m/dsdt.asl +++ b/src/mainboard/asus/m4a785t-m/dsdt.asl @@ -1618,7 +1618,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/asus/m5a88-v/dsdt.asl b/src/mainboard/asus/m5a88-v/dsdt.asl index 11684c4..6e1ccd1 100644 --- a/src/mainboard/asus/m5a88-v/dsdt.asl +++ b/src/mainboard/asus/m5a88-v/dsdt.asl @@ -1668,7 +1668,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/avalue/eax-785e/dsdt.asl b/src/mainboard/avalue/eax-785e/dsdt.asl index 672af6f..dd766f7 100644 --- a/src/mainboard/avalue/eax-785e/dsdt.asl +++ b/src/mainboard/avalue/eax-785e/dsdt.asl @@ -1668,7 +1668,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl index 5b9359f..faf2171 100644 --- a/src/mainboard/gigabyte/ma785gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index 5b9359f..faf2171 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl index 5b9359f..faf2171 100644 --- a/src/mainboard/gigabyte/ma78gm/dsdt.asl +++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl index 26c9024..923a828 100644 --- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl +++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl @@ -1713,7 +1713,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl index edbd2e5..848d43e 100644 --- a/src/mainboard/jetway/pa78vm5/dsdt.asl +++ b/src/mainboard/jetway/pa78vm5/dsdt.asl @@ -1695,7 +1695,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/kontron/kt690/dsdt.asl b/src/mainboard/kontron/kt690/dsdt.asl index 89d8e29..c221e0a 100644 --- a/src/mainboard/kontron/kt690/dsdt.asl +++ b/src/mainboard/kontron/kt690/dsdt.asl @@ -1637,7 +1637,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index b393a61..a02366e 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -1685,7 +1685,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl index 7f6dec3..53e12af 100644 --- a/src/mainboard/lippert/toucan-af/dsdt.asl +++ b/src/mainboard/lippert/toucan-af/dsdt.asl @@ -1684,7 +1684,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl index 9d64e89..7890df7 100644 --- a/src/mainboard/siemens/sitemp_g1p1/dsdt.asl +++ b/src/mainboard/siemens/sitemp_g1p1/dsdt.asl @@ -1222,7 +1222,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "SIEMENS", "SITEMP ", 0x20101005) DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8, /* SMBUS slave data */ SMK1, 8, diff --git a/src/mainboard/supermicro/h8qgi/dsdt.asl b/src/mainboard/supermicro/h8qgi/dsdt.asl index aa889a3..c854067 100644 --- a/src/mainboard/supermicro/h8qgi/dsdt.asl +++ b/src/mainboard/supermicro/h8qgi/dsdt.asl @@ -1638,7 +1638,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/supermicro/h8scm/dsdt.asl b/src/mainboard/supermicro/h8scm/dsdt.asl index 4aef6a2..5e18375 100644 --- a/src/mainboard/supermicro/h8scm/dsdt.asl +++ b/src/mainboard/supermicro/h8scm/dsdt.asl @@ -1649,7 +1649,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl index 6184bde..13e5620 100644 --- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl +++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl @@ -1751,7 +1751,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/technexion/tim5690/dsdt.asl b/src/mainboard/technexion/tim5690/dsdt.asl index 598dca0..20fe2d7 100644 --- a/src/mainboard/technexion/tim5690/dsdt.asl +++ b/src/mainboard/technexion/tim5690/dsdt.asl @@ -1637,7 +1637,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/technexion/tim8690/dsdt.asl b/src/mainboard/technexion/tim8690/dsdt.asl index d24c379..53be887 100644 --- a/src/mainboard/technexion/tim8690/dsdt.asl +++ b/src/mainboard/technexion/tim8690/dsdt.asl @@ -1637,7 +1637,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/mainboard/tyan/s8226/dsdt.asl b/src/mainboard/tyan/s8226/dsdt.asl index 1efb3b5..79bc096 100644 --- a/src/mainboard/tyan/s8226/dsdt.asl +++ b/src/mainboard/tyan/s8226/dsdt.asl @@ -1639,7 +1639,7 @@ DefinitionBlock ( DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/northbridge/via/vx800/examples/romstage.c b/src/northbridge/via/vx800/examples/romstage.c index 7c3fb7a..b629137 100644 --- a/src/northbridge/via/vx800/examples/romstage.c +++ b/src/northbridge/via/vx800/examples/romstage.c @@ -431,7 +431,7 @@ g) Rx73h = 32h if (boot_mode == 3) { /* some idea of Libo.Feng at amd.com in http://www.coreboot.org/pipermail/coreboot/2008-December/043111.html I want move the 1M data, I have to set some MTRRs myself. */ - /* seting mtrr before back memoy save s3 resume time about 0.14 seconds */ + /* setting mtrr before back memory save s3 resume time about 0.14 seconds */ /*because CAR stack use cache, and here to use cache , must be careful, 1 during these mtrr code, must no function call, (after this mtrr, I think it should be ok to use function) 2 before stack switch, no use variable that have value set before this diff --git a/src/southbridge/amd/amd8111/nic.c b/src/southbridge/amd/amd8111/nic.c index 4ab7212..5352705 100644 --- a/src/southbridge/amd/amd8111/nic.c +++ b/src/southbridge/amd/amd8111/nic.c @@ -52,7 +52,7 @@ static void nic_init(struct device *dev) mmio = resource->base; /* Hard Reset PHY */ - printk(BIOS_DEBUG, "Reseting PHY... "); + printk(BIOS_DEBUG, "Resetting PHY... "); if (conf->phy_lowreset) { write32((mmio + CMD3), VAL0 | PHY_RST_POL | RESET_PHY); } else { diff --git a/src/southbridge/amd/cimx/sb800/acpi/smbus.asl b/src/southbridge/amd/cimx/sb800/acpi/smbus.asl index 19ae92b..4055174 100644 --- a/src/southbridge/amd/cimx/sb800/acpi/smbus.asl +++ b/src/southbridge/amd/cimx/sb800/acpi/smbus.asl @@ -30,7 +30,7 @@ OperationRegion (SMB0, SystemIO, 0xB00, 0x0C) DAT1, 8, /* SMBUS data1 */ BLKD, 8, /* SMBUS block data */ SCNT, 8, /* SMBUS slave control */ - SCMD, 8, /* SMBUS shaow cmd */ + SCMD, 8, /* SMBUS shadow cmd */ SEVT, 8, /* SMBUS slave event */ SDAT, 8 /* SMBUS slave data */ } diff --git a/src/vendorcode/google/chromeos/vboot_loader.c b/src/vendorcode/google/chromeos/vboot_loader.c index 10fa52d..cb3b486 100644 --- a/src/vendorcode/google/chromeos/vboot_loader.c +++ b/src/vendorcode/google/chromeos/vboot_loader.c @@ -101,7 +101,7 @@ static void log_msg(const char *fmt, va_list args) static void fatal_error(void) { - printk(BIOS_ERR, "vboot encountered fatal error. Reseting.\n"); + printk(BIOS_ERR, "vboot encountered fatal error. Resetting.\n"); hard_reset(); } diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 44a9fe8..eb9d574 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -395,7 +395,7 @@ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer, cbfs_print_entry_info(image, entry, stderr); // setup new entry - DEBUG("Seting new empty entry.\n"); + DEBUG("Setting new empty entry.\n"); entry = cbfs_find_next_entry(image, entry); new_size = (cbfs_get_entry_addr(image, next) - cbfs_get_entry_addr(image, entry));

1 0

Patch merged into coreboot/master: 7037840 w83627hf/acpi: Move floppy drive enumeration from _INI into _FDE.
by gerrit＠coreboot.org 15 Aug '13

15 Aug '13

the following patch was just integrated into master: commit 7037840ece7ed221990a8e683293408b81a4cfd1 Author: Christoph Grenz <christophg+cb(a)grenz-bonn.de> Date: Thu Jul 4 03:06:26 2013 +0200 w83627hf/acpi: Move floppy drive enumeration from _INI into _FDE. Move the floppy drive enumeration from _INI() and PROB(), which stored the enumeration results into _FDE into _FDE(). _INI is called by any ACPI-capable OS on boot while _FDE is rarely used. So it's better to run the enumeration when requested rather than unconditionally. Change-Id: Icf1e2a551806592faa8ba8d80fa8d02681602007 Signed-off-by: Christoph Grenz <christophg+cb(a)grenz-bonn.de> Reviewed-on: http://review.coreboot.org/3604 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/3604 for details. -gerrit

1 0

Patch merged into coreboot/master: bbf0969 w83627hf/acpi: Make `AddressMax` a multiple of `AddressAlignment`
by gerrit＠coreboot.org 15 Aug '13

15 Aug '13

the following patch was just integrated into master: commit bbf096911d8fefa86120230c97131efb8dd53244 Author: Christoph Grenz <christophg+cb(a)grenz-bonn.de> Date: Sat Jul 6 17:09:39 2013 +0200 w83627hf/acpi: Make `AddressMax` a multiple of `AddressAlignment` The parallel port of the W83627HF can be configured on any port between 0x100 and 0xFFC with 4 byte alignment for traditional modes and 8 byte alignment for EPP mode. As the ACPI specification says that the maximum acceptable starting address has to be a multiple of the alignment granularity, correct the maximum starting address from 0xFFC to 0xFF8. Change-Id: I272e09d091149791f2867b1d06e4fc27bc1bb2cd Signed-off-by: Christoph Grenz <christophg+cb(a)grenz-bonn.de> Reviewed-on: http://review.coreboot.org/2942 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/2942 for details. -gerrit

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2013