coreboot-gerrit August 2013

coreboot-gerrit@coreboot.org

1 participants
247 discussions

Patch set updated for coreboot: 9f9f271 usbdebug: Use CAR migration
by Kyösti Mälkki 23 Aug '13

23 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3476 -gerrit commit 9f9f2716ff4dc76165a696dae0bfb6fe6e03f21c Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sat Jul 6 11:41:21 2013 +0300 usbdebug: Use CAR migration If we already initialized EHCI controller and USB device in romstage, locate active configuration from salvaged CAR_GLOBAL and avoid doing the hardware initialisation again. Change-Id: I7cb3a359488b25abc9de49c96c0197f6563a4a2c Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/include/cbmem.h | 1 + src/lib/cbmem_info.c | 1 + src/lib/usbdebug.c | 36 ++++++++++++++++++++++++++++++++++++ 3 files changed, 38 insertions(+) diff --git a/src/include/cbmem.h b/src/include/cbmem.h index 982a6d8..b241d34 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -70,6 +70,7 @@ #define CBMEM_ID_ROOT 0xff4007ff #define CBMEM_ID_VBOOT_HANDOFF 0x780074f0 #define CBMEM_ID_CAR_GLOBALS 0xcac4e6a3 +#define CBMEM_ID_EHCI_DEBUG 0xe4c1deb9 #define CBMEM_ID_NONE 0x00000000 #define CBMEM_ID_AGESA_RUNTIME 0x41474553 diff --git a/src/lib/cbmem_info.c b/src/lib/cbmem_info.c index 65be67c..a60761f 100644 --- a/src/lib/cbmem_info.c +++ b/src/lib/cbmem_info.c @@ -48,6 +48,7 @@ static struct cbmem_id_to_name { { CBMEM_ID_VBOOT_HANDOFF, "VBOOT " }, { CBMEM_ID_CAR_GLOBALS, "CAR GLOBALS" }, { CBMEM_ID_AGESA_RUNTIME, "AGESA RSVD " }, + { CBMEM_ID_EHCI_DEBUG, "USBDEBUG " }, }; void cbmem_print_entry(int n, u32 id, u64 base, u64 size) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index 4a1228f..0ef7c4d 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -25,6 +25,7 @@ #include <arch/byteorder.h> #include <cpu/x86/car.h> #include <string.h> +#include <cbmem.h> #include <usb_ch9.h> #include <ehci.h> @@ -752,6 +753,37 @@ void pci_ehci_read_resources(struct device *dev) pci_dev_read_resources(dev); } + +#if CONFIG_CAR_MIGRATION +static int get_usbdebug_from_cbmem(struct ehci_debug_info *info) +{ + struct ehci_debug_info *dbg_info_cbmem; + + dbg_info_cbmem = cbmem_find(CBMEM_ID_EHCI_DEBUG); + if (dbg_info_cbmem == NULL) + return -1; + + memcpy(info, dbg_info_cbmem, sizeof (*info)); + printk(BIOS_DEBUG, "EHCI debug port found in CBMEM.\n"); + + return 0; +} +#endif +#endif + +#if CONFIG_CAR_MIGRATION && defined(__PRE_RAM__) +static void migrate_ehci_debug(void) +{ + struct ehci_debug_info *dbg_info = dbgp_ehci_info(); + struct ehci_debug_info *dbg_info_cbmem; + + dbg_info_cbmem = cbmem_add(CBMEM_ID_EHCI_DEBUG, sizeof(*dbg_info)); + if (dbg_info_cbmem == NULL) + return; + + memcpy(dbg_info_cbmem, dbg_info, sizeof(*dbg_info)); +} +CAR_MIGRATE(migrate_ehci_debug); #endif int dbgp_ep_is_active(struct dbgp_pipe *pipe) @@ -773,6 +805,10 @@ int usbdebug_init(void) { struct ehci_debug_info *dbg_info = dbgp_ehci_info(); +#if CONFIG_CAR_MIGRATION && !defined(__PRE_RAM__) && !defined(__SMM__) + if (!get_usbdebug_from_cbmem(dbg_info)) + return 0; +#endif #if defined(__PRE_RAM__) || !CONFIG_EARLY_CONSOLE enable_usbdebug(CONFIG_USBDEBUG_DEFAULT_PORT); #endif

1 0

Patch set updated for coreboot: 0b34de9 usbdebug: Use separate data toggle for each pipe
by Kyösti Mälkki 23 Aug '13

23 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3865 -gerrit commit 0b34de9aeda740ddb26876392a4f7de00227e09c Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sat Aug 10 10:50:38 2013 +0300 usbdebug: Use separate data toggle for each pipe USB defines a mechanism to detect certain cases of lost handshakes using an alternating data sequence number, referred to as data toggling. This patch fixes each pipe to have its own tracking of the data toggle state. Change-Id: I62420bdaeadd0842da3189428a37eeb10c646900 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/lib/usbdebug.c | 45 ++++++++++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index 9e8f42c..aa79088 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -41,6 +41,7 @@ struct dbgp_pipe { u8 devnum; u8 endpoint; + u8 pid; u8 status; u8 bufidx; char buf[8]; @@ -69,10 +70,6 @@ static int dbgp_enabled(void); #define USB_DEBUG_DEVNUM 127 -#define DBGP_DATA_TOGGLE 0x8800 -#define DBGP_PID_UPDATE(x, tok) \ - ((((x) ^ DBGP_DATA_TOGGLE) & 0xffff00) | ((tok) & 0xff)) - #define DBGP_LEN_UPDATE(x, len) (((x) & ~0x0f) | ((len) & 0x0f)) /* * USB Packet IDs (PIDs) @@ -154,14 +151,15 @@ static void dbgp_breath(void) static int dbgp_wait_until_done(struct ehci_dbg_port *ehci_debug, struct dbgp_pipe *pipe, unsigned ctrl, int loop) { - u32 pids, lpid; + u32 rd_ctrl, rd_pids; + u8 lpid; int ret; retry: write32((unsigned long)&ehci_debug->control, ctrl | DBGP_GO); ret = dbgp_wait_until_complete(ehci_debug); - pids = read32((unsigned long)&ehci_debug->pids); - lpid = DBGP_PID_GET(pids); + rd_ctrl = read32((unsigned long)&ehci_debug->control); + rd_pids = read32((unsigned long)&ehci_debug->pids); if (ret < 0) { if (ret == -DBGP_ERR_BAD && --loop > 0) @@ -169,16 +167,29 @@ retry: return ret; } + lpid = DBGP_PID_GET(rd_pids); + + /* If I get an ACK or in-sync DATA PID, we are done. */ + if ((lpid == USB_PID_ACK) || (lpid == pipe->pid)) { + if (DBGP_LEN(rd_ctrl)) + pipe->pid ^= USB_PID_DATA_TOGGLE; + } + /* If the port is getting full or it has dropped data * start pacing ourselves, not necessary but it's friendly. */ - if ((lpid == USB_PID_NAK) || (lpid == USB_PID_NYET)) + else if (lpid == USB_PID_NYET) { dbgp_breath(); + if (--loop > 0) + goto retry; + ret = -DBGP_ERR_BAD; + } - /* If I get a NACK reissue the transmission */ - if (lpid == USB_PID_NAK) { + /* If I get a NACK or out-of-sync DATA PID, reissue the transmission. */ + else if ((lpid == USB_PID_NAK) || (lpid == (pipe->pid ^ USB_PID_DATA_TOGGLE))) { if (--loop > 0) goto retry; + ret = -DBGP_ERR_BAD; } return ret; @@ -223,14 +234,11 @@ static int dbgp_bulk_write(struct ehci_dbg_port *ehci_debug, struct dbgp_pipe *p return -1; addr = DBGP_EPADDR(pipe->devnum, pipe->endpoint); - - pids = read32((unsigned long)&ehci_debug->pids); - pids = DBGP_PID_UPDATE(pids, USB_PID_OUT); + pids = DBGP_PID_SET(pipe->pid, USB_PID_OUT); ctrl = read32((unsigned long)&ehci_debug->control); ctrl = DBGP_LEN_UPDATE(ctrl, size); ctrl |= DBGP_OUT; - ctrl |= DBGP_GO; dbgp_set_data(ehci_debug, bytes, size); write32((unsigned long)&ehci_debug->address, addr); @@ -257,14 +265,11 @@ static int dbgp_bulk_read(struct ehci_dbg_port *ehci_debug, struct dbgp_pipe *pi return -1; addr = DBGP_EPADDR(pipe->devnum, pipe->endpoint); - - pids = read32((unsigned long)&ehci_debug->pids); - pids = DBGP_PID_UPDATE(pids, USB_PID_IN); + pids = DBGP_PID_SET(pipe->pid, USB_PID_IN); ctrl = read32((unsigned long)&ehci_debug->control); ctrl = DBGP_LEN_UPDATE(ctrl, size); ctrl &= ~DBGP_OUT; - ctrl |= DBGP_GO; write32((unsigned long)&ehci_debug->address, addr); write32((unsigned long)&ehci_debug->pids, pids); @@ -317,8 +322,9 @@ static int dbgp_control_msg(struct ehci_dbg_port *ehci_debug, unsigned devnum, i pipe->devnum = devnum; pipe->endpoint = 0; + pipe->pid = USB_PID_DATA0; addr = DBGP_EPADDR(pipe->devnum, pipe->endpoint); - pids = DBGP_PID_SET(USB_PID_DATA0, USB_PID_SETUP); + pids = DBGP_PID_SET(pipe->pid, USB_PID_SETUP); ctrl = read32((unsigned long)&ehci_debug->control); ctrl = DBGP_LEN_UPDATE(ctrl, sizeof(req)); @@ -594,6 +600,7 @@ debug_dev_found: /* Prepare endpoint pipes. */ for (i=1; i<DBGP_MAX_ENDPOINTS; i++) { info->ep_pipe[i].devnum = USB_DEBUG_DEVNUM; + info->ep_pipe[i].pid = USB_PID_DATA0; } info->ep_pipe[DBGP_CONSOLE_EPOUT].endpoint = dbgp_desc.bDebugOutEndpoint; info->ep_pipe[DBGP_CONSOLE_EPIN].endpoint = dbgp_desc.bDebugInEndpoint;

1 0

Patch set updated for coreboot: 357b925 usbdebug: Dump low-level protocol details
by Kyösti Mälkki 23 Aug '13

23 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3866 -gerrit commit 357b9254faa1a6dce814432480044b1d8b12be23 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sat Aug 10 10:50:43 2013 +0300 usbdebug: Dump low-level protocol details Dumping these EHCI host controller registers is useful to solve problems with debug devices. Change-Id: I0610cecca57b1b952d4f87211dd00c8c0bc398b9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/lib/usbdebug.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index c42140f..10fc0c5 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -63,10 +63,12 @@ struct ehci_debug_info { }; #if CONFIG_DEBUG_USBDEBUG +static void dbgp_print_data(struct ehci_dbg_port *ehci_debug); static int dbgp_enabled(void); # define dprintk(LEVEL, args...) \ do { if (!dbgp_enabled()) printk(LEVEL, ##args); } while (0) #else +# define dbgp_print_data(x) do {} while(0) # define dprintk(LEVEL, args...) do {} while(0) #endif @@ -136,8 +138,10 @@ static int dbgp_wait_until_complete(struct ehci_dbg_port *ehci_debug) break; } while (++loop < DBGP_MICROFRAME_TIMEOUT_US); - if (! (ctrl & DBGP_DONE)) + if (! (ctrl & DBGP_DONE)) { + dprintk(BIOS_ERR, "dbgp_wait_until_complete: retry timeout.\n"); return -DBGP_ERR_SIGNAL; + } /* Now that we have observed the completed transaction, * clear the done bit. @@ -155,6 +159,7 @@ static int dbgp_wait_until_done(struct ehci_dbg_port *ehci_debug, struct dbgp_pi unsigned ctrl, int timeout_ms) { u32 rd_ctrl, rd_pids; + u32 ctrl_prev = 0, pids_prev = 0; u8 lpid; int ret, host_retries; int loop, max_loop; @@ -172,11 +177,21 @@ device_retry: host_retry: if (host_retries++ >= DBGP_MICROFRAME_RETRIES) return -DBGP_ERR_BAD; + if (loop == 1 || host_retries > 1) + dprintk(BIOS_SPEW, "dbgp: start (@ %3d,%d) ctrl=%08x\n", + loop, host_retries, ctrl | DBGP_GO); write32((unsigned long)&ehci_debug->control, ctrl | DBGP_GO); ret = dbgp_wait_until_complete(ehci_debug); rd_ctrl = read32((unsigned long)&ehci_debug->control); rd_pids = read32((unsigned long)&ehci_debug->pids); + if (rd_ctrl != ctrl_prev || rd_pids != pids_prev || (ret<0)) { + ctrl_prev = rd_ctrl; + pids_prev = rd_pids; + dprintk(BIOS_SPEW, "dbgp: status (@ %3d,%d) ctrl=%08x pids=%08x ret=%d\n", + loop, host_retries, rd_ctrl, rd_pids, ret); + } + /* Controller hardware failure. */ if (ret == -DBGP_ERR_SIGNAL) { return ret; @@ -212,6 +227,8 @@ host_retry: ret = -DBGP_ERR_BAD; } + dbgp_print_data(ehci_debug); + return ret; } @@ -244,6 +261,25 @@ static void dbgp_get_data(struct ehci_dbg_port *ehci_debug, void *buf, int size) bytes[i] = (hi >> (8*(i - 4))) & 0xff; } +#if CONFIG_DEBUG_USBDEBUG +static void dbgp_print_data(struct ehci_dbg_port *ehci_debug) +{ + u32 ctrl = read32((unsigned long)&ehci_debug->control); + u32 lo = read32((unsigned long)&ehci_debug->data03); + u32 hi = read32((unsigned long)&ehci_debug->data47); + int len = DBGP_LEN(ctrl); + if (len) { + int i; + dprintk(BIOS_SPEW, "dbgp: buf:"); + for (i = 0; i < 4 && i < len; i++) + dprintk(BIOS_SPEW, " %02x", (lo >> (8*i)) & 0xff); + for (; i < 8 && i < len; i++) + dprintk(BIOS_SPEW, " %02x", (hi >> (8*(i - 4))) & 0xff); + dprintk(BIOS_SPEW, "\n"); + } +} +#endif + static int dbgp_bulk_write(struct ehci_dbg_port *ehci_debug, struct dbgp_pipe *pipe, const char *bytes, int size) {

1 0

Patch set updated for coreboot: 54f3ded usbdebug: Fix control messages
by Kyösti Mälkki 23 Aug '13

23 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3867 -gerrit commit 54f3ded7f21e97447e4d22d76265b7ecbcf8c47f Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sat Aug 10 10:08:38 2013 +0300 usbdebug: Fix control messages Add support for control messages with a write of data stage. Add status stage after a read of non-zero length data stage. Do not retry control message if device responds with STALL. Change-Id: I16fb9ae39630b975af5461b63d050b9adaccef0f Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/lib/usbdebug.c | 37 +++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index aa79088..60a0aa6 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -192,6 +192,11 @@ retry: ret = -DBGP_ERR_BAD; } + /* Abort on STALL handshake for endpoint 0.*/ + else if ((lpid == USB_PID_STALL) && (pipe->endpoint == 0x0)) { + ret = -DBGP_ERR_BAD; + } + return ret; } @@ -307,10 +312,10 @@ static int dbgp_control_msg(struct ehci_dbg_port *ehci_debug, unsigned devnum, i u32 pids, addr, ctrl; struct usb_ctrlrequest req; int read; - int ret; + int ret, ret2; read = (requesttype & USB_DIR_IN) != 0; - if (size > (read ? DBGP_MAX_PACKET:0)) + if (size > DBGP_MAX_PACKET) return -1; /* Compute the control message */ @@ -329,9 +334,8 @@ static int dbgp_control_msg(struct ehci_dbg_port *ehci_debug, unsigned devnum, i ctrl = read32((unsigned long)&ehci_debug->control); ctrl = DBGP_LEN_UPDATE(ctrl, sizeof(req)); ctrl |= DBGP_OUT; - ctrl |= DBGP_GO; - /* Send the setup message */ + /* Setup stage */ dbgp_set_data(ehci_debug, &req, sizeof(req)); write32((unsigned long)&ehci_debug->address, addr); write32((unsigned long)&ehci_debug->pids, pids); @@ -339,8 +343,29 @@ static int dbgp_control_msg(struct ehci_dbg_port *ehci_debug, unsigned devnum, i if (ret < 0) return ret; - /* Read the result */ - ret = dbgp_bulk_read(ehci_debug, pipe, data, size, DBGP_LOOPS); + /* Data stage (optional) */ + if (read && size) + ret = dbgp_bulk_read(ehci_debug, pipe, data, size, DBGP_LOOPS); + else if (!read && size) + ret = dbgp_bulk_write(ehci_debug, pipe, data, size); + + /* Status stage in opposite direction */ + pipe->pid = USB_PID_DATA1; + ctrl = read32((unsigned long)&ehci_debug->control); + ctrl = DBGP_LEN_UPDATE(ctrl, 0); + if (read) { + pids = DBGP_PID_SET(pipe->pid, USB_PID_OUT); + ctrl |= DBGP_OUT; + } else { + pids = DBGP_PID_SET(pipe->pid, USB_PID_IN); + ctrl &= ~DBGP_OUT; + } + + write32((unsigned long)&ehci_debug->pids, pids); + ret2 = dbgp_wait_until_done(ehci_debug, pipe, ctrl, DBGP_LOOPS); + if (ret2 < 0) + return ret2; + return ret; }

1 0

Patch set updated for coreboot: a5c3efd usbdebug: Add optional quirk for old DIY debug part
by Kyösti Mälkki 23 Aug '13

23 Aug '13

Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3868 -gerrit commit a5c3efdf9898479ec0aa9373375d49114df35656 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 6 10:33:39 2013 +0300 usbdebug: Add optional quirk for old DIY debug part Not sure what this is about. Required for FX2. Change-Id: I86878f8f570911ed1ed3ec844c232ac91e934072 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- src/lib/usbdebug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c index 5c34e3a..8584f2d 100644 --- a/src/lib/usbdebug.c +++ b/src/lib/usbdebug.c @@ -607,10 +607,12 @@ try_next_port: } dprintk(BIOS_INFO, "EHCI debug port enabled.\n"); +#if 0 /* Completely transfer the debug device to the debug controller */ portsc = read32((unsigned long)&ehci_regs->port_status[debug_port - 1]); portsc &= ~PORT_PE; write32((unsigned long)&ehci_regs->port_status[debug_port - 1], portsc); +#endif dbgp_mdelay(100);

1 0

Patch merged into coreboot/master: 16c0145 usbdebug: Halt host controller before resetting it
by gerrit＠coreboot.org 23 Aug '13

23 Aug '13

the following patch was just integrated into master: commit 16c014578b9662bc2a0f099b77410e7ea3a793d1 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Mon Aug 12 15:32:25 2013 +0300 usbdebug: Halt host controller before resetting it Resetting an EHCI controller when it is not halted can have undefined behaviour. This mostly fixes a case where calling usbdebug_init() twice would fail to reset the USB dongle device properly. On amd/persimmon it still requires one extra retry, but at least it is now possible to have usbdebug enabled for both romstage and ramstage. Change-Id: Ib0e6e5a0167404f68af2edf112306fdb8def0be9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3862 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/3862 for details. -gerrit

1 0

Patch merged into coreboot/master: 1cf8577 SPI: Support STMicro partial page write
by gerrit＠coreboot.org 23 Aug '13

23 Aug '13

the following patch was just integrated into master: commit 1cf85774da278229229fb77891326d645176d24d Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Sun Aug 18 12:44:24 2013 +0300 SPI: Support STMicro partial page write Ported from spi/winbond.c. Fixes this error: ICH SPI: Too much to write. Does your SPI chip driver use CONTROLLER_PAGE_LIMIT? Change-Id: I50db8fd1104d3b7d319b278b14f97e3ff9cb6404 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3877 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks <dhendrix(a)chromium.org> See http://review.coreboot.org/3877 for details. -gerrit

1 0

Patch merged into coreboot/master: 93b2bd7 usbdebug: Do not support logging from SMM
by gerrit＠coreboot.org 23 Aug '13

23 Aug '13

the following patch was just integrated into master: commit 93b2bd70ff65a534e91c203c7948deea315675d5 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Tue Aug 13 21:51:53 2013 +0300 usbdebug: Do not support logging from SMM Letting SMI handler touch EHCI controller is an excellent source of USB problems. Remove usbdebug entirely from SMM. It may be possible to make usbdebug console work from SMM after hard work and coordination with payloads and even OS drivers. But we are not there. Change-Id: Id50586758ee06e8d76e682dc6f64f756ab5b79f5 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3858 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/3858 for details. -gerrit

1 0

Patch merged into coreboot/master: 6bfe61d usbdebug: Add compatibility quirk for FX2
by gerrit＠coreboot.org 23 Aug '13

23 Aug '13

the following patch was just integrated into master: commit 6bfe61d5d15d32d307047eeee8493d0e3ffa42ab Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Jun 6 10:33:39 2013 +0300 usbdebug: Add compatibility quirk for FX2 This quirk is needed with a DIY debug dongle using obsolete CY7C68013 (aka FX2) USB chips. Old revision of chip requires a SET_CONFIGURATION to be sent, while this is not required in EHCI debug port specs. Change-Id: I4926eb19b7e991d6efeef782682756571ad006b9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3386 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> See http://review.coreboot.org/3386 for details. -gerrit

1 0

Patch merged into coreboot/master: d799140 usbdebug: Block recursive calls of printk
by gerrit＠coreboot.org 23 Aug '13

23 Aug '13

the following patch was just integrated into master: commit d79914008abbc3eea4738d702ea7f3256e13327a Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Mon Aug 12 16:11:34 2013 +0300 usbdebug: Block recursive calls of printk When we create low-level debugging of EHCI controller registers, we call printk() within printk(). In ramstage this would leave us with deadlock waiting on the console spinlock. Change-Id: Idbe029af9af76de27094bb2964c60d9ccfdd96e6 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/3860 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3860 for details. -gerrit

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2013