Christoph Grenz (christophg+cb(a)grenz-bonn.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3602
-gerrit
commit c37afd8465145fcc7a9ba72759f92c66611bd1da
Author: Christoph Grenz <christophg+cb(a)grenz-bonn.de>
Date: Thu Jul 4 02:51:42 2013 +0200
w83627hf/acpi: Fix endianess error in floppy drive enumeration code
The enumeration results are stored as five DWORDs in one 20 byte buffer.
Bytes 3, 7, 11 and 15 were used to set the lowest bit of each DWORD.
ACPI uses little endian, so 1, 4, 8 and 12 are the correct indices.
Change-Id: I793225cb1bb62fd148ecfa1e61e02f5d7be62cdb
Signed-off-by: Christoph Grenz <christophg+cb(a)grenz-bonn.de>
---
src/superio/winbond/w83627hf/acpi/superio.asl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl
index 03f72f7..05b570b 100644
--- a/src/superio/winbond/w83627hf/acpi/superio.asl
+++ b/src/superio/winbond/w83627hf/acpi/superio.asl
@@ -356,10 +356,10 @@ Device(SIO) {
SIFR, 8
}
- CreateByteField (_FDE, 3, FD1)
- CreateByteField (_FDE, 7, FD2)
- CreateByteField (_FDE, 11, FD3)
- CreateByteField (_FDE, 15, FD4)
+ CreateByteField (_FDE, 1, FD1)
+ CreateByteField (_FDE, 4, FD2)
+ CreateByteField (_FDE, 8, FD3)
+ CreateByteField (_FDE, 12, FD4)
Store(One, ACT1)
Store(0, SELE)
the following patch was just integrated into master:
commit f66dd6966a2df6af8ec4a4018f1538b1166256f7
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Wed Jul 3 12:07:43 2013 +0200
w83627hf/acpi: Fix offset of logical device activation
The PnP's logical device activation normally resides at 0x30. This might
have been overlooked as 0x29 looks very close to 0x30 in human eyes.
Change-Id: Id5d5a92f2683ebe1808b943f686c062151d216da
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Reviewed-on: http://review.coreboot.org/3592
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See http://review.coreboot.org/3592 for details.
-gerrit
the following patch was just integrated into master:
commit 0bd5dff58cb43b307bcb02ac6baa436a525a5025
Author: Christoph Grenz <christophg+cb(a)grenz-bonn.de>
Date: Thu Jul 4 02:54:04 2013 +0200
w83627hf/acpi: Fix type error in floppy drive enumeration code
The enumeration method tried to evaluate an one-byte OperationRegion
instead of a field in this OperationRegion, which resulted in an
AE_TYPE error at runtime.
Indexing the OperationRegion with a single field fixes this error.
Change-Id: I15dd7aa6ecafb3a215d165d2b721003446815025
Signed-off-by: Christoph Grenz <christophg+cb(a)grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/3603
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
See http://review.coreboot.org/3603 for details.
-gerrit