coreboot-gerrit July 2013

coreboot-gerrit@coreboot.org

1 participants
1030 discussions

Patch set updated for coreboot: 4dd83bb cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors
by Ronald G. Minnich 17 Jul '13

17 Jul '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3468 -gerrit commit 4dd83bbe10f5c9469e717187dc7c2310cf4e2164 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Jun 14 23:42:45 2013 +0200 cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors Many CPU families no longer need the double startup IPI. Add CPU_AMD_AGESA as one indicator that it is not needed, as all AMD processors using AGESA – currently Family 10h to 15h – should not need it. Successfully tested on ASRock E350M1 with a Family 14h processor. This is a kludgy approach but it works. Change-Id: Ib310f2e5ab4b463a82bf0fa9fa9141b556cabf60 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/cpu/x86/lapic/lapic_cpu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index fbc8aa4..08cbe96 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -167,7 +167,7 @@ static int lapic_start_cpu(unsigned long apicid) return 0; } -#if !CONFIG_CPU_AMD_MODEL_10XXX +#if !CONFIG_CPU_AMD_MODEL_10XXX && !CONFIG_CPU_AMD_AGESA num_starts = 2; #else num_starts = 1;

1 0

Patch set updated for coreboot: 6e66959 cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors
by Ronald G. Minnich 17 Jul '13

17 Jul '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3468 -gerrit commit 6e669594a15db67c9ee8e2632d05540a8e3bf9e6 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Jun 14 23:42:45 2013 +0200 cpu/x86/lapic/lapic_cpu_init.c: Remove double startup IPI for AMD AGESA processors Many CPU families no longer the double startup IPI. Add CPU_AMD_AGESA as one indicator that it is not needed, as all AMD processors using AGESA – currently Family 10h to 15h – should not need it. Successfully tested on ASRock E350M1 with a Family 14h processor. Change-Id: Ib310f2e5ab4b463a82bf0fa9fa9141b556cabf60 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/cpu/x86/lapic/lapic_cpu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index fbc8aa4..08cbe96 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -167,7 +167,7 @@ static int lapic_start_cpu(unsigned long apicid) return 0; } -#if !CONFIG_CPU_AMD_MODEL_10XXX +#if !CONFIG_CPU_AMD_MODEL_10XXX && !CONFIG_CPU_AMD_AGESA num_starts = 2; #else num_starts = 1;

1 0

Patch set updated for coreboot: da50c40 ec/kontron/it8516e: Add option for external temperature sensor
by Ronald G. Minnich 17 Jul '13

17 Jul '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3772 -gerrit commit da50c401e65745ce3c0342c7979ce00e74623d25 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Jul 12 14:35:00 2013 +0200 ec/kontron/it8516e: Add option for external temperature sensor The IT8516E firmware of Kontron supports some selected external sensors attached to the EC via SMBUS or GPIO16. Change-Id: I4c451c360a393e916430e3bea04a95847455cef7 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- src/ec/kontron/it8516e/chip.h | 10 +++++++--- src/ec/kontron/it8516e/ec.c | 15 +++++++++++++++ src/ec/kontron/it8516e/ec.h | 11 +++++++++++ 3 files changed, 33 insertions(+), 3 deletions(-) diff --git a/src/ec/kontron/it8516e/chip.h b/src/ec/kontron/it8516e/chip.h index dddc5e0..5638efd 100644 --- a/src/ec/kontron/it8516e/chip.h +++ b/src/ec/kontron/it8516e/chip.h @@ -26,10 +26,14 @@ struct ec_kontron_it8516e_config { /* - * Per fan settings - * Can be overwritten by fan1_mode, fan2_mode, fan1_target - * and fan2_target options + * Fan settings (fan1: CPU; fan2: System) + * Can be overwritten by + * systemp_type, + * fan1_mode, fan2_mode, + * fan1_target, and fan2_target + * nvram options. */ + enum it8516e_systemp_types default_systemp; enum it8516e_fan_modes default_fan_mode[2]; u16 default_fan_target[2]; /* PWM: % / Speed: RPM / Thermal: °C */ }; diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c index fa7bbc8..7cf41d9 100644 --- a/src/ec/kontron/it8516e/ec.c +++ b/src/ec/kontron/it8516e/ec.c @@ -30,6 +30,8 @@ typedef struct ec_kontron_it8516e_config config_t; enum { /* EC commands */ + IT8516E_CMD_SET_SYSTEMP_TYPE = 0x06, + IT8516E_CMD_GET_SYSTEMP_TYPE = 0x07, IT8516E_CMD_GET_FAN_MODE = 0x10, IT8516E_CMD_SET_FAN_MODE = 0x11, IT8516E_CMD_GET_FAN_PWM = 0x12, @@ -40,6 +42,13 @@ enum { /* EC commands */ IT8516E_CMD_SET_FAN_TEMP = 0x17, }; +static void it8516e_set_systemp_type(const u8 type) +{ + if (send_ec_command(IT8516E_CMD_SET_SYSTEMP_TYPE)) + return; + send_ec_data(type); +} + static void it8516e_set_fan_mode(const u8 idx, const u8 mode) { if (send_ec_command(IT8516E_CMD_SET_FAN_MODE)) @@ -138,6 +147,12 @@ static void it8516e_pm2_init(const device_t dev) ec_set_ports(find_resource(dev, PNP_IDX_IO1)->base, find_resource(dev, PNP_IDX_IO0)->base); + u8 systemp_type = config->default_systemp; + get_option(&systemp_type, "systemp_type"); + if (systemp_type >= IT8516E_SYSTEMP_LASTPLUSONE) + systemp_type = IT8516E_SYSTEMP_NONE; + it8516e_set_systemp_type(systemp_type); + it8516e_set_fan_from_options(config, 0); it8516e_set_fan_from_options(config, 1); } diff --git a/src/ec/kontron/it8516e/ec.h b/src/ec/kontron/it8516e/ec.h index 5bd2801..b1930e1 100644 --- a/src/ec/kontron/it8516e/ec.h +++ b/src/ec/kontron/it8516e/ec.h @@ -40,4 +40,15 @@ enum it8516e_fan_modes { /* Possible modes of fan control */ IT8516E_MODE_THERMAL = 0x03, }; +enum it8516e_systemp_types { /* Possible sources of system temperature */ + IT8516E_SYSTEMP_NONE = 0x00, + IT8516E_SYSTEMP_AMD = 0x01, + IT8516E_SYSTEMP_LM75_90 = 0x02, + IT8516E_SYSTEMP_GPIO16 = 0x03, + IT8516E_SYSTEMP_LM75_9e = 0x04, + + /* add any new types above this line. */ + IT8516E_SYSTEMP_LASTPLUSONE, +}; + #endif

1 0

Patch merged into coreboot/master: cd24e3f lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String
by gerrit＠coreboot.org 17 Jul '13

17 Jul '13

the following patch was just integrated into master: commit cd24e3f6a7adecfc9d3b2a2dd2f81d84acffa91b Author: Peter Stuge <peter(a)stuge.se> Date: Sat Jul 6 20:10:36 2013 +0200 lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String The Linux thinkpad_acpi.c driver looks for this string while reading information about the system it is running on. This commit does not make the module load but it is one of several things that the module looks for on a ThinkPad. The use of 3 defines for the serial number template seems odd but it's done in a way that eliminates magic numbers, yet avoids use of strcpy, strlen, strindex, strchr, or strspan: we can have some correctness assured at compile time. Also, the defines can be copy/pasted for other mainboards and we should void errors due to people not changing magic numbers. Change-Id: Ief5f28d2e27bf959cb579c4c8eea9eecc9a89a7c Signed-off-by: Peter Stuge <peter(a)stuge.se> Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Reviewed-on: http://review.coreboot.org/3620 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3620 for details. -gerrit

1 0

Patch set updated for coreboot: a2f7ede inteltool/inteltool.c: Prepend hexadecimal values with `0x`
by Paul Menzel 17 Jul '13

17 Jul '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3776 -gerrit commit a2f7ede95fc3215df35ecf6bf2fca6a7d1f2070a Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed Jul 17 14:07:27 2013 +0200 inteltool/inteltool.c: Prepend hexadecimal values with `0x` Currently, it is not clear what base is used in inteltool’s output. $ sudo ./inteltool | grep Model CPU: ID 0x1067a, Processor Type 0, Family 6, Model 17, Stepping a $ grep -i model /proc/cpuinfo model : 23 model name : Pentium(R) Dual-Core CPU E5300 @ 2.60GHz […] To avoid confusion, make it clear, that `inteltool` outputs hexadecimal numbers by prepending it explicitly with `0x`. $ sudo ./inteltool | grep Model CPU: ID 0x1067a, Processor Type 0x0, Family 0x6, Model 0x17, Stepping 0xa The `#` flag in the format string is not used for consistency, as prepending `0x` is already done once in the code. Change-Id: I379e11bfd804e82e2a3c460b1de915a93513bf5f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/inteltool/inteltool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 7d892cb..219d84e 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,7 +374,7 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: ID 0x%x, Processor Type %x, Family %x, Model %x, Stepping %x\n", + printf("CPU: ID 0x%x, Processor Type 0x%x, Family 0x%x, Model 0x%x, Stepping 0x%x\n", id, (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf));

1 0

Patch set updated for coreboot: b58f324 inteltool/inteltool.c: Add CPUID raw model and remove colon
by Paul Menzel 17 Jul '13

17 Jul '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3777 -gerrit commit b58f3245cd31c78f72d162fdb4b48610819ea225 Author: Damien Zammit <damien(a)zamaudio.com> Date: Wed Jul 17 23:59:40 2013 +1000 inteltool/inteltool.c: Add CPUID raw model and remove colon The output now looks like $ sudo ./inteltool CPU: ID 0x1067a, Processor Type 0, Family 6, Model 17, Stepping a […] and is useful for finding out the Intel processor under `src/cpu/intel`. While at it, remove the colon after »Processor Type« too. Change-Id: I1b939ab9466f053c0b86683df145c7d2c8baadb4 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/inteltool/inteltool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 5cd964a..7d892cb 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,8 +374,8 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: Processor Type: %x, Family %x, Model %x, Stepping %x\n", - (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), + printf("CPU: ID 0x%x, Processor Type %x, Family %x, Model %x, Stepping %x\n", + id, (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf)); /* Determine names */

1 0

Patch set updated for coreboot: 24a130b inteltool.c: Add CPUID raw model.
by Damien Zammit 17 Jul '13

17 Jul '13

Damien Zammit (damien(a)zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3777 -gerrit commit 24a130b4e95a4f5dfff5f100af7562ead800b568 Author: Damien Zammit <damien(a)zamaudio.com> Date: Wed Jul 17 23:59:40 2013 +1000 inteltool.c: Add CPUID raw model. Change-Id: I1b939ab9466f053c0b86683df145c7d2c8baadb4 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- util/inteltool/inteltool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 5cd964a..6e705f8 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,8 +374,8 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: Processor Type: %x, Family %x, Model %x, Stepping %x\n", - (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), + printf("CPU: 0x%x : Processor Type: %x, Family %x, Model %x, Stepping %x\n", + id, (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf)); /* Determine names */

1 0

New patch to review for coreboot: e9bcaea Add CPUID raw model and prepend "0x" to hex values.
by Damien Zammit 17 Jul '13

17 Jul '13

Damien Zammit (damien(a)zamaudio.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3777 -gerrit commit e9bcaea1dc5afc8f7ee0b7c05c9576359f1800f4 Author: Damien Zammit <damien(a)zamaudio.com> Date: Wed Jul 17 23:59:40 2013 +1000 Add CPUID raw model and prepend "0x" to hex values. Change-Id: I1b939ab9466f053c0b86683df145c7d2c8baadb4 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- util/inteltool/inteltool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 5cd964a..5e7352a 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,8 +374,8 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: Processor Type: %x, Family %x, Model %x, Stepping %x\n", - (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), + printf("CPU: 0x%x : Processor Type: 0x%x, Family 0x%x, Model 0x%x, Stepping 0x%x\n", + id, (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf)); /* Determine names */

1 0

Patch set updated for coreboot: c6a6b35 inteltool/inteltool.c: Prepend hexadecimal values with `0x`
by Paul Menzel 17 Jul '13

17 Jul '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3776 -gerrit commit c6a6b351696396e36e36cc729acba332f579bc29 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed Jul 17 14:07:27 2013 +0200 inteltool/inteltool.c: Prepend hexadecimal values with `0x` Currently, it is not clear what base is used in inteltool’s output. $ sudo ./inteltool | grep Model CPU: Processor Type: 0, Family 6, Model 17, Stepping a $ grep -i model /proc/cpuinfo model : 23 model name : Pentium(R) Dual-Core CPU E5300 @ 2.60GHz […] To avoid confusion, make it clear, that `inteltool` outputs hexadecimal numbers by prepending it explicitly with `0x`. $ sudo ./inteltool | grep Model CPU: Processor Type: 0x0, Family 0x6, Model 0x17, Stepping 0xa The `#` flag in the format string is not used for consistency, as prepending `0x` is already done once in the code. Change-Id: I379e11bfd804e82e2a3c460b1de915a93513bf5f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/inteltool/inteltool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 5cd964a..9343dbc 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,7 +374,7 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: Processor Type: %x, Family %x, Model %x, Stepping %x\n", + printf("CPU: Processor Type: 0x%x, Family 0x%x, Model 0x%x, Stepping 0x%x\n", (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf));

1 0

New patch to review for coreboot: 55f9c6e inteltool/inteltool.c: Prepend hexadecimal values with `0x`
by Paul Menzel 17 Jul '13

17 Jul '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3776 -gerrit commit 55f9c6e91db754aed3c6007ebc8543c07b5b8a0c Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed Jul 17 14:07:27 2013 +0200 inteltool/inteltool.c: Prepend hexadecimal values with `0x` Currently, it is not clear what base is used in inteltool’s output. $ sudo ./inteltool | grep Model CPU: Processor Type: 0, Family 6, Model 17, Stepping a $ grep -i model /proc/cpuinfo model : 23 model name : Pentium(R) Dual-Core CPU E5300 @ 2.60GHz […] To avoid confusion, make it clear, that `inteltool` outputs hexadecimal numbers by prepending it with `0x` by using the `#` flag in the format string. $ sudo ./inteltool | grep Model CPU: Processor Type: 0, Family 0x6, Model 0x17, Stepping 0xa Change-Id: I379e11bfd804e82e2a3c460b1de915a93513bf5f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- util/inteltool/inteltool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 5cd964a..d4ebe58 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -374,7 +374,7 @@ int main(int argc, char *argv[]) * left-shifted "Extended Model" fields. * http://download.intel.com/design/processor/applnots/24161832.pdf */ - printf("CPU: Processor Type: %x, Family %x, Model %x, Stepping %x\n", + printf("CPU: Processor Type: %#x, Family %#x, Model %#x, Stepping %#x\n", (id >> 12) & 0x3, ((id >> 8) & 0xf) + ((id >> 20) & 0xff), ((id >> 12) & 0xf0) + ((id >> 4) & 0xf), (id & 0xf));

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
103
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2013