the following patch was just integrated into master:
commit c71ac38b1f1b8d89d0a06801c99952e1f4fdb0e4
Author: Peter Stuge <peter(a)stuge.se>
Date: Tue Jul 9 19:37:20 2013 +0200
SMBIOS: Clarify prompts and help texts for Serial and Version Numbers
Change-Id: If1fa39db79eeecbef90c8695143d2fe2adf2f21a
Signed-off-by: Peter Stuge <peter(a)stuge.se>
Reviewed-on: http://review.coreboot.org/3732
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Christian Gmeiner <christian.gmeiner(a)gmail.com>
See http://review.coreboot.org/3732 for details.
-gerrit
Peter Stuge (peter(a)stuge.se) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3779
-gerrit
commit d6a446892724b77553c4372d38f59f451609cb1d
Author: Peter Stuge <peter(a)stuge.se>
Date: Sat Jul 6 20:10:36 2013 +0200
lenovo/x60: Add "IBM ThinkPad Embedded Controller" SMBIOS OEM String
The Linux thinkpad_acpi.c driver looks for this string while
reading information about the system it is running on.
This commit does not make the module load but it is one of
several things that the module looks for on a ThinkPad.
Change-Id: Ia48bbd85ba4d528063695345b0f968d264573341
Signed-off-by: Peter Stuge <peter(a)stuge.se>
---
src/mainboard/lenovo/x60/mainboard.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
index b344ccb..f4c5a34 100644
--- a/src/mainboard/lenovo/x60/mainboard.c
+++ b/src/mainboard/lenovo/x60/mainboard.c
@@ -36,6 +36,7 @@
#include <pc80/mc146818rtc.h>
#include "dock.h"
#include <arch/x86/include/arch/acpigen.h>
+#include <smbios.h>
#include <x86emu/x86emu.h>
#define PANEL INT15_5F35_CL_DISPLAY_DEFAULT
@@ -133,9 +134,24 @@ static void mainboard_init(device_t dev)
}
}
+static int mainboard_smbios_data(device_t dev, int *handle, unsigned long *current)
+{
+ int len;
+ char tpec[] = "IBM ThinkPad Embedded Controller -[ ]-";
+ const char *oem_strings[] = {
+ tpec,
+ };
+
+ h8_build_id_and_function_spec_version(tpec + 35, 17);
+ len = smbios_write_type11(current, (*handle)++, oem_strings, ARRAY_SIZE(oem_strings));
+
+ return len;
+}
+
static void mainboard_enable(device_t dev)
{
dev->ops->init = mainboard_init;
+ dev->ops->get_smbios_data = mainboard_smbios_data;
}
struct chip_operations mainboard_ops = {
Peter Stuge (peter(a)stuge.se) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3732
-gerrit
commit 5c6a0438180dde962afda04e63c5ae4e9262e974
Author: Peter Stuge <peter(a)stuge.se>
Date: Tue Jul 9 19:37:20 2013 +0200
SMBIOS: Clarify prompts and help texts for Serial and Version Numbers
Change-Id: If1fa39db79eeecbef90c8695143d2fe2adf2f21a
Signed-off-by: Peter Stuge <peter(a)stuge.se>
---
src/mainboard/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig
index a8cf362..fdb0eac 100644
--- a/src/mainboard/Kconfig
+++ b/src/mainboard/Kconfig
@@ -335,18 +335,18 @@ config ENABLE_POWER_BUTTON
def_bool n if !POWER_BUTTON_IS_OPTIONAL && POWER_BUTTON_FORCE_DISABLE
config MAINBOARD_SERIAL_NUMBER
- string "Serial number"
+ string "SMBIOS Serial Number"
depends on GENERATE_SMBIOS_TABLES
default "123456789"
help
- Define the used serial number which will be used by SMBIOS tables.
+ The Serial Number to store in SMBIOS structures.
config MAINBOARD_VERSION
- string "Version number"
+ string "SMBIOS Version Number"
depends on GENERATE_SMBIOS_TABLES
default "1.0"
help
- Define the used version number which will be used by SMBIOS tables.
+ The Version Number to store in SMBIOS structures.
config MAINBOARD_SMBIOS_MANUFACTURER
string "SMBIOS Manufacturer"