June 2013 - coreboot-gerrit - mail.coreboot.org

New patch to review for coreboot: 0816eb4 Drop WARNINGS_ARE_ERRORS exceptions
by Stefan Reinauer June 28, 2013

June 28, 2013

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3569 -gerrit commit 0816eb4fd0a62e19429e4536004ee845b21d7a02 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Thu Jun 27 17:17:26 2013 -0700 Drop WARNINGS_ARE_ERRORS exceptions Thanks to Bruce's great work, we can finally drop this workaround. Change-Id: Ie92d1e53ef867fa34aa2489ccfb682d73195b213 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/mainboard/amd/dinar/Kconfig | 4 ---- src/mainboard/amd/south_station/Kconfig | 4 ---- src/mainboard/amd/torpedo/Kconfig | 4 ---- src/mainboard/amd/union_station/Kconfig | 4 ---- src/mainboard/supermicro/h8qgi/Kconfig | 4 ---- src/mainboard/supermicro/h8scm/Kconfig | 4 ---- src/mainboard/tyan/s8226/Kconfig | 4 ---- 7 files changed, 28 deletions(-) diff --git a/src/mainboard/amd/dinar/Kconfig b/src/mainboard/amd/dinar/Kconfig index f8019f6..441357b 100644 --- a/src/mainboard/amd/dinar/Kconfig +++ b/src/mainboard/amd/dinar/Kconfig @@ -92,10 +92,6 @@ config DRIVERS_PS2_KEYBOARD bool default y -config WARNINGS_ARE_ERRORS - bool - default n - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index 07b9d2d..81d631f 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -109,9 +109,5 @@ config DRIVERS_PS2_KEYBOARD bool default n -config WARNINGS_ARE_ERRORS - bool - default n - endif # BOARD_AMD_SOUTHSTATION diff --git a/src/mainboard/amd/torpedo/Kconfig b/src/mainboard/amd/torpedo/Kconfig index f70dbaa..cfcf3cb 100644 --- a/src/mainboard/amd/torpedo/Kconfig +++ b/src/mainboard/amd/torpedo/Kconfig @@ -154,10 +154,6 @@ config DRIVERS_PS2_KEYBOARD bool default y -config WARNINGS_ARE_ERRORS - bool - default n - config CONSOLE_POST bool depends on !NO_POST diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index 8612345..848fd36 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -108,9 +108,5 @@ config DRIVERS_PS2_KEYBOARD bool default n -config WARNINGS_ARE_ERRORS - bool - default n - endif # BOARD_AMD_UNIONSTATION diff --git a/src/mainboard/supermicro/h8qgi/Kconfig b/src/mainboard/supermicro/h8qgi/Kconfig index 2c58fcc..5ee9a19 100644 --- a/src/mainboard/supermicro/h8qgi/Kconfig +++ b/src/mainboard/supermicro/h8qgi/Kconfig @@ -93,10 +93,6 @@ config DRIVERS_PS2_KEYBOARD bool default y -config WARNINGS_ARE_ERRORS - bool - default n - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/supermicro/h8scm/Kconfig b/src/mainboard/supermicro/h8scm/Kconfig index c35b98e..a7f40be 100644 --- a/src/mainboard/supermicro/h8scm/Kconfig +++ b/src/mainboard/supermicro/h8scm/Kconfig @@ -96,10 +96,6 @@ config DRIVERS_PS2_KEYBOARD bool default y -config WARNINGS_ARE_ERRORS - bool - default n - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/tyan/s8226/Kconfig b/src/mainboard/tyan/s8226/Kconfig index eaa652b..68ce152 100644 --- a/src/mainboard/tyan/s8226/Kconfig +++ b/src/mainboard/tyan/s8226/Kconfig @@ -89,10 +89,6 @@ config DRIVERS_PS2_KEYBOARD bool default y -config WARNINGS_ARE_ERRORS - bool - default n - config ONBOARD_VGA_IS_PRIMARY bool default y

1 0

Patch set updated for coreboot: 49e9142 libpayload: Add strerror
by Stefan Reinauer June 28, 2013

June 28, 2013

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3537 -gerrit commit 49e914248060d3856831c35ffc62469472cdc6e6 Author: Stefan Tauner <stefan.tauner(a)gmx.at> Date: Thu Jun 27 17:06:27 2013 +0200 libpayload: Add strerror Change-Id: I33d45ad7d09473b8c6f5b7ee5fbadc0d184f9dcd Signed-off-by: Stefan Tauner <stefan.tauner(a)gmx.at> --- payloads/libpayload/include/string.h | 5 +++-- payloads/libpayload/libc/string.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/payloads/libpayload/include/string.h b/payloads/libpayload/include/string.h index 9e4f791..952261f 100644 --- a/payloads/libpayload/include/string.h +++ b/payloads/libpayload/include/string.h @@ -63,8 +63,9 @@ char *strstr(const char *h, const char *n); char *strsep(char **stringp, const char *delim); size_t strspn(const char *s, const char *a); size_t strcspn(const char *s, const char *a); -char* strtok(char *str, const char *delim); -char* strtok_r(char *str, const char *delim, char **ptr); +char *strtok(char *str, const char *delim); +char *strtok_r(char *str, const char *delim, char **ptr); +char *strerror(int errnum); /** @} */ /** diff --git a/payloads/libpayload/libc/string.c b/payloads/libpayload/libc/string.c index 6151164..71dd1a6 100644 --- a/payloads/libpayload/libc/string.c +++ b/payloads/libpayload/libc/string.c @@ -639,3 +639,17 @@ void perror(const char *s) { printf("%s: %d\n", s?s:"(none)", errno); } + +/** + * Get a message string describing the given error number. + * + * @param errnum The error number to be interpreted + * @return A pointer to a string describing the given error number + */ +char *strerror(int errnum) +{ + /* Reserve enough space for the string below + INT64_MIN in decimal + \0 */ + static char errstr[35]; + snprintf(errstr, sizeof(errstr), "Unknown error %d", errnum); + return errstr; +}

1 0

Patch merged into coreboot/master: 160243d Supermicro H8SCM/H8QGI: Increase size of bus variable to meet API
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 160243d73e13f1857299b980a88eb3a0cd7fc4fb Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 19:13:28 2013 -0600 Supermicro H8SCM/H8QGI: Increase size of bus variable to meet API Users of mptable_write_buses() pass two pass-by-reference parameters reflecting a maximum bus number and a search bus number. These bus numbers are expected to be held in "int" variables and are updated by the function. Both of the Supermicro boards define the search bus number as a byte value in mptable.c. For now, change the two Supermicro boards to use "int" to hold the search bus index. Change-Id: Ie71850719c1fa3cda0ac9c8773bb80650de95c70 Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3546 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3546 for details. -gerrit

1 0

Patch merged into coreboot/master: e8dca50 AMD Dinar: Eliminate warnings (initializers/prototypes/unused var)
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit e8dca508d30ae84daebdf8f1acdde942e5e2c57b Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 14:02:41 2013 -0600 AMD Dinar: Eliminate warnings (initializers/prototypes/unused var) Fix a bunch of compiler-generated warning messages. These fixes are mainly braces for grouping initializers. These changes are not intended to change any code functionality. There are two changes where function prototypes are added, and two cases where unused variables are eliminated. Change-Id: I93cef8899170b5575e7fb7c55181b381a7bcd9d8 Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3545 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3545 for details. -gerrit

1 0

Patch merged into coreboot/master: 21d6fd9 AMD SB700 boards: Set Azalia configuration flags
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 21d6fd9d7819ffbf5416e612d7db87a0afd4d29a Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 14:01:21 2013 -0600 AMD SB700 boards: Set Azalia configuration flags The existing code for setting Azalia configuration assumes that the configuration bits are contiguous within a single byte and can be set using a byte copy addressed into the lowest 2-bit subfield. The fix in Family 14 defines a union that can be addressed as a byte to overlay the bit fields. Since the offset of the four subfields is not necessarily fixed, change the code to initialize each of the four subfields individually. Change-Id: I1dff20bb8bd3e1bcd8b4e6b0537e20779d2a3521 Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3544 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3544 for details. -gerrit

1 0

Patch merged into coreboot/master: f9ba7bb supermicro/h8scm: Add a type cast for printk to correct a warning message
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit f9ba7bb4f95f9b8f2626d6c8c23adbd145903fff Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 13:59:36 2013 -0600 supermicro/h8scm: Add a type cast for printk to correct a warning message Copy a type cast from the other cases of the same switch statement to eliminate compiler warning messages. Change-Id: I8d0a88892f6a5f8e43227ab5f830041894b07f6a Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3543 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3543 for details. -gerrit

1 0

Patch merged into coreboot/master: 93b57c5 Dinar, H8SCM, H8QGI: Add prototype of get_bus_conf()
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 93b57c55a9424060e5c8024ab18311f087696db3 Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 19:27:17 2013 -0600 Dinar, H8SCM, H8QGI: Add prototype of get_bus_conf() On Dinar, H8SCM, and H8QGI, add <cpu/amd/amdfam15.h> as an include to pick up the prototype definition of get_bus_conf(). Change-Id: Ie4887670ac52aa194745881362df19cd1d75773e Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3542 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Zheng Bao <zheng.bao(a)amd.com> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3542 for details. -gerrit

1 0

Patch merged into coreboot/master: 01677b6 amd/cimx/sb700/late.c: Add type cast to (UINT8)
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 01677b6625bff61b6abc570cf7aec3146c7a8d47 Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 14:29:08 2013 -0600 amd/cimx/sb700/late.c: Add type cast to (UINT8) This change inserts a type cast to eliminate a compiler warning. Change-Id: If223f61f1565caeadb1b7e0762975b1b2412eda5 Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3541 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3541 for details. -gerrit

1 0

Patch merged into coreboot/master: 53abac1 amd/cimx/rd890/amd.h: Eliminate redefinition of NULL
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 53abac1767c5c40ce0eafe729cd04cca1fcc8292 Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 14:27:16 2013 -0600 amd/cimx/rd890/amd.h: Eliminate redefinition of NULL This change replaces a redefinition of NULL with the standard definition from <stddef.h> to eliminate a compiler redefinition warning. Change-Id: I441fa569f545c0efb00284b5ee58aa27cb6617ba Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3540 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3540 for details. -gerrit

1 0

Patch merged into coreboot/master: 58fff9d amd/agesa/family15/northbridge.c: Delete unused variable
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit 58fff9d44f14c750aacd63a700581f314d656ef8 Author: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Date: Tue Jun 25 14:21:44 2013 -0600 amd/agesa/family15/northbridge.c: Delete unused variable This change eliminates an unused variable that causes a build warning. Change-Id: I02487c7dd80d458f562d7afe1827eefcc0fb678b Signed-off-by: Bruce Griffith <Bruce.Griffith(a)se-eng.com> Reviewed-on: http://review.coreboot.org/3526 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/3526 for details. -gerrit

1 0