June 2013 - coreboot-gerrit - mail.coreboot.org

Patch set updated for coreboot: 021fcc4 intel/…/spi.c: Fix typo in comment: at*t*empted
by Paul Menzel June 29, 2013

June 29, 2013

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3572 -gerrit commit 021fcc412d024e7637e9816d3b4f039491f4a497 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Jun 29 11:41:27 2013 +0200 intel/…/spi.c: Fix typo in comment: at*t*empted Fix the spelling of attempted present since `spi.c` was added in commit »Add SPI flash driver« (1c56d9b1) [1]. [1] http://review.coreboot.org/997 Change-Id: Ic6f6af6298fed2f41f140a7aa62dccf98bf60927 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/southbridge/intel/bd82x6x/spi.c | 2 +- src/southbridge/intel/lynxpoint/spi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/southbridge/intel/bd82x6x/spi.c b/src/southbridge/intel/bd82x6x/spi.c index 09169b1..0c1f51c 100644 --- a/src/southbridge/intel/bd82x6x/spi.c +++ b/src/southbridge/intel/bd82x6x/spi.c @@ -677,7 +677,7 @@ int spi_xfer(struct spi_slave *slave, const void *dout, } /* - * Check if this is a write command atempting to transfer more bytes + * Check if this is a write command attempting to transfer more bytes * than the controller can handle. Iterations for writes are not * supported here because each SPI write command needs to be preceded * and followed by other SPI commands, and this sequence is controlled diff --git a/src/southbridge/intel/lynxpoint/spi.c b/src/southbridge/intel/lynxpoint/spi.c index eaa17d5..5501efc 100644 --- a/src/southbridge/intel/lynxpoint/spi.c +++ b/src/southbridge/intel/lynxpoint/spi.c @@ -589,7 +589,7 @@ int spi_xfer(struct spi_slave *slave, const void *dout, } /* - * Check if this is a write command atempting to transfer more bytes + * Check if this is a write command attempting to transfer more bytes * than the controller can handle. Iterations for writes are not * supported here because each SPI write command needs to be preceded * and followed by other SPI commands, and this sequence is controlled

1 0

Patch set updated for coreboot: e49d300 AMD SB800 boards: Include `SB800.h` instead of `SBPLATFORM.h`
by Paul Menzel June 29, 2013

June 29, 2013

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3571 -gerrit commit e49d3000cebd1f08d9bb119533607d6f85a76eba Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Jun 28 10:35:03 2013 +0200 AMD SB800 boards: Include `SB800.h` instead of `SBPLATFORM.h` `SBPLATFORM.h` includes the needed header `SB800.h` so just include `SB800.h` directly. Change-Id: If2781f74311bce84f83913c682acf36dcd9589a2 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/advansus/a785e-i/mainboard.c | 2 +- src/mainboard/amd/inagua/mainboard.c | 2 +- src/mainboard/amd/persimmon/mainboard.c | 2 +- src/mainboard/amd/south_station/mainboard.c | 2 +- src/mainboard/amd/union_station/mainboard.c | 2 +- src/mainboard/asus/m5a88-v/mainboard.c | 2 +- src/mainboard/avalue/eax-785e/mainboard.c | 2 +- src/mainboard/lippert/frontrunner-af/mainboard.c | 2 +- src/mainboard/lippert/toucan-af/mainboard.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mainboard/advansus/a785e-i/mainboard.c b/src/mainboard/advansus/a785e-i/mainboard.c index 9b6450d..19d5b2f 100644 --- a/src/mainboard/advansus/a785e-i/mainboard.c +++ b/src/mainboard/advansus/a785e-i/mainboard.c @@ -24,7 +24,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> -#include "SBPLATFORM.h" +#include "SB800.h" u8 is_dev3_present(void); diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c index dc23007..c117bdb 100644 --- a/src/mainboard/amd/inagua/mainboard.c +++ b/src/mainboard/amd/inagua/mainboard.c @@ -25,7 +25,7 @@ #include <cpu/amd/mtrr.h> #include <device/pci_def.h> #include <southbridge/amd/sb800/sb800.h> -#include "SBPLATFORM.h" /* Platfrom Specific Definitions */ +#include "SB800.h" /* Platfrom Specific Definitions */ void broadcom_init(void); void set_pcie_reset(void); diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c index b17bc6a..14e6fdb 100644 --- a/src/mainboard/amd/persimmon/mainboard.c +++ b/src/mainboard/amd/persimmon/mainboard.c @@ -28,7 +28,7 @@ #include "BiosCallOuts.h" #include <cpu/amd/agesa/s3_resume.h> #include <cpu/amd/mtrr.h> -#include "SBPLATFORM.h" +#include "SB800.h" void set_pcie_reset(void); void set_pcie_dereset(void); diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 43d6a78..400e415 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -26,7 +26,7 @@ #include <cpu/amd/mtrr.h> #include <device/pci_def.h> #include <delay.h> -#include "SBPLATFORM.h" /* Platfrom Specific Definitions */ +#include "SB800.h" /* Platfrom Specific Definitions */ void set_pcie_reset(void); diff --git a/src/mainboard/amd/union_station/mainboard.c b/src/mainboard/amd/union_station/mainboard.c index 8816e8d..ec65503 100644 --- a/src/mainboard/amd/union_station/mainboard.c +++ b/src/mainboard/amd/union_station/mainboard.c @@ -25,7 +25,7 @@ #include <device/pci_def.h> #include <southbridge/amd/sb800/sb800.h> #include <cpu/amd/mtrr.h> -#include "SBPLATFORM.h" /* Platfrom Specific Definitions */ +#include "SB800.h" /* Platfrom Specific Definitions */ void set_pcie_reset(void); void set_pcie_dereset(void); diff --git a/src/mainboard/asus/m5a88-v/mainboard.c b/src/mainboard/asus/m5a88-v/mainboard.c index 8ee338e..5dea06c 100644 --- a/src/mainboard/asus/m5a88-v/mainboard.c +++ b/src/mainboard/asus/m5a88-v/mainboard.c @@ -24,7 +24,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> -#include "SBPLATFORM.h" +#include "SB800.h" u8 is_dev3_present(void); diff --git a/src/mainboard/avalue/eax-785e/mainboard.c b/src/mainboard/avalue/eax-785e/mainboard.c index 6ce3469..8a91c75 100644 --- a/src/mainboard/avalue/eax-785e/mainboard.c +++ b/src/mainboard/avalue/eax-785e/mainboard.c @@ -24,7 +24,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> -#include "SBPLATFORM.h" +#include "SB800.h" u8 is_dev3_present(void); diff --git a/src/mainboard/lippert/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/mainboard.c index 57543c2..f46fbff 100644 --- a/src/mainboard/lippert/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/mainboard.c @@ -29,7 +29,7 @@ #include "BiosCallOuts.h" #include <cpu/amd/agesa/s3_resume.h> #include <cpu/amd/mtrr.h> -#include "SBPLATFORM.h" +#include "SB800.h" #include "OEM.h" /* SMBUS0_BASE_ADDRESS */ /* Init SIO GPIOs. */ diff --git a/src/mainboard/lippert/toucan-af/mainboard.c b/src/mainboard/lippert/toucan-af/mainboard.c index f6cf09c..d3052aa 100644 --- a/src/mainboard/lippert/toucan-af/mainboard.c +++ b/src/mainboard/lippert/toucan-af/mainboard.c @@ -29,7 +29,7 @@ #include "BiosCallOuts.h" #include <cpu/amd/agesa/s3_resume.h> #include <cpu/amd/mtrr.h> -#include "SBPLATFORM.h" +#include "SB800.h" #include "OEM.h" /* SMBUS0_BASE_ADDRESS */ /* Write data block to slave on SMBUS0. */

1 0

New patch to review for coreboot: 215591d intel/{bd82x6x,lynxpoint}/spi.c: Fix typo »at*t*empted« in comment
by Paul Menzel June 29, 2013

June 29, 2013

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3572 -gerrit commit 215591d44599675bb4918cc596b1399c23238387 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Sat Jun 29 11:41:27 2013 +0200 intel/{bd82x6x,lynxpoint}/spi.c: Fix typo »at*t*empted« in comment Fix the spelling of attempted present since `spi.c` was added in commit »Add SPI flash driver« (1c56d9b1) [1]. [1] http://review.coreboot.org/997 Change-Id: Ic6f6af6298fed2f41f140a7aa62dccf98bf60927 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/southbridge/intel/bd82x6x/spi.c | 2 +- src/southbridge/intel/lynxpoint/spi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/southbridge/intel/bd82x6x/spi.c b/src/southbridge/intel/bd82x6x/spi.c index 09169b1..0c1f51c 100644 --- a/src/southbridge/intel/bd82x6x/spi.c +++ b/src/southbridge/intel/bd82x6x/spi.c @@ -677,7 +677,7 @@ int spi_xfer(struct spi_slave *slave, const void *dout, } /* - * Check if this is a write command atempting to transfer more bytes + * Check if this is a write command attempting to transfer more bytes * than the controller can handle. Iterations for writes are not * supported here because each SPI write command needs to be preceded * and followed by other SPI commands, and this sequence is controlled diff --git a/src/southbridge/intel/lynxpoint/spi.c b/src/southbridge/intel/lynxpoint/spi.c index eaa17d5..5501efc 100644 --- a/src/southbridge/intel/lynxpoint/spi.c +++ b/src/southbridge/intel/lynxpoint/spi.c @@ -589,7 +589,7 @@ int spi_xfer(struct spi_slave *slave, const void *dout, } /* - * Check if this is a write command atempting to transfer more bytes + * Check if this is a write command attempting to transfer more bytes * than the controller can handle. Iterations for writes are not * supported here because each SPI write command needs to be preceded * and followed by other SPI commands, and this sequence is controlled

1 0

Patch set updated for coreboot: 166dfbb cbmem: Makefile: Add compilation rule
by Nico Huber June 28, 2013

June 28, 2013

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3028 -gerrit commit 166dfbb84b1cbfdf9b8611872f677a7ce02772b8 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Apr 5 11:12:12 2013 +0200 cbmem: Makefile: Add compilation rule Commit »cbmem compilation needs to use the hardened toolchain« (7c6b6bb5) [1] introduced `CPPFLAGS` but used `CFLAGS`, which might give the following build error, which was not spotted by Jenkins. cbmem.c:36:34: fatal error: boot/coreboot_tables.h: Datei oder Verzeichnis nicht gefunden compilation terminated. Looks like the default compilation rule does not always include `CPPFLAGS`. Therefore, add a more complete compilation rule. [1] http://review.coreboot.org/1791 Change-Id: I254d76c7d98b6f920501407239566e9655b2ddeb Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- util/cbmem/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index c93863a..d41d324 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -28,6 +28,9 @@ OBJS = $(PROGRAM).o all: $(PROGRAM) +%.o: %.c + $(CC) $(CPPFLAGS) $(CFLAGS) -c $< + $(PROGRAM): $(OBJS) clean:

1 0

New patch to review for coreboot: 07fca0c SB800: Remove includes of SBPLATFORM.h and replace by SB800.h
by Paul Menzel June 28, 2013

June 28, 2013

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3571 -gerrit commit 07fca0c2808c73921cde6b987606bdf65800c6ce Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Fri Jun 28 10:35:03 2013 +0200 SB800: Remove includes of SBPLATFORM.h and replace by SB800.h `SBPLATFORM.h` just includes the needed header `SB800.h` so just include `SB800.h` directly. This needs to be adapted to the other SB800 boards too. Change-Id: If2781f74311bce84f83913c682acf36dcd9589a2 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/amd/persimmon/mainboard.c | 2 +- src/mainboard/amd/south_station/mainboard.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c index b17bc6a..14e6fdb 100644 --- a/src/mainboard/amd/persimmon/mainboard.c +++ b/src/mainboard/amd/persimmon/mainboard.c @@ -28,7 +28,7 @@ #include "BiosCallOuts.h" #include <cpu/amd/agesa/s3_resume.h> #include <cpu/amd/mtrr.h> -#include "SBPLATFORM.h" +#include "SB800.h" void set_pcie_reset(void); void set_pcie_dereset(void); diff --git a/src/mainboard/amd/south_station/mainboard.c b/src/mainboard/amd/south_station/mainboard.c index 43d6a78..c1c514a 100644 --- a/src/mainboard/amd/south_station/mainboard.c +++ b/src/mainboard/amd/south_station/mainboard.c @@ -26,7 +26,6 @@ #include <cpu/amd/mtrr.h> #include <device/pci_def.h> #include <delay.h> -#include "SBPLATFORM.h" /* Platfrom Specific Definitions */ void set_pcie_reset(void);

1 0

Patch merged into coreboot/master: bc2c9ef ELOG: Fix warning to fix the compilation.
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit bc2c9efd56a1b7d5c9b97132423ac176b4d21b74 Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Wed Jun 26 20:04:49 2013 +0200 ELOG: Fix warning to fix the compilation. Without that fix we have: src/drivers/elog/elog.c: In function 'elog_is_header_valid': src/drivers/elog/elog.c:213:3: error: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Werror=format] Change-Id: I71b80a94c03a04eedb688ae107d92c05a878315e Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Reviewed-on: http://review.coreboot.org/3551 Reviewed-by: Nico Huber <nico.huber(a)secunet.com> Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/3551 for details. -gerrit

1 0

Patch set updated for coreboot: 91b5e42 ELOG: Fix warning to fix the compilation.
by Nico Huber June 28, 2013

June 28, 2013

Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3551 -gerrit commit 91b5e426c8ccf5b816cbf8dc50216ea2e667e19a Author: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Date: Wed Jun 26 20:04:49 2013 +0200 ELOG: Fix warning to fix the compilation. Without that fix we have: src/drivers/elog/elog.c: In function 'elog_is_header_valid': src/drivers/elog/elog.c:213:3: error: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int' [-Werror=format] Change-Id: I71b80a94c03a04eedb688ae107d92c05a878315e Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> --- src/drivers/elog/elog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 1a794d9..71e908b 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -210,7 +210,7 @@ static int elog_is_header_valid(struct elog_header *header) return 0; } if (header->header_size != sizeof(*header)) { - printk(BIOS_ERR, "ELOG: header size mismatch %u != %u\n", + printk(BIOS_ERR, "ELOG: header size mismatch %u != %zu\n", header->header_size, sizeof(*header)); return 0; }

1 0

Patch merged into coreboot/master: c9246da libpayload: Add strerror
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit c9246da4ddff9fef2bb26d05d87d1f616124b91e Author: Stefan Tauner <stefan.tauner(a)gmx.at> Date: Thu Jun 27 17:06:27 2013 +0200 libpayload: Add strerror Change-Id: I33d45ad7d09473b8c6f5b7ee5fbadc0d184f9dcd Signed-off-by: Stefan Tauner <stefan.tauner(a)gmx.at> Reviewed-on: http://review.coreboot.org/3537 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.huber(a)secunet.com> See http://review.coreboot.org/3537 for details. -gerrit

1 0

New patch to review for coreboot: 0945f01 amd/parmer/BiosCallOuts.c: Remove unneeded SATA comment
by Paul Menzel June 28, 2013

June 28, 2013

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3570 -gerrit commit 0945f013dd6f9226a8bab9cb2582a447a7f1b8ea Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Tue Jun 25 08:41:25 2013 +0200 amd/parmer/BiosCallOuts.c: Remove unneeded SATA comment Remove the superfluous comment, /* sata configuration */ which should be re-added, when there is actual code for it. AMD Thatcher and ASUS F2A85-M do not have this comment either, so removing the comment also unifies the files. Change-Id: I32d3e57d055cb4f0d9591bc27979edef1af6ecb4 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/mainboard/amd/parmer/BiosCallOuts.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c index ba33b85..94584fd 100644 --- a/src/mainboard/amd/parmer/BiosCallOuts.c +++ b/src/mainboard/amd/parmer/BiosCallOuts.c @@ -300,8 +300,6 @@ AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr) FchParams_env->Usb.Xhci0Enable = FALSE; #endif FchParams_env->Usb.Xhci1Enable = FALSE; - - /* sata configuration */ } printk(BIOS_DEBUG, "Done\n");

1 0

Patch merged into coreboot/master: c0b1a48 Drop WARNINGS_ARE_ERRORS exceptions
by gerrit＠coreboot.org June 28, 2013

June 28, 2013

the following patch was just integrated into master: commit c0b1a48cdaed0a9c955fd98563a1d5906a72b533 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Thu Jun 27 17:17:26 2013 -0700 Drop WARNINGS_ARE_ERRORS exceptions Thanks to Bruce's great work, we can finally drop this workaround. Change-Id: Ie92d1e53ef867fa34aa2489ccfb682d73195b213 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/3569 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones(a)se-eng.com> See http://review.coreboot.org/3569 for details. -gerrit

1 0