coreboot-gerrit May 2013

coreboot-gerrit@coreboot.org

1 participants
593 discussions

New patch to review for coreboot: 9a52cb7 armv7: invalid TLB entries as they are added/modified
by David Hendricks 01 May '13

01 May '13

David Hendricks (dhendrix(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3166 -gerrit commit 9a52cb7be3545c1e290a4a9341eef5939a41b98f Author: David Hendricks <dhendrix(a)chromium.org> Date: Tue Apr 30 16:01:50 2013 -0700 armv7: invalid TLB entries as they are added/modified The old approach was to invalidate the entire TLB every time we set up a table entry. This worked because we didn't turn the MMU on until after we had set everything up. Using the TLBIMVAA instruction to invalidate each entry as it's added/modified is more correct. Change-Id: I27654a543a2015574d910e15d48b3d3845fdb6d1 Signed-off-by: David Hendricks <dhendrix(a)chromium.org> --- src/arch/armv7/lib/mmu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/arch/armv7/lib/mmu.c b/src/arch/armv7/lib/mmu.c index 82c7358..d4e08f7 100644 --- a/src/arch/armv7/lib/mmu.c +++ b/src/arch/armv7/lib/mmu.c @@ -99,11 +99,10 @@ void mmu_config_range(unsigned long start_mb, unsigned long size_mb, printk(BIOS_DEBUG, "Setting dcache policy: 0x%08lx:0x%08lx [%s]\n", start_mb << 20, ((start_mb + size_mb) << 20) - 1, str); - for (i = start_mb; i < start_mb + size_mb; i++) + for (i = start_mb; i < start_mb + size_mb; i++) { ttb_entry[i] = (i << 20) | attr; - - /* TODO: add helper to invalidate TLB by MVA */ - tlb_invalidate_all(); + tlbimvaa(start_mb); + } } void mmu_init(void)

1 0

Patch merged into coreboot/master: c0466d4 ARMV7: add a function to disable MMU entries
by gerrit＠coreboot.org 01 May '13

01 May '13

the following patch was just integrated into master: commit c0466d46b7ea511f102eb6e57da59d95bf4ef95f Author: Ronald G. Minnich <rminnich(a)gmail.com> Date: Tue Apr 30 10:11:30 2013 -0700 ARMV7: add a function to disable MMU entries It is useful to be able to lock out certain address ranges, NULL being the most important example. void mmu_disable_range(unsigned long start_mb, unsigned long size_mb) will allow us to lock out selected virtual addresses on MiB boundaries. As in other ARM mmu functions, the addresses and quantities are in units of MiB. Change-Id: If516ce955ee2d12c5a409f25acbb5a4b424f699b Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Reviewed-on: http://review.coreboot.org/3160 Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks <dhendrix(a)chromium.org> Build-Tested: build bot (Jenkins) at Wed May 1 14:30:49 2013, giving +1 Reviewed-By: David Hendricks <dhendrix(a)chromium.org> at Wed May 1 20:12:47 2013, giving +2 See http://review.coreboot.org/3160 for details. -gerrit

1 0

Patch set updated for coreboot: 376ee09 device tree: track init times
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3162 -gerrit commit 376ee090d8b05b5f7578668242be994df700e544 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Tue Apr 30 15:41:13 2013 -0500 device tree: track init times With the introduction of a monotonic timer it is possible to track the individual times of each device's init() call. Add this ability behind a HAVE_MONOTONIC_TIMER option. Example log messages: Root Device init 5 usecs CPU_CLUSTER: 0 init 66004 usecs PCI: 00:00.0 init 1020 usecs PCI: 00:02.0 init 456941 usecs PCI: 00:13.0 init 3 usecs PCI: 00:14.0 init 3 usecs PCI: 00:15.0 init 92 usecs PCI: 00:15.1 init 37 usecs PCI: 00:15.2 init 36 usecs PCI: 00:15.3 init 35 usecs PCI: 00:15.4 init 35 usecs PCI: 00:15.5 init 36 usecs PCI: 00:15.6 init 35 usecs PCI: 00:16.0 init 3666 usecs PCI: 00:17.0 init 63 usecs PCI: 00:1b.0 init 3 usecs PCI: 00:1c.0 init 89 usecs PCI: 00:1c.1 init 15 usecs PCI: 00:1c.2 init 15 usecs PCI: 00:1c.3 init 15 usecs PCI: 00:1c.4 init 15 usecs PCI: 00:1c.5 init 16 usecs PCI: 00:1d.0 init 4 usecs PCI: 00:1f.0 init 495 usecs PCI: 00:1f.2 init 29 usecs PCI: 00:1f.3 init 4 usecs PCI: 00:1f.6 init 4 usecs Change-Id: Ibe499848432c7ab20166ab10d6dfb07db03eab01 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/device/device.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/device/device.c b/src/device/device.c index e0c8bf0..a971270 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -43,6 +43,7 @@ #if CONFIG_ARCH_X86 #include <arch/ebda.h> #endif +#include <timer.h> /** Linked list of ALL devices */ struct device *all_devices = &dev_root; @@ -1103,6 +1104,12 @@ static void init_dev(struct device *dev) return; if (!dev->initialized && dev->ops && dev->ops->init) { +#if CONFIG_HAVE_MONOTONIC_TIMER + struct mono_time start_time; + struct rela_time dev_init_time; + + timer_monotonic_get(&start_time); +#endif if (dev->path.type == DEVICE_PATH_I2C) { printk(BIOS_DEBUG, "smbus: %s[%d]->", dev_path(dev->bus->dev), dev->bus->link_num); @@ -1111,6 +1118,11 @@ static void init_dev(struct device *dev) printk(BIOS_DEBUG, "%s init\n", dev_path(dev)); dev->initialized = 1; dev->ops->init(dev); +#if CONFIG_HAVE_MONOTONIC_TIMER + dev_init_time = current_time_from(&start_time); + printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev), + rela_time_in_microseconds(&dev_init_time)); +#endif } }

1 0

Patch set updated for coreboot: aadf826 device tree: optionally track init times
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3162 -gerrit commit aadf82684328a4c994ad549e0be33cb55421ebba Author: Aaron Durbin <adurbin(a)chromium.org> Date: Tue Apr 30 15:41:13 2013 -0500 device tree: optionally track init times With the introduction of a monotonic timer it is possible to track the individual times of each device's init() call. Add this ability behind a DEV_INIT_TIMES Kconfig option. Example log messages: Root Device init 5 usecs CPU_CLUSTER: 0 init 66004 usecs PCI: 00:00.0 init 1020 usecs PCI: 00:02.0 init 456941 usecs PCI: 00:13.0 init 3 usecs PCI: 00:14.0 init 3 usecs PCI: 00:15.0 init 92 usecs PCI: 00:15.1 init 37 usecs PCI: 00:15.2 init 36 usecs PCI: 00:15.3 init 35 usecs PCI: 00:15.4 init 35 usecs PCI: 00:15.5 init 36 usecs PCI: 00:15.6 init 35 usecs PCI: 00:16.0 init 3666 usecs PCI: 00:17.0 init 63 usecs PCI: 00:1b.0 init 3 usecs PCI: 00:1c.0 init 89 usecs PCI: 00:1c.1 init 15 usecs PCI: 00:1c.2 init 15 usecs PCI: 00:1c.3 init 15 usecs PCI: 00:1c.4 init 15 usecs PCI: 00:1c.5 init 16 usecs PCI: 00:1d.0 init 4 usecs PCI: 00:1f.0 init 495 usecs PCI: 00:1f.2 init 29 usecs PCI: 00:1f.3 init 4 usecs PCI: 00:1f.6 init 4 usecs Change-Id: Ibe499848432c7ab20166ab10d6dfb07db03eab01 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/device/device.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/device/device.c b/src/device/device.c index e0c8bf0..a971270 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -43,6 +43,7 @@ #if CONFIG_ARCH_X86 #include <arch/ebda.h> #endif +#include <timer.h> /** Linked list of ALL devices */ struct device *all_devices = &dev_root; @@ -1103,6 +1104,12 @@ static void init_dev(struct device *dev) return; if (!dev->initialized && dev->ops && dev->ops->init) { +#if CONFIG_HAVE_MONOTONIC_TIMER + struct mono_time start_time; + struct rela_time dev_init_time; + + timer_monotonic_get(&start_time); +#endif if (dev->path.type == DEVICE_PATH_I2C) { printk(BIOS_DEBUG, "smbus: %s[%d]->", dev_path(dev->bus->dev), dev->bus->link_num); @@ -1111,6 +1118,11 @@ static void init_dev(struct device *dev) printk(BIOS_DEBUG, "%s init\n", dev_path(dev)); dev->initialized = 1; dev->ops->init(dev); +#if CONFIG_HAVE_MONOTONIC_TIMER + dev_init_time = current_time_from(&start_time); + printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev), + rela_time_in_microseconds(&dev_init_time)); +#endif } }

1 0

Patch set updated for coreboot: 440f987 libpayload: make searching for a file less verbose
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3164 -gerrit commit 440f987a4eb9861212c84f04917530c076aebc5c Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed May 1 08:40:13 2013 -0500 libpayload: make searching for a file less verbose The cbfs core code would print out all unmatched file names when searching for a file. This contributes to a lot of unnecessary messages in the boot log. Change this message to a DEBUG one so that it will only be printed when CONFIG_DEBUG_CBFS is enabled. Change-Id: I34c747e0d3406351318abf70994dbc0bb3fa6c01 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- payloads/libpayload/libcbfs/cbfs_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c index a714b91..3fe6971 100644 --- a/payloads/libpayload/libcbfs/cbfs_core.c +++ b/payloads/libpayload/libcbfs/cbfs_core.c @@ -158,7 +158,8 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name) media->close(media); return file_ptr; } else { - LOG(" (unmatched file @0x%x: %s)\n", offset, file_name); + DEBUG(" (unmatched file @0x%x: %s)\n", offset, + file_name); media->unmap(media, file_name); }

1 0

Patch merged into coreboot/master: 043b823 Google/Snow: Revise bootblock initialization.
by gerrit＠coreboot.org 01 May '13

01 May '13

the following patch was just integrated into master: commit 043b823a736d101da46a120cfa883c5c48e3ab81 Author: Hung-Te Lin <hungte(a)chromium.org> Date: Tue Apr 30 16:14:35 2013 +0800 Google/Snow: Revise bootblock initialization. It's fine to always start timer even in suspend/resume mode, so we can move the timer_start() back to the very beginning of boot procedure. That provides more precise boot time information. With that timer change, the wake up state test procedure can be simplified. Verified by building and booting firmware image on Google/Snow successfully, and then suspend-resume without problem (suspend_stress_test). Change-Id: I0d739650dbff4eb3a75acbbf1e4356f2569b487d Signed-off-by: Hung-Te Lin <hungte(a)chromium.org> Reviewed-on: http://review.coreboot.org/3151 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Wed May 1 11:00:22 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Wed May 1 18:26:50 2013, giving +2 See http://review.coreboot.org/3151 for details. -gerrit

1 0

New patch to review for coreboot: 53caf82 Kconfig: Remove duplicate entry for `USE_OPTION_TABLE`
by Paul Menzel 01 May '13

01 May '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3165 -gerrit commit 53caf8219419bf1d75ff16dc43e2134b171886e6 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Wed May 1 16:21:53 2013 +0200 Kconfig: Remove duplicate entry for `USE_OPTION_TABLE` The following commit commit eb50c7d922e91f0247b3705eccb2d2eec638c277 Author: Edwin Beasant <edwin_beasant(a)virtensys.com> Date: Tue Jul 6 21:05:04 2010 +0000 Re-integrate "USE_OPTION_TABLE" code. added a duplicate entry `config USE_OPTION_TABLE`. Remove it again. Change-Id: I3ff64c360bad531439e74fa1b25a06c4a447a33f Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/Kconfig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Kconfig b/src/Kconfig index ab2a927..a5781ac 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -328,10 +328,6 @@ config HIGH_SCRATCH_MEMORY_SIZE hex default 0x0 -config USE_OPTION_TABLE - bool - default n - config HAVE_OPTION_TABLE bool default n

1 0

New patch to review for coreboot: 9fb5e00 libpayload: make searching for a file less verbose
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3164 -gerrit commit 9fb5e0033048862c5b9b51a97842ca7db960f033 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed May 1 08:40:13 2013 -0500 libpayload: make searching for a file less verbose The cbfs core code would print out all unmatched file names when searching for a file. This contributes to a lot of unnecessary messages in the boot log. Change this message to a DEBUG one so that it will only be printed when CONFIG_DEBUG_CBFS is enabled. Change-Id: I34c747e0d3406351318abf70994dbc0bb3fa6c01 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- payloads/libpayload/libcbfs/cbfs_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c index a714b91..3fe6971 100644 --- a/payloads/libpayload/libcbfs/cbfs_core.c +++ b/payloads/libpayload/libcbfs/cbfs_core.c @@ -158,7 +158,8 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name) media->close(media); return file_ptr; } else { - LOG(" (unmatched file @0x%x: %s)\n", offset, file_name); + DEBUG(" (unmatched file @0x%x: %s)\n", offset, + file_name); media->unmap(media, file_name); }

1 0

Patch set updated for coreboot: 7b2c1ad device tree: optionally track init times
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3162 -gerrit commit 7b2c1ad89bc2bd9b1371b80357ca07aa20066446 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Tue Apr 30 15:41:13 2013 -0500 device tree: optionally track init times With the introduction of a monotonic timer it is possible to track the individual times of each device's init() call. Add this ability behind a DEV_INIT_TIMES Kconfig option. Example log messages: Root Device init 5 usecs CPU_CLUSTER: 0 init 66004 usecs PCI: 00:00.0 init 1020 usecs PCI: 00:02.0 init 456941 usecs PCI: 00:13.0 init 3 usecs PCI: 00:14.0 init 3 usecs PCI: 00:15.0 init 92 usecs PCI: 00:15.1 init 37 usecs PCI: 00:15.2 init 36 usecs PCI: 00:15.3 init 35 usecs PCI: 00:15.4 init 35 usecs PCI: 00:15.5 init 36 usecs PCI: 00:15.6 init 35 usecs PCI: 00:16.0 init 3666 usecs PCI: 00:17.0 init 63 usecs PCI: 00:1b.0 init 3 usecs PCI: 00:1c.0 init 89 usecs PCI: 00:1c.1 init 15 usecs PCI: 00:1c.2 init 15 usecs PCI: 00:1c.3 init 15 usecs PCI: 00:1c.4 init 15 usecs PCI: 00:1c.5 init 16 usecs PCI: 00:1d.0 init 4 usecs PCI: 00:1f.0 init 495 usecs PCI: 00:1f.2 init 29 usecs PCI: 00:1f.3 init 4 usecs PCI: 00:1f.6 init 4 usecs Change-Id: Ibe499848432c7ab20166ab10d6dfb07db03eab01 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/Kconfig | 6 ++++++ src/device/device.c | 12 ++++++++++++ 2 files changed, 18 insertions(+) diff --git a/src/Kconfig b/src/Kconfig index ab2a927..11355c2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -324,6 +324,12 @@ config TIMER_QUEUE help Provide a timer queue for performing time-based callbacks. +config DEV_INIT_TIMES + def_bool n + depends on HAVE_MONOTONIC_TIMER + help + Track the times each device takes to initialize in the device tree. + config HIGH_SCRATCH_MEMORY_SIZE hex default 0x0 diff --git a/src/device/device.c b/src/device/device.c index e0c8bf0..ac786ff 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -43,6 +43,7 @@ #if CONFIG_ARCH_X86 #include <arch/ebda.h> #endif +#include <timer.h> /** Linked list of ALL devices */ struct device *all_devices = &dev_root; @@ -1103,6 +1104,12 @@ static void init_dev(struct device *dev) return; if (!dev->initialized && dev->ops && dev->ops->init) { +#if CONFIG_DEV_INIT_TIMES + struct mono_time start_time; + struct rela_time dev_init_time; + + timer_monotonic_get(&start_time); +#endif if (dev->path.type == DEVICE_PATH_I2C) { printk(BIOS_DEBUG, "smbus: %s[%d]->", dev_path(dev->bus->dev), dev->bus->link_num); @@ -1111,6 +1118,11 @@ static void init_dev(struct device *dev) printk(BIOS_DEBUG, "%s init\n", dev_path(dev)); dev->initialized = 1; dev->ops->init(dev); +#if CONFIG_DEV_INIT_TIMES + dev_init_time = current_time_from(&start_time); + printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev), + rela_time_in_microseconds(&dev_init_time)); +#endif } }

1 0

Patch set updated for coreboot: 6677018 cbfs: make searching for a file less verbose
by Aaron Durbin 01 May '13

01 May '13

Aaron Durbin (adurbin(a)google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3131 -gerrit commit 6677018b02c94c0e41fbb7f6c7f84db58da36980 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Thu Apr 25 08:42:23 2013 -0500 cbfs: make searching for a file less verbose The cbfs core code would print out all unmatched file names when searching for a file. This contributes to a lot of unnecessary messages in the boot log. Change this message to a DEBUG one so that it will only be printed when CONFIG_DEBUG_CBFS is enabled. Change-Id: I1e46a4b21d80e5d2f9b511a163def7f5d4e0fb99 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> --- src/lib/cbfs_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/cbfs_core.c b/src/lib/cbfs_core.c index 9732b82..1220d48 100644 --- a/src/lib/cbfs_core.c +++ b/src/lib/cbfs_core.c @@ -158,7 +158,8 @@ struct cbfs_file *cbfs_get_file(struct cbfs_media *media, const char *name) media->close(media); return file_ptr; } else { - LOG(" (unmatched file @0x%x: %s)\n", offset, file_name); + DEBUG(" (unmatched file @0x%x: %s)\n", offset, + file_name); media->unmap(media, file_name); }

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2013