Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2939
-gerrit
commit 79d991174c16ae3f7ad7fd216705c82b94687575
Author: Nico Huber <nico.h(a)gmx.de>
Date: Thu Mar 28 15:08:20 2013 +0100
crossgcc: Fix building with texinfo-5.x
If you have a recent version of texinfo installed, building the reference
toolchain fails with the following error:
(in util/crossgcc/build-gcc/crossgcc-build.log)
[...]/gcc-4.7.2/gcc/doc/cppopts.texi:806: @itemx must follow @item
Looks like a warning-became-an-error problem in texinfo, to me. Fix that by
making every erroneous @itemx an @item.
Change-Id: I685ae1ecfee889b7c857b148cfab7411a10e7ecd
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
util/crossgcc/patches/gcc-4.7.2_texinfo.patch | 98 +++++++++++++++++++++++++++
1 file changed, 98 insertions(+)
diff --git a/util/crossgcc/patches/gcc-4.7.2_texinfo.patch b/util/crossgcc/patches/gcc-4.7.2_texinfo.patch
new file mode 100644
index 0000000..34c6a68
--- /dev/null
+++ b/util/crossgcc/patches/gcc-4.7.2_texinfo.patch
@@ -0,0 +1,98 @@
+diff -urp gcc-4.7.2/gcc/doc/cppopts.texi gcc-4.7.2/gcc/doc/cppopts.texi
+--- gcc-4.7.2/gcc/doc/cppopts.texi 2013-03-28 13:41:01.000000000 +0100
++++ gcc-4.7.2/gcc/doc/cppopts.texi 2013-03-28 13:55:05.000000000 +0100
+@@ -803,7 +803,7 @@ Replacement: [ ] @{ @}
+ Enable special code to work around file systems which only permit very
+ short file names, such as MS-DOS@.
+
+-@itemx --help
++@item --help
+ @itemx --target-help
+ @opindex help
+ @opindex target-help
+diff -urp gcc-4.7.2/gcc/doc/generic.texi gcc-4.7.2/gcc/doc/generic.texi
+--- gcc-4.7.2/gcc/doc/generic.texi 2011-12-23 23:07:16.000000000 +0100
++++ gcc-4.7.2/gcc/doc/generic.texi 2013-03-28 14:01:19.000000000 +0100
+@@ -1415,13 +1415,13 @@ generate these expressions anyhow, if it
+ not matter. The type of the operands and that of the result are
+ always of @code{BOOLEAN_TYPE} or @code{INTEGER_TYPE}.
+
+-@itemx POINTER_PLUS_EXPR
++@item POINTER_PLUS_EXPR
+ This node represents pointer arithmetic. The first operand is always
+ a pointer/reference type. The second operand is always an unsigned
+ integer type compatible with sizetype. This is the only binary
+ arithmetic operand that can operate on pointer types.
+
+-@itemx PLUS_EXPR
++@item PLUS_EXPR
+ @itemx MINUS_EXPR
+ @itemx MULT_EXPR
+ These nodes represent various binary arithmetic operations.
+diff -urp gcc-4.7.2/gcc/doc/invoke.texi gcc-4.7.2/gcc/doc/invoke.texi
+--- gcc-4.7.2/gcc/doc/invoke.texi 2012-09-14 22:45:27.000000000 +0200
++++ gcc-4.7.2/gcc/doc/invoke.texi 2013-03-28 13:55:57.000000000 +0100
+@@ -5179,7 +5179,7 @@ thus dbg_cnt() returns true always unles
+ e.g. With -fdbg-cnt=dce:10,tail_call:0
+ dbg_cnt(dce) will return true only for first 10 invocations
+
+-@itemx -fenable-@var{kind}-@var{pass}
++@item -fenable-@var{kind}-@var{pass}
+ @itemx -fdisable-@var{kind}-@var{pass}=@var{range-list}
+ @opindex fdisable-
+ @opindex fenable-
+@@ -5327,11 +5327,11 @@ Dump after duplicating the computed goto
+ @option{-fdump-rtl-ce3} enable dumping after the three
+ if conversion passes.
+
+-@itemx -fdump-rtl-cprop_hardreg
++@item -fdump-rtl-cprop_hardreg
+ @opindex fdump-rtl-cprop_hardreg
+ Dump after hard register copy propagation.
+
+-@itemx -fdump-rtl-csa
++@item -fdump-rtl-csa
+ @opindex fdump-rtl-csa
+ Dump after combining stack adjustments.
+
+@@ -5342,11 +5342,11 @@ Dump after combining stack adjustments.
+ @option{-fdump-rtl-cse1} and @option{-fdump-rtl-cse2} enable dumping after
+ the two common sub-expression elimination passes.
+
+-@itemx -fdump-rtl-dce
++@item -fdump-rtl-dce
+ @opindex fdump-rtl-dce
+ Dump after the standalone dead code elimination passes.
+
+-@itemx -fdump-rtl-dbr
++@item -fdump-rtl-dbr
+ @opindex fdump-rtl-dbr
+ Dump after delayed branch scheduling.
+
+@@ -5391,7 +5391,7 @@ Dump after the initialization of the reg
+ @opindex fdump-rtl-initvals
+ Dump after the computation of the initial value sets.
+
+-@itemx -fdump-rtl-into_cfglayout
++@item -fdump-rtl-into_cfglayout
+ @opindex fdump-rtl-into_cfglayout
+ Dump after converting to cfglayout mode.
+
+@@ -5421,7 +5421,7 @@ Dump after removing redundant mode switc
+ @opindex fdump-rtl-rnreg
+ Dump after register renumbering.
+
+-@itemx -fdump-rtl-outof_cfglayout
++@item -fdump-rtl-outof_cfglayout
+ @opindex fdump-rtl-outof_cfglayout
+ Dump after converting from cfglayout mode.
+
+@@ -5433,7 +5433,7 @@ Dump after the peephole pass.
+ @opindex fdump-rtl-postreload
+ Dump after post-reload optimizations.
+
+-@itemx -fdump-rtl-pro_and_epilogue
++@item -fdump-rtl-pro_and_epilogue
+ @opindex fdump-rtl-pro_and_epilogue
+ Dump after generating the function prologues and epilogues.
+
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2936
-gerrit
commit dcc62724982320ec38b36f5283ccf3215b862dda
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Mar 28 13:03:38 2013 +0100
AMD CIMx SB800: Update Kconfig help texts to new SATA mode default
In the following commit
commit ee5c111755ac4acc6dfb6e10a4e271211e149a39
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Mar 12 12:41:40 2013 +0100
AMD CIMx SB800: Enable AHCI mode for SATA controller by default
Reviewed-on: http://review.coreboot.org/2661
I forgot to update the help texts to the new SATA mode default. Do
so now.
Additionally note that help texts for `choice` do not seem to be
shown.
Change-Id: I17f401633a2136efca2b21a621482e0724ff9f04
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/southbridge/amd/cimx/sb800/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/southbridge/amd/cimx/sb800/Kconfig b/src/southbridge/amd/cimx/sb800/Kconfig
index 53fad3c..554d8c7 100644
--- a/src/southbridge/amd/cimx/sb800/Kconfig
+++ b/src/southbridge/amd/cimx/sb800/Kconfig
@@ -49,17 +49,17 @@ choice
default SB800_SATA_AHCI
help
Select the mode in which SATA should be driven. NATIVE AHCI, or RAID.
- The default is NATIVE.
+ The default is AHCI.
config SB800_SATA_IDE
bool "NATIVE"
help
- NATIVE is the default mode and does not require a ROM.
+ NATIVE does not require a ROM.
config SB800_SATA_AHCI
bool "AHCI"
help
- AHCI may work with or without AHCI ROM. It depends on the payload support.
+ AHCI is the default and may work with or without AHCI ROM. It depends on the payload support.
For example, seabios does not require the AHCI ROM.
config SB800_SATA_RAID
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2936
-gerrit
commit b3f98a619f62a501015382ff255eab25e8b5dd2b
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Mar 28 13:03:38 2013 +0100
AMD CIMx SB800: Update Kconfig help texts for new default of SATA mode
In the following commit
commit ee5c111755ac4acc6dfb6e10a4e271211e149a39
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Tue Mar 12 12:41:40 2013 +0100
AMD CIMx SB800: Enable AHCI mode for SATA controller by default
Reviewed-on: http://review.coreboot.org/2661
I forgot to update the help texts to the new default for the SATA
mode.
Change-Id: I17f401633a2136efca2b21a621482e0724ff9f04
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/southbridge/amd/cimx/sb800/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/southbridge/amd/cimx/sb800/Kconfig b/src/southbridge/amd/cimx/sb800/Kconfig
index 53fad3c..554d8c7 100644
--- a/src/southbridge/amd/cimx/sb800/Kconfig
+++ b/src/southbridge/amd/cimx/sb800/Kconfig
@@ -49,17 +49,17 @@ choice
default SB800_SATA_AHCI
help
Select the mode in which SATA should be driven. NATIVE AHCI, or RAID.
- The default is NATIVE.
+ The default is AHCI.
config SB800_SATA_IDE
bool "NATIVE"
help
- NATIVE is the default mode and does not require a ROM.
+ NATIVE does not require a ROM.
config SB800_SATA_AHCI
bool "AHCI"
help
- AHCI may work with or without AHCI ROM. It depends on the payload support.
+ AHCI is the default and may work with or without AHCI ROM. It depends on the payload support.
For example, seabios does not require the AHCI ROM.
config SB800_SATA_RAID
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2935
-gerrit
commit 4077682d6ad76d07dc778603bdfd67df8c0480d7
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Mar 28 11:44:19 2013 +0100
superiotool: Allow to override Makefile variables `CC`, `INSTALL` and `PREFIX`
This way for example a different compiler can easily be used.
CC=clang make
Change-Id: I50b83554fd4826d00d87e60a30eb1f6a88834397
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
util/superiotool/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile
index 060dd41..900b8ae 100644
--- a/util/superiotool/Makefile
+++ b/util/superiotool/Makefile
@@ -20,9 +20,9 @@
PROGRAM = superiotool
-CC = gcc
-INSTALL = /usr/bin/install
-PREFIX = /usr/local
+CC ?= gcc
+INSTALL ?= /usr/bin/install
+PREFIX ?= /usr/local
# Set the superiotool version string to the output of 'git describe'.
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2935
-gerrit
commit 5102b5f87cdd31b0dd39b4123e8ffe0448abadb5
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Thu Mar 28 11:44:19 2013 +0100
superiotool: Allow to override Makefile variables `CC`, `INSTALL` and `PREFIX`
This way for example a different compiler can easily be used.
CC=clang make
Change-Id: I50b83554fd4826d00d87e60a30eb1f6a88834397
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
util/superiotool/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile
index 060dd41..900b8ae 100644
--- a/util/superiotool/Makefile
+++ b/util/superiotool/Makefile
@@ -20,9 +20,9 @@
PROGRAM = superiotool
-CC = gcc
-INSTALL = /usr/bin/install
-PREFIX = /usr/local
+CC ?= gcc
+INSTALL ?= /usr/bin/install
+PREFIX ?= /usr/local
# Set the superiotool version string to the output of 'git describe'.
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2934
-gerrit
commit dde10a98b559239dba9c6fc4f176dab3d01c7abe
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Wed Mar 27 09:50:30 2013 +0100
PDCurses: pdcscrn.c: Use `#ifdef` instead of `#if CONFIG_SPEAKER`
Building libpayload with the PDCurses backend the following warning
is shown.
/src/coreboot/payloads/libpayload(master) $ make clean
/src/coreboot/payloads/libpayload(master) $ make
[…]
CC curses/pdcurses-backend/pdcscrn.libcurses.o
curses/pdcurses-backend/pdcscrn.c: In function 'PDC_scr_open':
curses/pdcurses-backend/pdcscrn.c:75:5: warning: "CONFIG_SPEAKER" is not defined [-Wundef]
[…]
The GCC documentation writes [1]
In some contexts this shortcut is undesirable. The -Wundef option
causes GCC to warn whenever it encounters an identifier which is
not a macro in an ‘#if’.
so use `#ifdef` [2] to silence this warning. No functional change is
done, as `CONFIG_SPEAKER` is assigned the value `Y` when defined.
[1] http://gcc.gnu.org/onlinedocs/cpp/If.html
[2] http://gcc.gnu.org/onlinedocs/cpp/Ifdef.html
Change-Id: I8e9c9b5d01985b21ad05018986d614cf9bf2b439
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
payloads/libpayload/curses/pdcurses-backend/pdcscrn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
index d3f1849..e741b15 100644
--- a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
+++ b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
@@ -72,7 +72,7 @@ int PDC_scr_open(int argc, char **argv)
SP->lines = PDC_get_rows();
SP->cols = PDC_get_columns();
-#if CONFIG_SPEAKER
+#ifdef CONFIG_SPEAKER
SP->audible = TRUE;
#endif
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2933
-gerrit
commit c33a40b04140e614f75737fadbbb597833152133
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Wed Mar 27 16:42:50 2013 -0700
libpayload: drop size_t and ssize_t
They're causing trouble
Change-Id: I2ceb28160571b703c8894c41e6305b75284cf60b
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
payloads/libpayload/include/armv7/arch/types.h | 3 ---
payloads/libpayload/include/x86/arch/types.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/payloads/libpayload/include/armv7/arch/types.h b/payloads/libpayload/include/armv7/arch/types.h
index bb40257..1bd815b 100644
--- a/payloads/libpayload/include/armv7/arch/types.h
+++ b/payloads/libpayload/include/armv7/arch/types.h
@@ -53,9 +53,6 @@ typedef signed long long s64;
typedef long time_t;
typedef long suseconds_t;
-typedef unsigned long size_t;
-typedef long ssize_t;
-
#ifndef NULL
#define NULL ((void *)0)
#endif
diff --git a/payloads/libpayload/include/x86/arch/types.h b/payloads/libpayload/include/x86/arch/types.h
index bb40257..1bd815b 100644
--- a/payloads/libpayload/include/x86/arch/types.h
+++ b/payloads/libpayload/include/x86/arch/types.h
@@ -53,9 +53,6 @@ typedef signed long long s64;
typedef long time_t;
typedef long suseconds_t;
-typedef unsigned long size_t;
-typedef long ssize_t;
-
#ifndef NULL
#define NULL ((void *)0)
#endif