the following patch was just integrated into master:
commit dbc11e2f766ab520fe2ccb61fdfed69b89e9d623
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Tue Mar 26 21:39:03 2013 -0700
armv7: clean+invalidate all cache levels when disabling MMU
This iterates thru all cache levels and cleans + invalidates all
data and unified caches before disabling dcache and MMU.
Change-Id: I8a671b4c90d7b88b8d0a95947bfa17f912cebaa2
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
Reviewed-on: http://review.coreboot.org/2930
Reviewed-by: Gabe Black <gabe.black(a)gmail.com>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Thu Mar 28 22:51:27 2013, giving +1
See http://review.coreboot.org/2930 for details.
-gerrit
the following patch was just integrated into master:
commit 19f3092b5297b2f6e128a97698176ed1173be909
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Tue Mar 26 17:47:05 2013 -0700
armv7: cosmetic changes to dcache_op_mva()
This is just a cosmetic change to dcache_op_mva() to (hopefully) make
it a easier to follow and more difficult to screw up.
Change-Id: Ia348b2d58f2f2bf5c3cafabcfba06bc411937dba
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
Reviewed-on: http://review.coreboot.org/2927
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
Build-Tested: build bot (Jenkins) at Thu Mar 28 22:25:33 2013, giving +1
See http://review.coreboot.org/2927 for details.
-gerrit
the following patch was just integrated into master:
commit 8f398876170c4076a52850cf3f9cbeb23b951204
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Thu Mar 28 13:45:19 2013 -0700
armv7: fix a bad variable assignment
'<' was used when '<<' is needed. Oops!
Change-Id: I8451f76888e86219df16b50739cd2c8db80dcb14
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
Reviewed-on: http://review.coreboot.org/2941
Reviewed-by: Gabe Black <gabe.black(a)gmail.com>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Thu Mar 28 22:38:40 2013, giving +1
See http://review.coreboot.org/2941 for details.
-gerrit
the following patch was just integrated into master:
commit d21ca52adebab875c66ff1843adcbb979400532f
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Tue Mar 26 17:45:39 2013 -0700
armv7: pass incremented value to dccimvac
This passes the correct value into dccimvac.
Change-Id: I6098440ea48a9b6429380d5913fce6d36e3afb41
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
Reviewed-on: http://review.coreboot.org/2926
Reviewed-by: Gabe Black <gabe.black(a)gmail.com>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Thu Mar 28 22:11:47 2013, giving +1
See http://review.coreboot.org/2926 for details.
-gerrit
David Hendricks (dhendrix(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2941
-gerrit
commit c6ff729e69a3ddebf77dc2d27fa115052c244797
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Thu Mar 28 13:45:19 2013 -0700
armv7: fix a bad variable assignment
'<' was used when '<<' is needed. Oops!
Change-Id: I8451f76888e86219df16b50739cd2c8db80dcb14
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
---
src/arch/armv7/lib/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/armv7/lib/cache.c b/src/arch/armv7/lib/cache.c
index b8f4d88..bcf82d2 100644
--- a/src/arch/armv7/lib/cache.c
+++ b/src/arch/armv7/lib/cache.c
@@ -264,7 +264,7 @@ void armv7_invalidate_caches(void)
write_csselr(csselr);
icache_invalidate_all();
- csselr = level < 1;
+ csselr = level << 1;
write_csselr(csselr);
dcache_invalidate_all();
break;
David Hendricks (dhendrix(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2927
-gerrit
commit c0b2644d0a29d8da403f2afd2e38dd43a67c7bc2
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Tue Mar 26 17:47:05 2013 -0700
armv7: cosmetic changes to dcache_op_mva()
This is just a cosmetic change to dcache_op_mva() to (hopefully) make
it a easier to follow and more difficult to screw up.
Change-Id: Ia348b2d58f2f2bf5c3cafabcfba06bc411937dba
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
---
src/arch/armv7/lib/cache.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/arch/armv7/lib/cache.c b/src/arch/armv7/lib/cache.c
index bcf82d2..de772a1 100644
--- a/src/arch/armv7/lib/cache.c
+++ b/src/arch/armv7/lib/cache.c
@@ -180,19 +180,21 @@ static unsigned int line_bytes(void)
static void dcache_op_mva(unsigned long addr,
unsigned long len, enum dcache_op op)
{
- unsigned long line, i;
+ unsigned long line, linesize;
- line = line_bytes();
+ linesize = line_bytes();
+ line = addr & ~(linesize - 1);
dsb();
- for (i = addr & ~(line - 1); i < addr + len; i += line) {
+ while (line < addr + len) {
switch(op) {
case OP_DCCIMVAC:
- dccimvac(i);
+ dccimvac(line);
break;
default:
break;
}
+ line += linesize;
}
isb();
}
David Hendricks (dhendrix(a)chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2926
-gerrit
commit 4aebda5ec6a8f3c39c6a6df119054e2515146df6
Author: David Hendricks <dhendrix(a)chromium.org>
Date: Tue Mar 26 17:45:39 2013 -0700
armv7: pass incremented value to dccimvac
This passes the correct value into dccimvac.
Change-Id: I6098440ea48a9b6429380d5913fce6d36e3afb41
Signed-off-by: David Hendricks <dhendrix(a)chromium.org>
---
src/arch/armv7/lib/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/armv7/lib/cache.c b/src/arch/armv7/lib/cache.c
index c93da36..b8f4d88 100644
--- a/src/arch/armv7/lib/cache.c
+++ b/src/arch/armv7/lib/cache.c
@@ -188,7 +188,7 @@ static void dcache_op_mva(unsigned long addr,
for (i = addr & ~(line - 1); i < addr + len; i += line) {
switch(op) {
case OP_DCCIMVAC:
- dccimvac(addr);
+ dccimvac(i);
break;
default:
break;
the following patch was just integrated into master:
commit 69a21b1eb9de9ab931959ac6efaa69333ffd2807
Author: Nico Huber <nico.h(a)gmx.de>
Date: Thu Mar 28 15:08:20 2013 +0100
crossgcc: Fix building with texinfo-5.x
If you have a recent version of texinfo installed, building the reference
toolchain fails with the following error:
(in util/crossgcc/build-gcc/crossgcc-build.log)
[...]/gcc-4.7.2/gcc/doc/cppopts.texi:806: @itemx must follow @item
Looks like a warning-became-an-error problem in texinfo, to me. Fix that by
making every erroneous @itemx an @item.
Change-Id: I685ae1ecfee889b7c857b148cfab7411a10e7ecd
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-on: http://review.coreboot.org/2939
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Idwer Vollering <vidwer(a)gmail.com>
Build-Tested: build bot (Jenkins) at Thu Mar 28 15:37:20 2013, giving +1
See http://review.coreboot.org/2939 for details.
-gerrit