Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4056
-gerrit
commit b6e4ecb08e21d3606d83a685a04f24118eebf097
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Nov 13 21:53:23 2013 +0100
Enable 3G modem on lenovo
Just like bluetooth and wlan it need to be enabled in EC.
Do it analogously to above mentioned
Change-Id: Ia4bfeb6fb05c6f61a47340e4213e72df5dae179b
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/ec/lenovo/h8/h8.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index ca34fb6..5836a51 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -50,6 +50,14 @@ void h8_wlan_enable(int on)
ec_clr_bit(0x3a, 5);
}
+static void h8_3g_enable(int on)
+{
+ if (on)
+ ec_set_bit(0x3a, 6);
+ else
+ ec_clr_bit(0x3a, 6);
+}
+
static void h8_log_ec_version(void)
{
unsigned char ecfw[9], c;
@@ -154,6 +162,8 @@ static void h8_enable(device_t dev)
val = 1;
h8_bluetooth_enable(val);
+ h8_3g_enable(1);
+
if (get_option(&val, "first_battery"))
val = 1;
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4056
-gerrit
commit 7ff77deac33cdb9e7ce6bbeb728ad5ddafc68acc
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Nov 13 21:53:23 2013 +0100
Enable 3G modem on lenovo
Just like bluetooth and wlan it need to be enabled in EC.
Do it analogously to above mentioned
Change-Id: Ia4bfeb6fb05c6f61a47340e4213e72df5dae179b
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/ec/lenovo/h8/h8.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index ca34fb6..e42749f 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -50,6 +50,14 @@ void h8_wlan_enable(int on)
ec_clr_bit(0x3a, 5);
}
+static void h8_3g_enable(int on)
+{
+ if (on)
+ ec_set_bit(0x3a, 6);
+ else
+ ec_clr_bit(0x3a, 6);
+}
+
static void h8_log_ec_version(void)
{
unsigned char ecfw[9], c;
@@ -154,6 +162,11 @@ static void h8_enable(device_t dev)
val = 1;
h8_bluetooth_enable(val);
+ if (get_option(&val, "umts"))
+ val = 1;
+
+ h8_3g_enable(val);
+
if (get_option(&val, "first_battery"))
val = 1;
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4054
-gerrit
commit 28404a880d494d5fd2b7fa468850f80afece0ce4
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Wed Nov 13 18:31:24 2013 +0100
Make H8 work by default
Currently H8 skips important init if unable to access CMOS config.
Change default to enable all features to have a sane system without
using CMOS config.
Change-Id: I94f39d9d2b4044d60f0cd7b7700bc8629e99201c
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/ec/lenovo/h8/h8.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 9ffdfc1..ca34fb6 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -150,16 +150,17 @@ static void h8_enable(device_t dev)
if (!get_option(&val, "volume"))
ec_write(H8_VOLUME_CONTROL, val);
+ if (get_option(&val, "bluetooth"))
+ val = 1;
+ h8_bluetooth_enable(val);
- if (!get_option(&val, "bluetooth"))
- h8_bluetooth_enable(val);
+ if (get_option(&val, "first_battery"))
+ val = 1;
- if (!get_option(&val, "first_battery")) {
- tmp = ec_read(H8_CONFIG3);
- tmp &= ~(1 << 4);
- tmp |= (val & 1)<< 4;
- ec_write(H8_CONFIG3, tmp);
- }
+ tmp = ec_read(H8_CONFIG3);
+ tmp &= ~(1 << 4);
+ tmp |= (val & 1) << 4;
+ ec_write(H8_CONFIG3, tmp);
h8_set_audio_mute(0);
}