Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 13:
(4 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/61259/comment/fc68c2b5_3768408f PS12, Line 15: GPP_CLK_ON, /* GPP clock always on; default */
nit: inconsistent use of tabs and spaces in this enum.
Done
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/61259/comment/e1176cc4_92a18dff PS12, Line 19: #include <device/device.h>
It'd be good to alphabetize the global imports (even though it's not fully alphabetized as is).
Done
https://review.coreboot.org/c/coreboot/+/61259/comment/5d2dbe5a_7c39a7a7 PS12, Line 158: const fsp_dxio_descriptor *dxio_descs = NULL;
Move declarations before logic.
Done
https://review.coreboot.org/c/coreboot/+/61259/comment/7d7290ec_996920c3 PS12, Line 164: if (dxio_descs != NULL) {
Is it an error if dxio_descs == NULL?
Done