Attention is currently required from: Raul Rangel, Rob Barnes, Felix Held.
4 comments:
File src/soc/amd/cezanne/chip.h:
Patch Set #12, Line 15: GPP_CLK_ON, /* GPP clock always on; default */
nit: inconsistent use of tabs and spaces in this enum.
Done
File src/soc/amd/cezanne/fch.c:
Patch Set #12, Line 19: #include <device/device.h>
It'd be good to alphabetize the global imports (even though it's not fully alphabetized as is).
Done
Patch Set #12, Line 158: const fsp_dxio_descriptor *dxio_descs = NULL;
Move declarations before logic.
Done
Patch Set #12, Line 164: if (dxio_descs != NULL) {
Is it an error if dxio_descs == NULL?
Done
To view, visit change 61259. To unsubscribe, or for help writing mail filters, visit settings.