Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
soc/intel/icelake: Remove unused headers
This patch removes inclusion of unused headers from soc/intel/icelake
Change-Id: Icb653dee7992538aadf98d84adadd081f816fd01 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/icelake/include/soc/bootblock.h M src/soc/intel/icelake/include/soc/cpu.h M src/soc/intel/icelake/include/soc/espi.h 4 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36536/1
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c index db43e50..f348c1b 100644 --- a/src/soc/intel/icelake/bootblock/bootblock.c +++ b/src/soc/intel/icelake/bootblock/bootblock.c @@ -15,6 +15,7 @@
#include <bootblock_common.h> #include <intelblocks/gspi.h> +#include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> #include <soc/iomap.h> diff --git a/src/soc/intel/icelake/include/soc/bootblock.h b/src/soc/intel/icelake/include/soc/bootblock.h index 2f6473d..4ca2c37 100644 --- a/src/soc/intel/icelake/include/soc/bootblock.h +++ b/src/soc/intel/icelake/include/soc/bootblock.h @@ -16,8 +16,6 @@ #ifndef _SOC_ICELAKE_BOOTBLOCK_H_ #define _SOC_ICELAKE_BOOTBLOCK_H_
-#include <intelblocks/systemagent.h> - /* Bootblock pre console init programming */ void bootblock_cpu_init(void); void bootblock_pch_early_init(void); diff --git a/src/soc/intel/icelake/include/soc/cpu.h b/src/soc/intel/icelake/include/soc/cpu.h index b5722da..7d170580 100644 --- a/src/soc/intel/icelake/include/soc/cpu.h +++ b/src/soc/intel/icelake/include/soc/cpu.h @@ -16,7 +16,6 @@ #ifndef _SOC_ICELAKE_CPU_H_ #define _SOC_ICELAKE_CPU_H_
-#include <device/device.h> #include <intelblocks/msr.h>
/* Latency times in units of 32768ns */ diff --git a/src/soc/intel/icelake/include/soc/espi.h b/src/soc/intel/icelake/include/soc/espi.h index 36ee947..fcc796e 100644 --- a/src/soc/intel/icelake/include/soc/espi.h +++ b/src/soc/intel/icelake/include/soc/espi.h @@ -16,8 +16,6 @@ #ifndef _SOC_ICELAKE_ESPI_H_ #define _SOC_ICELAKE_ESPI_H_
-#include <stdint.h> - /* PCI Configuration Space (D31:F0): ESPI */ #define SCI_IRQ_SEL (7 << 0) #define SCIS_IRQ9 0
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
Patch Set 1: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36536/1/src/soc/intel/icelake/inclu... File src/soc/intel/icelake/include/soc/espi.h:
https://review.coreboot.org/c/coreboot/+/36536/1/src/soc/intel/icelake/inclu... PS1, Line 49: uint8_t <stdint.h> ?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36536/1/src/soc/intel/icelake/inclu... File src/soc/intel/icelake/include/soc/espi.h:
https://review.coreboot.org/c/coreboot/+/36536/1/src/soc/intel/icelake/inclu... PS1, Line 49: uint8_t
<stdint. […]
Done
Hello Patrick Rudolph, Arthur Heymans, Michael Niewöhner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36536
to look at the new patch set (#2).
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
soc/intel/icelake: Remove unused headers
This patch removes inclusion of unused headers from soc/intel/icelake
Change-Id: Icb653dee7992538aadf98d84adadd081f816fd01 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/icelake/include/soc/bootblock.h M src/soc/intel/icelake/include/soc/cpu.h 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36536/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36536 )
Change subject: soc/intel/icelake: Remove unused headers ......................................................................
soc/intel/icelake: Remove unused headers
This patch removes inclusion of unused headers from soc/intel/icelake
Change-Id: Icb653dee7992538aadf98d84adadd081f816fd01 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36536 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/icelake/include/soc/bootblock.h M src/soc/intel/icelake/include/soc/cpu.h 3 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c index db43e50..f348c1b 100644 --- a/src/soc/intel/icelake/bootblock/bootblock.c +++ b/src/soc/intel/icelake/bootblock/bootblock.c @@ -15,6 +15,7 @@
#include <bootblock_common.h> #include <intelblocks/gspi.h> +#include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> #include <soc/iomap.h> diff --git a/src/soc/intel/icelake/include/soc/bootblock.h b/src/soc/intel/icelake/include/soc/bootblock.h index 2f6473d..4ca2c37 100644 --- a/src/soc/intel/icelake/include/soc/bootblock.h +++ b/src/soc/intel/icelake/include/soc/bootblock.h @@ -16,8 +16,6 @@ #ifndef _SOC_ICELAKE_BOOTBLOCK_H_ #define _SOC_ICELAKE_BOOTBLOCK_H_
-#include <intelblocks/systemagent.h> - /* Bootblock pre console init programming */ void bootblock_cpu_init(void); void bootblock_pch_early_init(void); diff --git a/src/soc/intel/icelake/include/soc/cpu.h b/src/soc/intel/icelake/include/soc/cpu.h index b5722da..7d170580 100644 --- a/src/soc/intel/icelake/include/soc/cpu.h +++ b/src/soc/intel/icelake/include/soc/cpu.h @@ -16,7 +16,6 @@ #ifndef _SOC_ICELAKE_CPU_H_ #define _SOC_ICELAKE_CPU_H_
-#include <device/device.h> #include <intelblocks/msr.h>
/* Latency times in units of 32768ns */
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Michael Niewöhner (Code Review)
-
Subrata Banik (Code Review)