Change in coreboot[master]: soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB uncondit...
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36538 )
Change subject: soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB unconditionally ......................................................................
soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB unconditionally
Icelake default selects PLATFORM_USES_FSP2_1 which means stack will be shared between FSP and coreboot (CONFIG_FSP_USES_CB_STACK) hence no need to have any other default value than 129KiB (128KiB for FSP and 1KiB for coreboot)
Change-Id: I856f7e48a4a1e86eb082b9e772e0776664edca51 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/icelake/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/36538/1
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 4ae043a..aa59f85 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -70,8 +70,7 @@
config DCACHE_BSP_STACK_SIZE hex - default 0x20400 if FSP_USES_CB_STACK - default 0x4000 + default 0x20400 help The amount of anticipated stack usage in CAR by bootblock and other stages. In the case of FSP_USES_CB_STACK default value will be
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36538 )
Change subject: soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB unconditionally ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36538 )
Change subject: soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB unconditionally ......................................................................
soc/intel/icelake: Set DCACHE_BSP_STACK_SIZE default ~129KiB unconditionally
Icelake default selects PLATFORM_USES_FSP2_1 which means stack will be shared between FSP and coreboot (CONFIG_FSP_USES_CB_STACK) hence no need to have any other default value than 129KiB (128KiB for FSP and 1KiB for coreboot)
Change-Id: I856f7e48a4a1e86eb082b9e772e0776664edca51 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36538 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/icelake/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 86f1ff5..a04993d 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -70,8 +70,7 @@
config DCACHE_BSP_STACK_SIZE hex - default 0x20400 if FSP_USES_CB_STACK - default 0x4000 + default 0x20400 help The amount of anticipated stack usage in CAR by bootblock and other stages. In the case of FSP_USES_CB_STACK default value will be
-
Arthur Heymans (Code Review) -
Subrata Banik (Code Review)