Change in coreboot[master]: Revert "console: Update for vboot before bootblock"

[Nico Huber (Code Review)]

Hello build bot (Jenkins), Raul Rangel, Martin Roth, Patrick Georgi, Furquan Shaikh, Eric Peers, Aaron Durbin,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/42165

to review the following change.

Change subject: Revert "console: Update for vboot before bootblock"
......................................................................

Revert "console: Update for vboot before bootblock"

This reverts commit baba3e961072bfb7ffb4f0031ada27046a58d29e.

Reason for revert: Submitted during review.

Change-Id: I657a6170aba5aba685531380353aa9ba999f9c4e
---
M src/console/Makefile.inc
1 file changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/42165/1

diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc
index e2a20d7..2154eb9 100644
--- a/src/console/Makefile.inc
+++ b/src/console/Makefile.inc
@@ -11,14 +11,12 @@
 smm-y += die.c
 smm-y += post.c

-ifneq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
+verstage-y += init.c
 verstage-y += printk.c
+verstage-y += vtxprintf.c vsprintf.c
 verstage-y += console.c
-endif
 verstage-y += post.c
 verstage-y += die.c
-verstage-y += init.c
-verstage-y += vtxprintf.c vsprintf.c

romstage-y += vtxprintf.c printk.c vsprintf.c
 romstage-y += init.c console.c

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42165 )

Change subject: Revert "console: Update for vboot before bootblock"
......................................................................

Patch Set 1: Code-Review-2

Everything's submitted during review.

I addressed the issues.  If there are more issues, please commente.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42165 )

Change subject: Revert "console: Update for vboot before bootblock"
......................................................................

Patch Set 1:
> Patch Set 1: Code-Review-2
>
> Everything's submitted during review.
>
> I addressed the issues.  If there are more issues, please commente.

If you don't know what I'm referring to, why did you explicitly
state we should comment later? It's just rude to submit changes
like that. I think the same rules should apply to all of us,
even you, that is that we don't bluntly mark comments as resolved
and hit submit at the very first chance.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42165 )

Change subject: Revert "console: Update for vboot before bootblock"
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1: Code-Review-2
> >
> > Everything's submitted during review.
> >
> > I addressed the issues.  If there are more issues, please commente.
>
> If you don't know what I'm referring to, why did you explicitly
> state we should comment later? It's just rude to submit changes
> like that. I think the same rules should apply to all of us,
> even you, that is that we don't bluntly mark comments as resolved
> and hit submit at the very first chance.

I said that because I'm going to be revisiting this code again soon.  As I stated in the patch.  I had fixed all your requests, had I not?

The patch had a +2, so it was available to be submitted.  This is normal stuff, not anything with privilege.  Let's not get personal please.

[XS] Change in coreboot[master]: Revert "console: Update for vboot before bootblock"

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42165?usp=email )

Change subject: Revert "console: Update for vboot before bootblock"
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.