Patch Set 1:

Patch Set 1: Code-Review-2

Everything's submitted during review.

I addressed the issues. If there are more issues, please commente.

If you don't know what I'm referring to, why did you explicitly
state we should comment later? It's just rude to submit changes
like that. I think the same rules should apply to all of us,
even you, that is that we don't bluntly mark comments as resolved
and hit submit at the very first chance.

I said that because I'm going to be revisiting this code again soon. As I stated in the patch. I had fixed all your requests, had I not?

The patch had a +2, so it was available to be submitted. This is normal stuff, not anything with privilege. Let's not get personal please.

View Change

To view, visit change 42165. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I657a6170aba5aba685531380353aa9ba999f9c4e
Gerrit-Change-Number: 42165
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Eric Peers <epeers@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 15 Jun 2020 23:11:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment