Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39111 )
Change subject: soc/intel/tigerlake: Add Jasper lake GPIO support ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39111/12/src/soc/intel/common/acpi/... File src/soc/intel/common/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/39111/12/src/soc/intel/common/acpi/... PS12, Line 4: Copyright (C) 2020 Intel Corporation. Please use "Copyright 2020 The coreboot project Authors." here and in all the other files in this CL.
Also if possible using SPDX license header.
Refer to the document here - https://doc.coreboot.org/releases/coreboot-4.11-relnotes.html#shorter-file-h...
https://review.coreboot.org/c/coreboot/+/39111/12/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39111/12/src/soc/intel/tigerlake/ac... PS12, Line 122: rg0 >= GPP_B0 && Arg0 <= GPP_A24)
This was intentionally written in ACPI ASL2.0. […]
Actually all the ASL files in this CL seems to be written using legacy ASL. Is there a reason to not use ASL2.0?
https://review.coreboot.org/c/coreboot/+/39111/12/src/soc/intel/tigerlake/ac... PS12, Line 90: /* GPIO Community 4 */ Here GPIO community 2 is removed for TGL. Can you please put it back?
-
Karthik Ramasubramanian (Code Review)