3 comments:
File src/soc/intel/common/acpi/gpio_op.asl:
Patch Set #12, Line 4: Copyright (C) 2020 Intel Corporation.
Please use "Copyright 2020 The coreboot project Authors." here and in all the other files in this CL.
Also if possible using SPDX license header.
Refer to the document here - https://doc.coreboot.org/releases/coreboot-4.11-relnotes.html#shorter-file-headers
File src/soc/intel/tigerlake/acpi/gpio.asl:
Patch Set #12, Line 122: rg0 >= GPP_B0 && Arg0 <= GPP_A24)
This was intentionally written in ACPI ASL2.0. […]
Actually all the ASL files in this CL seems to be written using legacy ASL. Is there a reason to not use ASL2.0?
Patch Set #12, Line 90: /* GPIO Community 4 */
Here GPIO community 2 is removed for TGL. Can you please put it back?
To view, visit change 39111. To unsubscribe, or for help writing mail filters, visit settings.