Change in coreboot[master]: soc/intel/common: Remove HOST_RESET_ONLY reset type support

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

soc/intel/common: Remove HOST_RESET_ONLY reset type support

Remove HOST_RESET_ONLY reset type of GLOBAL_RESET HECI command as it
is not supported any more.

Change-Id: I17171e1e5fe79710142369499d3d904a5ba98636
Signed-off-by: Sridhar Siricilla 
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 2 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/39149/1

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 5877d53..c5c7097 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -609,8 +609,7 @@
 }

/*
- * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/
- * HOST_RESET_ONLY/CSE_RESET_ONLY.
+ * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/CSE_RESET_ONLY.
  */
 int cse_request_global_reset(enum rst_req_type rst_type)
 {
@@ -632,8 +631,7 @@
    size_t reply_size;

printk(BIOS_DEBUG, "HECI: Global Reset(Type:%d) Command\n", rst_type);
-	if (!((rst_type == GLOBAL_RESET) ||
-		(rst_type == HOST_RESET_ONLY) || (rst_type == CSE_RESET_ONLY))) {
+	if (!(rst_type == GLOBAL_RESET || rst_type == CSE_RESET_ONLY)) {
    	printk(BIOS_ERR, "HECI: Unsupported reset type is requested\n");
    	return 0;
    }
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index c597a3f..bbe8ba9 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -119,7 +119,6 @@

enum rst_req_type {
    GLOBAL_RESET = 1,
-	HOST_RESET_ONLY = 2,
    CSE_RESET_ONLY = 3,
 };

[Sridhar Siricilla (Code Review)]

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39149

to look at the new patch set (#2).

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

soc/intel/common: Remove HOST_RESET_ONLY reset type support

Remove HOST_RESET_ONLY reset type of GLOBAL_RESET HECI command as it
is not supported.

Change-Id: I17171e1e5fe79710142369499d3d904a5ba98636
Signed-off-by: Sridhar Siricilla 
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 2 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/39149/2

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@7 
PS1, Line 7: soc/intel/common: Remove HOST_RESET_ONLY reset type support
Is support for this reset type deprecated for all ME/TXE/SPS/CSE firmware versions, or only from a specific version onwards?

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@10 
PS1, Line 10: any more
anymore

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@7 
PS1, Line 7: soc/intel/common: Remove HOST_RESET_ONLY reset type support
> Is support for this reset type deprecated for all ME/TXE/SPS/CSE firmware versions, or only from a s […]

Yes, no platform support reset type HOST_RESET_ONLY.

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@10 
PS1, Line 10: any more
> anymore

Done

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@7 
PS1, Line 7: soc/intel/common: Remove HOST_RESET_ONLY reset type support
> Yes, no platform support reset type HOST_RESET_ONLY.

Ack

https://review.coreboot.org/c/coreboot/+/39149/1//COMMIT_MSG@10 
PS1, Line 10: any more
> Done

Done

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

soc/intel/common: Remove HOST_RESET_ONLY reset type support

Remove HOST_RESET_ONLY reset type of GLOBAL_RESET HECI command as it
is not supported.

Change-Id: I17171e1e5fe79710142369499d3d904a5ba98636
Signed-off-by: Sridhar Siricilla 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39149
Tested-by: build bot (Jenkins) 
Reviewed-by: Rizwan Qureshi 
Reviewed-by: Angel Pons 
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Rizwan Qureshi: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 48c26f3..b24a99a 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -609,8 +609,7 @@
 }

/*
- * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/
- * HOST_RESET_ONLY/CSE_RESET_ONLY.
+ * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/CSE_RESET_ONLY.
  */
 int cse_request_global_reset(enum rst_req_type rst_type)
 {
@@ -632,8 +631,7 @@
    size_t reply_size;

printk(BIOS_DEBUG, "HECI: Global Reset(Type:%d) Command\n", rst_type);
-	if (!((rst_type == GLOBAL_RESET) ||
-		(rst_type == HOST_RESET_ONLY) || (rst_type == CSE_RESET_ONLY))) {
+	if (!(rst_type == GLOBAL_RESET || rst_type == CSE_RESET_ONLY)) {
    	printk(BIOS_ERR, "HECI: Unsupported reset type is requested\n");
    	return 0;
    }
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index 59ddc5b..2b07092 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -121,7 +121,6 @@

enum rst_req_type {
    GLOBAL_RESET = 1,
-	HOST_RESET_ONLY = 2,
    CSE_RESET_ONLY = 3,
 };

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39149 )

Change subject: soc/intel/common: Remove HOST_RESET_ONLY reset type support
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1005
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1004
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1003

Please note: This test is under development and might not be accurate at all!